Skip to content

feat(members): a crewmate's Sessions tab groups its sessions and shows a recap in place - #28931

Merged
bolichen97 merged 1 commit into
mainfrom
feat/mate-sessions-tab-recap
Nov 4, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/mate-sessions-tab-recap

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crewmate's Sessions tab shows every session the mate dispatched, grouped by what each needs, and a click shows that session's recap in place without leaving the page.

Today the mate Profile card's Sessions tab lists only the mate's live direct children, one status dot each. Closed sessions and grandchildren are missing, and a click leaves the page for the chat.

Why it matters

This is migration step 4 of the crewmate workers RFC (#26643), with the click behavior the owner chose in #27837. The person can see what a mate's sessions are doing from the mate's own page.

Not a goal

  • Hiding anything from the sidebar or any list (step 6, behind a flag).
  • Approvals or question cards in the mate chat (step 5).
  • Opening a session's transcript from the tab: it stays reachable from History and search.

What changed (motivation → approach → change)

Goal → reuse the Crew panel's list and groups, rooted at the mate thread (#28869 makes the routes answer a mate), and add one records-only recap read → this change:

  • Sessions tab (pages/members/MateSessionsList.tsx): the open sessions the store stamps mate_root for the mate, merged with the mate's GET .../crew-workers answer, which adds closed sessions and the ledger line. A session adopted or released away keeps its birth created_by and is not listed. Rows sit in the Crew panel's groups; "Waiting on the main chat" reads "Waiting on ", and Done is folded. A 404 from an older gateway is no data, not an error; a 404 that names the mate as no root yet (its thread still restoring) keeps polling. The mate side panel's session filter adds mate_root (MembersPageSidePanel.tsx), and the profile card swaps its flat list for the new component (MembersPageProfile.tsx).
  • Click: the row says Details with a down chevron, expands in place (aria-expanded), and a second click folds it. No navigation, no side panel, no drawer. Open approvals and questions say to open that session from the sidebar to answer them (this PR hides nothing from the sidebar).
  • Recap route (GET .../crew-workers/{worker}/recap, dashboard/handlers/crew_worker_recap.py): exactly the lines the docs(rfc): ask where a crewmate's sessions live, mate home folder or lineage stamps #27837 table lists, read from the work item and the session's own crew-log folds (timeline, approvals, tools). It never reads the model-written intent summary. It uses the Crew panel's gate and tree check, so it is owner only and refuses a session outside the named root's tree. Text goes through the board's redactor. A PR link is a GitHub pull-request artifact, or pr on the acceptance's owner/name repo, and its label is the number in that link. A closed session's folds come from its newest saved unit. The route is a registered redaction sink (src/kiro_crew/security_posture_sinks_gateway.py). crew_workers._ledger_work_items is split out of _ledger_items so both read one board seam.
  • Empty: no report lines → "No report yet"; open approvals and questions still show.
  • i18n: 24 new pages.membersPage keys in all 12 catalogs plus the pseudolocale; driving_idle, now unused, is removed.
  • Client: api.crewWorkerRecap (website/src/api/client/chat.ts), the CrewWorkerRecap type and the slot's mate_root field (website/src/types/index.chat.ts, website/src/types/index.ts).
  • Feature map, crew-mode spec, the API key-order test (website/src/test/ApiClient.refactor.surface.test.ts) and route-table goldens updated. src/kiro_crew/crew_mode.py changes only in feat(crew-mode): the Crew panel routes answer a crewmate thread as a root #28869's commit.

No preview flag: the RFC gates only the hiding step, so this tab is additive.

Backwards compatibility

Compatible: the tab still lists every live session the mate created, plus more; one new GET route; a Crew Mode root's routes are unchanged.

Reader: website/src/pages/members/MembersPageProfile.tsx:sessionsBody -- crew page -- the row click no longer opens the session; it expands a recap instead (owner decision in #27837); MembersPageProfile.drivingTitle.test.tsx "expands the clicked row in place and never opens the session"
Reader: website/src/i18n/locales/en.json:pages.membersPage.driving_idle -- crew page -- its one reader was the removed flat list; no other source names it (git grep)

Tests

Backend, test/test_crew_worker_recap.py:

  • the recap carries the item's own lines (title, status/reason/state, summary, decision, PR link, artifacts, last update);
  • a session with no item is its slot title and nothing else;
  • a grandchild's item is found on its sub-conductor's ledger;
  • sessions outside the tree, and a non-root, are refused; the owner gate holds;
  • no model call: every chat_summary callable is patched to raise, and the module never names it;
  • report text is redacted; a PR link never comes from a malformed repo or a non-GitHub URL;
  • the session folds give the last turn end, pending approvals and open ask_question calls under any prefix; a closed session reads its newest saved unit.

Frontend:

  • MateSessionsList.test.tsx: Crew panel groups with "Waiting on Ada" and Done folded; stamped store rows show without the route, and an adopted-away row does not; empty state, also with no root; a not_crew_mode_root 404 keeps polling; a click (the row says Details) expands in place, the URL and history are unchanged, and neither summary API is called; the recap renders exactly the RFC lines with where to answer, "No report yet" when empty, approvals with no report, and a PR label that matches its link.
  • MembersPageProfile.drivingTitle.test.tsx: untitled rows read "Untitled session"; a click expands and neither opens the session nor navigates.
  • lib/crewWorkers.test.ts: liveMateWorkers takes stamped and direct rows, never the mate or a peer's row.

Proof: not provable -- other: new feature, not a fix; no production hunk to revert against a failing test.

Manual verification

The component was rendered in a browser against mocked API answers and clicked through: expand, fold, a second row, light and dark (screenshots below). Not run against a live gateway.

Screenshots / video

Mate Sessions tab with a row expanded in place. Each row says Details, and an open approval says where to answer it (light):

approval row expanded, light

A full recap with a PR link (dark), and a session with no report (light):

recap, dark

no report yet, light

More: collapsed list and the other theme of each

grouped light

grouped dark

recap light

approval dark

no report yet dark

Shot from the real MateSessionsList component with mocked API answers, in a local harness (pods are not available on this host).

Related Issues

Part of #28920

Stacked on #28869 (step 3, its first commit here); this PR's own change is the second commit.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 3, 2026 07:03
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 369e8688f1436ecb223a2f82621f1ffcf1eecd45 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The tab reuses the Crew panel's gate, tree check, groups and redactor, and adds only one read-only recap route.

Notes

  • The description calls _ledger_work_items a plain split of _ledger_items, but the diff also changes behaviour: if getattr(item, "worker_instance_id", None): continue stops peer-crew items from matching local slot keys. That changes the existing Crew panel's ledger lines and crew_workers.py:999's item lookup too. Say so in the description, or move it to its own fix.

[DESIGN-REVIEWED] 369e868

Description read

[DESCRIPTION-READ] 3f9f2f5eb14863f60ba2405ac0a540c822a01e9bac40638f37279fdfe74fab49

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 369e8688f1436ecb223a2f82621f1ffcf1eecd45 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: both RFCs (rfc-crewmate-workers-under-the-crewmate, rfc-mate-sessions-folder-or-lineage) are accepted on base and cover the tab and the in-place recap. Two small notes below.

Notes

  • Item 6 — undeclared: the description calls _ledger_work_items a split "so both read one board seam". The diff also adds if getattr(item, "worker_instance_id", None): continue, which changes the Crew panel's existing worker lines. No linked defect or base-failing reproduction is cited. Subtraction: drop the peer-crew skip from this PR and land it with its own reported defect.
  • Item 5 — duplicate of crew_workers._crew_ledger_items (crew_workers.py:360): crew_worker_recap._crew_item re-walks "root first, then each member" a second time. That makes 2 spellings of one walk (grepped dict.fromkeys(\[?root|members), and their skip rules already differ (board != worker vs key != root). Subtraction: replace _crew_item with one generic walk that returns the raw item, so _crew_ledger_items and the recap share it.

What this change ships

Inventory (8 items) — 6 justified

Intent: let the person see every session a crewmate dispatched, grouped by what each needs, and read its recap without leaving the mate's page. ADDITION.

  1. Sessions tab now lists closed sessions and grandchildren, in Crew panel groups, with Done folded — justified
  2. "Waiting on the main chat" reads "Waiting on " in this tab — justified
  3. Row click expands a recap in place instead of opening the chat — justified
  4. "No report yet" empty recap; open approvals still show — justified
  5. New GET .../crew-workers/{worker}/recap route, records only, redacted — duplicate of _crew_ledger_items walk
  6. Crew panel ignores ledger items bound on a peer crew — undeclared
  7. Mate side panel's session filter adds mate_root — justified
  8. driving_idle string removed; 24 new i18n keys — justified

[FIRST-PRINCIPLES-REVIEWED] 369e868

Description read

[DESCRIPTION-READ] e8e81a8d325db5491974c99296a7d9f1f26f814454afe8d058a8c188ef2feea5

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 369e8688f1436ecb223a2f82621f1ffcf1eecd45 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the Done group opened and the two new failure notices. No supplied screenshot shows them, and the blind reader said: "What 'Done · 1' holds: I never see it opened."

Evidence gaps

  • The Done · N disclosure opened, with its finished rows and their recap (the Reported done / accepted / rejected / abandoned status lines). Needs a screenshot of the Done group expanded.
  • The sessions_read_failed notice ("Could not load the full session list. Showing the open sessions.") above a partial list. Needs a screenshot of the list read failing.
  • The recap_failed notice ("Could not load this session's details."), both alone and above a recap that was already loaded. Needs a screenshot of an expanded row whose recap read failed.

Notes

  • recap_answer_where, "open that session from the sidebar to answer it": the old row click opened the session, and now nothing here does. The reader "can't find where" to go and asked "Is a session the same thing as a job card?" Suggested fix: in the approval and question lines, make the session's title a link that opens that session.
  • In the screenshots, a row under APPROVAL NEEDED shows a bare "In progress" status, and a row under WORKING has an open question. The reader said "The heading and the details tell different stories." If the gateway can send a status that disagrees with the row's group, lead the Status line with the group's own state.
  • The reader thought "Waiting on Ada", "Waiting for approval" and "Has a question" meant nearly the same thing and could not tell them apart. Suggested fix: rename recap_open_approvals to "Approvals to answer" so it no longer starts with "Waiting".

[UX-REVIEWED] 369e868

Description read

[DESCRIPTION-READ] 82b2965cb3f31052944a3440aa3445c8f1cef5c349becc43786db756ce66e195

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 369e8688f1436ecb223a2f82621f1ffcf1eecd45 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 369e868

Verdict parsed from the review's SHA-scoped output markers for commit 369e8688f1436ecb223a2f82621f1ffcf1eecd45.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 369e8688f1436ecb223a2f82621f1ffcf1eecd45 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 369e8688f1436ecb223a2f82621f1ffcf1eecd45 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 369e868

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 369e8688f1436ecb223a2f82621f1ffcf1eecd45 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from 4b72208 to 87c493b Compare November 3, 2026 07:55
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security_posture_sinks_gateway.py

  • @iamwhatever posted a complete reasoning template for 369e868.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from 87c493b to fb36cc9 Compare November 3, 2026 08:37
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from fb36cc9 to cead2fc Compare November 3, 2026 09:41
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from cead2fc to 7c07eb5 Compare November 3, 2026 09:45
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from 7c07eb5 to 3e2c942 Compare November 3, 2026 10:51
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 4, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from b07a371 to 87f447c Compare November 4, 2026 07:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 4, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes at 87f447c for one point. The project now has a standing rule that a fix must not rely on regex to parse text, and this PR adds regex to recognise a pull-request link:

  • dashboard/handlers/crew_worker_recap.py:48 adds _GITHUB_PR_URL = re.compile(...), and line 91 uses it (_GITHUB_PR_URL.fullmatch(value)) to decide whether an artifact value is a PR link.
  • website/src/pages/members/MateSessionsList.tsx:54 adds a regex .exec(url) to pull the PR number out of that URL.

Please replace both with a structured check:

  • Backend: parse the value with urllib.parse.urlsplit. Then require scheme == "https", netloc == "github.com", and a path that splits into exactly owner, repo, "pull", number (plus at most one known suffix such as files), with number being digits that don't start with 0. Better still, read pr and the repo from the work item's typed fields, which the recap already has for pr, and build the link from those, instead of judging free-form artifact text.
  • Frontend: use new URL(url), compare hostname and protocol exactly, and split pathname. Or take the number straight from the recap's pr field rather than from the URL.

Your existing tests cover the cases this must keep (a branch named pull/7 is not a PR, and a non-GitHub URL is refused), so they can stay as they are.

The open design question on this PR, whether a row click shows the recap or opens the session, is still with the maintainers. It is separate from this point.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch from 87f447c to 56b407d Compare November 4, 2026 08:17
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@bolichen97 the no-regex point is addressed in 56b407d:

  • Backend (crew_worker_recap.py): the PR link is built from the item's typed pr and acceptance repo first. A reported artifact is used only when urllib.parse.urlsplit shows https, netloc github.com exactly, no query, and a path of owner/repo/pull/<n> with at most one of files/commits/checks; n is digits with no leading zero.
  • Frontend (MateSessionsList.tsx): new URL, exact protocol and host, no credentials, port or query, the path not rewritten by the parser, and the same segment rule.
  • No regex is left in either path. Tests on both sides cover a branch named pull/7, non-GitHub hosts, http, a leading zero, a query, a port, credentials, dot segments, bad name characters and extra segments.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 4, 2026
@iamwhatever
iamwhatever force-pushed the feat/mate-sessions-tab-recap branch 2 times, most recently from 038ad47 to 1b7e22e Compare November 4, 2026 09:16
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026

@buluoray buluoray left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approving 369e868. The code is right. The three text fixes below are non-blocking; please make them before merge.

What this does for users: a crewmate's Sessions tab now lists every session the mate dispatched at any depth, closed ones included, in the Crew panel's groups. Clicking a row expands a records-only recap in place.

Text to fix (non-blocking):

  1. The description says "a Crew Mode root's routes are unchanged" and calls _ledger_work_items a split. The new worker_instance_id skip (crew_workers.py:345-348) also changes the existing Crew Mode list's ledger lines (_crew_ledger_items) and the steer route's item lookup (crew_workers.py:999). It is a correct fix: it matches work_ledger.py:523 and :771, and test_a_peer_crews_item_never_stands_for_a_local_session pins it. But the compatibility section should say it, or it should land separately. The Design and First Principles lanes raised the same point.
  2. crew-mode.md says the artifact PR link is one "that urlsplit parses". The code at this head uses the PR monitor's parse_github_pull_request_target. That parser uses urlparse, accepts www.github.com, and requires exactly /owner/repo/pull/N with no suffix. Please name that parser. The 08:17Z comment also describes the earlier implementation rather than this one.
  3. "Stacked on #28869 (its first commit here)" is stale: #28869 has merged, and the PR is one commit.

Checked and fine:

  • No model call. The recap reads the work item and the session's timeline/approvals/tools folds only, and never imports chat_summary. It polls every 10 s only while the tab is open.
  • No cross-mate leak. The route has the owner gate and refuses app callers, requires a known root, and returns 404 for a session outside that root's stamped tree or closed lineage. The client filters on the server's mate_root stamp.
  • Redaction runs before cutting, and the status/reason/state values are store-validated enums.
  • The regex point from the earlier review is addressed at this head. The new code has no regex and reuses the existing PR and source-link parsers.
  • i18n: 24 keys present in all 12 catalogs plus the pseudolocale, with {{name}} kept. File sizes are well under the cap.

Evidence. Backend: 103 tests passed across the three touched files. Frontend: 227 tests passed in three of the four touched files. MembersPageProfile.drivingTitle.test.tsx was not run locally because of a local dependency gap; it is green in CI. I ran three mutations one at a time, and each reddened a named test:

  • Removing the tree check reddened test_a_session_outside_the_tree_and_a_non_root_are_refused.
  • Removing the redactor reddened test_text_is_redacted_before_it_is_cut and test_report_text_is_redacted.
  • Removing the peer skip reddened test_a_peer_crews_item_never_stands_for_a_local_session.

The UI points below are from source reading only:

Follow-ups, not blocking:

  • reply has no status label, so a reply report shows no status line.
  • An untitled session's recap prints its short key ("chat-3") as an extra heading, because the server and client fallbacks differ.
  • The recap returns artifacts and approval tool names that the UI never renders.
  • _crew_item duplicates the _crew_ledger_items walk.
  • "N · … to answer it" reads oddly when N > 1.

Review state: the earlier CHANGES_REQUESTED review is still open, and its reviewer should re-check this head. That review also says the click-shows-recap question is still open, while the RFC on main records it as decided. The owner should confirm which one stands. Sensitive Change Review is red waiting for its template on this head.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 369e868
  • What rule changed: No rule changed. src/kiro_crew/security_posture_sinks_gateway.py gains one row in _GATEWAY_SINKS (hunk at line 856, +7 lines, 0 removed) that registers the new recap route as a redaction sink: "One crew member's in-place recap" -> dashboard/handlers/crew_worker_recap.py. The route is GET /api/chat/slots/{slot}/crew-workers/{worker}/recap (dashboard/server_runtime/mcp_routes.py:459).
  • Before -> after (what was allowed/blocked, now): Before: no recap route existed. After: the owner can read a read-only recap of one session in a mate's tree. It is gated by the same owner check as the crew-workers list (crew_workers._gate(request, "crew_mode.recap"), crew_worker_recap.py:283). It returns 404 for a non-root or a session outside that root's tree. Ledger text (title, summary, decision, artifacts, PR link, pending approval tool names) goes through work_ledger_board._redact_deep (crew_worker_recap.py:60-72, called at :239) on the WHOLE strings. It is cut to length only afterwards (_cut :55, _cut_artifacts :134-141, applied at :253-271). Nothing that was blocked is now allowed. No other sink row changed.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): A secret a worker pasted into its work report (summary, decision or artifact) reaches the owner's own browser in the recap. Bounded: the route is owner-only (app callers and non-owners get 403), and it shows the same ledger text the work-ledger board already shows through the same redactor. It does not break commands or lock anyone out: the route is additive and read-only.
  • Evidence checked (which sandbox result proves it): N/A for a sandbox result: no sandbox, fence, mask or shell-gate rule is touched. The evidence is tests on this head. test/test_crew_worker_recap.py::test_report_text_is_redacted (an AKIA key in the summary is gone). ::test_text_is_redacted_before_it_is_cut (a key that straddles the 2000-char and 512-char caps is removed whole from summary, decision and an artifact). ::test_the_recap_keeps_the_owner_gate (403 for a denied owner check and for an app caller). ::test_a_session_outside_the_tree_and_a_non_root_are_refused. ::test_the_recap_makes_no_model_call. CI "New-test stability (ubuntu-latest)" ran this file repeatedly on 369e868: 86 passed in each of 6 runs (11:04:55Z-11:09:46Z).
  • No regression:
    • Tools still work (which tools/commands were run, result): Local, on this tree before push: pytest on test_crew_worker_recap.py, test_crew_workers_mate_root.py, test_shared_crew_worker_bindings.py, test_github_pull_request_monitor.py, test_security_posture.py, test_security_posture_facade.py and test_crew_mode_trust_posture.py (180 passed). Also isort, black, flake8, mypy and scripts/docs-lint.sh, all clean. In website/: tsc, eslint, npm run i18n:check, and vitest on src/pages/members, src/lib/crewWorkers.test.ts, src/test/ApiClient.refactor.surface.test.ts and src/i18n (2412 passed). A live gateway run of the route on this head: UNVERIFIED.
    • Backward compatible (old config / old data / old callers still work, how checked): Additive. A new route and a new sink row. No config key, stored format or existing route signature changes. Existing crew-workers list / timeline / steer / approve behaviour for a mate root merged earlier in feat(crew-mode): the Crew panel routes answer a crewmate thread as a root #28869. This PR shares the open-slot row mapper (liveWorkerRow) and skips peer-crew ledger items (worker_instance_id set) when matching local sessions (crew_workers._ledger_work_items). Checked by the test_crew_workers_mate_root.py / test_shared_crew_worker_bindings.py runs above and the full backend suite below. An older gateway without the route: the UI treats 404 as no data (MateSessionsList.tsx listNotServed / recapGone), covered by MateSessionsList.test.tsx. Behaviour against a real older gateway: UNVERIFIED.
    • Existing tests (which suites passed on this head): CI on 369e868 (check-runs read 16:55Z: 83 success, 11 skipped; the only failures/cancel are Sensitive Change Review). Backend Tests (3.12, 1-8) all success (shard totals 28830 / 34098 / 29262 / 28643 / 32286 / 33753 / 27391 / 28859 passed). Backend Tests (Windows) 1-8, IPv6 ubuntu/windows, namespace sandbox, crew container, Kernel Lock Owner: success. Frontend Tests 1-4 success (982 / 982 / 981 / 981 test files). E2E (stub ACP backend, offline), E2E Gateway Boot ubuntu/windows, E2E private member namespace: success. Coverage Gate, Fast Gate, Security Scope Review, First Principles, GPT 6.1, Opus 5.5: success.
  • How to undo: Before merge: close feat(members): a crewmate's Sessions tab groups its sessions and shows a recap in place #28931; nothing ships. After merge: git revert <merge commit of #28931> (the PR is one commit, 369e868). That removes the route, the sink row and the Sessions tab together. No data migration, so a revert leaves no stored state behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants