Skip to content

docs: record that a bot's sessions tab opens a session - #36187

Merged
buluoray merged 1 commit into
mainfrom
crew/slack/decision-bot-sessions-tab
Nov 14, 2026
Merged

buluoray merged 1 commit into
mainfrom
crew/slack/decision-bot-sessions-tab

Conversation

@buluoray

@buluoray buluoray commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the maintainer's decision that a Bot's Sessions tab can open a session from its recap, and that a session with no report shows the task the Bot last gave it.

A Bot's Sessions tab lists the worker sessions it started. A click expands a row in place into a recap. Two things about that recap were decided on 2026-11-03 and are now changed:

Both behaviours follow a recorded decision, so no code may change them until a new entry supersedes it. This pull request is that entry and nothing else.

Why it matters

Without the entry, the two fixes are regressions by this repository's own rule (docs/decisions/README.md, rule 6) and cannot land. With it, a person can open a worker session from the one place that lists it, and the recap stops reading as empty for sessions that hold real work.

Not a goal

  • No code change. The button and the recap change come in their own pull requests, after this entry is signed.
  • No change to the rest of the 2026-11-03 entry: sessions stay grouped by lineage stamps, stay out of the person's session lists, and a row click still expands in place.
  • No change to the 2026-11-06 entry: every task a Bot hands to a worker still belongs in its work ledger.

What changed (motivation → approach → change)

One new decision entry and its row in the entries table.

File under docs/decisions/ Change
2026-11-12-a-bots-sessions-tab-opens-a-session-and-shows-the-task-it-was-last-given.md New entry. It supersedes, in part, 2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md.
README.md One new row in the entries table.

What the entry says:

  • A row click still expands the recap in place.
  • The opened recap has a button that opens that session in the chat view. For a closed session it reads "Reopen session" and reopens the saved conversation first. It is the recap's one action; everything else in the recap stays read-only.
  • A session whose work item has no report, or that has no work item, shows a bounded excerpt of the latest message the Bot sent to that worker, in place of "No report yet". The rest is reached through the button. "No report yet" stays for a session the Bot never sent a message.

The maintainer signed this entry. Ray Xu (@buluoray) restated the decision in a comment on this pull request, as docs/decisions/README.md rule 4 asks, and the entry's first Evidence line links that comment. A chat message is not evidence, so the entry quotes none.

An agent wrote the entry's text. The decision is the maintainer's.

The reviewer rule blocks this pull request by design. docs/decisions/README.md rule 3: a superseding entry "ships in its own pull request: the recorded-decisions-are-not-regressions rule blocks that PR by design, and a maintainer's override is what lets it land". No override is requested here; that is the maintainer's step.

Backwards compatibility

Compatible: documentation only. The 2026-11-03 entry stays byte-identical (scripts/check_decisions_history.py passes), and no code reads this file.

Removes nothing: no entry is edited, renamed or deleted.

Tests

No test changes: the diff is two documentation files.

Checks run on this head:

  • DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py: every entry at the base is intact at the head.
  • bash scripts/docs-lint.sh: all documentation checks passed.
  • scripts/check_brand_name.py and scripts/check_comment_history.py against the merge base: clean.

Manual verification

N/A: no behaviour changes. The entry was read against the format in docs/decisions/README.md and against the entry and RFC section it changes.

Related Issues

Part of #36175
Part of #36177

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 12, 2026 23:20
@buluoray
buluoray requested a review from mbriones98 November 12, 2026 23:20
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Documentation only. The new decision entry follows the supersede process in docs/decisions/README.md and links a maintainer comment on the record as its evidence.

Notes

  • Supersedes: names the whole 2026-11-03 entry, but the Decision sentence supersedes it only "in part". A reader who only scans headers may take every rule in the 2026-11-03 entry as replaced. Saying "in part" in the README table row helps, but the header line itself still names the whole entry.

[DESIGN-REVIEWED] 76438a0

Description read

[DESCRIPTION-READ] d229657c8463fea258bd3e0fea1cf21a5f7118085a12d4fc8b451d588390adf8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 — this comment is updated in place on each push.

Human judgment by @buluoray overrides the Opus 5.5 finding for 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] 76438a0

Verdict recorded from an authorized human decision for commit 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 76438a0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0 false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Request changes

Why: the decider found 1 problem and estimates an 85% chance that this change introduces a defect, at or above the 80% level where it asks for changes.

This docs-only PR adds a decision entry that partly supersedes the 2026-11-03 Sessions-tab entry, plus its row in the README index. The content checks out against the repo. The RFC sentences it cites exist ("no longer opens it" and "no report yet" in rfc-mate-sessions-folder-or-lineage.md, lines 100 and 104). So does the quote from the 2026-11-06 ledger entry. The named maintainer, Ray Xu (@⁠buluoray), is in MAINTAINERS.md, and no existing entry is edited. The problem is that the entry is not signed at this head: its key Evidence line reads PENDING. Entries are immutable once merged, so landing this head would permanently record a decision without the on-record maintainer restatement that rule 4 requires. The PR description says as much. Swap PENDING for the comment link, then land it with the maintainer override.

Problems found:

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 7e8b22ccf6 · 22 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

I decided this, as maintainer:

On a Bot's Sessions tab a click on a row still expands it in place into a recap. The opened recap carries one button that opens that session in the chat view ("Reopen session" for a closed session, which is reopened from its saved conversation first); everything else in the recap stays read-only. A session whose work item has no report, or that has no work item, shows a short excerpt of the latest message the Bot sent to that worker, through the same redaction as the row, in place of "No report yet". "No report yet" stays only for a session the Bot never sent a message. This supersedes, in part, 2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md (its "recap built from the crew log only" clause); every other rule of that entry stands.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@buluoray
buluoray force-pushed the crew/slack/decision-bot-sessions-tab branch from 7e8b22c to 1d03218 Compare November 13, 2026 10:20
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 13, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

I decided this, as maintainer. It replaces my earlier comment on this pull request (#36187 (comment)), which said "short excerpt" and left out the RFC sentences.

On a Bot's Sessions tab a click on a row still expands it in place into a recap. The opened recap carries one button that opens that session in the chat view ("Reopen session" for a closed session, which is reopened from its saved conversation first). It is the recap's one action; everything else in the recap stays read-only.

A session whose work item has no report, or that has no work item, shows a bounded excerpt of the latest message the Bot sent to that worker, in place of "No report yet": a few lines, through the same redaction as the session's row, with the rest reached through the button. "No report yet" stays only for a session the Bot never sent a message.

This supersedes, in part, 2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md: its "recap built from the crew log only" clause, and with it the sentences "the Sessions tab no longer opens it" and "shows its title and 'no report yet'" of docs/request-for-change/rfc-mate-sessions-folder-or-lineage.md. Every other rule of that entry stands.

@buluoray
buluoray force-pushed the crew/slack/decision-bot-sessions-tab branch from 1d03218 to e7779ee Compare November 13, 2026 19:17
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 13, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt e7779ee owner-decision: The maintainer decided this superseding entry and restated it on this PR: #36187 (comment). The rule blocks a Supersedes entry by design; this override is the approval it asks for.

@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override fable e7779ee owner-decision: The maintainer decided this superseding entry and restated it on this PR: #36187 (comment). The rule blocks a Supersedes entry by design; this override is the approval it asks for.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the gpt AI finding on e7779ee79c6e97253aeb5ebe67a2a6a1ab3ce1dc.

The maintainer decided this superseding entry and restated it on this PR: #36187 (comment). The rule blocks a Supersedes entry by design; this override is the approval it asks for.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the fable AI finding on e7779ee79c6e97253aeb5ebe67a2a6a1ab3ce1dc.

The maintainer decided this superseding entry and restated it on this PR: #36187 (comment). The rule blocks a Supersedes entry by design; this override is the approval it asks for.

This decision applies only to this commit. A new push requires a new judgment.

A Bot's Sessions tab expands a row in place into a recap and gives
no way to open the session, and a session with no bound work item
always reads "No report yet".

This entry records the change of mind: the opened recap gets a
button that opens the session, and a session with no report shows a
bounded excerpt of the latest message the Bot sent to that worker.
It supersedes, in part, the 2026-11-03 Sessions tab entry. The
evidence line for the maintainer's restatement is filled in before
this merges.

Part of #36175
Part of #36177
@buluoray
buluoray force-pushed the crew/slack/decision-bot-sessions-tab branch from e7779ee to 76438a0 Compare November 13, 2026 23:23
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 76438a0 reissue: Same ruling as #36187 (comment) for this rebased head; the entry is unchanged and the maintainer's decision is #36187 (comment).

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a reissue release (class reissue) for the fable AI finding on 76438a09cae4fb11b07f9ac7e98e4c77daab7bd0.

Same ruling as #36187 (comment) for this rebased head; the entry is unchanged and the maintainer's decision is #36187 (comment).

This decision applies only to this commit. A new push requires a new judgment.

@buluoray
buluoray enabled auto-merge (squash) November 14, 2026 00:22
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 14, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the whole diff at 76438a0: one new decision entry and its README row.

  • The entry is narrow. A row click still expands the recap in place, and the recap gains one action, open or reopen in the chat view, while everything else stays read-only.
  • The "No report yet" replacement is bounded. It's a few lines of the Bot's latest message to that worker, through the same redaction as the session's row. "No report yet" stays for a session the Bot never sent a message.
  • The supersession is scoped. It names the exact clause of 2026-11-03-a-crewmates-sessions-leave-the-sidebar-for-its-sessions-tab.md and the two RFC sentences it replaces, says every other rule stands, and links the issues (#36175, #36177) and #28931.
  • The README row matches the entry. This is a docs-only change with no code and no regex.

All checks are green. Approving. Auto-merge is left as you set it.

@buluoray
buluoray merged commit a60e984 into main Nov 14, 2026
97 of 99 checks passed
@buluoray
buluoray deleted the crew/slack/decision-bot-sessions-tab branch November 14, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants