Skip to content

build(docker): install kiro-cli from the shared pin files, not the latest manifest (#25616) - #29340

Merged
buluoray merged 1 commit into
release/0.11.0from
crew/slack/0.11-docker-kiro-cli-pin
Nov 3, 2026
Merged

buluoray merged 1 commit into
release/0.11.0from
crew/slack/0.11-docker-kiro-cli-pin

Conversation

@buluoray

@buluoray buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let the 0.11 release lanes publish the Docker image again by installing kiro-cli from release/0.11.0's own pin (2.36.0), as #25616 does on main.

On release/0.11.0 the Docker build installs whatever kiro-cli the latest manifest names. The manifest moved to 3.0.0, whose installer puts the binary in /root/.local/bin, which is not on PATH, so the build's own check fails: kiro-cli --version -> /bin/sh: 1: kiro-cli: not found. That failed "Publish Docker Image (insider)" on the v0.11.2-rc.3 run (41724994078).

Why it matters

github-release needs publish-docker to succeed, so no 0.11 release run can finish while the build follows the latest manifest. v0.11.2 cannot reach stable until this lands.

Not a goal

  • No kiro-cli pin change: packaging/kiro-cli-version stays at 2.36.0 and packaging/kiro-cli-sha256 is unchanged.
  • No other workflow, runner or release-gate change.
  • No tag, no merge here, no version or CHANGELOG change.

What changed (motivation → approach → change)

git cherry-pick -x of 2896110cd5 (#25616). It applied with no conflict, and every added and removed line matches its main commit.

The Docker build reads the version from packaging/kiro-cli-version and the per-arch sha256 from packaging/kiro-cli-sha256 (bind-mounted into the build), and fails closed on a missing or mismatched hash. publish-docker.yml stops resolving the latest manifest, build-desktop.yml and .dockerignore follow the same pin, and docs/build/desktop-app.md and docs/build/release.md describe it. test/test_docker_kiro_cli_pin.py pins the behaviour.

On this branch the pin files are 0.11's own: version 2.36.0, with sha256 lines for 2.36.0/kirocli-x86_64-linux.zip and 2.36.0/kirocli-aarch64-linux.zip.

Backwards compatibility

Compatible: the image now gets the pinned kiro-cli instead of the latest one; no key, path or option is removed.

Removes nothing: the build stops following the latest manifest; no reader depended on that.

Tests

Proof: not provable -- other: a release-branch pick of #25616, whose proof ran on main

  • test/test_docker_kiro_cli_pin.py plus the 40 other test files that read the touched files: 2145 passed, 3 skipped. docs-lint: passed. Both workflow files parse as YAML.
  • Local docker build --platform linux/amd64 of docker/Dockerfile through the kiro-cli step: RESOLVED=2.36.0, /tmp/kirocli.zip: OK, kiro-cli --version -> kiro-cli 2.36.0.

Manual verification

The local build above. The next release run on the merge commit runs the real lane.

Related Issues

Part of the v0.11.2 release; ports #25616 to release/0.11.0. Follows #29325.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

…test manifest (#25616)

(cherry picked from commit 2896110)

Co-authored-by: Zezhen Xu <32421101+CrysisDeu@users.noreply.github.com>
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 3, 2026 22:09
@buluoray
buluoray requested review from cruisercohen and removed request for a team November 3, 2026 22:09
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 689b9218ac6c288b7c4aa0ca5ada16333cddbffd touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 689b9218ac6c288b7c4aa0ca5ada16333cddbffd — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a straight release-branch pick of #25616. It removes the cause (the build following a mutable manifest) by reusing the pin files that already exist.

What this change ships

Inventory (6 items) — 6 justified

Intent: let the 0.11 release lanes publish the Docker image again by installing the kiro-cli version 0.11 pins. This is a FIX.

  1. The Docker image installs pinned kiro-cli 2.36.0 instead of whatever the latest manifest names, and checks it against packaging/kiro-cli-sha256 — justified
  2. The KIRO_CLI_VERSION build-arg default changes from latest to empty, which skips the lane's cross-check — justified
  3. The publish lane labels the image from the pin file and no longer fetches the manifest — justified
  4. .dockerignore lets exactly the two pin files into the build context — justified
  5. The desktop-app and release docs, plus a build-desktop comment, now say the pin has a reader on every release — justified
  6. A new test checks that the Dockerfile never reads the manifest, that both architectures have a sha line, and that the lane label matches the pin — justified

[FIRST-PRINCIPLES-REVIEWED] 689b921

Description read

[DESCRIPTION-READ] bf25bf7a9e17a18470fce615a99a988b5ccd9e435e2ea5f0981546be063d765d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 689b9218ac6c288b7c4aa0ca5ada16333cddbffd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The Docker image now installs kiro-cli from the pin files the desktop build already uses, so a moved upstream manifest can no longer break or silently change a release image.

Notes

  • Each release now has to bump the kiro-cli pin as a deliberate step, and docs/build/release.md now describes it that way. Nothing fails if the pin falls behind the upstream release, so the risk is that images drift onto an older kiro-cli unnoticed.

[DESIGN-REVIEWED] 689b921

Description read

[DESCRIPTION-READ] 7ae7c1e3025a9cc9bcedfdd8298735cbdd03a393997bb723f4c590c2f5c6ce13

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 689b9218ac6c288b7c4aa0ca5ada16333cddbffd and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 689b921

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 689b9218ac6c288b7c4aa0ca5ada16333cddbffd false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 689b9218ac6c288b7c4aa0ca5ada16333cddbffd — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 689b921

Verdict parsed from the review's SHA-scoped output markers for commit 689b9218ac6c288b7c4aa0ca5ada16333cddbffd.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 689b9218ac6c288b7c4aa0ca5ada16333cddbffd false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@buluoray
buluoray merged commit 1c6a7ad into release/0.11.0 Nov 3, 2026
28 of 33 checks passed
@buluoray
buluoray deleted the crew/slack/0.11-docker-kiro-cli-pin branch November 3, 2026 23:29
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant