Repository navigation
build(docker): install kiro-cli from the shared pin files, not the latest manifest (#25616) - #29340
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a straight release-branch pick of #25616. It removes the cause (the build following a mutable manifest) by reusing the pin files that already exist. What this change shipsInventory (6 items) — 6 justifiedIntent: let the 0.11 release lanes publish the Docker image again by installing the kiro-cli version 0.11 pins. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 689b921 Description read[DESCRIPTION-READ] bf25bf7a9e17a18470fce615a99a988b5ccd9e435e2ea5f0981546be063d765d That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The Docker image now installs kiro-cli from the pin files the desktop build already uses, so a moved upstream manifest can no longer break or silently change a release image. Notes
[DESIGN-REVIEWED] 689b921 Description read[DESCRIPTION-READ] 7ae7c1e3025a9cc9bcedfdd8298735cbdd03a393997bb723f4c590c2f5c6ce13 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Let the 0.11 release lanes publish the Docker image again by installing kiro-cli from
release/0.11.0's own pin (2.36.0), as #25616 does onmain.On
release/0.11.0the Docker build installs whatever kiro-cli the latest manifest names. The manifest moved to 3.0.0, whose installer puts the binary in/root/.local/bin, which is not on PATH, so the build's own check fails:kiro-cli --version->/bin/sh: 1: kiro-cli: not found. That failed "Publish Docker Image (insider)" on the v0.11.2-rc.3 run (41724994078).Why it matters
github-releaseneedspublish-dockerto succeed, so no 0.11 release run can finish while the build follows the latest manifest. v0.11.2 cannot reach stable until this lands.Not a goal
packaging/kiro-cli-versionstays at 2.36.0 andpackaging/kiro-cli-sha256is unchanged.What changed (motivation → approach → change)
git cherry-pick -xof2896110cd5(#25616). It applied with no conflict, and every added and removed line matches its main commit.The Docker build reads the version from
packaging/kiro-cli-versionand the per-arch sha256 frompackaging/kiro-cli-sha256(bind-mounted into the build), and fails closed on a missing or mismatched hash.publish-docker.ymlstops resolving the latest manifest,build-desktop.ymland.dockerignorefollow the same pin, anddocs/build/desktop-app.mdanddocs/build/release.mddescribe it.test/test_docker_kiro_cli_pin.pypins the behaviour.On this branch the pin files are 0.11's own: version 2.36.0, with sha256 lines for
2.36.0/kirocli-x86_64-linux.zipand2.36.0/kirocli-aarch64-linux.zip.Backwards compatibility
Compatible: the image now gets the pinned kiro-cli instead of the latest one; no key, path or option is removed.
Removes nothing: the build stops following the latest manifest; no reader depended on that.
Tests
Proof: not provable -- other: a release-branch pick of #25616, whose proof ran on main
test/test_docker_kiro_cli_pin.pyplus the 40 other test files that read the touched files: 2145 passed, 3 skipped.docs-lint: passed. Both workflow files parse as YAML.docker build --platform linux/amd64ofdocker/Dockerfilethrough the kiro-cli step:RESOLVED=2.36.0,/tmp/kirocli.zip: OK,kiro-cli --version->kiro-cli 2.36.0.Manual verification
The local build above. The next release run on the merge commit runs the real lane.
Related Issues
Part of the v0.11.2 release; ports #25616 to
release/0.11.0. Follows #29325.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.