Repository navigation
feat(crew): pick a crewmate's agent harness from the runnable list - #29498
Conversation
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the harness page as this commit renders it. Every harness-page screenshot shows a caption the diff deletes, and no shot shows the per-option model-effect lines that replace it. Evidence gaps
Notes
[UX-REVIEWED] 0e1cb6d Description read[DESCRIPTION-READ] 29f6a301da77c9b62f5ae05c674fb7fd7fa5ddd9583332417570a51663a3dc06 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The picker and the save now check the same server list. Removing the preview flag is safe, because the loader drops unknown Notes
[DESIGN-REVIEWED] 0e1cb6d Description read[DESCRIPTION-READ] 5048a77eff52c57d10236b1772fc6602a08ec55ea7023cf55d0b9f5794b6fb4a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)GPT 6.1 flagged blocking issues on This comment is updated in place on each push. Review detailsBLOCKING -- website/src/pages/members/CrewProfileSettings.tsx:156 -- Confirmed Auto-only entitlement prevents runnable harness changes
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — LOW. I confirmed every condition in code: False positive or not applicable? A repository writer can comment: |
b4510b1 to
713b3e5
Compare
713b3e5 to
9443c47
Compare
9443c47 to
31c91ce
Compare
31c91ce to
8d62eb1
Compare
8d62eb1 to
94471b8
Compare
22072af to
2d2e05b
Compare
2d2e05b to
f3e2a23
Compare
f3e2a23 to
5a3c426
Compare
|
Disposition for GPT 6.1 F1 ("Auto-only entitlement is mistaken for an unknown catalog", Not changed, by owner decision. An auto-only list keeps the pins.
This matches the previous GPT round on F2 (a failed per-harness model read was silent) is fixed in this head: the picker names the harness whose list failed. |
The profile's Agent harness row leaves preview. It offers only the harnesses a crewmate can run on here (selectable on this gateway and crewmate-capable, so governance locks apply), computed once on the server by crewmate_harness.crewmate_harnesses(); a save accepts exactly that list. Inherited clears the pin. Each choice names its known worker limits, and a stored pin the list does not offer stays shown, marked unavailable. Part of #21910
|
/ai-review override first-principles 0e1cb6d owner-decision: Owner accepted taking the crewmate harness row out of preview, listing only runnable harnesses, before the RFC status flips from draft; decision recorded in RFC #29442 and amendment #30116 (both merged) and in #29509 (comment) |
Human judgment recorded@iamwhatever recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
bolichen97
left a comment
There was a problem hiding this comment.
Approving 0e1cb6d. I read the product hunks in crewmate_harness.py, crew_update.py, crew_records.py and sections_dashboard.py, and the picker change in CrewProfileSettings.tsx.
- The resolution order is untouched: a crewmate's pin still wins, then the inherited value, as in the signed #29442 direction. No stored pin is rewritten; a saved
kiropin reads back askiro. crewmate_harnesses(config)is the one list both the picker and a save use: selectable here (so governance'sagent_backendscope still narrows it), able to start here (a KAS that boot proved unstartable is left out), and crewmate-capable (ACP_BACKENDS_MEMBER_CAPABILITIES & ACP_BACKENDS_MEMBER_DISPATCH), judged by the runtime the pin actually starts on. That keeps a save from storing a pin a crewmate cannot run on, which is input validation, not a new security restriction.- The picker leaves Feature Previews and shows an "Inherited" choice that clears the pin. Tests cover the list, the governance lock, the Kiro CLI case, the unstartable KAS case and the save refusal.
No new regex. All checks pass on this head (97 ok, 0 red, 0 pending), and no human has an open change request.
Problem / Motivation
Goal: A person can pick each crewmate's agent harness in the crewmate's profile, choosing only from harnesses that crewmate can actually run on.
Today a crewmate's harness pin (
agents.<name>.acp_backend) can only be set by hand inconfig.json, or through a profile row hidden behind thecrewmate-harnessdeveloper preview (#25485). Even that row lists every selectable harness, including ones a crewmate cannot run on. Picking one of those stores a pin that refuses later.Why it matters
People who want one crewmate on Claude Code, and the rest on the default, have no normal way to say so. The preview row lets them store a pin that can never run a crewmate. A list the person can trust, with each harness's limits named, removes that trap.
Not a goal
CrewEditorNextDialog). The profile row stays the one picker.What changed (motivation → approach → change)
Goal → one server-side list that both the picker and the save use → the existing row out of preview.
crewmate_harness.crewmate_harnesses(config)returns the harnesses that are selectable here (selectable_backends(), which already applies the enterpriseagent_backendgovernance lock) AND crewmate-capable (ACP_BACKENDS_MEMBER_CAPABILITIES∩ACP_BACKENDS_MEMBER_DISPATCH). Each one is judged on the runtime its pin starts on (CrewBackendPin.resolve), so a Kiro CLI pin is offered only where kiro-cli runs it on KAS, and a KAS pin is not offered when boot recorded that KAS cannot start here (enterprise_boot.refuse_unstartable_kas). The two worker-limit lists are judged the same way, because a worker checks its session's runtime backend.GET /api/agents/resolved-modelreturns it asharnesses, beside the existingworker_harnesses.harness_pin_rejected(value, config)checks againstcrewmate_harnesses(config). Empty still clears the pin.crewmate-harnesspreview flag, its Feature Previews card, its i18n keys and its settings-registry entry are removed. The row now shows on every crewmate's Settings page. The "Choose an agent harness" button on the harness-error notice now always shows, because the row it opens is always there.ACP_BACKENDS_MATE_WORKER_KITsays its workers cannot start there; a harness with no limit has no line under it.Product-shape: this moves a control out of a developer preview to every user. The RFC for it is being written in parallel under
docs/request-for-change/; it is not on main yet and will be linked here when it exists.Backwards compatibility
Breaking:
PUT /api/agents/<name>with anacp_backendthat is selectable but not crewmate-capable now answers 400invalid_acp_backendinstead of storing it. Writer sweep on origin/main @ 405155b: the only writer ofacp_backendthrough this route isCrewProfileSettings.tsx, which now offers only the server list; no other caller sendsacp_backend(git grep -n "acp_backend" -- website/src src/kiro_crew/dashboard).Reader: src/kiro_crew/dashboard/agent_admin/crew_update.py:api_kirocrew_agent_update -- crew page -- the one caller of
harness_pin_rejected; updated, testtest_a_selectable_but_uncapable_harness_is_refusedReader: website/src/pages/members/CrewProfileSettings.tsx:CrewProfileSettings -- crew page -- the one reader of
PREVIEW_CREWMATE_HARNESS; the row no longer reads it, testreads Inherited and names what that runs on, with no preview switchReader: website/src/pages/settings/FeaturePreviewsSection.tsx:FeaturePreviewsSection -- crew page -- the preview card is removed with the flag; settings tests pass
Reader: src/kiro_crew/crewmate_harness.py:CrewBackendPin.resolve -- chat|cron|subagent -- start path unchanged, so an already-stored pin keeps the behaviour it has today; test
test_a_hand_edited_uncapable_pin_stays_named_in_the_readoutTests
test/test_crewmate_harness.py: offered list = selectable ∩ capable; a capable but unselectable harness is not offered; a governance lock removes a harness; a Kiro pin is offered only where it runs on KAS; worker limits name their harnesses; the save accepts exactly the offered list; the API refuses an uncapable harness; the readout keeps naming a hand-edited pin.website/src/pages/members/CrewProfileSettings.test.tsx: no preview switch; offers exactly the server list plus Inherited; Inherited clears the pin; only real limits show under a harness; a stored pin outside the list is not a choice and the notice names it; a harness pick keeps a model the new harness serves and resets one it does not; Inherited resets both pins; a failed model list read saves nothing; the keyboard can reach the choices when no option is checked.Proof: not provable -- other: feature addition, not a fix; the new tests lock in new behaviour
Manual verification
Rendered the real built SPA with every
/api/**stubbed (no gateway), and took the shots below. Local GPT and Opus reviews found nothing.Screenshots / video
The Settings page: the Agent harness row now shows with no preview switch.
The harness page: only the server's list. A harness with no limit has no line under it.
A stored pin the list does not offer (
goose): the Settings row reads "goose (unavailable)", the notice names it, and the harness page lists only runnable choices.A pin that can't start here: the notice and its "Choose an agent harness" button, which now always shows.
Other theme
Related Issues
Part of #21910
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.