Repository navigation
docs(rfc): record owner reveal of removed credentials (way A) - #29519
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only change: it records an owner decision in the RFC before the implementation lands, and nothing in Notes
[DESIGN-REVIEWED] f86d2af Description read[DESCRIPTION-READ] 27666248281667b3b38abdd37856adc312677fe7abe0d634e6dc5b9c9e7bcf5d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — 🔴 changes requested (blocking)Reviewed The RFC now contradicts itself on whether the owner can reveal a removed credential: §7 adds an owner-only Show button, but the unchanged §1 card text and §2 coach text still say the value can never be shown. BLOCKING — docs/request-for-change/rfc-redaction-explain-and-reveal.md:186 [BLOCK-MERGE] f86d2af Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
RFC update on a decision change that has been shared with the team. |
Problem / Motivation
Goal: Record the owner's decision that the dashboard owner may reveal a credential value redaction removed, under one rule future redaction work must keep.
A customer had an agent mint a secret and store it in Supabase, which cannot read secrets back. Chat redaction removed the only other copy, and the RFC says "there cannot be a 'show original' button". The owner decided on 2026-11-03 to allow an owner-only reveal from gateway memory ("way A").
Why it matters
The implementation PR #29513 adds that reveal. Its First Principles lane blocks because the RFC on main still rules it out. This docs-only PR records the decision on main first, as the repo's process asks for a product-shape change.
Not a goal
partial).What changed (motivation → approach → change)
docs/request-for-change/rfc-redaction-explain-and-reveal.md:Backwards compatibility
Compatible: documentation only.
Removes nothing: no code, route, record or key changes.
Tests
Proof: not provable -- docs or config only
Manual verification
N/A — docs only; rendered Markdown checked locally.
Related Issues
Implementation: #29513.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.