Skip to content

docs(rfc): record owner reveal of removed credentials (way A) - #29519

Merged
iamwhatever merged 1 commit into
mainfrom
docs/rfc-owner-reveal
Nov 4, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/rfc-owner-reveal

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the owner's decision that the dashboard owner may reveal a credential value redaction removed, under one rule future redaction work must keep.

A customer had an agent mint a secret and store it in Supabase, which cannot read secrets back. Chat redaction removed the only other copy, and the RFC says "there cannot be a 'show original' button". The owner decided on 2026-11-03 to allow an owner-only reveal from gateway memory ("way A").

Why it matters

The implementation PR #29513 adds that reveal. Its First Principles lane blocks because the RFC on main still rules it out. This docs-only PR records the decision on main first, as the repo's process asks for a product-shape change.

Not a goal

What changed (motivation → approach → change)

docs/request-for-change/rfc-redaction-explain-and-reveal.md:

  • New §7 Owner reveal (decided 2026-11-03) with the rule: Redacted values may be revealed only to the owner through the browser; no agent-reachable path may ever return them; originals never touch disk. It names memory-only storage (bounded, 24-hour TTL, record carries a handle only), the one owner-gated reader that refuses every internal/agent/app/non-owner caller, audit before the value is returned, Show/Copy/Hide, the computer-use identity limit, and the surfaces covered (this gateway's own replies; no messaging channels).
  • Three sentences that said nothing could ever show a removed value now point to §7 (fact 1, §4a preview, What does not change).

Backwards compatibility

Compatible: documentation only.

Removes nothing: no code, route, record or key changes.

Tests

Proof: not provable -- docs or config only

Manual verification

N/A — docs only; rendered Markdown checked locally.

Related Issues

Implementation: #29513.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 4, 2026 09:07
@iamwhatever
iamwhatever requested a review from CrysisDeu November 4, 2026 09:07
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision f86d2af8702e00909ede44198270d78fe64b15f4 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision f86d2af8702e00909ede44198270d78fe64b15f4 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f86d2af8702e00909ede44198270d78fe64b15f4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only change: it records an owner decision in the RFC before the implementation lands, and nothing in docs/decisions/ conflicts with it.

Notes

[DESIGN-REVIEWED] f86d2af

Description read

[DESCRIPTION-READ] 27666248281667b3b38abdd37856adc312677fe7abe0d634e6dc5b9c9e7bcf5d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed f86d2af8702e00909ede44198270d78fe64b15f4 — this comment is updated in place on each push.

The RFC now contradicts itself on whether the owner can reveal a removed credential: §7 adds an owner-only Show button, but the unchanged §1 card text and §2 coach text still say the value can never be shown.

BLOCKING — docs/request-for-change/rfc-redaction-explain-and-reveal.md:186
"- Not saved — the system removed the value before saving, so this page cannot show it and no setting can change that." (also §2, line 229: "the conversation cannot show them, and no setting changes this for the conversation.")
Trigger: someone builds the lock-tag card or the coach from this RFC. §1 gives the card's three lead facts and §2 gives the coach text. The diff updates Fact 1, §4a and "What does not change" to name Owner reveal, but leaves these two places as they were.
Outcome: the spec gives two answers. Built as written, the card says "this page cannot show it" right next to §7's Show button. Or an implementer follows §1 and §2 and leaves out the reveal that §7 records as decided.
Anchor: defect
Fix: reword the §1 "Not saved" fact and the §2 coach sentence to name the Owner reveal (§7) exception, the same way the diff reworded Fact 1 and the §4a preview.

[BLOCK-MERGE] f86d2af
[OPUS-REVIEWED] f86d2af

Verdict parsed from the review's SHA-scoped output markers for commit f86d2af8702e00909ede44198270d78fe64b15f4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f86d2af8702e00909ede44198270d78fe64b15f4 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f86d2af8702e00909ede44198270d78fe64b15f4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f86d2af

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f86d2af8702e00909ede44198270d78fe64b15f4 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

RFC update on a decision change that has been shared with the team.

@iamwhatever
iamwhatever merged commit 89c6361 into main Nov 4, 2026
92 of 94 checks passed
@iamwhatever
iamwhatever deleted the docs/rfc-owner-reveal branch November 4, 2026 17:46
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant