Repository navigation
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs only: this adds a draft RFC that records a decision for a maintainer to make, and it changes no code. Notes
[DESIGN-REVIEWED] 2e5c8e4 Description read[DESCRIPTION-READ] 2e96c224d828b408d0abae7a625473ec791fa25ac0a11b37f63190afa53380fe That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9290302 to
2e5c8e4
Compare
|
Design brief for maintainers (RFC, docs only; no approval from me, the decision is a maintainer's). What it proposes. Scrub credentials from every transcript row at write time, including rows a person typed into a channel. Today For. In a shared channel, a pasted key is kept raw for as long as the transcript exists, and every reader, search, memory consolidation and summaries see it. One boundary for every role is simpler than eleven caller-side scrubs that each new persister must remember. Against.
Long-term debt. The two-rule state is the main debt; open question 1 (route the dashboard save in the same release) would close it. A reveal-on-demand store would remove the irreversibility, but nothing on base has one. It tightens an existing rule (user rows were stored verbatim by design, and |
bolichen97
left a comment
There was a problem hiding this comment.
Maintainer decision (security sign-off): not adopted; this tightens what is changed in stored user messages.
Thanks for writing this up so carefully. The RFC states its costs plainly, and its audit of the current code is accurate. The project's current rule is not to increase security strictness, and this proposal would rewrite text a person typed, so user-typed rows stay stored as typed. The open questions, especially a reveal-on-demand store for originals, are worth keeping in mind if that rule changes.
|
Hold at 2e5c8e4 for a maintainer decision about what to do with this PR. The RFC text is clear and its audit of the code is accurate. But a maintainer has already ruled on it: bolichen97's review of this head says the proposal is not adopted and user-typed rows stay stored as typed. This PR would still land the document as KiroCrew/docs/request-for-change/rfc-redact-user-rows-at-rest.md Lines 1 to 13 in 2e5c8e4 KiroCrew/docs/request-for-change/README.md Lines 244 to 255 in 2e5c8e4 rejected status today.
To clear this, a maintainer should either close the PR, or have it land as a record of the rejection: a status line and index row that say it was not adopted, with the reason. The Design lane's note about the withheld-row cost is moot once the proposal is rejected. — crew-pr-reviewer (r146) |
|
This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result on this head: docs only (one new RFC and one index row, +105/-0). No security defect and no blocking repository rule applies. The code audit holds up at the audited commit. The The open point is the record, not the code. A maintainer review on this exact head says the proposal is not adopted. Merging as is would put it on main as Optional, only if some version of the doc is kept:
|
|
Thank you for the careful write-up. A maintainer reviewed this RFC and decided not to adopt it: user-typed rows stay stored as typed under the project's current security rule (#29685 (review)). Closing this PR for that reason. The open questions, such as a reveal-on-demand store for originals, remain on record here if that rule changes. |
Problem / Motivation
Goal: Record, as a draft RFC, the decision to scrub credentials out of the transcript rows people type, so a maintainer can accept or reject it.
A credential someone pastes into a channel is stored in the transcript as typed.
_redact_at_write_boundaryreturns user rows unscrubbed, and every dashboard reader of that conversation is served the row. #10965 removes that exemption, which reverses a rule the code pins, and its First Principles lane blocks until the decision is on record.Why it matters
In a shared channel, more than one person reads the same transcript, so a pasted key outlives the moment it was typed. The fix costs something real: the rewrite cannot be undone. That trade is a maintainer's call, and without a record #10965 cannot merge.
Not a goal
draft; a maintainer decides.What changed (motivation → approach → change)
A new draft RFC,
rfc-redact-user-rows-at-rest.md, and its row in thedocs/request-for-change/README.mdindex. The RFC states the problem, the proposed rule (scrub every role at write, plus the title and live-slot copies), the costs accepted, three alternatives and three open questions.Backwards compatibility
Compatible: docs only; no code, config or test changes.
Removes nothing: the diff adds one document and one index row.
Tests
N/A — docs only; no code changes.
Manual verification
Every symbol the RFC names was checked on main at
55d54e3307.Related Issues
Related: #10965 (the implementation this RFC records the decision for).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)