Skip to content

feat(redaction): scrub every persisted conversation row - #10965

Closed
rnoack1 wants to merge 1 commit into
kirodotdev:mainfrom
rnoack1:split/autonudge-inbound-row-scrub-and-marker
Closed

rnoack1 wants to merge 1 commit into
kirodotdev:mainfrom
rnoack1:split/autonudge-inbound-row-scrub-and-marker

Conversation

@rnoack1

@rnoack1 rnoack1 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A credential typed into channel chat is no longer stored verbatim in the transcript served to dashboard readers.

A persisted conversation row is an egress: it is served back to every connected dashboard client. _redact_at_write_boundary returned early for role == "user", so every channel, task and eval persister stored the user's turn verbatim, and a credential typed into chat was written to the transcript unmasked and then served to every reader of it.

Why it matters

The credential reaches readers who should never see it, and it persists, so the exposure outlives the session that caused it.

Reversed decision: typed user text is no longer stored verbatim

This change reverses a decision this repository previously pinned, and the reversal is deliberate rather than incidental.

_redact_at_write_boundary's docstring read "text the user typed is stored verbatim", and test_user_typed_content_is_stored_verbatim asserted it. Both change here: the role == "user" early return is deleted, so the boundary scrubs user rows too, and the test becomes test_a_user_row_arriving_through_the_shared_helper_is_scrubbed.

The old pin's stated justification was that it matched "the dashboard's own write-back boundary". The dashboard slot save does not route through this boundary at all (it writes its rows in chat_persistence), so nothing on the dashboard side relied on the exemption, and a row typed into the dashboard is unaffected by this change. A channel transcript row keeps no original, so the row on disk is the only copy, and storing it verbatim is exactly the egress this change closes.

The reasoning is recorded in docs/system-specs/modules/history.md, under the serve-time alternative: the transcript at rest is itself an egress, so storing a credential verbatim defers the exposure instead of removing it. The irreversible-false-positive cost is accepted and stated in that spec.

Backwards compatibility

Compatible: both take-aways are internal to this repository and every reader of each is updated in this same commit.

  • Reader: test/test_security_posture.py:test_every_redactor_call_site_is_a_registered_sink_or_allowlisted -- chat -- imessage/transport_dispatch.py leaves NON_EGRESS_REDACTION_MODULES and joins the redaction-sink registry as a session-title sink in the same commit, so it stays in exactly one bucket; test_a_module_cannot_be_in_both_buckets and test_allowlist_has_no_stale_entries both pass

Withheld rows, and who reads them. A user row goes through the host's composed policy, so a host whose companion policy fails to compose stores <withheld: redaction unavailable> in place of a user row's body. Assistant and system rows keep the baseline redactor pair and are never withheld. That is an error state rather than a normal one, and the row is still written -- but on such a host these three readers see the placeholder instead of the user's text:

  • Reader: src/kiro_crew/history_search.py:_iter_message_texts -- chat -- yields every role's content for both the search fold and the snippet, so a withheld body is not searchable on that host
  • Reader: src/kiro_crew/history_consolidation_span.py:_rendered -- chat -- reads every role's content into the consolidation span that feeds memory recall
  • Reader: src/kiro_crew/dashboard/handlers/sessions_parts/summaries.py:_build_summary_prompt -- chat -- takes user and assistant content into the one-line session summary

The alternative is worse rather than better: redact_via_context RAISES on such a host, which took the whole message down instead of one field.

What changed

  • User rows are scrubbed at the boundary. _redact_at_write_boundary scrubs a user row through redact_log_via_context, the active credential policy, so a host with composed patterns of its own is not skipped; other roles keep the baseline pair. A new persister is covered without being registered. The decision to rewrite user-typed rows at rest is recorded in RFC: redact credentials in user-typed transcript rows at rest (docs/request-for-change/rfc-redact-user-rows-at-rest.md, draft, not yet on main).
  • No per-persister scrubs. The Slack nudge and the sub-agent persist drop their own scrubs and hand raw text to append, which the boundary now covers; nudge_channel_fire.py and imessage/transport_dispatch.py leave the non-egress allowlist.
  • Copies that bypass the boundary are scrubbed where they are made. Seven transports (Feishu, iMessage, Teams, Webex, WeCom, Weixin, WhatsApp) derive the session title from the first inbound message and store it in metadata, so each scrubs the title before the 40-character cut. Discord, Telegram and the Slack mirror project a turn into the live dashboard slot, which is not a ConversationLog write, so they scrub both halves first.
  • A replayed row is still recognised. The dashboard slot save stores a user row raw, and a prebuilt entry is written as-is, so append_if_absent treats a raw or a redacted copy on disk as the same row. Otherwise a window replay would append a credential-bearing row a second time.

The exemption was measured before it was removed. An earlier revision deferred this, citing four timeouts above 120s in test_history_consolidation_retry.py and test_history_locking_remediation.py and attributing them to _might_contain_credential. That attribution was wrong: the pre-filter is flat on a long uniform run (0.32 ms at 32 kB) and gates the quadratic _CREDENTIAL_PATTERNS alternation, so the boundary costs 2.4 ms there and scales linearly. With the early return removed at this head, both suites pass (101 tests) in 8.5s, slowest test 2.9s.

Not a goal

  • Telling the reader a row was rewritten. The rewrite mark and its dashboard cue are a separate follow-up PR, so this one carries no UI.
  • Recovering a rewritten row's original text. The row on disk is the rewrite, and nothing retains what was typed.
  • Rows already on disk. The scrub runs at write, so transcripts written before this change are left as they are.
  • Defining new credential patterns. Rows are routed through the host's already-composed policy; no file under src/kiro_crew/security/ is touched.
  • The dashboard's own typed rows, which the slot save writes without passing through this boundary. Until it does, one linked transcript holds user rows under two rules.
  • The rest of the split of test(autonudge): verify redaction rendering in the popover projection #7996. Other units in that split carry other paths; this one is the inbound row scrub.

Tests

  • the row-scrub suite pins the boundary directly: a user row appended through a real ConversationLog is stored without its credential, and a clean one is stored unchanged. Negative control: restoring the early return reddens exactly the three boundary tests (this suite's two plus the shared-helper test in the one-conversation suite)
  • a positive control that fails without the composed-policy shim, so the suite cannot pass vacuously; the session-title scrubbers are checked to use the non-raising spelling
  • test_display_time_redaction.py::test_load_leaves_user_content_raw now writes its raw user row directly to disk, since append no longer stores one; it still pins that the load-time pass leaves a user row alone
  • 14,662 backend tests pass across every touched module's suites, the security posture suite, the facade guards and the history suites
  • flake8 and isort clean on every Python file this change touches; black clean on every line it changes

Scope

One unit of a split of #7996, which is 9.3x this repository's added-line cap and cannot be reviewed as a single change. This unit is the inbound row scrub only. It depends on nothing else in that split and can merge on its own.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 15, 2026
@dwu96

dwu96 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@rnoack1
rnoack1 marked this pull request as ready for review September 15, 2026 05:00
@rnoack1
rnoack1 requested review from a team and krishdhasmana September 15, 2026 05:00
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 83b4575925888b2cabd7db899f023791cde4c98d touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 83b4575925888b2cabd7db899f023791cde4c98d via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 83b4575

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 83b4575925888b2cabd7db899f023791cde4c98d via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the reversal of the verbatim-user-row pin is stated as a deliberate decision, the serve-time alternative is weighed in history.md, and the readers that see withheld rows are listed.

Notes

  • The permanent at-rest rewrite of user text rests on an RFC (docs(rfc): redact credentials in user-typed transcript rows at rest #29685) that is still a draft and not on main. A maintainer should accept that RFC before this merges, so the one-way door has a recorded owner.
  • On a host whose credential policy fails to compose, the user's text is replaced for good, and the 7 derived session titles become <withheld: redaction unavailable> cut to 40 characters. A transient failure therefore loses data permanently.
  • The PR keeps two redaction rules in one linked transcript: dashboard-typed rows are stored verbatim and channel rows are scrubbed. That openly breaks the "one transcript cannot have two redaction policies" docstring (§3.6). The follow-up that routes the dashboard slot save through the boundary should be filed as an issue now.

[DESIGN-REVIEWED] 83b4575

Description read

[DESCRIPTION-READ] ab8d5809d2f098f1c1a6109c5cfa7213c3fad5aa9591aceb8facb68262401c47

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — 🔴 BLOCK

Premise-level review of 83b4575925888b2cabd7db899f023791cde4c98d via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: BLOCK

product-shape change without accepted RFC: every channel user's typed text is now permanently rewritten at rest, reversing a pinned "stored verbatim" decision. The only record cited is the author's own draft RFC, not on main.

Notes

  • Item 3 — symptom-level: seven copies of redact_log_via_context(user_text…)[:40] plus seven sink-registry rows, when all 9 .set_title( callers go through ConversationLog.set_title (src/kiro_crew/history.py:880). Subtraction: replace the per-transport scrubs and their 7 _DELIVERY_SINKS rows with a single scrub in set_title.
  • Item 5 — symptom-level: the dual-body match in append_if_absent exists only because "the dashboard slot save does not route through this boundary". The TestOneRedactionRule docstring "one transcript cannot have two redaction policies" stays, while the spec now says "holds user rows under two rules".

What this change ships

Inventory (7 items) — 3 justified

Intent: stop a credential typed into channel chat from being stored and served verbatim. FIX.

  1. User rows from channels are scrubbed irreversibly at rest by the composed policy — product shape, no recorded decision
  2. On a host whose policy fails to compose, a user row's body is stored as <withheld: redaction unavailable> — undeclared in Goal, rides along
  3. Seven transports scrub the session title — symptom-level, duplicates set_title boundary
  4. Discord, Telegram and Slack scrub both halves before the live dashboard projection — justified
  5. append_if_absent treats a raw and a redacted copy on disk as the same row — symptom-level
  6. Slack nudge and sub-agent drop their own scrubs — justified
  7. Two modules leave the non-egress allowlist and join the sink registry — justified

Blockers

product-shape change without accepted RFC: user-typed transcript rows rewritten at rest — product-shape
Trigger: if role == "user": return redact_log_via_context(content) replaces the early return, and the deleted pin test_user_typed_content_is_stored_verbatim said "the user's words are not rewritten". The description says "recorded in RFC … rfc-redact-user-rows-at-rest.md, draft, not yet on main". That RFC is not in the base RFC status list. rfc-redaction-explain-and-reveal.md (partial) has no text on user rows at rest.
Outcome: every channel user loses their verbatim text by default, irreversibly. Per history.md, a false positive "rewrites a user's own text at rest permanently". No recorded decision accepts that.
Clears when: an RFC covering redaction of user-typed transcript rows at rest is merged on the base as accepted/in-progress/partial/implemented, then the author pushes or rebases; or a maintainer posts /ai-review override first-principles 83b4575925888b2cabd7db899f023791cde4c98d product-shape: <decision>.

[FIRST-PRINCIPLES-REVIEWED] 83b4575

Description read

[DESCRIPTION-READ] c28d51b022ca5ac99de4f8c9a0d6d0c750ce8fc75dd01ed3eb4091292fd4b1f6

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 83b4575925888b2cabd7db899f023791cde4c98d via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 83b4575

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 16, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-inbound-row-scrub-and-marker branch from da18d20 to 1aa2f7d Compare September 16, 2026 07:44
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Sep 16, 2026
@rnoack1 rnoack1 changed the title Scrub every persisted conversation row and mark a rewritten one feat(redaction): scrub every persisted conversation row and mark a rewritten one Sep 16, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-inbound-row-scrub-and-marker branch from 1aa2f7d to da362d4 Compare September 16, 2026 09:04
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 16, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-inbound-row-scrub-and-marker branch from da362d4 to d12448d Compare September 16, 2026 09:48
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 23, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-inbound-row-scrub-and-marker branch from fd1b5b7 to ef70afe Compare September 26, 2026 23:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 27, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-inbound-row-scrub-and-marker branch from ef70afe to 66509f8 Compare September 27, 2026 00:47
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Sep 27, 2026

Copy link
Copy Markdown
Contributor

PR triage (automated, 2026-10-05) — verdict: DISTINCT / BREAKING_CHANGE, recommend REBASE + maintainer decision

Checked against origin/main a97659dfc (1024 commits past this PR's merge base 02d350cb9).

  • Not covered by main. redact_row_via_context, carries_redaction_marker, _ScrubbedRow, the DurableRow 5-tuple and the redacted row field are absent on main. No merged PR does this.

  • Overlap. feat(autonudge): scrub loop text on every egress so a credential cannot reach a reader #10967 (PR, open) is a sibling unit of the test(autonudge): verify redaction rendering in the popover projection #7996 (PR, open) split. It touches the same security_posture.py _REDACTION_SINKS table and slack/gateway.py, but in different hunks and for a different egress (the auto-nudge loop serializer and broadcast, not transcript rows). The two complement each other and neither duplicates the other. When both land, the second one to merge will have to reconcile the _REDACTION_SINKS table.

  • Breaking behaviour change, already raised by the First Principles lane. I'm only re-confirming it here, not filing a new request:

    • Channel-typed user rows are now rewritten at rest (llm_helpers.save_conversation_turn, each */transport_dispatch.py). The merged RFC docs(rfc): redaction that explains itself #13250 (docs/request-for-change/rfc-redaction-explain-and-reveal.md, What does not change) still records "Messages written by the user are saved exactly as typed". It mentions this PR only under Open questions.
    • history._redact_at_write_boundary now routes non-user rows through redact_log_via_context. On a host where the context is installed but composition fails, assistant/system rows are now stored as <withheld: redaction unavailable> instead of passing through the baseline redactors. The text is lost permanently on disk.
    • cron_inject.hydrate_slot_from_history now also applies redact_row_via_context to rows read from disk. On that same miscomposed host, the hydrated window shows only placeholders.

    This needs a maintainer decision recorded in the RFC before merge.

  • Stale. mergeable_state=dirty. git merge-tree reports content conflicts in dashboard/chat_persistence.py, dashboard/cron_inject.py, dashboard/session_transfer.py, history.py, slack/handler.py, wecom/ and whatsapp/transport_dispatch.py, test/test_history.py, and website/ (UserMessage.tsx, chatSlice.ts, messageRenderers.tsx, transcriptRenderers.tsx). Main has since refactored chat persistence (refactor(dashboard): compose chat persistence from slot owners #16104) and moved the resume hydrator into dashboard/chat_api/resume.py. That is the hydrator Opus flagged for dropping redacted=, so re-check that finding after you rebase.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rnoack1 for the row-scrub and marker work. One rebase issue before this can land.

#17642 (remote-crew-sidebar RFC, wave 4) deleted remote_adopt.py on main, and #17662 deleted the rest of the relay path. The peer now owns its session and the dashboard opens a crew window onto it (#16757). These hunks touch code that no longer exists, so they are no longer needed:

  • src/kiro_crew/dashboard/remote_adopt.py (deleted on main): R460-466 and R483-490 (prepare_backfill_rows), R655-660 (apply_adopted_backfill).

Could you drop those hunks and rebase on main? Please keep the rest of the PR as it is. Thank you.

@rnoack1

rnoack1 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for catching it. Rebased onto main, and the head is now 403d32adc70fad1e36e7eefcd42e8c44045bf03f.

All three hunks are gone. src/kiro_crew/dashboard/remote_adopt.py is not among the 74 files this PR touches, and the file does not exist at this head or on main, so nothing in the diff points at the deleted relay path any more. prepare_backfill_rows and apply_adopted_backfill appear zero times in the diff.

The rest of the PR is unchanged.

@rnoack1 rnoack1 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the held carry_provenance fix; OK to push.

@iamwhatever

Copy link
Copy Markdown
Contributor

Holding at 0f7e757fcc0aba7df18613bef655356ac2f7d949. No code defect found in what I read, but several things block approval:

  • Sensitive change, reserved for a human. This changes what every persisted transcript row is redacted with and edits the redaction registry in src/kiro_crew/security_posture.py (new sinks, two modules removed from NON_EGRESS_REDACTION_MODULES). The Sensitive Change Review check fails on this head because a fork PR cannot pass it (run). A maintainer has to take it over on an in-repo branch.
  • Active change request. @iamwhatever's CHANGES_REQUESTED review (feat(redaction): scrub every persisted conversation row #10965 (review)) is still active. The author says the remote_adopt.py hunks are gone; the reviewer needs to re-review or dismiss.
  • Lane concerns with no disposition. Design asks for the four fixture timeouts to be traced before the role == "user" exemption in _redact_at_write_boundary stays deferred (
    if role == "user":
    ). It also notes that redact_log_via_context documents itself as a log-line helper that is not an egress boundary (
    def redact_log_via_context(text: str) -> str:
    ). First Principles flags items 3, 6 and 9: the composed-policy switch for non-user rows, the per-caller shape, and a title that promises a rewrite mark the diff does not ship. Each needs its own disposition.
  • Untracked deferrals. Removing the exemption and the rewrite-mark follow-up are both described as deferred, but neither has a linked issue. Please fix them here, or open one issue per item and link it in the description.
  • Product decision. The merged RFC docs(rfc): redaction that explains itself #13250 still says user messages are saved exactly as typed. A maintainer needs to record the reversal there.

— crew-pr-reviewer (r116)

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at befd463.

The head moved since our r116 HOLD (0f7e757). In what I read I found no new code defect, but approval is blocked on these:

  1. Sensitive change, reserved for a human. It changes what persisted rows are redacted with (history_append.py#L31-L53) and edits the redaction registry (security_posture.py#L443). Sensitive Change Review fails on this fork head, so a maintainer has to take it over.
  2. First Principles BLOCK on this head, no disposition. The lane asks for the role == "user" early return to be deleted in place of 11 caller scrubs, or for measured evidence that deleting it costs something. The docstring and history.md disagree about whether the dashboard relies on it. Please fix it or post a target=first-principles rebuttal with evidence.
  3. Title. Both Design and First Principles note that no rewrite mark ships. Drop "and mark a rewritten one" from the title.
  4. Untracked deferrals. The rewrite mark and the exemption removal are both deferred with no linked issue. Open one issue for each and link it in the description, or do the work here.
  5. Active change request. The CHANGES_REQUESTED review at 58c5e08 still stands. It needs a re-review or a dismissal.
  6. CI. Most test jobs were still running at review time, and PR Readiness is pending.
  7. Product decision. RFC docs(rfc): redaction that explains itself #13250 still says user messages are saved exactly as typed. A maintainer needs to record the reversal there.

— crew-pr-reviewer (r123)

@rnoack1

rnoack1 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever both items are done at head 4404d182c0cd834fd4210d96b865268dcfe0e67a:

  • remote_adopt.py hunks dropped. The PR no longer touches src/kiro_crew/dashboard/remote_adopt.py; the file is absent at this head, and the diff contains 0 occurrences of prepare_backfill_rows or apply_adopted_backfill.
  • Rebased on main. The single commit's parent is 1270c45f4df319ffeff92691fb1a30c7641d5a2d, which is on main, and GitHub reports the PR as mergeable.

One thing to flag: the rest of the PR did not stay as it was. The review lanes asked for a smaller change, so the rewritten-row mark and its UI cue moved to a later PR, and the per-persister user-row scrubs were replaced by one scrub at the transcript write boundary (_redact_at_write_boundary no longer skips user rows). The description describes what ships now.

Could you re-review when you get a chance? Thank you.

…written one

Ten channel persisters stored the user's turn verbatim, so a credential typed into chat reached every dashboard reader; each persister now scrubs the row and a rewritten row carries a marker the reader can see.
Split from a larger autonudge egress change: this unit is the inbound row scrub and its marker only.
@rnoack1

rnoack1 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #36640: the same commit, rebased onto current main and opened from a branch of this repository. Sensitive Change Review cannot pass on a fork PR, so the change moves there. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) needs-author-decision PR blocked on author input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants