Repository navigation
docs(rfc): redaction that explains itself - #13250
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the §Step-1 sibling-channel claims (Teams/Webex/WhatsApp "no server-side unfurl") the same way the RFC verifies Slack's edit path — live, via #12699 — before the implementation PR treats them as closed. Suggestions
[DESIGN-REVIEWED] 3eeec23 |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
abbb003 to
be158d0
Compare
Propose explaining every redaction in place instead of leaving a bare placeholder: a lock tag with its source for a removed value, and a blocked-link chip for a suspicious URL. The decision recorded here is that a blocked link keeps its full URL in the message meta so a wrongly blocked link can be opened once. Most blocked links are false positives, and a chip that only explains why a link is gone does not give the reader the link back. The request the gate stops is one nobody chose; a human who reads the full URL and clicks Open once has chosen. A URL carrying a credential is not kept and offers no Open, the removers run again at the click, only the session owner gets the actions, and every retained field is bounded. The document lands before its implementation so that the implementation PR is judged against a decision on the base branch.
be158d0 to
3eeec23
Compare
|
Holding my approval on one thing only, and it is a one-line change rather than a design objection. The front matter says That mismatch has a concrete consequence rather than being a wording nit. The First Principles lane reads a base-branch RFC's status as the product-shape decision record, and treats Compare the precedent this RFC cites. What I am asking for: change the front matter to |
Propose explaining every redaction in place instead of leaving a bare placeholder: a lock tag with its source for a removed value, and a blocked-link chip for a suspicious URL. The decision recorded here is that a blocked link keeps its full URL in the message meta so a wrongly blocked link can be opened once. Most blocked links are false positives, and a chip that only explains why a link is gone does not give the reader the link back. The request the gate stops is one nobody chose; a human who reads the full URL and clicks Open once has chosen. A URL carrying a credential is not kept and offers no Open, the removers run again at the click, only the session owner gets the actions, and every retained field is bounded. The document lands before its implementation so that the implementation PR is judged against a decision on the base branch. Co-authored-by: Ray Xu <rayrayxu@amazon.com>
Summary
Docs-only. Adds
docs/request-for-change/rfc-redaction-explain-and-reveal.md(plus its interactive prototype and the index row). It proposes that a redaction explains itself where it happens, instead of leaving a bare[REDACTED: …]placeholder.This RFC was split out of #12684. It lands first so the implementation is reviewed against a decision that is already on the base branch, the same way
rfc-crewmates-launch.mdwent in.The decision to review
A blocked link keeps its full URL, so a wrongly blocked link can be opened. Most blocked links are false positives, for example wiki pages with Chinese titles or review-filter URLs with long queries. A chip that only explains why a link is gone does not give the reader the link back. §3 explains why this is safe and sets four limits:
The open questions include the overlapping work in #10965 (a marker on redacted rows), #10038 (media delivery in MCP apps), #11501 (a single redaction-pass helper, which needs a merge order), and the false-positive fixes in #9811, #10192 and #9937.
Implementation
Rollout steps 1 and 3 ship together in one follow-up PR. It replaces #12684 and #13192.
Tested
scripts/docs-lint.shpasses, and the comment-history gate passes.