Repository navigation
feat(security): redaction that explains itself (RFC prototype C+A) - #12684
Conversation
|
Intent: Land the redaction-explain-and-reveal RFC (with its interactive prototype) and implement exactly its rollout step 1: the three renderer hard rules that stop zero-click fetches of agent-written URLs (Slack unfurls always off with no opt-in, remote media in agent-output markdown deferred behind a click-to-load chip, widget CSP already on main and recorded). |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS "Pre-fill request" leaves the reader unsure it won't send — the reassurance only arrives after the click. Watch
Suggestions
[UX-REVIEWED] e810593 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify no shipped skill, cron prompt, or saved automation passes Suggestions
[DESIGN-REVIEWED] e810593 |
Opus 5 Review — ✅ human override acceptedReviewed Human judgment by @buluoray overrides the Opus 5 finding for [OPUS-OVERRIDE] e810593 Verdict recorded from an authorized human decision for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Inline-everywhere cards reverse the base RFC's decided bottom-sheet shape on "the owner's request" alone, and the PR's own RFC edit leaves §4 contradicting it. Not justified as shipped
What this change shipsInventory (10 items) — 8 justifiedIntent: let a reader understand each redacted value or blocked link and act on it safely — an ADDITION implementing rfc-redaction-explain-and-reveal (
[FIRST-PRINCIPLES-REVIEWED] e810593 |
78ece88 to
ff83ff8
Compare
|
span=c78420ec1c9f
self-added: yes
|
|
span=a2060682e076
self-added: yes
|
|
span=a5991e945cf0
self-added: yes
|
|
span=f17037245770
self-added: yes
|
span=96ab7f1cd7d4
|
span=c52b42c34cb1
|
span=0fa2f871df64
|
span=2283ad848ce1
|
|
span=e072207effd8
self-added: yes
|
ff83ff8 to
adf2159
Compare
|
span=e072207effd8
self-added: yes
|
|
span=5364f7e06ecf
self-added: yes
|
|
Disposition for GPT 5.6 BLOCKING on |
|
/ai-review override fable 4775cba: Both rows follow the owner-approved Artifactory mock layout (three buttons kept by owner decision). |
Human judgment recorded@buluoray marked the fable AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Fable 5. Re-run the lane's latest workflow run for |
Credentials: a neutral lock tag per removed value (first reply in a session carries the one-time coach with compact lock glyphs), opening a card with the source recorded at redaction time, Open in Terminal (typed, never run), Technical details, More ways, a false-positive report and About redaction. The grey security notice on the dashboard is removed. Blocked links: a Blocked link chip with Inspect, a card with Destination, Reason, Review full URL, Copy URL, Open once (confirmed, Cancel default) and Allow for this host (workspace rule, Undo, Settings -> Security -> Redaction). Renderer hard rules stop zero-click fetches.
|
Disposition for GPT 5.6 on BLOCKING test/test_redaction_allow.py:18 (loader thread can outlive the fixture) — fixed. The FINDING exfil.py:1420 (repeated identical URL keeps one record) — accurate, accepted as-is. |
|
/ai-review override fable e810593: Both rows follow the owner-approved Artifactory mock layout (three buttons kept by owner decision). |
Human judgment recorded@buluoray marked the fable AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override scope e810593: The completed re-run on this head classified every candidate with 0 newly refused on macOS, Ubuntu and Windows (verdict CONCERNS, no confirmed regression); the held failure came from an earlier run that could not read the PR under API rate limiting. |
Human judgment recorded@buluoray marked the scope AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Summary
Implements rfc-redaction-explain-and-reveal (merged in #13250) to its prototype, variants C then A, in one PR: credential redaction and blocked-link inspection together.
Credentials
[REDACTED: credential], with the field label kept (aws_secret_access_key = 🔒 credential · why?), inside code blocks too. Copying a block turns each tag into<REDACTED>.Blocked links
⋯ query N chars· Inspect.redaction-allow/, a leaf the sandbox seals read-only. Once a host is allowed, its blocked links in that workspace render as plain links, history included, and the open card keeps its Undo.Also: the chat loop redacts each streamed delta, which removed a value before the segment flush could describe it. The flush now also redacts the raw segment and keeps its records only when both produce the same text.
RFC step 1, shipped here too (the RFC ships steps 1 and 3 together):
send_message/update_messagenow answerunfurl_links/unfurl_media=truewith 400unfurl_disabled, and Block Kit trees carrying remote media with 400blocks_remote_media_disabled.RFC change in this PR: cards open inline below the content they explain on every screen size; the RFC's mobile bottom sheet is replaced (the RFC text is updated here to match), at the owner's request.
Evidence
Each state rendered by the implementation (Storybook
Chat/Redaction) beside the RFC prototype in the same state.States beyond the prototype
Recording, Allow → plain link with the card kept open: https://github.com/user-attachments/assets/72093c08-65b8-4f66-bba8-a7370f0a8702
Colours are the dashboard theme tokens (
--info,--accent,--warn), so the accent reads green in this theme where the prototype used blue.Deviation from the prototype
Testing
test_credential_sources.py,test_redaction_credential_records.pyandtest_redaction_allow.py; the redaction cases intest_chat_runner_coverage.pyrewritten; about 3.5k related tests pass; black, isort, flake8, mypy and comment-history pass.i18n:check19/19 across 12 locales.Alignment with #13685 (owner file-view switch)
#13685 added an owner switch that turns off the credential pass in files the dashboard opens for the owner. This PR now sits beside it:
docs/request-for-change/rfc-redaction-explain-and-reveal.md): the "no setting" statements are scoped to the conversation, the mode-0600 remedy names the file-view switch as the way to read the value back in the dashboard, and step 6 describes the combined section.redact_credentials_with_recordsalso stands down inside the scope.redaction-allowdirectory adds 3 leaf-only protected names (one per home root) totest_sandbox_protected_name_holds.py, and the security package line budget rises to 27,000 for the redaction record, credential-source and allowed-host modules.