Skip to content

feat(chat): put Edit & Resend on the user message row - #29979

Merged
buluoray merged 1 commit into
kirodotdev:mainfrom
Skymore:feat/inline-edit-resend
Nov 12, 2026
Merged

buluoray merged 1 commit into
kirodotdev:mainfrom
Skymore:feat/inline-edit-resend

Conversation

@Skymore

@Skymore Skymore commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On the main chat, Edit & Resend is one click away on your own message, and no message's hover strip shows the same action twice.

Hovering one of your own messages shows Quote, Copy and More. Edit & Resend, the action people reach for most on their own message, sits inside More. More also lists Quote message again, right under the Quote button the row already shows. Older assistant replies have the same duplicate.

Why it matters

Editing and resending a prompt is a routine step when a reply goes the wrong way. Today it costs an extra click and a menu scan every time, and the repeated Quote makes both menus look broken.

Not a goal

  • Changing which buttons sit on an assistant reply's row.
  • The bubble's right-click menu. It keeps its full list on both message kinds.
  • Surfaces where Reply in thread holds the seat (crewmate threads). Edit stays in More there.
  • Any change to what Edit & Resend or Quote does.

What changed (motivation → approach → change)

Edit & Resend joins the row of an editable user message, after Copy; Quote keeps its seat. More stops listing what the row already shows, on user messages and assistant replies.

Message Row More
Your message, can be edited Quote, Copy, Edit & Resend, More Copy link, Pin
Your message, cannot be edited (turn running, remote-bound) Quote, Copy, More (unchanged) Copy link, Pin
Your message, Reply in thread offered Reply in thread, Copy, More (unchanged) Quote, Copy link, Pin, Edit & Resend (unchanged)
Assistant reply with Quote in the seat (older replies) Quote, Copy, More (unchanged) Copy as rich text, Copy link, Pin, Raw
Assistant reply with Regenerate, Fork or Reply in thread in the seat unchanged unchanged, Quote first

Override requested: max-two-buttons-per-row. The editable user-message row goes from three controls to four. The rule (website/AUTOSDE.yaml, blocking) grandfathers this row at three, for Copy (#16977), and forbids a fourth, so this needs a maintainer ruling. Why both stay on the row: Edit & Resend is the action people use most on their own message, and Quote is how a later message answers this one (#14968: reply-to-message, in the main chat and in crewmate DMs), so neither should sit one menu deep. Taking Quote's seat for Edit was tried and rejected for that reason. The shape already exists on main: the newest reply in a loaded window reads Regenerate, Copy, Fork, More. The 390px touch row still fits without sideways scroll (screenshot below).

More now lists only what the row does not show, the rule it already followed for Copy. This overrides a decision from #14968, recorded in a comment this diff deletes in both components: More listed Quote even when Quote held the seat, so that More and the right-click menu agreed. The right-click menu is a separate surface with no row beside it, so it keeps the full list.

The row pencil carries the same data-message-edit hook as the existing pencil, so it is hidden while the row stands in for the pinned prompt banner. Docs: the Rewind and Quote rows in docs/feature-map/README.md name the new path. website/scripts/capture-quote-message.mjs asserts the new user row and More lists.

Backwards compatibility

Compatible: no API, prop or stored data changes; every action is still reachable from the row, More or the right-click menu.

Reader: website/src/test/CrewChatWindow.test.tsx:openEdit -- crew page -- the crew window's rewind tests open the editor from the row button; retries a second refused rewind from ITS row passes
Reader: website/src/pages/chat/UserMessage.tsx:menuItems -- chat -- right-click menu unchanged; opens on right-click with Quote first, then the row actions passes
Reader: website/src/pages/chat/AssistantMessage.tsx:contextItems -- chat -- right-click menu unchanged; opens on right-click: Quote first, then both copy formats, Copy link, Pin passes
Reader: website/scripts/capture-quote-message.mjs:10-user-more -- chat -- asserts the new row and More lists
Reader: docs/feature-map/README.md:Rewind -- chat -- path updated to the row pencil

Tests

  • UserMessage.quote.test.tsx: an editable message shows Quote + Copy + Edit & Resend + More, and Quote, Copy and the pencil all work from the row; More lists Copy link and Pin only; a non-editable message keeps Quote + Copy + More and More drops Quote; Quote alone with nothing else shows no More; an editable bare carried quote reads Copy + Edit & Resend + More; with Reply in thread, Quote and Edit stay in More; the pinned stand-in withholds Edit from both menus.
  • AssistantMessage.quote.test.tsx: with Quote in the seat, More is Copy as rich text, Copy link, Pin, Raw; Quote tests fire from the row button; with Regenerate or Reply in thread in the seat, More still leads with Quote.
  • UserMessage.pinnedStandinActions.test.tsx: the row pencil is display: none while the row is the pinned stand-in.
  • CrewChatWindow.test.tsx: helpers open Edit from the row button; every crew-window rewind test runs through it.
  • Determinism: the four changed test files ran 3 times with --sequence.shuffle and fresh seeds, 148/148 each time.
  • Related sets: the 70 test files that render AssistantMessage plus the user-message and crew-window files (74 files, 1430 tests), the frontend related set from scripts/run_scoped_tests.py, npm run typecheck, eslint on the changed files, the flake-pattern ratchet, and the backend tests that reference changed files.

Manual verification

Real Chromium against website/capture/quote-message.html (real UserMessage and AssistantMessage), built once from origin/main and once from this branch: dark, light, and a 390px touch viewport. Checked the row labels, both More lists, that the pencil opens the inline editor, and no page errors. Both right-click menus were checked unchanged.

Screenshots / video

Before (origin/main) on the left, this PR on the right.

Your message: hover row, then More open.

Dark: user row and More, before vs after

An older assistant reply with More open: the second Quote is gone, the row keeps its Quote button.

Assistant reply More, before vs after

Light theme and 390px touch (your message)

Light: user row and More, before vs after

390px touch row, before vs after

Reaching the editor, side by side: More → Edit & Resend before, the row pencil after Copy.

edit-resend-before-after.webm

Related Issues

Closes #29471

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Skymore
Skymore requested review from a team and KiroCrewCaptain as code owners November 4, 2026 22:44
@Skymore
Skymore requested a review from CrysisDeu November 4, 2026 22:44
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 4, 2026
@Skymore
Skymore force-pushed the feat/inline-edit-resend branch 3 times, most recently from 446c6e5 to 7f0fba1 Compare November 4, 2026 23:41
@Skymore

Skymore commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md since this head was pushed (7783a9f -> 021c1cc); CI re-running once a maintainer approves the fork workflows.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 5, 2026
@Skymore
Skymore force-pushed the feat/inline-edit-resend branch from 7f0fba1 to 9e05ea5 Compare November 5, 2026 01:48
@Skymore

Skymore commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md and website/src/pages/chat/UserMessage.tsx since this head was pushed (021c1cc -> 4a8672a), which left the PR conflicting; resolved by keeping both Feature Map rows. CI re-running.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 5, 2026
@Skymore
Skymore force-pushed the feat/inline-edit-resend branch from 9e05ea5 to d7fe257 Compare November 5, 2026 21:45
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 5, 2026
@Skymore

Skymore commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased onto 165dbc0eba to resolve a conflict in docs/feature-map/README.md with #30219 (Bot / Ultra Mode wording) and #30213 ($ skill menu in the Edit & Resend field). Kept both: main's wording and EditSkillPicker note, plus this PR's Quote and Rewind row text. vitest related on the changed files: 640 files pass; tsc and eslint pass.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ human override accepted

@buluoray overrode this lane for 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 (the recorded decision, this commit only); the model review was skipped.

[FIRST-PRINCIPLES-OVERRIDE] 2a0d979

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change solves the stated problem, and the four-button row is an override the author already asked a maintainer for.

Notes

  • The new comment in UserMessage.tsx says the fourth row control is "a maintainer ruling for this row only (feat(chat): put Edit & Resend on the user message row #29979)", but the description is still asking for that ruling. Keep the comment only once a maintainer agrees, and otherwise take the pencil back off the row.
  • This reverses the feat(chat): quote a whole message from its bubble #14968 rule that More must match the right-click menu, and only a code comment recorded that rule. Writing the new rule ("More lists only what the row lacks") in docs/decisions/ would stop a later PR from restoring the old one.

[DESIGN-REVIEWED] 2a0d979

Description read

[DESCRIPTION-READ] 584e3d1adb2939e034ed6b0ce35c17bd48f8dc81e60ddf0742621ada015332ae

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

The screenshots show every changed control: the row pencil, both trimmed More menus, light and dark, and the 390px touch row. Nobody has done a blind first-time read, because this lane reviews forks in one pass.

Notes

  • The crew-window user row (crewWindowRenderers.tsx) now gets the same pencil, but no screenshot shows it. A crew-window hover still would confirm it renders the same there.

[UX-REVIEWED] 2a0d979

Description read

[DESCRIPTION-READ] a66ee5e2c9c000b97d72b70dc35833d3fcbde9ee0a16d567f1def95fdb52eef4

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ human override accepted

@buluoray overrode this lane for 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 (the recorded decision, this commit only); the model review was skipped.

[OPUS-OVERRIDE] 2a0d979

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ human override accepted

@buluoray overrode this lane for 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 (the recorded decision, this commit only); the model review was skipped.

[GPT-OVERRIDE] 2a0d979

@Skymore

Skymore commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author
  • span=c86bcc609a76 Edit & Resend makes the user-message row four controls

Needs a decision: the finding is accurate. The four-control row is intended, and the PR description asks for a max-two-buttons-per-row exception (the "Override requested" paragraph). A writer either grants it with /ai-review override, or rules against it and Edit & Resend goes back into More.
Why the exception is asked: Edit & Resend is the action people use most on their own message; Quote is how a later message replies to this one (#14968); main already draws a four-control reply row (Regenerate + Copy + Fork + More).
If granted, the next push rewords the code comment that calls this a "product ruling" and adds a docs/decisions record if the maintainer wants one, since none exists yet.

@Skymore

Skymore commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author
  • span=c874527267fe Edit & Resend makes the user-message row four controls

Needs a decision: the finding is accurate. The four-control row is intended, and the PR description asks for a max-two-buttons-per-row exception (the "Override requested" paragraph). A writer either grants it with /ai-review override, or rules against it and Edit & Resend goes back into More.
Why the exception is asked: Edit & Resend is the action people use most on their own message; Quote is how a later message replies to this one (#14968); main already draws a four-control reply row (Regenerate + Copy + Fork + More).
If granted, the next push rewords the code comment that calls this a "product ruling" and adds a docs/decisions record if the maintainer wants one, since none exists yet.

@buluoray

buluoray commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Maintainer decision (buluoray): the max-two-buttons-per-row override for this PR is accepted. The editable user-message row may carry four controls (Quote, Copy, Edit & Resend, More), for the reason the PR gives: Edit & Resend is the action people use most on their own message, and Quote is how a later message answers this one, so neither moves one menu deep. This ruling covers this row only; it does not widen the rule for other rows.

The Opus and GPT blocks on that rule are answered by this decision. A code review on the current head follows.

buluoray
buluoray previously approved these changes Nov 6, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

APPROVE at f164251. I found no behaviour defect, no regression for existing users and no false statement in the description. The four-control row is covered by the maintainer's recorded override, so it is not judged again here.

What it does for users: Edit & Resend on your own message is now one click, after Copy on the hover row, and no More menu repeats an action its row already shows, on user messages or older assistant replies.

Head and scope

  • The live head is a merge of main (7c364bc) into d7fe257. The PR's own added and removed lines are identical between d7fe257, which the AI lanes reviewed, and this head. Only hunk offsets moved. So the lane verdicts still describe this code.
  • HEAD^2..HEAD touches only the nine files listed in the PR: two docs/feature-map lines, the capture script, three website source files and four website test files. The fork changes no workflow and nothing else outside the website. git merge-tree against origin/main exits 0.

Behaviour checked against source

  • Edit on the row: website/src/pages/chat/UserMessage.tsx:659 sets editInRow = compactRow && canEditResend && !onReplyInThread. canEdit is supplied by page/transcriptRendering.tsx:358 (not running, not regenerating, not remote-bound), which this PR leaves alone, and by crewWindowRenderers.tsx:76 (canRewind). Where Reply in thread holds the seat, editInRow is false and Edit stays in More (editInMore, :664).
  • Pinned stand-in: the row pencil carries data-message-edit, which styles/chat-transcript.css:492 hides under [data-pinned-standin]. editInMore also excludes standIn, so Edit is withheld from both the row and More while the row stands in. That matches main.
  • More dedupe: the user More shows Quote only when quoteInMore (Quote not on the row), and Edit only when editInMore. AssistantMessage.tsx drops Quote from More only when quoteRow (:440, so Quote holds the seat). With Regenerate, Fork or Reply in thread in the seat, More still leads with Quote.
  • Right-click menus are unchanged. The diff has no hunk in UserMessage menuItems (:671 on) or in AssistantMessage contextItems. The existing test that opens the stand-in's right-click menu still expects Quote, Copy text, Copy link, Pin, and it passes.
  • Nothing else left More. moreHasItems now counts quoteInMore and editInMore instead of quoteOffered and canEdit, so a row that only had Quote to add no longer draws an empty More. Copy link, Pin and app actions are unchanged.
  • Accessibility: the new button's title and aria-label use the existing catalog key pages.chat.userMessage.edit_resend, the same key as the existing pencil and menu item, so every locale already carries it. DOM and Tab order is seat, Copy, Edit & Resend, More.

Tests run locally (fork CI has not run on this head)

  • UserMessage.quote, UserMessage.pinnedStandinActions, AssistantMessage.quote, CrewChatWindow, UserMessage, UserMessage.contentWidth, UserMessage.editSkillPicker, ImeEnterGuardSites, messageActionMenus and userBubbleMobileOverflow: 264 passed and 1 failed of 265.
  • The failure is CrewChatWindow "draws a code fence in a peer USER row copy-only too", a 5s timeout. It is inherited: it fails the same way on main 7c364bc, it passes when run alone, and the PR does not touch it.
  • Mutations, run one at a time with the file restored after each:
    • Dropping !onReplyInThread from editInRow reddens "beside Reply in thread, Reply takes the seat, Copy follows, and Quote and Edit are in More".
    • Dropping canEditResend from editInRow reddens "a message that cannot be edited keeps Quote + Copy + More, and More does not list Quote again".
    • Reverting the user More Quote to quoteOffered reddens three tests, including "More then lists only what the row does not show".
    • Removing !quoteRow in AssistantMessage reddens "seats Quote, keeps Copy right after it, and folds Link, Pin and Raw into More without a second Quote".
    • Removing data-message-edit from the row pencil reddens "also leaves out the row pencil of the Quote-offering row".

Source or screenshot only

  • The 390px touch screenshot shows Quote, Copy, pencil, More and the time on one line, with no overflow. I did not render it myself.
  • The capture script assertions were read, not run.
  • Typecheck and eslint were not run.

Lane findings other than the row-count rule

  • Design (PASS) asked for a decision record once the override was granted. That still holds: this head adds no docs/decisions entry. Follow-up: record the ruling there, and point the "product ruling" code comment at UserMessage.tsx:647 to it.
  • UX (PASS) noted that no screenshot shows the crew window row. That still holds. Its behaviour is covered: CrewChatWindow's openEdit now clicks the row button and every rewind test passes through it. Follow-up: add a crew-window hover still.

CI on this head: 5 success, 1 skipped, 0 failure in check-runs. The PR Readiness status is failure, waiting on the fork workflow run and the lane overrides. Auto-merge is off and no human review is on the PR yet.

@buluoray

buluoray commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

/ai-review override fable f164251 owner-decision: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment). This record covers that rule only.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the gpt AI finding on a5cf8751054d8c70bf66b954a9b17dc6671f14f2.

buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment). This record covers that rule only.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention labels Nov 11, 2026
@buluoray

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@Skymore this head (a5cf875) now conflicts with main, so GitHub cannot merge it. Could you rebase onto current main and push?

Where it stands otherwise: the approval is in place, and the max-two-buttons-per-row override is recorded for the Opus and GPT lanes on this head. The remaining red checks (Dependency License Gate and PR Policy hit a GitHub API rate limit, and Security Scope Review timed out while publishing) are not about the code, and a new push re-runs them. Once the new head is up, I will approve its fork workflow runs, re-record the override for both lanes, and re-approve.

On a user message that can be edited, the row reads Quote + Copy + Edit & Resend + More: Edit follows Copy, one more control over max-two-buttons-per-row by product ruling, the same shape as a reply's seat + Copy + Fork. On user messages and assistant replies alike, More lists only what the row does not show, so Quote no longer appears twice. The right-click menu keeps the full list.
@Skymore

Skymore commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current main, still one commit (2a0d97992c), no code change from a5cf875105.

The only conflict was docs/feature-map/README.md: main (#35225 and others) edited the Quote row's description column and this PR edits its entry column, so each column kept the side that changed it. The source files merged cleanly. Locally, vitest related on the changed sources (695 files, 9775 tests), tsc and eslint pass.

@buluoray override commands for this head, for after the Opus/GPT BLOCKs post:

/ai-review override fable 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 owner-decision: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in https://github.com/kirodotdev/KiroCrew/pull/29979#issuecomment-6698442399. This record covers that rule only.
/ai-review override gpt 2a0d97992c9d193b0e5c18902bafd7b2eca542d1 owner-decision: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in https://github.com/kirodotdev/KiroCrew/pull/29979#issuecomment-6698442399. This record covers that rule only.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 11, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approve at 2a0d979. The rebase reset my approval; this re-approves the same change on the new head.

Checked: I compared this head's patch with the one I approved at a5cf875. The code and test changes are identical line for line. The only difference is in docs/feature-map/README.md: main reworded the "Quote a message" row, and this head applies the same edit to the new wording.

What it does for users: on their own message, Edit & Resend is one click on the hover row instead of two, and More lists only what the row does not already show.

The four-control row is the exception I accepted as maintainer in #29979 (comment). I have approved the fork workflow runs on this head. When the Opus and GPT lanes post their max-two-buttons-per-row finding here, I will re-record the override for both.

@Skymore Skymore closed this Nov 11, 2026
@Skymore Skymore reopened this Nov 11, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 11, 2026
@buluoray

Copy link
Copy Markdown
Contributor

/ai-review override fable 2a0d979 owner-decision: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment). This record covers that rule only.

@buluoray

Copy link
Copy Markdown
Contributor

/ai-review override gpt 2a0d979 owner-decision: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment). This record covers that rule only.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the fable AI finding on 2a0d97992c9d193b0e5c18902bafd7b2eca542d1.

buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment). This record covers that rule only.

This decision applies only to this commit. A new push requires a new judgment.

@buluoray

Copy link
Copy Markdown
Contributor

/ai-review override first-principles 2a0d979 max-two-buttons-per-row: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment), so the maintainer ruling the code comment cites exists. This record covers that rule only.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the gpt AI finding on 2a0d97992c9d193b0e5c18902bafd7b2eca542d1.

buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment). This record covers that rule only.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: max-two-buttons-per-row is not a release class. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@buluoray

Copy link
Copy Markdown
Contributor

/ai-review override first-principles 2a0d979 owner-decision: buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment), so the maintainer ruling the code comment cites exists. This record covers that rule only.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 2a0d97992c9d193b0e5c18902bafd7b2eca542d1.

buluoray accepted the max-two-buttons-per-row override for the editable user-message row (four controls) in #29979 (comment), so the maintainer ruling the code comment cites exists. This record covers that rule only.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 11, 2026
@buluoray
buluoray merged commit 2d4848e into kirodotdev:main Nov 12, 2026
89 of 94 checks passed
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

编辑已发送消息时,要先点「···」才能看到「编辑并重发」

2 participants