Repository navigation
fix(release): backport six KAS and security fixes to 0.12.0 line - #30809
Conversation
Cherry-picked with -x from main onto release/0.12.0 for 0.12.1, in main merge order. Every pick applied clean. - #29990 fix(approvals): resolve an approval by id only in the session it was shown in (cherry picked from commit 4d2b8a5) - #30129 fix(session): don't resume in an earlier process's hidden scratch dir (cherry picked from commit 599e33e) - #30205 fix(acp): let Crew's MCP servers defer on the KAS engine bundle (cherry picked from commit 3d4e4a6) - #30279 fix: keep one more credential value out of log output (cherry picked from commit 9fcf80f) - #30195 fix(acp): answer KAS user-input questions instead of letting Deny read as yes (cherry picked from commit bbf4e6d) - #30199 fix: redact four log lines and tighten two small checks (cherry picked from commit 16ff876) Co-authored-by: Bolin Chen <17506219+bolichen97@users.noreply.github.com> Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: each pick is a clean backport of a fix already merged on Notes
[DESIGN-REVIEWED] 55e090d Description read[DESCRIPTION-READ] 2453c6f6e9905e8c74abfee4728915cc60cae23639a0dfd8bd164c5401ba9f7c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff adds or changes no visible control, label or state. The frontend edits only change which API route an approval click uses and where the unread relay posts, so no screenshot is needed. Notes
[UX-REVIEWED] 55e090d Description read[DESCRIPTION-READ] cddf75e22b74965c1d629fe8291c892ffafb404dafcd2c28b530e42c94a151a9 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: every item is a fix already merged on What this change shipsInventory (9 items) — 9 justifiedIntent: ship six fixes already merged on
[FIRST-PRINCIPLES-REVIEWED] 55e090d Description read[DESCRIPTION-READ] 227543b51d299eb0f3c84b69a45e279579acbb043f0b3c3c60fa7551d6d34b86 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: In the deny composite, the only stricter piece is the rm floor's fallback for a command it cannot read. It runs only after TIGHTENING: the rm floor's fail-closed word test ADJUDICATED: 19 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix (15 rows) and windows (4 rows); no UNADJUDICATED:
[SCOPE-REVIEWED] 55e090d |
Partial backport of #31391 (main 4023e84) to the 0.12 line. Carried: - get_or_create.py: native Windows keeps a scratch cwd, because no scratch-root mask applies there (a Kiro spawn is delegated to Kiro's own sandbox). This is the Windows branch the GPT review asked for. - get_or_create.py: a caller that opts in (fallback_hidden_cwd) and names an earlier process's hidden scratch tree as its own cwd starts in the default directory instead. - turn_admission.py and eager_spawn.py: the dashboard chat opts in with fallback_hidden_cwd=True. - test_session_get_or_create.py: #31391's tests, without the notice assertions, plus a Windows test adapted from main's test_hidden_scratch_notice.py. Left out: the chat start notice (_note_skipped_hidden_cwd and HIDDEN_SCRATCH_CWD_NOTICE), _fallback_turn_project in turn_spec_hooks.py, the ErrorCard and i18n strings, and test_hidden_scratch_notice.py. The notice surface (startup_notice) comes from #25347, which is not on 0.12. The fallback is kept on 0.12 for #31319: without it every MCP server in that chat fails with ENOENT and the chat is dead, and the hidden folder is unreachable from the process anyway. With no chat notice on 0.12, the existing WARNING log line names the hidden folder and says the session starts in the default directory. (cherry picked from commit 4023e84, partial)
Sensitive change review
|
Problem / Motivation
Goal: Bring six KAS and security fixes that merged on
mainafterv0.12.0ontorelease/0.12.0, so the 0.12.1 patch ships them.KAS is the default backend on 0.12.0, so the three KAS fixes reach every default install. The other three close security gaps (one session's approval click settling another's request, and secrets echoed into log lines).
Why it matters
EPERM uv_cwd,rc=None). Reported by a user on 0.12.0.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange. Cuttingv0.12.1-rc.Nand the bare tag follow docs/build/release.md and stay with the maintainers.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontoorigin/release/0.12.0@f315771db6(=v0.12.0), in main merge order, then squashed into one commit. The commit message lists every source commit.4d2b8a5c9e599e33e9f03d4e4a6c329fcf80f316bbf4e6df7c16ff876b5aNo conflicts. The squashed tree is byte-identical to the tree of the six separate picks.
The second commit is a partial pick of #31391 (
4023e84b16), built by hand on top of the first. It carries the Windows branch the GPT review asked for, plus the chat's hidden-scratch fallback:get_or_create.py)fallback_hidden_cwd,get_or_create.py,turn_admission.py,eager_spawn.py)test_session_get_or_create.pyteststest_hidden_scratch_notice.py_note_skipped_hidden_cwd,HIDDEN_SCRATCH_CWD_NOTICE),_fallback_turn_project, ErrorCard and i18n strings,test_hidden_scratch_notice.pystartup_notice) comes from #25347, which is not on 0.12The fallback is kept on 0.12 for #31319: without it every MCP server in that chat fails with ENOENT and the chat is dead, and the hidden folder is unreachable from the process anyway. With no chat notice on 0.12, the WARNING log line names the hidden folder and says the session starts in the default directory.
Backwards compatibility
Compatible: each change is the one already merged on
main, and each PR's own compatibility note applies unchanged.Removes nothing: no pick hides, deletes or renames anything 0.12.0 accepts.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the related set was run here: the 18 Python test files this diff adds or changes, plus every test file that imports a source module these picks touch, 126 files in total. Sequential batches of up to 20 files, one pytest process each,-n 0. 8305 passed. 5 tests fail, and each fails the same way on cleanorigin/release/0.12.0@f315771db6, so none comes from this diff:test_acp_harness_contract.py::test_a_missing_self_served_binary_names_its_install_command[copilot],test_auto_improvement_members.py::test_assignments_build_real_context_from_only_their_private_store, two intest_folder_steering_provider_dedup.py, andtest_harness_parity.py::test_is_kiro_cli_is_positive.ChatInput.approval,dashboardSlice,dashboardSliceRelay,slotReadRelay): 193 of 196 pass. The same 3ChatInput.approvaltests fail on cleanorigin/release/0.12.0on this host (a local dev-server path restriction), so they do not come from this diff.test_session_get_or_create.py, 60 passed, including the Windows test. Removing the Windows branch makes that test fail. Every test file that mentionseager_spawn,turn_admissionorget_or_create(785 files, batches of 20,-n 0) passes excepttest_harness_parity.py::test_is_kiro_cli_is_positiveandtest_auto_improvement_members.py::test_assignments_build_real_context_from_only_their_private_store, both listed above as failing on clean release.Manual verification
N/A - every pick was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend changes come from #29990 and #30199 unchanged, and both PRs waived screenshots because nothing on screen changes.
Related Issues
Backport of #29990, #30129, #30205, #30279, #30195 and #30199, plus part of #31391, to the 0.12 line for 0.12.1. Related: #31319. Source issues: #29989, #29775, #30194.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes unchanged.
Pattern harvest
Not generalizable: this PR only carries six fixes already on
main. Each source PR has its own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.