Skip to content

feat: open remote gateway files in a local editor over ssh - #31141

Merged
bolichen97 merged 1 commit into
mainfrom
fix/11338-remote-editor-links
Nov 8, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/11338-remote-editor-links

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When the gateway runs on another machine, a user can open a file from the dashboard's file menus in their own local VS Code, over their own SSH.

For a gateway on a remote or headless host, every file-open action in the file-path menus ends at "Copy path". Open and Reveal act on the gateway host, and the desktop app's "Open in editor" opens a path that does not exist on the viewer's machine. Editing a file the agent may not write (config.json, .env) then needs a separate SSH session.

Why it matters

Running the gateway on a cloud dev box or another headless server is a common setup, and those users have no way to get from a file path to an editor. One click now opens the right file in their own editor, and the dashboard gains no write access: the edit happens in the user's editor, over the user's SSH.

Not a goal

  • Editors other than VS Code (Kiro, Cursor, Windsurf). Each needs someone to confirm that a <scheme>://vscode-remote/ssh-remote+<host> link opens a remote file in it; adding one is one id in REMOTE_EDITOR_IDS and REMOTE_EDITORS.
  • A per-browser SSH host. The host is one gateway setting, and its description says the alias must exist on every machine the dashboard is opened from.
  • Windows gateways (C:\ paths) and chats bound to a session environment, whose paths are on another machine.
  • Opening through a VS Code window already attached to the host, the follow-up suggested on the issue.

What changed (motivation → approach → change)

The browser cannot know how the viewer reaches the gateway over SSH, so the user says it once in Settings. The side panel's ⋯ menu for an open file then offers Open in VS Code: VS Code's own vscode://vscode-remote/ssh-remote+<host><path> link, which the viewer's editor opens with the viewer's own SSH credentials. This builds on #19557, trimmed to the link, the two settings and their checks.

Piece Change
Settings Settings → Display → Remote editor: an Editor select (Off, VS Code) and an SSH host field, saved as dashboard.remote_editor.editor and .host and read back on load (config/sections_dashboard.py, config/sections.py, config/loader_builders.py, dashboard/handlers/core_config_schema.py, pages/settings/DisplayPanel.tsx). The descriptions say the viewer's computer needs VS Code with Remote-SSH, and that the host is the Host name in that computer's ~/.ssh/config. The host field saves when it loses focus; it shows an example placeholder and a "Saved" line once the save lands, until the user types again
Menu Open in VS Code in the side panel's ⋯ menu (components/MarkdownPanelHeader.tsx), the link built by utils/remoteEditorUrl.ts
Branding GET /api/dashboard/branding carries remote_editor (dashboard/handlers/core.py, hooks/useBranding.tsx, api/client/themes.ts)
Change cards an agent-proposed host reads as code_exec, the editor as cannot-widen (change_card_catalog_kinds.py)
Generated and docs config-baseline.json, docs/settings-registry.generated.json, docs/ui-index.generated.json, settingsRegistry.gen.ts, the 12 locale catalogs and i18n/en.context.json, a brand exemption in eslint.i18n.config.js, the feature map and learn-cron-dashboard.md

Only the side panel offers the row. It always shows the gateway's copy of a file, while a path chip in a chat can name a file on another machine (a chat bound to a session environment), where the link would open the wrong file. Any path chip reaches the row through Open in side panel.

Both values end up in a clickable link. The editor is an enum because it becomes the URL scheme. The host must be a DNS name or SSH alias, the grammar the desktop app's editor-link check already takes, so it carries no URL structure and no leading - that ssh could read as an option. The write gate refuses anything else, and the branding endpoint drops a hand-edited value that either check refuses. The row is offered only for an absolute path with no . or .. segment, because URL parsing would drop the segment and could point the link at another host. Each segment is percent-encoded, and a name the desktop app's check refuses (a backslash or control character) gets no row. The row is not gated on direct_local, which reads true through an ssh -L forward. In the desktop app the link opens as a new window, which the desktop app confirms before handing it to the OS: its navigation guard refuses an in-window navigation to an editor scheme.

Backwards compatibility

Compatible: two new optional keys, off by default; with no editor set, nothing renders differently.

Removes nothing: the change only adds two settings, a branding field and a menu row.

Tests

  • website/src/test/MarkdownPanel.remoteEditor.test.tsx: the side panel row links to the file on the SSH host with each segment encoded (space, #, parentheses); no row while the editor is off; target="_blank" from an embedded pane and from a desktop-app window; no row in a path chip menu; remoteEditorUrl builds no link for a relative path, a dot segment, or a backslash or control character the desktop app's editor-link check refuses.
  • website/src/test/DisplayPanel.remoteEditor.test.tsx: picking VS Code saves the editor and refetches branding; the empty host field shows its placeholder; the host is saved trimmed on blur and a "Saved" line appears, gone again once the user types; a refused host stays in the field with the format message and no "Saved" line.
  • test/test_config_patch_remote_editor.py: the write gate takes vscode, "" and a DNS name, and refuses another scheme, a port, a path or query, and a leading dash; a saved editor and host survive KiroCrewConfig.load(), and a hand-edited scalar loads as off.
  • test/test_dashboard_branding.py: branding serves only values the schema accepts; test/test_dashboard_handlers_core_coverage.py pins the default payload with remote_editor.

Determinism: the three backend files passed 20 times at -n0, 10 times at -n 4 --dist loadgroup --max-worker-restart=2 beside test_config_patch_otlp_endpoints.py, and in a shuffled order (seed 31141). The two vitest files passed 10 shuffled runs (--sequence.shuffle, seeds 1001 to 1010).

Manual verification

Rendered the real SPA built from this head (website/dist, API stubbed) and read back the side panel row's href: vscode://vscode-remote/ssh-remote+dev-box/home/dev/notes/cleanup.md. The path chip menu for the same file has no editor row. Not done here: clicking the link on a desktop with VS Code and Remote-SSH installed.

Screenshots / video

Side panel ⋯ menu for an open file, dark and light:

side panel menu, dark side panel menu, light

A path chip menu in chat offers no editor row:

path chip menu

The SSH host field empty, with its placeholder, and right after a save on blur, with the "Saved" line (dark and light):

host field placeholder, dark

host saved, dark host saved, light

Settings → Display → Remote editor, set, with the shipped copy (before the placeholder and the "Saved" line):

settings, set

Light theme, Off, and the two save errors

settings, set, light
settings, off
host refused
editor save failed

Related Issues

Closes #11338

Builds on #19557 by @helenastafford.

Sibling sweep

N/A — a feat PR.

Pattern harvest

N/A — a feat PR.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 06:24
@bolichen97
bolichen97 requested a review from Zedmor November 6, 2026 06:24
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: the feature is new, off by default, closes #11338, and no existing mechanism opens a gateway file over SSH. Two parts are bigger than they need to be.

Notes

  • Item 2 — one consumer, generalized: REMOTE_EDITOR_IDS = ("vscode",) builds a one-value enum, a REMOTE_EDITORS record with one entry, an Off/VS Code select and a change-card row, all justified only by "adding one is one id" (the "so we can later" form). Subtraction: delete dashboard.remote_editor.editor and treat a non-empty host as on, with vscode as a constant scheme in remoteEditorUrl.
  • Item 4 — duplicate of website/src/components/DiffBlock.tsx vscodeFileUrl: the encode lambda in remoteEditorUrl.ts repeats its per-segment encodeURIComponent(...).replace(/[!'()*]/g, …) line for line (1 prior site). Subtraction: move that one encoder out of vscodeFileUrl and call it from both, so the copy goes.

What this change ships

Inventory (8 items) — 6 justified

Intent: a user with a gateway on a remote host opens a file shown in the dashboard in their own local VS Code over their own SSH. ADDITION.

  1. The side panel's ⋯ menu shows "Open in VS Code" once it is configured — justified
  2. Settings → Display → Remote editor: an Editor select (Off / VS Code) — one consumer, generalized
  3. Settings → Display → Remote editor: an SSH host field that saves on blur and shows "Saved" — justified
  4. The link builder remoteEditorUrl: encodes each path segment and refuses ./.. and control characters — duplicate of DiffBlock.tsx vscodeFileUrl encoder
  5. The branding endpoint returns remote_editor and drops values the schema refuses — justified
  6. A host proposed by the agent is classed as code-exec; the editor as cannot-widen — justified
  7. The write gate checks both keys (enum, host pattern, max length) — justified
  8. Generated registries, 12 locale catalogs, an eslint brand exemption, spec and feature-map rows — justified

[FIRST-PRINCIPLES-REVIEWED] ddf0ca6

Description read

[DESCRIPTION-READ] 938389e4d51f5341087b9172335ab80bc0fb15d4cab804bc2db49b6eb69d69d1

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The feature is additive, off by default, gives the dashboard no write access, and both link inputs are validated when saved and again when served.

Notes

  • The editor list is kept in two places, REMOTE_EDITOR_IDS in Python and REMOTE_EDITORS in remoteEditorUrl.ts, and only a comment keeps them equal. The branding payload could send the display name too, so the frontend has nothing to copy.

[DESIGN-REVIEWED] ddf0ca6

Description read

[DESCRIPTION-READ] aac02cddcbbb437f1b16f5e7e3de4bac61eff0108ead90bd934f4a98e98bb97f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader read "Open in VS Code" correctly and identified the SSH host field correctly. They declined to fill the host field only because they have no SSH setup, and someone without one has no use for this feature.

Notes

  • The SSH host field stays enabled when Editor is "Off" (shot-09), and the reader "can't tell whether it matters". Disable or hide it while Off, as the menu row already depends on the editor.
  • The editor save error leaves the dropdown on "VS Code" (shot-11), and the reader "can't tell whether VS Code is the old value or the one that failed". Name the kept value in remote_editor_save_failed, for example "Couldn't switch the editor; it's still {{editor}}."
  • The reader "wouldn't think to look" for Remote editor under "Display — Zoom, font, and color theme preferences". It sits next to Terminal, so the placement matches existing patterns. But the section subtitle no longer covers what the section holds, so widen it to cover external apps.

[UX-REVIEWED] ddf0ca6

Description read

[DESCRIPTION-READ] 71c63f943dc8d831619a097000813fe01e815dcb4ef11592eb5307a2e9274b65

That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ddf0ca6

Verdict parsed from the review's SHA-scoped output markers for commit ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ddf0ca6

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ddf0ca6bb2a7a697936457bb90cb1aad5e3fe656 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 6, 2026 06:43
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97
bolichen97 force-pushed the fix/11338-remote-editor-links branch from b79a41c to dddd3d1 Compare November 6, 2026 12:41
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026
@bolichen97

bolichen97 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=324b234bfb47 Saved remote-editor settings never reach branding

fixed in dddd3d1: _build_dashboard_config now passes remote_editor= to DashboardConfig, keeping a stored dict and falling back to the off default for a missing or non-dict value (the update_nudge pattern beside it).
test_load_reads_the_saved_remote_editor goes through KiroCrewConfig.load(); it fails with the loader line removed and passes with it.

@bolichen97

bolichen97 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=b8f800fd372f dashboard.remote_editor is never read by the config loader

fixed in dddd3d1: _build_dashboard_config (config/loader_builders.py) now passes remote_editor=, keeping a stored dict and falling back to the default when the value is not a dict.
test_load_reads_the_saved_remote_editor loads through KiroCrewConfig.load(), not a direct DashboardConfig(...); it fails with the loader line removed and passes with it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 6, 2026
@bolichen97
bolichen97 force-pushed the fix/11338-remote-editor-links branch from dddd3d1 to 7b68b46 Compare November 6, 2026 13:36
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=173e0ef0e5df Embedded panes offer editor links the desktop shell rejects

fixed in aad4525d291c: remoteEditorUrl now returns null for a path with a backslash or a control character, the same set editorLinkTarget in website/electron/external-scheme.js refuses, so no row is offered that would do nothing.
FilePathMenu.test.tsx "builds no link for a name the desktop editor-link check refuses" fails with that line removed and passes with it.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97
bolichen97 force-pushed the fix/11338-remote-editor-links branch from 7b68b46 to a049169 Compare November 6, 2026 15:26
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 6, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 7, 2026
@bolichen97
bolichen97 force-pushed the fix/11338-remote-editor-links branch from 4dcf5fc to 17ce78c Compare November 8, 2026 01:59
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no
resolution: removed -- the path chip and file viewer rows are gone, so a transcript path never reaches the link

  • span=173e0ef0e5df Session-environment paths open on the wrong machine

removed in 17ce78c: the row is gone from FilePathMenu.tsx (path chips in chat, the file tree and every other chip surface) and from the file viewer; only the side panel's ⋯ menu (MarkdownPanelHeader.tsx) builds the link.
The side panel reads the gateway's copy of a file, and pages/chat/SidePanel.tsx withholds gateway file tabs for a chat whose placement is remote and holds them while placement is unknown, so the link always names the file the panel shows.
MarkdownPanel.remoteEditor.test.tsx "is not in a path chip menu, whose path may name a file on another machine" pins the chip menu without the row.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=5c610058f3b1 Neither setting says what the user's own computer needs

fixed in 17ce78c: the editor description reads "Adds “Open in VS Code” to the ⋯ menu of a file open in the side panel. Needs VS Code with Remote-SSH on the computer you’re using. The file opens there, connected to the SSH host below."
The host description reads "The name after Host in ~/.ssh/config on the computer you’re using, like dev-box. Every computer you open this dashboard from needs that name." Both are in all 12 catalogs and the settings search registry, and the screenshots are re-captured from this head.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/config/sections.py and src/kiro_crew/docs/ui-index.generated.json (a conflict on the old head), plus the generated settings files and locale catalogs this PR also edits (c0e9c2e -> 7f11b5c); the generated files are rebuilt on the new base; CI re-running.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Thanks. A separate PR for the attached-window row once this one lands is the right shape; it will get its own review. One thing to know when you rebase it: this branch now offers the link only in the side panel's ⋯ menu for an open file, not in path chips or the file viewer, because a chip in a chat bound to a session environment can name a file on another machine.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 8, 2026
@bolichen97
bolichen97 force-pushed the fix/11338-remote-editor-links branch from 17ce78c to bb005e9 Compare November 8, 2026 08:45
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Rebased onto main ece4f407e2 to clear a merge conflict in the generated src/kiro_crew/docs/ui-index.generated.json: main's copy was taken and regenerated with npm run gen:ui. No code changed (new head bb005e99db). The red lanes on 17ce78c57a were API failures, not findings: UX, Design, First Principles, GPT and Opus could not read the PR's comments, and the Dependency License Gate hit the dependency-graph rate limit.

The UX copy from the earlier ruling is applied: remote_editor_editor_desc and the host description are in en.manual.json and all 12 locale catalogs. Local GPT and Opus reviews at bb005e99db: no findings. Local checks: the PR's backend tests (136 passed), its two frontend tests (10 passed), and the ui-index freshness tests (33 passed).

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 8, 2026
When the gateway runs on another machine, every file-open action in
the dashboard's file menus ended at "Copy path": open and reveal act on
the gateway host, and the desktop app's "Open in editor" opens a path
that does not exist on the viewer's machine.

Settings > Display > Remote editor takes an editor (VS Code, or off)
and the SSH host the viewer reaches the gateway by. Once both are set,
the side panel's overflow menu for an open file offers "Open in VS
Code", a vscode://vscode-remote/ssh-remote+<host><path> link that the
viewer's own editor opens over the viewer's own SSH. The dashboard
grants no new write access: the edit happens in that editor.

Only the side panel offers the row. It always shows the gateway's copy
of a file, while a path in a transcript can name a file on another
machine (a chat bound to a session environment), so a row there could
open the wrong file.

The editor is an enum because it becomes the link's URL scheme, and
the host must be a DNS name or SSH alias, the grammar the desktop
app's editor-link check takes, so it adds no URL structure and no
leading dash ssh could read as an option. The write gate enforces
both, and the branding endpoint drops a hand-edited value either one
refuses. A path that is not absolute or has a dot segment gets no
link, since URL parsing would remove the segment and could point the
link at another host. In an embedded pane the link opens as a new
window, which the desktop app confirms first.

Builds on #19557 by @helenastafford.

Closes #11338

Co-authored-by: Helena Stafford <43710966+helenastafford@users.noreply.github.com>
@bolichen97
bolichen97 force-pushed the fix/11338-remote-editor-links branch from bb005e9 to ddf0ca6 Compare November 8, 2026 17:20
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 8, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: save-on-blur SSH host field with no visible save signal

  • SSH host field: the user can't tell what to type or when it saved span=17745736871e

fixed in ddf0ca6: the empty field now shows the placeholder "e.g. dev-box", and a "Saved" status line appears once a save on blur lands, the same pattern as the session folder root field. It goes away when the user types again and never shows beside a refused host.
Save on blur is kept. Both strings are in every locale catalog with the pseudolocale regenerated; the settings test pins the placeholder, the line after a save, its removal on typing, and its absence on a refusal. Screenshots are in the description.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 8, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. On this head the review checked the whole path from the stored setting to the link. The owner-only PATCH gate refuses a bad editor or host with a full regex match. The branding endpoint checks again and drops hand-edited values such as -oProxyCommand=x, dev-box/x?y or a non-string. remoteEditorUrl returns no link for a dot segment, a backslash or a control character, and every character it emits fits the desktop app's EDITOR_LINK_RE. The tests check these refusal cases, the side-panel-only placement and the Settings save flow, and they do not sleep or leave shared state behind.

Security: the PR does pass new user input into a clickable vscode:// link and adds change-card classification rows, but neither opens a hole. An agent cannot point the link at another machine without the owner. The host is classified code_exec and the editor cannot widen. Three separate checks refuse a value with URL structure or an ssh option: the write gate, the branding re-check and the desktop app's own link check. The /a/../../ssh-remote+other/x host switch is pinned to no link.

Done well: the row only appears in the side panel, where the file is known to be on the gateway, and a negative test keeps it out of chat path chips.

Optional:

  • Nothing pins dashboard.remote_editor.host as code_exec. If it moves to _CANNOT_WIDEN_SETTINGS, an agent-proposed host shows as a normal card and the related tests stay green. One row in test_session_environment_paths_keep_their_class would catch this, like the existing coder_url row.
  • The help text tells users to type the name after Host in ~/.ssh/config, but the host grammar refuses an alias such as dev_box. Either change the wording or widen this regex and the desktop HOSTNAME_RE together.
  • After this lands, close #19557 as superseded and credit its author.

@bolichen97
bolichen97 merged commit 1002b34 into main Nov 8, 2026
101 checks passed
@bolichen97
bolichen97 deleted the fix/11338-remote-editor-links branch November 8, 2026 18:50
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote files in a local editor (vscode://kiro:// ssh-remote links) from file-path menus

3 participants