Skip to content

fix(dashboard): open remote-editor links as a file or a folder, and offer Kiro - #38292

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
jcjaskula-aws:fix/remote-editor-kiro-link
Nov 20, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
jcjaskula-aws:fix/remote-editor-kiro-link

Conversation

@jcjaskula-aws

@jcjaskula-aws jcjaskula-aws commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The side panel's "Open in " links open a file as a file and a folder as a folder, in VS Code or in Kiro.

The link opens the file's path as a folder. With Settings → Display → Remote editor set to VS Code, ⋯ → Open in VS Code opens a new remote window whose workspace is the file's path, and the file is never shown. The link is vscode://vscode-remote/ssh-remote+<host><path>, and the editor reads a remote path with no line number as a folder; the same link ending in :1 opens the file in the current window. That same rule is what a folder needs, yet a side-panel folder tab offers no way to open the folder in an editor. Kiro, which reads the same link shape, is not offered at all.

Why it matters

Everyone who turns the Remote editor setting on hits this on every click: the row's one job is to open the file, and today it opens an empty workspace instead. Opening a whole project folder over SSH, the other common need, has no entry point. Kiro users have no option even though kiro:// handles the same link.

Not a goal

  • A free-form editor or link template. The editor list stays fixed, so no config write can point the link at an arbitrary protocol handler.
  • Path chips or the file viewer's ⋯ menu; the links stay in the side panel (the Markdown panel's ⋯ menu and the folder tab's header).
  • Editors other than VS Code and Kiro.

What changed (motivation → approach → change)

The editor treats an ssh-remote path as a folder unless it carries :line, so remoteEditorUrl (utils/remoteEditorUrl.ts) takes the target's kind: a file link ends in :1, a folder link has no suffix. The folder tab's header (pages/chat/FolderPanel.tsx) gets an "Open in " entry with the folder link. It shares one ⋯ menu with Reveal, so the row holds Refresh and that menu (max-two-buttons-per-row). Kiro reads the same authority, so it joins the fixed editor list on both sides, REMOTE_EDITOR_IDS in config/sections_dashboard.py and REMOTE_EDITORS in the frontend, and the Remote editor select offers it.

Piece Change
Link <editor>://vscode-remote/ssh-remote+<host><path>, :1 for a file and bare for a folder; editors vscode and kiro
Folder tab Header ⋯ menu holding Reveal and "Open in " for the open folder; the menu shows when either is available
Desktop app external-scheme.js accepts kiro:// file links under the same rules as vscode://; any other kiro: URL stays blocked
Setting text The editor description no longer names VS Code, in every locale catalog (website/src/i18n/locales); the pseudolocale is regenerated
Generated config-baseline.json, the settings registry (settings-registry.generated.json, settingsRegistry.gen.ts) and the eslint brand allowlist (eslint.i18n.config.js)

The spec's Remote editor paragraph and the feature map name both editors and the :1 suffix.

Backwards compatibility

Compatible: vscode stays a valid editor id and kiro is new; a saved config keeps working, a file link only gains its trailing :1, and the folder tab's Reveal moves from a header button into the header's ⋯ menu.

Removes nothing: the change adds an editor id, a scheme the desktop check accepts, a link suffix and a folder entry. The folder tab's Reveal keeps its action and its gate and moves into the header's ⋯ menu.

Tests

  • MarkdownPanel.remoteEditor.test.tsx: a file link ends in :1 and a folder link has no suffix, and a Kiro choice gives "Open in Kiro" with a kiro:// link.
  • FolderPanel.test.tsx: the ⋯ menu's editor entry links to the folder with no suffix and is absent while no editor is picked; with Reveal and an editor both available the row holds only Refresh and the ⋯ trigger, and the menu holds both entries; Reveal opens through the menu.
  • test_config_patch_remote_editor.py: kiro is accepted as dashboard.remote_editor.editor.
  • website/electron/test/external-scheme.test.js: kiro:// file links ask before opening; a kiro: extension URI and an option-shaped host stay blocked.

Locally: those suites, the 58 suites that render the folder tab or the link, the i18n suite (81 files), the config baseline and settings registry tests, tsc, eslint and the i18n lint pass.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Pasting each link by hand into a browser on the viewer's computer, against a remote host: vscode://vscode-remote/ssh-remote+<host>/<path> and the same with kiro:// opened the path as a folder, and kiro://vscode-remote/ssh-remote+<host>/<path>:1 opened the file in the current window. The rows themselves have not been clicked through on this head.

Screenshots / video

The folder tab's header holds Refresh and one ⋯ menu; the menu holds Reveal (when the host can open a file manager) and "Open in " (once an editor and SSH host are set in Settings → Display → Remote editor).
image

Folder tab header with Kiro set as the remote editor and the ⋯ menu open: "Show in file manager" and "Open in Kiro" (hovered), which opens the folder as a remote workspace. With no editor set, the menu holds Reveal alone.

Related Issues

Closes #38284

Sibling sweep

Swept: git grep -nE "vscode-remote|vscode://" -- website/src website/electron src/kiro_crew
Sibling: website/src/components/DiffBlock.tsx:111 -- not affected -- builds the local vscode://file authority, not ssh-remote

Pattern harvest

Not generalizable: one link builder, whose target editor reads a remote path with no line number as a folder; no other code builds an ssh-remote link.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 17, 2026
@jcjaskula-aws
jcjaskula-aws force-pushed the fix/remote-editor-kiro-link branch from 5847ac9 to aee3a5b Compare November 17, 2026 16:27
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 17, 2026
@jcjaskula-aws
jcjaskula-aws force-pushed the fix/remote-editor-kiro-link branch from aee3a5b to fc13559 Compare November 19, 2026 17:40
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 06b372f74ddfc9c7a0766d833d3267499fe92f5e via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 06b372f

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 06b372f74ddfc9c7a0766d833d3267499fe92f5e via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 06b372f

@jcjaskula-aws
jcjaskula-aws force-pushed the fix/remote-editor-kiro-link branch from fc13559 to 75a11d9 Compare November 19, 2026 23:09
@jcjaskula-aws

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: folder tab header "Open in " link beside Refresh and Reveal
resolution: narrowed -- Reveal and the editor link share one overflow menu

  • span=9f733a4f3c8f Folder tab header holds three action buttons

fixed in 75a11d9: the header row holds Refresh and one ⋯ DropdownMenu trigger (rendered only when it has an item); Reveal and "Open in " are entries in that menu, built like CronRowActions.
FolderPanel.test.tsx "keeps the header to Refresh plus one overflow trigger holding Reveal and the editor link" pins the row's controls to Refresh and the trigger, and the menu to both entries.

@jcjaskula-aws

Copy link
Copy Markdown
Contributor Author

@bolichen97 when you have a moment, could you approve the workflow runs on this PR? As a fork PR, CI is waiting on maintainer approval. It's the follow-up to #31141: remote-editor links now open a file as a file (:1) and a folder as a folder, Kiro is offered as an editor, and the folder tab gets "Open in " in its ⋯ menu next to Reveal (the menu keeps the header at two buttons, per the Opus review). #39642 carries the :1 part alone if you'd rather land that first.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 19, 2026
@jcjaskula-aws
jcjaskula-aws force-pushed the fix/remote-editor-kiro-link branch from 75a11d9 to 74d5cc6 Compare November 20, 2026 04:49
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 20, 2026
…ffer Kiro

The side panel's "Open in <editor>" link opened the file's path as a
folder. A `vscode://vscode-remote/ssh-remote+<host><path>` link with no
line number makes VS Code (and Kiro, which reads the same authority) open
the path as a remote workspace; with a `:line` suffix it opens the file in
the current window. A file link now ends in `:1`.

The same rule gives folders their own link: a side-panel folder tab's
header gets an "Open in <editor>" button whose link carries no suffix, so
the folder opens as a remote workspace. `remoteEditorUrl` takes the kind.

Kiro joins VS Code in the Remote editor setting (`REMOTE_EDITOR_IDS` and
`REMOTE_EDITORS`), giving a `kiro://` link of the same shape. The desktop
app's editor-link check accepts the `kiro` scheme under the same rules as
`vscode`, so any other `kiro:` URL stays blocked. The setting's
description no longer names VS Code, in every catalog.
@jcjaskula-aws
jcjaskula-aws force-pushed the fix/remote-editor-kiro-link branch from 74d5cc6 to 06b372f Compare November 20, 2026 04:56
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Nov 20, 2026
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⚠️ could not complete

The first-principles review did not produce a verdict for 06b372f74ddfc9c7a0766d833d3267499fe92f5e (the review step never ran, because an earlier step in this job failed — no model call was made). See the Fork First Principles Review job logs. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 06b372f74ddfc9c7a0766d833d3267499fe92f5e via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The base already has the :1 file suffix, so this revision adds Kiro to the fixed editor list and a folder entry in a ⋯ menu, with a screenshot of the menu.

Notes

  • The Editor setting text still says the row is added "to the ⋯ menu of a file open in the side panel", but the folder tab's ⋯ menu now offers it too. Users who pick an editor won't learn the folder entry exists.
  • Reveal moved from a header button into the ⋯ menu, so website/scripts/capture-reveal-label-sweep.mjs may no longer find FolderPanel's reveal control by its label. Re-run that script, or point it at the menu item.

[DESIGN-REVIEWED] 06b372f

Description read

[DESCRIPTION-READ] 44b7dcc356accb519574ad1a4944303b0037bb2e867c3e824f236e4d41cf82c3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 06b372f74ddfc9c7a0766d833d3267499fe92f5e via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of Settings → Display → Remote editor, where the Editor select now offers "Kiro" and its description text changed. The folder-tab ⋯ menu is shown; nobody without the diff has read it, which is a limit of this lane, not something the author missed.

Evidence gaps

  • Remote editor settings: the select's new Kiro option (from REMOTE_EDITORS = { vscode: 'VS Code', kiro: 'Kiro' }) and the rewritten remote_editor_editor_desc appear in no image. Attach a screenshot of Settings → Display → Remote editor with the select open, showing Off / VS Code / Kiro and the new description.

Notes

  • The new description, "Adds a row to the ⋯ menu of a file open in the side panel that opens the file in this editor", doesn't mention the folder-tab entry this PR adds. Someone looking for a way to open a whole folder won't learn that it exists. Suggested text: "Adds "Open in " to the ⋯ menu of a file or folder open in the side panel."
  • In a product called Kiro Crew, "Open in Kiro" next to "Show in file manager" could be read as opening the folder inside Kiro Crew itself. If someone without the diff reads it that way, label it "Open in Kiro (editor)" or use the app's own icon.

[UX-REVIEWED] 06b372f

Description read

[DESCRIPTION-READ] 3a2d6079d55a5730879833d4631f726b9dbfb9fba62aaea237698789592271cd

That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 06b372f74d. I read the diff: the folder link drops the :1 suffix so the editor opens it as a folder, the file link keeps it, and kiro:// goes through the same EDITOR_LINK_RE and confirm step as vscode:// (extension URIs and -o hosts stay blocked, with tests for both). The two editor lists stay equal, and the folder tab's Reveal keeps its gate inside the new menu. CI and readiness are green.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 enabled auto-merge (squash) November 20, 2026 06:30
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 20, 2026
@bolichen97
bolichen97 merged commit b85217a into kirodotdev:main Nov 20, 2026
97 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026
@jcjaskula-aws
jcjaskula-aws deleted the fix/remote-editor-kiro-link branch November 20, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote editor link opens the file's path as a folder, and Kiro is not offered

2 participants