Repository navigation
fix(dashboard): open remote-editor links as a file or a folder, and offer Kiro - #38292
Conversation
5847ac9 to
aee3a5b
Compare
aee3a5b to
fc13559
Compare
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
fc13559 to
75a11d9
Compare
|
self-added: yes
|
|
@bolichen97 when you have a moment, could you approve the workflow runs on this PR? As a fork PR, CI is waiting on maintainer approval. It's the follow-up to #31141: remote-editor links now open a file as a file ( |
75a11d9 to
74d5cc6
Compare
…ffer Kiro The side panel's "Open in <editor>" link opened the file's path as a folder. A `vscode://vscode-remote/ssh-remote+<host><path>` link with no line number makes VS Code (and Kiro, which reads the same authority) open the path as a remote workspace; with a `:line` suffix it opens the file in the current window. A file link now ends in `:1`. The same rule gives folders their own link: a side-panel folder tab's header gets an "Open in <editor>" button whose link carries no suffix, so the folder opens as a remote workspace. `remoteEditorUrl` takes the kind. Kiro joins VS Code in the Remote editor setting (`REMOTE_EDITOR_IDS` and `REMOTE_EDITORS`), giving a `kiro://` link of the same shape. The desktop app's editor-link check accepts the `kiro` scheme under the same rules as `vscode`, so any other `kiro:` URL stays blocked. The setting's description no longer names VS Code, in every catalog.
74d5cc6 to
06b372f
Compare
First Principles Review (Opus 5.5, fork) —
|
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The base already has the Notes
[DESIGN-REVIEWED] 06b372f Description read[DESCRIPTION-READ] 44b7dcc356accb519574ad1a4944303b0037bb2e867c3e824f236e4d41cf82c3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of Settings → Display → Remote editor, where the Editor select now offers "Kiro" and its description text changed. The folder-tab ⋯ menu is shown; nobody without the diff has read it, which is a limit of this lane, not something the author missed. Evidence gaps
Notes
[UX-REVIEWED] 06b372f Description read[DESCRIPTION-READ] 3a2d6079d55a5730879833d4631f726b9dbfb9fba62aaea237698789592271cd That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
bolichen97
left a comment
There was a problem hiding this comment.
Approving 06b372f74d. I read the diff: the folder link drops the :1 suffix so the editor opens it as a folder, the file link keeps it, and kiro:// goes through the same EDITOR_LINK_RE and confirm step as vscode:// (extension URIs and -o hosts stay blocked, with tests for both). The two editor lists stay equal, and the folder tab's Reveal keeps its gate inside the new menu. CI and readiness are green.
AI-assisted, sent by Bolin Review bot
Problem / Motivation
Goal: The side panel's "Open in " links open a file as a file and a folder as a folder, in VS Code or in Kiro.
The link opens the file's path as a folder. With Settings → Display → Remote editor set to VS Code, ⋯ → Open in VS Code opens a new remote window whose workspace is the file's path, and the file is never shown. The link is
vscode://vscode-remote/ssh-remote+<host><path>, and the editor reads a remote path with no line number as a folder; the same link ending in:1opens the file in the current window. That same rule is what a folder needs, yet a side-panel folder tab offers no way to open the folder in an editor. Kiro, which reads the same link shape, is not offered at all.Why it matters
Everyone who turns the Remote editor setting on hits this on every click: the row's one job is to open the file, and today it opens an empty workspace instead. Opening a whole project folder over SSH, the other common need, has no entry point. Kiro users have no option even though
kiro://handles the same link.Not a goal
What changed (motivation → approach → change)
The editor treats an
ssh-remotepath as a folder unless it carries:line, soremoteEditorUrl(utils/remoteEditorUrl.ts) takes the target's kind: a file link ends in:1, a folder link has no suffix. The folder tab's header (pages/chat/FolderPanel.tsx) gets an "Open in " entry with the folder link. It shares one ⋯ menu with Reveal, so the row holds Refresh and that menu (max-two-buttons-per-row). Kiro reads the same authority, so it joins the fixed editor list on both sides,REMOTE_EDITOR_IDSinconfig/sections_dashboard.pyandREMOTE_EDITORSin the frontend, and the Remote editor select offers it.<editor>://vscode-remote/ssh-remote+<host><path>,:1for a file and bare for a folder; editorsvscodeandkiroexternal-scheme.jsacceptskiro://file links under the same rules asvscode://; any otherkiro:URL stays blockedwebsite/src/i18n/locales); the pseudolocale is regeneratedconfig-baseline.json, the settings registry (settings-registry.generated.json,settingsRegistry.gen.ts) and the eslint brand allowlist (eslint.i18n.config.js)The spec's Remote editor paragraph and the feature map name both editors and the
:1suffix.Backwards compatibility
Compatible:
vscodestays a valid editor id andkirois new; a saved config keeps working, a file link only gains its trailing:1, and the folder tab's Reveal moves from a header button into the header's ⋯ menu.Removes nothing: the change adds an editor id, a scheme the desktop check accepts, a link suffix and a folder entry. The folder tab's Reveal keeps its action and its gate and moves into the header's ⋯ menu.
Tests
MarkdownPanel.remoteEditor.test.tsx: a file link ends in:1and a folder link has no suffix, and a Kiro choice gives "Open in Kiro" with akiro://link.FolderPanel.test.tsx: the ⋯ menu's editor entry links to the folder with no suffix and is absent while no editor is picked; with Reveal and an editor both available the row holds only Refresh and the ⋯ trigger, and the menu holds both entries; Reveal opens through the menu.test_config_patch_remote_editor.py:kirois accepted asdashboard.remote_editor.editor.website/electron/test/external-scheme.test.js:kiro://file links ask before opening; akiro:extension URI and an option-shaped host stay blocked.Locally: those suites, the 58 suites that render the folder tab or the link, the i18n suite (81 files), the config baseline and settings registry tests, tsc, eslint and the i18n lint pass.
Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Pasting each link by hand into a browser on the viewer's computer, against a remote host:
vscode://vscode-remote/ssh-remote+<host>/<path>and the same withkiro://opened the path as a folder, andkiro://vscode-remote/ssh-remote+<host>/<path>:1opened the file in the current window. The rows themselves have not been clicked through on this head.Screenshots / video
The folder tab's header holds Refresh and one ⋯ menu; the menu holds Reveal (when the host can open a file manager) and "Open in " (once an editor and SSH host are set in Settings → Display → Remote editor).

Folder tab header with Kiro set as the remote editor and the ⋯ menu open: "Show in file manager" and "Open in Kiro" (hovered), which opens the folder as a remote workspace. With no editor set, the menu holds Reveal alone.
Related Issues
Closes #38284
Sibling sweep
Swept: git grep -nE "vscode-remote|vscode://" -- website/src website/electron src/kiro_crew
Sibling: website/src/components/DiffBlock.tsx:111 -- not affected -- builds the local
vscode://fileauthority, notssh-remotePattern harvest
Not generalizable: one link builder, whose target editor reads a remote path with no line number as a folder; no other code builds an
ssh-remotelink.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)