Repository navigation
fix(i18n): word four two-sentence messages as one catalog message - #31383
Conversation
The source-links stop note, the browser permission explainer, the usage chart slider label and the crew memory-binding notice each joined two translated sentences in code with an English space or full stop. In Japanese and Simplified Chinese that put ASCII punctuation between full-width sentences. Each is now one catalog message in all shipped catalogs. English reads the same.
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the diff only rewords strings in existing UI, and no remaining code reads the catalog keys it removes. Notes
[DESIGN-REVIEWED] 9225f73 Description read[DESCRIPTION-READ] 0fc4b092c8c585a8cb4eb7a9bb68e60fabe7d546d18841423667aff92e00b31d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: only non-English copy changes and no control changes. English is byte-identical, so a screenshot or blind read would show no visible difference. Notes
[UX-REVIEWED] 9225f73 Description read[DESCRIPTION-READ] 323eeaf96d620e5f93b1a9eab8e181e0e58f9881e6e35aa16180649780bd5590 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a fix, and it changes the four messages at the cause: the call sites that glued two catalog sentences together. The two siblings left unfixed are named and deferred because open PRs touch those files. Notes
What this change shipsInventory (5 items) — 4 justifiedIntent: in every language, these four UI messages read as one naturally worded message, with no English space or full stop forced between sentences. FIX.
[FIRST-PRINCIPLES-REVIEWED] 9225f73 Description read[DESCRIPTION-READ] 44ac6ee7e0c6eb7757fece4545e99179b8c8e7f2c69c0084f2e6cf68bdf38356 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 9225f73 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (20 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: four UI messages built from two joined translations become one catalog message each.
…1383) The source-links stop note, the browser permission explainer, the usage chart slider label and the crew memory-binding notice each joined two translated sentences in code with an English space or full stop. In Japanese and Simplified Chinese that put ASCII punctuation between full-width sentences. Each is now one catalog message in all shipped catalogs. English reads the same. (cherry picked from commit 7cc1a84)
…1383) The source-links stop note, the browser permission explainer, the usage chart slider label and the crew memory-binding notice each joined two translated sentences in code with an English space or full stop. In Japanese and Simplified Chinese that put ASCII punctuation between full-width sentences. Each is now one catalog message in all shipped catalogs. English reads the same. (cherry picked from commit 7cc1a84)
Problem / Motivation
Goal: Four UI messages that joined two translated sentences in code are each one catalog message in every shipped language.
The source-links stop note, the browser permission explainer, the usage chart slider name and the crew memory-binding notice each glued two catalog sentences with an English space (the chart with
.). No language could word them as one message, and Japanese and Simplified Chinese got an ASCII space or full stop between full-width sentences.Why it matters
These lines explain a stopped action, a browser permission, a chart a screen reader announces, and why a memory store cannot be used. A foreign separator between sentences reads as a rendering slip.
Not a goal
What changed (motivation → approach → change)
components/SourceLinksSubmenu.tsxstop notehide_all_source_links_stopped+ space +hide_all_source_links_retryhide_all_source_links_stopped_retrypages/chat/BrowserLiveCardViews.tsxexplainerallow_explainer+ space +allow_asked_onceallow_explainer_asked_oncepages/overview/TokenStackedAreaChart.tsxslider namearia_label+.+keyboard_hintaria_label_keyboard_hintcomponents/crew/CrewEditorNextDialog.tsxmemory noticememory_binding_diagnosticmemory_binding_mismatch_diagnostic,memory_binding_unavailable_diagnosticEach locale value reuses that locale's existing sentences: ja and zh-CN join with no space (the chart label gets a full-width
。), every other language keeps the space or.(Hindi takes a danda). Where a new value inherited wording the style guides reject, it is corrected: informal address in Bengali, Hindi and Russian, and U+202F before the French colon. Fragment keys with no other reader are removed from all 12 catalogs;aria_labelandmemory_binding_unavailablekeep their other readers. The translator note inen.context.jsonmoves to the new chart key.en-XAis regenerated. English is byte-identical.Backwards compatibility
Compatible: only displayed text and one accessible name change, and the English text is byte-identical. No API, route, setting or stored value is touched.
Tests
website/src/test/ChatWholeMessageJoins.i18n.test.tschecks the English messages are byte-identical, that ja and zh-CN carry no ASCII space or full stop between sentences, that every shipped language has each message, and that none of the four files still glues the parts. All 7 checks fail on main and pass here. The per-language style suites pass withI18N_BASE_REF=origin/main.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Rendered the memory-binding notice text in Russian and French on main and on this branch (screenshots below, from this branch at
f55b8efb9b; the PNGs are not in the final commit). This host has no CJK font, so the Japanese and Chinese shapes are pinned by the test instead. Local reviews: GPT on gpt-5.6-sol and Opus; the one note (stale translator context) is fixed here.Screenshots / video
Before (main):
After:
Related Issues
Fixes #31379
Sibling sweep
Swept: a line scanner over website/src for two i18nT calls joined by an English space, colon or period that form two sentences
Sibling: website/src/pages/ChannelPage.tsx:1205 -- not affected -- open PRs #30515 and #29402 touch this file
Sibling: website/src/pages/developer/AgentBackendTab.tsx:1101 -- not affected -- open PR #29509 touches this file
Pattern harvest
Rule candidate: lint
Pattern: a translated string built as
${i18nT(a)} ${i18nT(b)}where both are full sentencesChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)