Repository navigation
fix(settings): word update errors and the sign-in note as one message - #31208
Conversation
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the reworded About-panel update errors and the Remote Crew sign-in note. The blind read was not performed because the PR supplied no admissible image. Evidence gaps
[UX-REVIEWED] 7e35776 Description read[DESCRIPTION-READ] 470247aa0632c175e5905c7819f5b4a366958f1047adef63c114928f62a649d5 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a text-only catalog consolidation, and the removed fragment keys have no readers left in the tree. Notes
[DESIGN-REVIEWED] 7e35776 Description read[DESCRIPTION-READ] 53ecf46f875ff4f060501c935804739f755eb1f25ac7752edb2a35f76034cdd8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This fix works on the actual cause: the site code assembled the messages. Each site now reads one catalog message. The siblings outside Settings are deferred to #31669. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: People reading an update error or the stale sign-in note see it worded naturally in their own language. This is a FIX (#31204).
[FIRST-PRINCIPLES-REVIEWED] 7e35776 Description read[DESCRIPTION-READ] 4288487071f9b2f370ba399601e1ef69e052af310f0cab72103b21e7c9454add That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
e7a6c34 to
02e8179
Compare
02e8179 to
3de5f63
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at 3de5f63: a deferred follow-up needs a linked issue. The fix itself looks right.
Each Settings site now reads one catalog message with {{reason}} (AboutPanel.tsx#L495, RemoteCrewPanelLaunch.tsx#L199). The new keys exist in every catalog, the old fragment keys have no remaining reader, and CI is green.
Blocker: Not a goal leaves the same English-separator join on five sites outside Settings, and the First Principles lane recorded them as accepted and deferred. No issue tracks them. #31204 covers Settings only. The sites are:
- SourceLinksSubmenu.tsx#L231
- CrewEditorNextDialog.tsx#L508
- ChannelPage.tsx#L1205
- AgentBackendTab.tsx#L1101
- AgentTemplatesTab.tsx#L658
To clear it, open one issue that lists these sites (it can carry the lint from your Pattern harvest) and link it in the PR description, or fix them here.
AI findings judged non-blocking:
- Opus: the hi/ru restart note is informal while
sign_in_unconfirmedis formal. This is wording only, and the description cites the style guides. - UX: no usable screenshots. The change is text only and the new test pins it.
- Design: a lint would catch this class better than a two-file test. That is a process suggestion, not a defect.
I read the source and the CI results; I did not run the tests.
— crew-pr-reviewer (r148)
|
@iamwhatever Thanks. The five sites outside Settings:
The description now says "Deferred: #31669" under Not a goal, added at your request. No code change. |
The About panel joined a translated update-error label to its reason with an English colon, and the Remote Crew sign-in note joined two translated sentences with an English space. In Japanese and Simplified Chinese that put a half-width colon or a stray space between full-width text. Each is now one catalog message, with the reason as a placeholder, in all shipped catalogs. English reads the same.
3de5f63 to
7e35776
Compare
|
Changes since the 17:57Z review (head 3de5f63 → 7e35776):
|
bolichen97
left a comment
There was a problem hiding this comment.
Approving at 7e35776. All checks pass. The author already holds auto-merge, so I am not setting it.
What I checked:
- Each Settings message that was two translated parts glued with an English
:or space is now one catalog message with a{{reason}}placeholder, so each language places its own colon. This covers the About panel's check, download and install errors, and the Remote Crew sign-in note. SettingsWholeMessageJoins.i18n.test.tspins the exact English text, a full-width colon in Japanese and Simplified Chinese, the narrow no-break space in French, the reason in every shipped language, and that the old glued literals are gone from the source.- Frontend and catalogs only. The test uses no regex.
@iamwhatever, your 11-06 change request at 3de5f63 asked for a tracked issue for the join sites outside Settings. #31669 now tracks the three still open (the other two were fixed by #31383), and the description links it under "Not a goal". Could you re-review and clear it if you agree?
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at 7e35776.
Each About panel update error and the Remote Crew stale sign-in note is now one catalog message with {{reason}}, so each language places its own separator (AboutPanel.tsx#L495, RemoteCrewPanelLaunch.tsx#L199-L200). Every shipped catalog carries the new keys, English is unchanged, and the old fragment keys had no other reader.
The deferral in our r148 change request is resolved: #31669 tracked the remaining sites outside Settings and was closed by #31698, and the other two were fixed by #31383.
AI findings judged non-blocking:
- UX: no admissible screenshot. The change is catalog text with English byte-identical, and the new test pins the per-language separators (SettingsWholeMessageJoins.i18n.test.ts#L25).
- Design: says
sign_in_unconfirmedcontradicts "four fragment keys replaced". It does not: the four are the three About panel fragments andsign_in_unconfirmed_expired;sign_in_unconfirmedis still read by the other branch (RemoteCrewPanelLaunch.tsx#L199-L200). - First Principles: the source-literal
it.eachblock rides along. Test-only (SettingsWholeMessageJoins.i18n.test.ts#L69). - Opus (earlier round): the hi/ru restart note is informal. Wording only; the description cites the style guides.
CI: the only red check is Sensitive Change Review attempt 2, which hit a GitHub API rate limit after the approval re-run; attempt 1 on this head passed and the required PR Readiness is green. I read the source, catalogs and CI; I did not run the tests.
— crew-pr-reviewer (r149)
Red check Sensitive Change Review (run 42377511625) does not count: its log ends with "Could not read the PR from the API (CalledProcessError: gh: API rate limit exceeded for installation ...)", an API rate-limit error, not a finding.
…#31208) The About panel joined a translated update-error label to its reason with an English colon, and the Remote Crew sign-in note joined two translated sentences with an English space. In Japanese and Simplified Chinese that put a half-width colon or a stray space between full-width text. Each is now one catalog message, with the reason as a placeholder, in all shipped catalogs. English reads the same. (cherry picked from commit 03016b6)
…#31208) The About panel joined a translated update-error label to its reason with an English colon, and the Remote Crew sign-in note joined two translated sentences with an English space. In Japanese and Simplified Chinese that put a half-width colon or a stray space between full-width text. Each is now one catalog message, with the reason as a placeholder, in all shipped catalogs. English reads the same. (cherry picked from commit 03016b6)
Problem / Motivation
Goal: The About panel update errors and the Remote Crew stale sign-in note are each one translated message in every shipped language.
The About panel built each update error as a translated label, an English
:, then a translated reason. The Remote Crew stale sign-in note joined two translated sentences with an English space. No language could word these as one message: Japanese and Simplified Chinese got a half-width colon or a stray space between full-width text, and French got no narrow no-break space before its colon.Why it matters
These lines are what a person reads when an update or a crew sign-in goes wrong. A separator that does not belong to the language reads as a rendering slip at the moment they need the text most.
Not a goal
What changed (motivation → approach → change)
Symptom: a foreign separator between two translated parts. Cause: the message was assembled in code. Change: each site reads one whole catalog message, with the reason as
{{reason}}.AboutPanel.tsxcheck error (2 sites)couldn_t_check_for_updates+:+ reasoncouldn_t_check_for_updates_reasonAboutPanel.tsxdownload error (3 sites)download_failed+:+ reasondownload_failed_reasonAboutPanel.tsxinstall error (2 sites)install_failed+:+ reasoninstall_failed_reasonRemoteCrewPanelLaunch.tsxstale notesign_in_unconfirmed+ space +sign_in_unconfirmed_expiredsign_in_unconfirmed_restartEach locale value reuses that locale's existing wording, so nothing is retranslated: ja and zh-CN join with a full-width colon (or no space between sentences), fr puts U+202F before its colon, every other language keeps
:and a space. The joined Russian and Hindi sign-in note addresses the reader informally, as the style guides ask. The four fragment keys had no other reader and are replaced in place in all 12 catalogs;en-XAis regenerated. English is byte-identical.Backwards compatibility
Compatible: only displayed text changes, and the English text is byte-identical. No API, route, setting or stored value is touched.
Tests
website/src/test/SettingsWholeMessageJoins.i18n.test.tschecks the English messages are byte-identical, that ja and zh-CN use a full-width colon with no:, that fr puts U+202F before its colon, that every shipped language carries the reason, that the restart note has no space between CJK sentences, and that neither file still glues the parts. All 10 checks fail on main and pass here. The About panel, Remote Crew and per-language style suites pass unchanged.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Rendered the four messages through the real
ErrorNoticein French on main and on this branch (screenshots below, from this branch atae63c8c323; the PNGs are not in the final commit). This host has no CJK font, so the Japanese and Chinese shapes are pinned by the test instead.Screenshots / video
Before (main), French:
After:
Related Issues
Fixes #31204
Sibling sweep
Swept: a line scanner over website/src/pages/settings for two i18nT calls joined by an English space, colon or period
Sibling: website/src/pages/settings/SecurityPanelDeniedCommands.tsx:711 -- not affected -- two counts side by side, not a sentence join
Pattern harvest
Rule candidate: lint
Pattern: a translated string built as
${i18nT(a)}: ${i18nT(b)}or${i18nT(a)} ${i18nT(b)}Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)