Skip to content

fix(settings): word update errors and the sign-in note as one message - #31208

Merged
iamwhatever merged 1 commit into
mainfrom
crew/conductor/settings-whole-message-joins
Nov 7, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
crew/conductor/settings-whole-message-joins

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The About panel update errors and the Remote Crew stale sign-in note are each one translated message in every shipped language.

The About panel built each update error as a translated label, an English : , then a translated reason. The Remote Crew stale sign-in note joined two translated sentences with an English space. No language could word these as one message: Japanese and Simplified Chinese got a half-width colon or a stray space between full-width text, and French got no narrow no-break space before its colon.

Why it matters

These lines are what a person reads when an update or a crew sign-in goes wrong. A separator that does not belong to the language reads as a rendering slip at the moment they need the text most.

Not a goal

What changed (motivation → approach → change)

Symptom: a foreign separator between two translated parts. Cause: the message was assembled in code. Change: each site reads one whole catalog message, with the reason as {{reason}}.

Site Before After
AboutPanel.tsx check error (2 sites) couldn_t_check_for_updates + : + reason couldn_t_check_for_updates_reason
AboutPanel.tsx download error (3 sites) download_failed + : + reason download_failed_reason
AboutPanel.tsx install error (2 sites) install_failed + : + reason install_failed_reason
RemoteCrewPanelLaunch.tsx stale note sign_in_unconfirmed + space + sign_in_unconfirmed_expired sign_in_unconfirmed_restart

Each locale value reuses that locale's existing wording, so nothing is retranslated: ja and zh-CN join with a full-width colon (or no space between sentences), fr puts U+202F before its colon, every other language keeps : and a space. The joined Russian and Hindi sign-in note addresses the reader informally, as the style guides ask. The four fragment keys had no other reader and are replaced in place in all 12 catalogs; en-XA is regenerated. English is byte-identical.

Backwards compatibility

Compatible: only displayed text changes, and the English text is byte-identical. No API, route, setting or stored value is touched.

Tests

website/src/test/SettingsWholeMessageJoins.i18n.test.ts checks the English messages are byte-identical, that ja and zh-CN use a full-width colon with no : , that fr puts U+202F before its colon, that every shipped language carries the reason, that the restart note has no space between CJK sentences, and that neither file still glues the parts. All 10 checks fail on main and pass here. The About panel, Remote Crew and per-language style suites pass unchanged.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Rendered the four messages through the real ErrorNotice in French on main and on this branch (screenshots below, from this branch at ae63c8c323; the PNGs are not in the final commit). This host has no CJK font, so the Japanese and Chinese shapes are pinned by the test instead.

Screenshots / video

Before (main), French:

before

After:

after

Related Issues

Fixes #31204

Sibling sweep

Swept: a line scanner over website/src/pages/settings for two i18nT calls joined by an English space, colon or period
Sibling: website/src/pages/settings/SecurityPanelDeniedCommands.tsx:711 -- not affected -- two counts side by side, not a sentence join

Pattern harvest

Rule candidate: lint
Pattern: a translated string built as ${i18nT(a)}: ${i18nT(b)} or ${i18nT(a)} ${i18nT(b)}

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 07:33
@RohanK6
RohanK6 requested a review from Zedmor November 6, 2026 07:33
@RohanK6
RohanK6 enabled auto-merge (squash) November 6, 2026 07:33
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the reworded About-panel update errors and the Remote Crew sign-in note. The blind read was not performed because the PR supplied no admissible image.

Evidence gaps

  • About panel errors couldn_t_check_for_updates_reason, download_failed_reason and install_failed_reason, shown in the update error notice. No screenshot shows the new joined text. To close it, attach a github.com/user-attachments still of the error notice in French (U+202F before the colon) and, if a CJK font is available, in ja or zh-CN.
  • Remote Crew stale sign-in note sign_in_unconfirmed_restart (RemoteCrewPanelLaunch.tsx). No screenshot shows it. To close it, attach a still of the note in at least one non-English locale.
  • The description's before/after French images show as "[image removed]", and the description says the PNGs are not in the final commit. So nothing for this revision was admitted. Re-attach them as user-attachments assets.

[UX-REVIEWED] 7e35776

Description read

[DESCRIPTION-READ] 470247aa0632c175e5905c7819f5b4a366958f1047adef63c114928f62a649d5

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a text-only catalog consolidation, and the removed fragment keys have no readers left in the tree.

Notes

  • The description's "four fragment keys … are replaced" is slightly off: sign_in_unconfirmed is kept and still read by the !canRestart branch. Only sign_in_unconfirmed_expired and the three About-panel fragments go away.
  • No rendered evidence downloaded, but English is unchanged and no surface is reshaped, so the missing-evidence trigger does not apply.

[DESIGN-REVIEWED] 7e35776

Description read

[DESCRIPTION-READ] 53ecf46f875ff4f060501c935804739f755eb1f25ac7752edb2a35f76034cdd8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This fix works on the actual cause: the site code assembled the messages. Each site now reads one catalog message. The siblings outside Settings are deferred to #31669.

Notes

  • Item 5 — rides along: the source-literal checks (it.each over "aboutPanel.download_failed')}: " …) only test that the old spelling is gone. The catalog checks in the same test already fail on main, so these lines add nothing the catalog checks don't already cover. Subtraction: delete the it.each block in SettingsWholeMessageJoins.i18n.test.ts.

What this change ships

Inventory (6 items) — 5 justified

Intent: People reading an update error or the stale sign-in note see it worded naturally in their own language. This is a FIX (#31204).

  1. The About panel "couldn't check for updates" error is one message in each language (2 sites) — justified
  2. The About panel "download failed" error is one message in each language (3 sites) — justified
  3. The About panel "couldn't install the update" error is one message in each language (2 sites) — justified
  4. The Remote Crew stale sign-in note with the restart sentence is one message — justified
  5. A test that fails if the old glued source strings come back — rides along
  6. The four fragment keys are removed from all 12 catalogs; a grep for the old keys finds 0 code readers left — justified

[FIRST-PRINCIPLES-REVIEWED] 7e35776

Description read

[DESCRIPTION-READ] 4288487071f9b2f370ba399601e1ef69e052af310f0cab72103b21e7c9454add

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7e35776

Verdict parsed from the review's SHA-scoped output markers for commit 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7e35776

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7e3577665e6e1053b4c4ff11cd5de35595ed6b3d false-positive: <reason, 20 to 500 characters>

@RohanK6
RohanK6 force-pushed the crew/conductor/settings-whole-message-joins branch from e7a6c34 to 02e8179 Compare November 6, 2026 08:08
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/settings-whole-message-joins branch from 02e8179 to 3de5f63 Compare November 6, 2026 09:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST_CHANGES at 3de5f63: a deferred follow-up needs a linked issue. The fix itself looks right.

Each Settings site now reads one catalog message with {{reason}} (AboutPanel.tsx#L495, RemoteCrewPanelLaunch.tsx#L199). The new keys exist in every catalog, the old fragment keys have no remaining reader, and CI is green.

Blocker: Not a goal leaves the same English-separator join on five sites outside Settings, and the First Principles lane recorded them as accepted and deferred. No issue tracks them. #31204 covers Settings only. The sites are:

To clear it, open one issue that lists these sites (it can carry the lint from your Pattern harvest) and link it in the PR description, or fix them here.

AI findings judged non-blocking:

  • Opus: the hi/ru restart note is informal while sign_in_unconfirmed is formal. This is wording only, and the description cites the style guides.
  • UX: no usable screenshots. The change is text only and the new test pins it.
  • Design: a lint would catch this class better than a two-file test. That is a process suggestion, not a defect.

I read the source and the CI results; I did not run the tests.

— crew-pr-reviewer (r148)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 6, 2026
@RohanK6

RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever Thanks. The five sites outside Settings:

The description now says "Deferred: #31669" under Not a goal, added at your request. No code change.

The About panel joined a translated update-error label to its reason
with an English colon, and the Remote Crew sign-in note joined two
translated sentences with an English space. In Japanese and Simplified
Chinese that put a half-width colon or a stray space between full-width
text. Each is now one catalog message, with the reason as a placeholder,
in all shipped catalogs. English reads the same.
@RohanK6
RohanK6 force-pushed the crew/conductor/settings-whole-message-joins branch from 3de5f63 to 7e35776 Compare November 7, 2026 13:33
@RohanK6

RohanK6 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Changes since the 17:57Z review (head 3de5f63 → 7e35776):

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 7e35776. All checks pass. The author already holds auto-merge, so I am not setting it.

What I checked:

  • Each Settings message that was two translated parts glued with an English : or space is now one catalog message with a {{reason}} placeholder, so each language places its own colon. This covers the About panel's check, download and install errors, and the Remote Crew sign-in note.
  • SettingsWholeMessageJoins.i18n.test.ts pins the exact English text, a full-width colon in Japanese and Simplified Chinese, the narrow no-break space in French, the reason in every shipped language, and that the old glued literals are gone from the source.
  • Frontend and catalogs only. The test uses no regex.

@iamwhatever, your 11-06 change request at 3de5f63 asked for a tracked issue for the join sites outside Settings. #31669 now tracks the three still open (the other two were fixed by #31383), and the description links it under "Not a goal". Could you re-review and clear it if you agree?

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 7e35776.

Each About panel update error and the Remote Crew stale sign-in note is now one catalog message with {{reason}}, so each language places its own separator (AboutPanel.tsx#L495, RemoteCrewPanelLaunch.tsx#L199-L200). Every shipped catalog carries the new keys, English is unchanged, and the old fragment keys had no other reader.

The deferral in our r148 change request is resolved: #31669 tracked the remaining sites outside Settings and was closed by #31698, and the other two were fixed by #31383.

AI findings judged non-blocking:

  • UX: no admissible screenshot. The change is catalog text with English byte-identical, and the new test pins the per-language separators (SettingsWholeMessageJoins.i18n.test.ts#L25).
  • Design: says sign_in_unconfirmed contradicts "four fragment keys replaced". It does not: the four are the three About panel fragments and sign_in_unconfirmed_expired; sign_in_unconfirmed is still read by the other branch (RemoteCrewPanelLaunch.tsx#L199-L200).
  • First Principles: the source-literal it.each block rides along. Test-only (SettingsWholeMessageJoins.i18n.test.ts#L69).
  • Opus (earlier round): the hi/ru restart note is informal. Wording only; the description cites the style guides.

CI: the only red check is Sensitive Change Review attempt 2, which hit a GitHub API rate limit after the approval re-run; attempt 1 on this head passed and the required PR Readiness is green. I read the source, catalogs and CI; I did not run the tests.

— crew-pr-reviewer (r149)

Red check Sensitive Change Review (run 42377511625) does not count: its log ends with "Could not read the PR from the API (CalledProcessError: gh: API rate limit exceeded for installation ...)", an API rate-limit error, not a finding.

@iamwhatever
iamwhatever merged commit 03016b6 into main Nov 7, 2026
98 of 99 checks passed
@iamwhatever
iamwhatever deleted the crew/conductor/settings-whole-message-joins branch November 7, 2026 20:27
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026
buluoray pushed a commit that referenced this pull request Nov 8, 2026
…#31208)

The About panel joined a translated update-error label to its reason
with an English colon, and the Remote Crew sign-in note joined two
translated sentences with an English space. In Japanese and Simplified
Chinese that put a half-width colon or a stray space between full-width
text. Each is now one catalog message, with the reason as a placeholder,
in all shipped catalogs. English reads the same.

(cherry picked from commit 03016b6)
buluoray pushed a commit that referenced this pull request Nov 8, 2026
…#31208)

The About panel joined a translated update-error label to its reason
with an English colon, and the Remote Crew sign-in note joined two
translated sentences with an English space. In Japanese and Simplified
Chinese that put a half-width colon or a stray space between full-width
text. Each is now one catalog message, with the reason as a placeholder,
in all shipped catalogs. English reads the same.

(cherry picked from commit 03016b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings update errors and the Remote Crew sign-in note glue translated parts with an English colon or space

3 participants