Repository navigation
fix(i18n): word three glued channel and agent sentences as one message - #31698
Conversation
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing screenshot of the agent backend detail strip's could-not-check note. The note changes from neutral text to a red BlockersThe could-not-check note is restyled as an error, and there is no screenshot of it Notes
[DESIGN-REVIEWED] 1c1b49e Description read[DESCRIPTION-READ] fe88f7fb8a7173efeb2c580fb1e6c7fc6320cb543e65011b51b578e467624525 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the agent backend "could not check" detail, which now renders in red with a warning icon. The PR says nothing visible changes, but in English this note goes from neutral 13px text to the Evidence gaps
Notes
[UX-REVIEWED] 1c1b49e Description read[DESCRIPTION-READ] 11a87bdf25536cadb73ab3ac8d5cd2bb64d72c58e92e1dff616b3ae46b805f1e That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Each new key has its reader, and the two removed fragment keys have no other reader. The ErrorNotice switch is required by What this change shipsInventory (6 items) — 6 justifiedIntent: CJK readers see the channel-clear note, the agent backend could-not-check note and the unpinned model badge title as one natural sentence. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 1c1b49e Description read[DESCRIPTION-READ] 66f113e7488f3a5a37c759a8699170021dd52a5ef2facbb91fcfb62984f83638 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsI found nothing blocking. Neither of the two candidate findings held up when I checked the code.
I also confirmed that the three new translation keys exist where the code looks them up. No findings. [OPUS-REVIEWED] 1c1b49e Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
20fa981 to
e48344f
Compare
The channel clear acknowledgment, the agent backend could-not-check note and the unpinned model badge title each joined two catalog pieces in code with an English space or colon. Translators could not word them as one sentence, and Japanese and Chinese read ASCII separators between full-width text. Each is now one catalog message that reuses the locale's own pieces, so English reads exactly as before; the two fragment keys left with no reader are removed.
e48344f to
1c1b49e
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving head 1c1b49e. The gate shows 99 checks passed. The 8 red entries are cancelled duplicate runs, and each of those checks has a newer successful run on this head.
- Three glued sentences become one key each:
clear_context_done_messages_deleted,install_check_failed_can_still_switchandmodel_auto_title. A locale can now punctuate the whole sentence, and the Japanese tests pin that no English space or colon is left. The old keyscan_still_switchandclear_context_messages_deletedare removed with their last callers, and every locale file in the diff gets the new keys. - One visible change: a failed install probe now shows through
ErrorNotice(inline,role="alert") instead of a plain paragraph. The comment and the test say why it has no hand-off button: that detail can hold unsaved Strands setup drafts.
No product regex (the one pattern is in a test), and no new restriction.
#31698) The channel clear acknowledgment, the agent backend could-not-check note and the unpinned model badge title each joined two catalog pieces in code with an English space or colon. Translators could not word them as one sentence, and Japanese and Chinese read ASCII separators between full-width text. Each is now one catalog message that reuses the locale's own pieces, so English reads exactly as before; the two fragment keys left with no reader are removed. (cherry picked from commit e68ca0a)
#31698) The channel clear acknowledgment, the agent backend could-not-check note and the unpinned model badge title each joined two catalog pieces in code with an English space or colon. Translators could not word them as one sentence, and Japanese and Chinese read ASCII separators between full-width text. Each is now one catalog message that reuses the locale's own pieces, so English reads exactly as before; the two fragment keys left with no reader are removed. (cherry picked from commit e68ca0a)
Problem / Motivation
Goal: The channel clear note, the agent backend could-not-check note and the unpinned model badge title each read as one translated message.
Three surfaces build one sentence from two catalog pieces joined in code with an English space or
::ChannelPage.tsx:clear_context_done+ space +clear_context_messages_deletedAgentBackendTab.tsx(two sites):install_check_failed+ space +can_still_switchAgentTemplatesTab.tsx:model+:+model_auto(the badge title)A language cannot word these sentences itself, and Japanese and Chinese read ASCII separators between full-width text.
Why it matters
These notes tell a person what a clear removed and why a switch button is still live. Stray English spacing in CJK reads as a broken string, and translators cannot reorder the pieces.
Not a goal
What changed (motivation → approach → change)
Symptom: ASCII separators between full-width sentences. Cause: two catalog pieces joined in code. Change: each site renders one whole catalog message.
pages.channelPage.clear_context_done_messages_deletedContext cleared. The channel's messages were deleted too.コンテキストを消去しました。チャネルのメッセージも削除されました。pages.developer.agentBackendTab.install_check_failed_can_still_switchpages.overview.agentTemplatesTab.model_auto_titleModel: auto (backend default)モデル:auto(バックエンドのデフォルト)Each locale value reuses that locale's own two pieces, so nothing is retranslated: ja and zh-CN join with no separator and use a full-width colon, and every other language keeps its space and
:. English lives inen.manual.json, anden-XA.jsonis regenerated. The two fragment keys left with no reader,clear_context_messages_deletedandcan_still_switch, are removed from all catalogs.clear_context_done,install_check_failed,modelandmodel_autokeep their other readers.The agent backend detail strip shows this note for a failed install probe, which
errors-use-error-noticecounts as an error. Because this PR edits that site, it now renders throughErrorNotice(inline, with no agent hand-off: the same detail can hold the Strands setup card, whose model and sign-in drafts are not saved yet, so aNo hand-offcomment names them). The row status line keeps the same sentence as plain status text.Backwards compatibility
Compatible: only displayed text changes in ja and zh-CN; English and every spaced language read byte-identically, and no API, route, setting or stored value is touched.
Reader: website/src/pages/ChannelPage.tsx:clear acknowledgment -- entry: crew page -- the only reader of clear_context_messages_deleted, now reads the whole-message key (ChannelPage.clearContext tests)
Reader: website/src/pages/developer/AgentBackendTab.tsx:install-unknown note -- entry: crew page -- both readers of can_still_switch now read the whole-message key (AgentBackendTab tests)
Tests
ChannelPage.clearContext.test.tsx: the English deletion note reads as before, and the Japanese one runs on with no space. The Japanese test fails with origin/main and passes with this change.AgentBackendTab.test.tsx: the Japanese could-not-check note reads as one sentence, inside anErrorNoticealert with no hand-off button. It fails with origin/main and passes with this change. The existing English assertions still pass.AgentTemplatesTab.test.tsx: the unpinned badge title readsModel: auto (backend default)in English andモデル:auto(バックエンドのデフォルト)in Japanese. The Japanese test fails with origin/main.Proof: not provable -- frontend test (prove.py runs Python only)
Determinism: each test switches i18next language inside
actand restores English in afinally; no clock, timer or network.tsc,eslint,i18n:checkand the wholesrc/i18nsuite including the per-locale style tests (both withI18N_BASE_REF=origin/main; the French value uses U+202F before its colon, asstyle/fr.mdrequires), and every ChannelPage, AgentBackendTab and AgentTemplatesTab test file (66 files, 1350 tests) pass. Local GPT review ran on gpt-5.6-sol (the brief pins gpt-6.1-sol, which was not available) and Opus 5.5: no findings.Manual verification
N/A -- unit coverage sufficient: the change is which catalog key renders, and each rendered Japanese string is asserted through the real component.
Screenshots / video
Why no screenshot: the English text is unchanged and the capture host has no CJK font, so a screenshot would show no visible difference; the Japanese text is asserted by the tests.
Related Issues
Fixes #31669
Deferred: #31685
Sibling sweep
Swept: line scan of website/src for two i18nT calls joined by a literal space, colon or {" "}
Sibling: website/src/pages/ChannelPage.tsx -- changed here
Sibling: website/src/pages/developer/AgentBackendTab.tsx -- changed here
Sibling: website/src/pages/overview/AgentTemplatesTab.tsx -- changed here
Sibling: website/src/pages/settings/AboutPanel.tsx -- tracked in #31208
Sibling: website/src/pages/settings/RemoteCrewPanelLaunch.tsx -- tracked in #31208
Sibling: website/src/apps/ops-mission-control/SignalsPanel.tsx -- tracked in #31685
Sibling: website/src/apps/ops-mission-control/HandoverPanel.tsx -- tracked in #31685
Sibling: website/src/apps/auto-research/ResearchLabPage.tsx -- tracked in #31685
Sibling: website/src/pages/settings/McpManagementHero.tsx -- tracked in #31685
Pattern harvest
Rule candidate: lint
Pattern: two i18nT() calls joined by a literal separator in a template or JSX, which the catalog cannot word as one sentence.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project Apache-2.0 license.