Skip to content

fix(website): name the session storage sort dropdown - #31499

Merged
iamwhatever merged 1 commit into
mainfrom
crew/conductor/session-storage-sort-label
Nov 6, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
crew/conductor/session-storage-sort-label

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The session storage sort dropdown has a name a screen reader reads, in every shipped language.

In website/src/pages/system/SessionStorageScreen.tsx, the sort dropdown beside the session search had no aria-label, so assistive tech read only the chosen order ("Largest first") and not what the control sorts.

Why it matters

A screen reader user cannot tell the dropdown changes the order of the session list.

Not a goal

  • Changing the sort options, layout or behavior.
  • Labelling other controls on this screen.

What changed (motivation → approach → change)

The dropdown now carries an aria-label from a new key, pages.sessionStorage.sort_label ("Sort sessions"), in all 12 shipped catalogs, with en-XA.json regenerated.

Backwards compatibility

Compatible: only an accessible name is added; no value, prop or request changes.

Removes nothing: the diff only adds an attribute and one catalog key.

Tests

website/src/test/SessionStorageScreen.test.tsx gains one case that waits for the list and finds the dropdown by the name "Sort sessions". It fails on main and passes here.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: the change is attribute-only and the test queries the rendered screen by accessible name.

Screenshots / video

Why no screenshot: the diff adds an aria-label attribute only, which renders no pixels.

Related Issues

Fixes #31496

Sibling sweep

Swept: grep -nE "<(SimpleSelect|Input|input|textarea)\b" website/src/pages/system/SessionStorageScreen.tsx
Siblings: none -- the search input on this screen already carries search_placeholder as its name

Pattern harvest

Not generalizable: each unnamed control needs its own label copy, so a lint rule would only flag, not fix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 15:28
@RohanK6
RohanK6 requested a review from Zedmor November 6, 2026 15:28
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 29519d2b628b366dce18366de13b2bdc4e20bdb3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check: the diff only adds an aria-label ("Sort sessions") to an existing dropdown. Nothing on screen changes, so no screenshot or blind read is needed.

[UX-REVIEWED] 29519d2

Description read

[DESCRIPTION-READ] 64f74ed31060d00fd540aa36b8b9c98f2df2e3906e292e3e068c57d85207eb79

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 29519d2b628b366dce18366de13b2bdc4e20bdb3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (3 items) — 3 justified

Intent: let screen-reader users know what the Session Storage sort dropdown does, in every shipped language. FIX (#31496).

  1. Screen readers now announce the session storage sort dropdown as "Sort sessions" — justified
  2. A new catalog string, "Sort sessions", translated in all 12 locales plus the regenerated pseudo-locale — justified
  3. A test that finds the dropdown by its accessible name — justified

[FIRST-PRINCIPLES-REVIEWED] 29519d2

Description read

[DESCRIPTION-READ] 81ebdc7c5dc0a68f4f85e40b6b138e4e250421f8308dca16be41fcd3fbafbcd2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 29519d2b628b366dce18366de13b2bdc4e20bdb3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 29519d2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 29519d2b628b366dce18366de13b2bdc4e20bdb3 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 29519d2b628b366dce18366de13b2bdc4e20bdb3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. The PR only adds an accessible name through the aria-label prop that SimpleSelect already supports, so it renders nothing new and takes nothing away.

[DESIGN-REVIEWED] 29519d2

Description read

[DESCRIPTION-READ] f53853c1b5bd0de4b49808a513aa38a7396dbf8b78120d7d2065c7113a02f0d1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 29519d2b628b366dce18366de13b2bdc4e20bdb3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 29519d2

Verdict parsed from the review's SHA-scoped output markers for commit 29519d2b628b366dce18366de13b2bdc4e20bdb3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 29519d2b628b366dce18366de13b2bdc4e20bdb3 false-positive: <reason, 20 to 500 characters>

@RohanK6
RohanK6 force-pushed the crew/conductor/session-storage-sort-label branch from 2e891d8 to 29519d2 Compare November 6, 2026 15:59
@RohanK6

RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main 484ef40: Backend Tests (Windows) (2) failed in test_security_gate_liveness (package line budget), which main fixed in #31469. No code change; CI re-running.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 6, 2026 17:35

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 29519d2.

The sort dropdown gets aria-label from a new pages.sessionStorage.sort_label key (SessionStorageScreen.tsx#L425). SimpleSelect forwards it to the trigger (SimpleSelect.tsx#L185). The key is in all 12 catalogs plus the regenerated en-XA, and the new test finds the control by its name. All AI lanes pass with no open items, and the current-head checks are green.

— crew-pr-reviewer (r148)

@iamwhatever
iamwhatever merged commit 175e470 into main Nov 6, 2026
97 of 98 checks passed
@iamwhatever
iamwhatever deleted the crew/conductor/session-storage-sort-label branch November 6, 2026 17:46
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
(cherry picked from commit 175e470)

Original author: Rohan Khanderia (#31499).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session storage: sort dropdown has no accessible name

2 participants