Repository navigation
fix(website): name the session storage sort dropdown - #31499
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check: the diff only adds an [UX-REVIEWED] 29519d2 Description read[DESCRIPTION-READ] 64f74ed31060d00fd540aa36b8b9c98f2df2e3906e292e3e068c57d85207eb79 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (3 items) — 3 justifiedIntent: let screen-reader users know what the Session Storage sort dropdown does, in every shipped language. FIX (#31496).
[FIRST-PRINCIPLES-REVIEWED] 29519d2 Description read[DESCRIPTION-READ] 81ebdc7c5dc0a68f4f85e40b6b138e4e250421f8308dca16be41fcd3fbafbcd2 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. The PR only adds an accessible name through the [DESIGN-REVIEWED] 29519d2 Description read[DESCRIPTION-READ] f53853c1b5bd0de4b49808a513aa38a7396dbf8b78120d7d2065c7113a02f0d1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
2e891d8 to
29519d2
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at 29519d2.
The sort dropdown gets aria-label from a new pages.sessionStorage.sort_label key (SessionStorageScreen.tsx#L425). SimpleSelect forwards it to the trigger (SimpleSelect.tsx#L185). The key is in all 12 catalogs plus the regenerated en-XA, and the new test finds the control by its name. All AI lanes pass with no open items, and the current-head checks are green.
— crew-pr-reviewer (r148)
Problem / Motivation
Goal: The session storage sort dropdown has a name a screen reader reads, in every shipped language.
In
website/src/pages/system/SessionStorageScreen.tsx, the sort dropdown beside the session search had noaria-label, so assistive tech read only the chosen order ("Largest first") and not what the control sorts.Why it matters
A screen reader user cannot tell the dropdown changes the order of the session list.
Not a goal
What changed (motivation → approach → change)
The dropdown now carries an
aria-labelfrom a new key,pages.sessionStorage.sort_label("Sort sessions"), in all 12 shipped catalogs, withen-XA.jsonregenerated.Backwards compatibility
Compatible: only an accessible name is added; no value, prop or request changes.
Removes nothing: the diff only adds an attribute and one catalog key.
Tests
website/src/test/SessionStorageScreen.test.tsxgains one case that waits for the list and finds the dropdown by the name "Sort sessions". It fails on main and passes here.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is attribute-only and the test queries the rendered screen by accessible name.
Screenshots / video
Why no screenshot: the diff adds an aria-label attribute only, which renders no pixels.
Related Issues
Fixes #31496
Sibling sweep
Swept: grep -nE "<(SimpleSelect|Input|input|textarea)\b" website/src/pages/system/SessionStorageScreen.tsx
Siblings: none -- the search input on this screen already carries search_placeholder as its name
Pattern harvest
Not generalizable: each unnamed control needs its own label copy, so a lint rule would only flag, not fix.
Checklist