Skip to content

fix(website): name the sidebar folder rename box - #31699

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/folder-rename-name
Nov 7, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/folder-rename-name

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The chat sidebar folder rename box has a name a screen reader reads, in the list and board views and every shipped language.

The inline folder rename box (double-click a folder name, or the folder menu Rename item) had no label and no placeholder in website/src/pages/chat-sidebar/folderBlocks.tsx (list view) and website/src/pages/chat-sidebar/boardLane.tsx (board view), so assistive tech announced it as an unnamed edit.

Why it matters

A screen reader user cannot tell the box renames the folder.

Not a goal

  • Changing the rename flow, commit or cancel keys.
  • Labelling other sidebar fields.

What changed (motivation → approach → change)

Both rename boxes now carry an aria-label from a new key, pages.chatSidebar.folder_name_label ("Folder name"), in all 12 shipped catalogs, with en-XA.json regenerated.

Backwards compatibility

Compatible: only an accessible name is added; no value, prop or request changes.

Removes nothing: the diff only adds attributes and one catalog key.

Tests

website/src/test/ChatSidebarW3Coverage.test.tsx gains two cases that open the rename box by double-click, in the list view and in the board view, and find it by the name "Folder name". Both fail on main; the board case also fails with only the list fix. renderSidebar takes an optional columns list (default []) for the board case.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: the change is attribute-only and the tests query the rendered sidebar by accessible name.

Screenshots / video

Why no screenshot: the diff adds aria-label attributes only, which render no pixels.

Related Issues

Fixes #31697

Sibling sweep

Swept: grep -n "folderEditInputRef} " website/src/pages/chat-sidebar/*.tsx
Sibling: website/src/pages/chat-sidebar/folderBlocks.tsx -- changed here
Sibling: website/src/pages/chat-sidebar/boardLane.tsx -- changed here

Pattern harvest

Not generalizable: each unnamed field needs its own label copy, so a lint rule would only flag, not fix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 19:21
@RohanK6
RohanK6 requested a review from Zedmor November 6, 2026 19:21
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 401f3399bb35f5532ca17f42014173d632a97f03 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only adds an accessible name to both existing rename inputs. It renders nothing new and takes nothing away.

[DESIGN-REVIEWED] 401f339

Description read

[DESCRIPTION-READ] b8bfc9c78d87a6242270ec98c22f7180d9b4d075f9eb7cc9dfbe8c1b29046407

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 401f3399bb35f5532ca17f42014173d632a97f03 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check: the PR only adds an aria-label ("Folder name") to an existing rename box, so no pixels change. No screenshot is needed, and the missing blind read leaves no gap.

[UX-REVIEWED] 401f339

Description read

[DESCRIPTION-READ] 6361cd2b1477dfe225bc7edd24f366905960aee9294de840dc0c8cce00dc3af9

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 401f3399bb35f5532ca17f42014173d632a97f03 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a fix for a linked issue (#31697), and both new tests fail on main. It labels both of the sidebar's unlabelled <Input> rename boxes, so no sibling is left.

What this change ships

Inventory (3 items) — 3 justified

Intent: let a screen reader user tell that the inline box renames the chat-sidebar folder. FIX.

  1. The list-view folder rename box is announced as "Folder name" — justified
  2. The board-view folder rename box is announced as "Folder name" — justified
  3. A new catalog key pages.chatSidebar.folder_name_label in all 12 shipped catalogs plus regenerated en-XA — justified

[FIRST-PRINCIPLES-REVIEWED] 401f339

Description read

[DESCRIPTION-READ] 0363a769b526848d01ed9e03b8b1d099be081f38cf84204cc7a2f7b077079378

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 401f3399bb35f5532ca17f42014173d632a97f03 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 401f339

Verdict parsed from the review's SHA-scoped output markers for commit 401f3399bb35f5532ca17f42014173d632a97f03.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 401f3399bb35f5532ca17f42014173d632a97f03 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 401f3399bb35f5532ca17f42014173d632a97f03 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 401f339

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 401f3399bb35f5532ca17f42014173d632a97f03 false-positive: <reason, 20 to 500 characters>

@RohanK6
RohanK6 force-pushed the crew/conductor/folder-rename-name branch from 2f045da to 15e88ce Compare November 6, 2026 20:23
@RohanK6

RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main 39717a0: Backend Tests (Windows) (2) failed in test_security_gate_liveness (package line budget), which main fixed in #31625. No code change; CI re-running.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/folder-rename-name branch from 15e88ce to 401f339 Compare November 6, 2026 21:53
@RohanK6

RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main 7c364bc: Backend Tests (Windows) (7) failed in test_pull_request_target_allowlist (sensitive-change-review.yml), which main fixed in #31803. No code change; CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 6, 2026 23:20
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the sidebar folder rename input gets an aria-label in the list and board views, with the new folder_name_label string added to each locale file and two tests that find the field by its name.

@RohanK6
RohanK6 merged commit 594344f into main Nov 7, 2026
153 of 159 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/folder-rename-name branch November 7, 2026 00:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
(cherry picked from commit 594344f)

Original author: Rohan Khanderia (#31699).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat sidebar: folder rename box has no accessible name

2 participants