Repository navigation
fix(website): name the sidebar folder rename box - #31699
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only adds an accessible name to both existing rename inputs. It renders nothing new and takes nothing away. [DESIGN-REVIEWED] 401f339 Description read[DESCRIPTION-READ] b8bfc9c78d87a6242270ec98c22f7180d9b4d075f9eb7cc9dfbe8c1b29046407 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check: the PR only adds an [UX-REVIEWED] 401f339 Description read[DESCRIPTION-READ] 6361cd2b1477dfe225bc7edd24f366905960aee9294de840dc0c8cce00dc3af9 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a fix for a linked issue (#31697), and both new tests fail on main. It labels both of the sidebar's unlabelled What this change shipsInventory (3 items) — 3 justifiedIntent: let a screen reader user tell that the inline box renames the chat-sidebar folder. FIX.
[FIRST-PRINCIPLES-REVIEWED] 401f339 Description read[DESCRIPTION-READ] 0363a769b526848d01ed9e03b8b1d099be081f38cf84204cc7a2f7b077079378 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
2f045da to
15e88ce
Compare
15e88ce to
401f339
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the sidebar folder rename input gets an aria-label in the list and board views, with the new folder_name_label string added to each locale file and two tests that find the field by its name.
Problem / Motivation
Goal: The chat sidebar folder rename box has a name a screen reader reads, in the list and board views and every shipped language.
The inline folder rename box (double-click a folder name, or the folder menu Rename item) had no label and no placeholder in
website/src/pages/chat-sidebar/folderBlocks.tsx(list view) andwebsite/src/pages/chat-sidebar/boardLane.tsx(board view), so assistive tech announced it as an unnamed edit.Why it matters
A screen reader user cannot tell the box renames the folder.
Not a goal
What changed (motivation → approach → change)
Both rename boxes now carry an
aria-labelfrom a new key,pages.chatSidebar.folder_name_label("Folder name"), in all 12 shipped catalogs, withen-XA.jsonregenerated.Backwards compatibility
Compatible: only an accessible name is added; no value, prop or request changes.
Removes nothing: the diff only adds attributes and one catalog key.
Tests
website/src/test/ChatSidebarW3Coverage.test.tsxgains two cases that open the rename box by double-click, in the list view and in the board view, and find it by the name "Folder name". Both fail on main; the board case also fails with only the list fix.renderSidebartakes an optionalcolumnslist (default[]) for the board case.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is attribute-only and the tests query the rendered sidebar by accessible name.
Screenshots / video
Why no screenshot: the diff adds aria-label attributes only, which render no pixels.
Related Issues
Fixes #31697
Sibling sweep
Swept: grep -n "folderEditInputRef} " website/src/pages/chat-sidebar/*.tsx
Sibling: website/src/pages/chat-sidebar/folderBlocks.tsx -- changed here
Sibling: website/src/pages/chat-sidebar/boardLane.tsx -- changed here
Pattern harvest
Not generalizable: each unnamed field needs its own label copy, so a lint rule would only flag, not fix.
Checklist