Skip to content

fix(apps): pin design-critique at the commit that translates its errors - #31706

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/adoption-live-design-critique-pin
Nov 6, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/adoption-live-design-critique-pin

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A host that adopts design-critique shows a failed critique's reason in the user's language.

With the dashboard in a language other than English, a critique whose reply could not be read ended on the English "The critic replied but not in a readable format." (found by the adoption smoke on origin/main, de-DE, stub ACP backend). Five more failure sentences were English literals thrown as Error messages, which the page shows as they are, and eleven catalog lines (the "didn't finish", "still working", more-than-20-screens, not-an-image, start-button, picker and "Unrecognised" lines) still shipped the English source in the other eleven languages. The adoption pin names a commit that has all of them in English.

Why it matters

Every non-English user of an adopted design-critique reads the failure in English, at the moment they most need to understand what went wrong, and sees English start and picker buttons on an otherwise translated page.

Not a goal

  • Changing the adoption machinery, the D12 equality rule, or any other pin.
  • Fixing the wheel copy (website/src/apps/design-critique/), which an adopted host never renders and Move every built-in app out to KiroCrewApps and forbid built-in apps #26967 removes.
  • Moving a host that already adopted design-critique: it is an ordinary registry app and reaches 1.0.2 through the catalog row (kirodotdev/KiroCrewApps, linked below).

What changed (motivation → approach → change)

The fix landed in the app repository first: KiroCrewCaptain/kirocrew-app-design-critique#1, now main at 2f57dc551dd8 (1.0.2), with green CI on ubuntu, macOS and Windows plus the reproducible-bundle, host-parser and internal-content jobs. This PR pins that commit: the row in src/kiro_crew/apps/adoption-pins.json is the output of scripts/adoption_pin.py compute, and adoption_pin.py verify reports all five rows ok.

The wheel built-in's src/kiro_crew/apps/builtins/design_critique/app.json version moves to 1.0.2. A first-adoption pin must equal the wheel version (D12, pinned_tree_refusal); without the bump a host that has not adopted yet would block the new pin with version_mismatch, a code never retried for that pin.

App repo: KiroCrewCaptain/kirocrew-app-design-critique@2f57dc5

Backwards compatibility

Compatible: same name, repository, legacyNav and minAppSdkLevel; the version moves one patch up, so neither the record-version check nor would_downgrade refuses it.

Removes nothing: only the pinned commit, its digests and the matching wheel version change.

Tests

test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table takes the new row; test_every_shipped_pin_matches_its_wheel_built_in_version holds the bump.

Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head ba85221)

Determinism: no test logic changes, only the pinned data table. The seven test_builtin_adoption*.py files and test_core_design_critique_decoupling.py give 240 passed and 1 skipped; the wheel copy's own tests give 169 passed.

The app repository's new ui/tests/DesignCritiqueErrorText.i18n.test.tsx runs a critique in Russian to each failure and fails on any sentence a non-English catalog ships verbatim in English; all 11 cases fail against its previous main.

Manual verification

scripts/adoption_pin.py verify over the network, with a throwaway HOME and KIROCREW_HOME: all five rows ok (git tree and codeload archive digests match, and the pinned-tree checks pass against the shipped built-in).

Related Issues

Part of #26967

Catalog row: kirodotdev/KiroCrewApps#69 moves the design-critique ref to the same commit. It is not auto-merged: the driver merges it right after this PR lands.

Sibling sweep

Swept: git grep -n "36188055057a19bbc32783b278b9cacb433000eb" (every place naming the old design-critique pin)
Sibling: src/kiro_crew/apps/adoption-pins.json -- changed here
Sibling: test/test_builtin_adoption_pins.py -- changed here
Sibling: src/kiro_crew/apps/builtins/design_critique/app.json -- changed here

Pattern harvest

Rule candidate: review-prompt
Pattern: a user-facing message thrown as an Error literal bypasses the catalog when the page shows e.message as it is

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ba852214675c0a71d4161e3d6acd7c1a8afdae7d touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ba852214675c0a71d4161e3d6acd7c1a8afdae7d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Only pin data and the matching version change; the user-facing fix ships from the app repository, and the D12 version bump is explained.

Notes

[DESIGN-REVIEWED] ba85221

Description read

[DESCRIPTION-READ] ee78766162aa67e62d2d75d9207de60c8852c9110c827b3c12ffe5503473a512

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ba852214675c0a71d4161e3d6acd7c1a8afdae7d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a data-only pin bump. The wheel version bump is required by the pin-must-equal-wheel-version check (builtin_adoption_checks.py:131).

What this change ships

Inventory (3 items) — 3 justified

Intent: when a host has adopted design-critique, a failed critique explains why in the user's language instead of English. This is a FIX.

  1. Hosts that adopt design-critique now get commit 2f57dc55 (1.0.2), which shows its failure text and buttons in the user's language — justified
  2. The wheel's built-in design-critique now reports version 1.0.2, so a host that has not adopted it yet does not refuse the new pin with version_mismatch — justified
  3. The copy of the shipped-pins table in the test matches the new row — justified

[FIRST-PRINCIPLES-REVIEWED] ba85221

Description read

[DESCRIPTION-READ] 0ced564331350ecb6edf44ea2ec52f7e4a644f46dc54303f7e0269e1df08a139

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ba852214675c0a71d4161e3d6acd7c1a8afdae7d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ba85221

Verdict parsed from the review's SHA-scoped output markers for commit ba852214675c0a71d4161e3d6acd7c1a8afdae7d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ba852214675c0a71d4161e3d6acd7c1a8afdae7d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ba852214675c0a71d4161e3d6acd7c1a8afdae7d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ba85221

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ba852214675c0a71d4161e3d6acd7c1a8afdae7d false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97
bolichen97 force-pushed the fix/adoption-live-design-critique-pin branch from 73775ff to b724e59 Compare November 6, 2026 20:32
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto origin/main 39717a0 for a main red, no code change: Backend Tests (3.12, 2), Backend Tests (Windows) (2) and the Coverage Gate that follows them failed at 73775ff on test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget (the security package at 34753 lines against main's old budget of 34733). This PR touches nothing under src/kiro_crew/security/. #31625 raised that budget on main. On the rebased head b724e59, that test, the seven test_builtin_adoption*.py files and test_core_design_critique_decoupling.py pass locally (241 passed, 1 skipped). CI is re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
A failed critique showed English in every language: six failure
sentences were literals thrown as Error messages and the page shows a
thrown message as it is, and eleven catalog lines still shipped the
English source in the other eleven languages.
KiroCrewCaptain/kirocrew-app-design-critique 1.0.2 (2f57dc551dd8)
translates them. Pin that commit so a host that adopts runs it.

The wheel built-in's app.json version moves to 1.0.2 with it, because a
first-adoption pin must equal the wheel version (D12): otherwise a host
that has not adopted yet would block the new pin with version_mismatch.

Part of #26967
@bolichen97
bolichen97 force-pushed the fix/adoption-live-design-critique-pin branch from b724e59 to ba85221 Compare November 6, 2026 21:53
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: green board, no conflicts, no outstanding change requests.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the on-call. Review lanes pass on ba85221, no conflict, no open change request.

@KiroCrewCaptain
KiroCrewCaptain merged commit 50fd483 into main Nov 6, 2026
97 of 99 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/adoption-live-design-critique-pin branch November 6, 2026 23:41
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
bolichen97 added a commit to kirodotdev/KiroCrewApps that referenced this pull request Nov 6, 2026
KiroCrewCaptain/kirocrew-app-design-critique 1.0.2 (2f57dc551dd8) translates a failed critique's reason and the lines its other catalogs still shipped in English. Moving the ref is what offers an already-adopted install the update; kirodotdev/KiroCrew#31706 moves the pin to the same commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants