Repository navigation
fix(apps): pin design-critique at the commit that translates its errors - #31706
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Only pin data and the matching version change; the user-facing fix ships from the app repository, and the D12 version bump is explained. Notes
[DESIGN-REVIEWED] ba85221 Description read[DESCRIPTION-READ] ee78766162aa67e62d2d75d9207de60c8852c9110c827b3c12ffe5503473a512 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a data-only pin bump. The wheel version bump is required by the pin-must-equal-wheel-version check ( What this change shipsInventory (3 items) — 3 justifiedIntent: when a host has adopted design-critique, a failed critique explains why in the user's language instead of English. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] ba85221 Description read[DESCRIPTION-READ] 0ced564331350ecb6edf44ea2ec52f7e4a644f46dc54303f7e0269e1df08a139 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
73775ff to
b724e59
Compare
|
Rebased onto |
A failed critique showed English in every language: six failure sentences were literals thrown as Error messages and the page shows a thrown message as it is, and eleven catalog lines still shipped the English source in the other eleven languages. KiroCrewCaptain/kirocrew-app-design-critique 1.0.2 (2f57dc551dd8) translates them. Pin that commit so a host that adopts runs it. The wheel built-in's app.json version moves to 1.0.2 with it, because a first-adoption pin must equal the wheel version (D12): otherwise a host that has not adopted yet would block the new pin with version_mismatch. Part of #26967
b724e59 to
ba85221
Compare
chenmingwei23
left a comment
There was a problem hiding this comment.
Approving: green board, no conflicts, no outstanding change requests.
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved for the on-call. Review lanes pass on ba85221, no conflict, no open change request.
KiroCrewCaptain/kirocrew-app-design-critique 1.0.2 (2f57dc551dd8) translates a failed critique's reason and the lines its other catalogs still shipped in English. Moving the ref is what offers an already-adopted install the update; kirodotdev/KiroCrew#31706 moves the pin to the same commit.
Problem / Motivation
Goal: A host that adopts design-critique shows a failed critique's reason in the user's language.
With the dashboard in a language other than English, a critique whose reply could not be read ended on the English "The critic replied but not in a readable format." (found by the adoption smoke on
origin/main, de-DE, stub ACP backend). Five more failure sentences were English literals thrown asErrormessages, which the page shows as they are, and eleven catalog lines (the "didn't finish", "still working", more-than-20-screens, not-an-image, start-button, picker and "Unrecognised" lines) still shipped the English source in the other eleven languages. The adoption pin names a commit that has all of them in English.Why it matters
Every non-English user of an adopted design-critique reads the failure in English, at the moment they most need to understand what went wrong, and sees English start and picker buttons on an otherwise translated page.
Not a goal
website/src/apps/design-critique/), which an adopted host never renders and Move every built-in app out to KiroCrewApps and forbid built-in apps #26967 removes.What changed (motivation → approach → change)
The fix landed in the app repository first: KiroCrewCaptain/kirocrew-app-design-critique#1, now
mainat2f57dc551dd8(1.0.2), with green CI on ubuntu, macOS and Windows plus the reproducible-bundle, host-parser and internal-content jobs. This PR pins that commit: the row insrc/kiro_crew/apps/adoption-pins.jsonis the output ofscripts/adoption_pin.py compute, andadoption_pin.py verifyreports all five rowsok.The wheel built-in's
src/kiro_crew/apps/builtins/design_critique/app.jsonversion moves to 1.0.2. A first-adoption pin must equal the wheel version (D12,pinned_tree_refusal); without the bump a host that has not adopted yet would block the new pin withversion_mismatch, a code never retried for that pin.App repo: KiroCrewCaptain/kirocrew-app-design-critique@2f57dc5
Backwards compatibility
Compatible: same name, repository,
legacyNavandminAppSdkLevel; the version moves one patch up, so neither the record-version check norwould_downgraderefuses it.Removes nothing: only the pinned commit, its digests and the matching wheel version change.
Tests
test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_tabletakes the new row;test_every_shipped_pin_matches_its_wheel_built_in_versionholds the bump.Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head ba85221)
Determinism: no test logic changes, only the pinned data table. The seven
test_builtin_adoption*.pyfiles andtest_core_design_critique_decoupling.pygive 240 passed and 1 skipped; the wheel copy's own tests give 169 passed.The app repository's new
ui/tests/DesignCritiqueErrorText.i18n.test.tsxruns a critique in Russian to each failure and fails on any sentence a non-English catalog ships verbatim in English; all 11 cases fail against its previousmain.Manual verification
scripts/adoption_pin.py verifyover the network, with a throwawayHOMEandKIROCREW_HOME: all five rowsok(git tree and codeload archive digests match, and the pinned-tree checks pass against the shipped built-in).Related Issues
Part of #26967
Catalog row: kirodotdev/KiroCrewApps#69 moves the design-critique
refto the same commit. It is not auto-merged: the driver merges it right after this PR lands.Sibling sweep
Swept: git grep -n "36188055057a19bbc32783b278b9cacb433000eb" (every place naming the old design-critique pin)
Sibling: src/kiro_crew/apps/adoption-pins.json -- changed here
Sibling: test/test_builtin_adoption_pins.py -- changed here
Sibling: src/kiro_crew/apps/builtins/design_critique/app.json -- changed here
Pattern harvest
Rule candidate: review-prompt
Pattern: a user-facing message thrown as an Error literal bypasses the catalog when the page shows e.message as it is
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)