Repository navigation
chore: move design-critique to the commit its Kiro Crew pin names - #69
Merged
Merged
Conversation
KiroCrewCaptain/kirocrew-app-design-critique 1.0.2 (2f57dc551dd8) translates a failed critique's reason and the lines its other catalogs still shipped in English. Moving the ref is what offers an already-adopted install the update; kirodotdev/KiroCrew#31706 moves the pin to the same commit.
Merged
5 tasks done
Opus 5 Review — ✅ no blocking findingsOpus 5 completed its review of This comment is updated in place on each push. |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. |
App Readiness Review — ✅ no blocking findingsEvery app repository this PR adds or re-pins passed the blocking readiness rules at Rules: Review detailsNo findings. design-critique @ 2f57dc551dd8c7c59452bdbde09071dcb3b8123bNo findings. [APP-READINESS-REVIEWED] 3334a51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
refof the design-critique row incatalog/official-registry.jsonto the commit Kiro Crew's adoption pin now names. No other field or row changes.361880552f57dc551dd8c7c59452bdbde09071dcb3b8123bThe commit is the head of the repository's
main(KiroCrewCaptain/kirocrew-app-design-critique#1), with green CI on ubuntu, macOS and Windows. It translates a failed critique's reason (six failure sentences were English literals the page showed as they were) and the eleven lines the other catalogs still shipped in English. An already-adopted install is an ordinary registry app, so this row is how it reaches 1.0.2: its record version is below the new one, so the store offers the update.Merge condition: right after the Kiro Crew pin PR
The Kiro Crew PR is kirodotdev/KiroCrew#31706. It moves the pin and the wheel version. The row's
noteasks forrefto equal the pin. This PR is not set to auto-merge: the driver merges it once #31706 has landed.would_downgrade), so nothing moves backwards. The pair just disagrees until this one lands.Verification
tools/format.py --check: all 3 files normalized.tools/validate.py: OK. The 3 warnings were already there, on other apps.pytest tests/: 521 passed; the one failure,test_format_checkers_for_every_format_we_use_are_active, fails the same way onmainhere because this environment lacksjsonschema[format].scripts/adoption_pin.py verifyreports all five rowsokwith the new design-critique pin: the commit's git tree and codeload archive match itstreeSha256andarchiveSha256.