Skip to content

chore: move design-critique to the commit its Kiro Crew pin names - #69

Merged
bolichen97 merged 1 commit into
mainfrom
chore/design-critique-1.0.2
Nov 6, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
chore/design-critique-1.0.2

Conversation

@bolichen97

Copy link
Copy Markdown
Collaborator

What

Moves the ref of the design-critique row in catalog/official-registry.json to the commit Kiro Crew's adoption pin now names. No other field or row changes.

App From To Version
design-critique 36188055 2f57dc551dd8c7c59452bdbde09071dcb3b8123b 1.0.1 → 1.0.2

The commit is the head of the repository's main (KiroCrewCaptain/kirocrew-app-design-critique#1), with green CI on ubuntu, macOS and Windows. It translates a failed critique's reason (six failure sentences were English literals the page showed as they were) and the eleven lines the other catalogs still shipped in English. An already-adopted install is an ordinary registry app, so this row is how it reaches 1.0.2: its record version is below the new one, so the store offers the update.

Merge condition: right after the Kiro Crew pin PR

The Kiro Crew PR is kirodotdev/KiroCrew#31706. It moves the pin and the wheel version. The row's note asks for ref to equal the pin. This PR is not set to auto-merge: the driver merges it once #31706 has landed.

  • This PR merged first: adopted installs are offered 1.0.2 early. That is harmless, but the catalog and the pin disagree until the Kiro Crew PR lands.
  • The Kiro Crew PR merged first: a nightly host adopts at the new commit while the catalog still names the old one. The update path refuses an older version (would_downgrade), so nothing moves backwards. The pair just disagrees until this one lands.

Verification

  • tools/format.py --check: all 3 files normalized.
  • tools/validate.py: OK. The 3 warnings were already there, on other apps.
  • pytest tests/: 521 passed; the one failure, test_format_checkers_for_every_format_we_use_are_active, fails the same way on main here because this environment lacks jsonschema[format].
  • Kiro Crew's scripts/adoption_pin.py verify reports all five rows ok with the new design-critique pin: the commit's git tree and codeload archive match its treeSha256 and archiveSha256.

KiroCrewCaptain/kirocrew-app-design-critique 1.0.2 (2f57dc551dd8) translates a failed critique's reason and the lines its other catalogs still shipped in English. Moving the ref is what offers an already-adopted install the update; kirodotdev/KiroCrew#31706 moves the pin to the same commit.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Opus 5 Review — ✅ no blocking findings

Opus 5 completed its review of 3334a5129974252a06b9362188316610382ae98f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3334a51

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 3334a5129974252a06b9362188316610382ae98f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3334a51

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

App Readiness Review — ✅ no blocking findings

Every app repository this PR adds or re-pins passed the blocking readiness rules at 3334a5129974252a06b9362188316610382ae98f.

Rules: review/app-readiness-rules.md (base-branch snapshot). This comment is updated in place on each push.

Review details

No findings.

design-critique @ 2f57dc551dd8c7c59452bdbde09071dcb3b8123b

No findings.

[APP-READINESS-REVIEWED] 3334a51

@bolichen97
bolichen97 merged commit 1d68028 into main Nov 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant