Repository navigation
fix(dashboard): scroll the list when "More below" is clicked - #31800
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The deleted "a label, not a control: decorative" pin is countered by linked issue #21588 and three GUI-lane reports of users clicking a strip that did nothing. What this change shipsInventory (5 items) — 5 justifiedIntent: let someone who sees "More below" under a clipped Settings list click it and reach the hidden rows (FIX).
[FIRST-PRINCIPLES-REVIEWED] b608752 Description read[DESCRIPTION-READ] b02682c82f3d1b3e2286a35044bef5d2fabd89d75435c73e6cf603ebe3535ba6 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the click now does what the strip's styling suggests, the fix is the same at both hosts, and screenshots of this revision are attached. Notes
[DESIGN-REVIEWED] b608752 Description read[DESCRIPTION-READ] cec395a3bbde66f7b0ac470d0eaa92b3359547f10bf3739ef16248570e552a47 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader guessed correctly that "More below" scrolls the list and said they would click it. The screenshots and the GIF show the strip before a click, after one click and at the end of the list. Notes
[UX-REVIEWED] b608752 Description read[DESCRIPTION-READ] fb974862ec93145535e07a7a30a85c65cd787a52ec19c896a2475b4175f478c3 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
44f213a to
4f350ee
Compare
|
Rebased: main moved in website/src/i18n/en.context.json since this head went green (26c8238 -> f71f5dd); CI re-running. The new base also carries #31803, which fixes the Windows shard's [operator: bolichen97] |
4f350ee to
c8ced73
Compare
|
Rebased: main moved in website/src/i18n/en.context.json since this head went green (f71f5dd -> e4611c5); CI re-running. The patch is unchanged ( [operator: bolichen97] |
c8ced73 to
0f12e58
Compare
|
Rebased: main moved in website/src/components/SidePanelLayout.tsx and website/src/i18n/en.context.json since this head went green (e4611c5 -> 5f7f8d1); CI re-running. The patch is unchanged ( [operator: bolichen97] |
|
[operator: bolichen97] Backend Tests (3.12, 2), Backend Tests (Windows) (2) and the Coverage Gate behind them fail on |
0f12e58 to
2fd9c7a
Compare
|
Rebased: main moved in website/src/i18n/en.context.json since this head went green (5f7f8d1 -> 959bc04); CI re-running. The new base carries #32252 and #32209, which fix the two main reds (the security line-budget test on Backend Tests shard 2, Windows shard 2 and Coverage Gate, and the Windows ignore-list test on shard 7). The patch is unchanged ( [operator: bolichen97] |
2fd9c7a to
b608752
Compare
|
self-added: yes
[operator: bolichen97] |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the 'More below' cue becomes a button that scrolls its list down; with updated tests.
(cherry picked from commit b0ffbf6)
Problem / Motivation
Goal: Clicking the "More below" strip under a clipped Settings list scrolls that list down, so the strip does what it looks like it does.
A first-time user in the nightly GUI test opened Settings on a short window, saw "More below" in accent text under the side rail, clicked it, and nothing happened. They had to scroll the list by hand to find Developer. The same strip sits under the two-pane section list inside a Settings tab.
Why it matters
The strip reads as a control (accent colour, a chevron, its own bar), so a click that does nothing reads as broken. The rows it points at (Developer, Releases, About) are the ones a new user is looking for on a laptop-height window. The GUI lane has reported this three times.
Not a goal
MORE_BELOW_MASKfades,JumpToBottomButton).What changed (motivation → approach → change)
The strip was a plain label with no click behaviour, while its styling invites a click.
MoreBelowCueis now a real<button>that takes the list it sits under (scrollerRef). A click scrolls that list down by 80% of its visible height, so the rows that were at the bottom stay in view; it scrolls smoothly, or jumps when the user prefers reduced motion. Both hosts, the Settings side rail (SidePanelLayout) and the capped two-pane section list (SettingsSubNav), keep a ref to their scrolling box next to the existing edge-measuring ref and pass it in. This is the same shape as the chat suggestion strip's scroll arrows inFollowUpBar.At the end of the list the strip hides its label as before, which also takes the button out of the tab order, so it is never a stop that does nothing. If the button has keyboard focus when it hides, focus moves to the last row of the list instead of falling back to the page.
website/docs/page-layout.mdand the translator note forcomponents.sidePanelLayout.more_belowinen.context.jsonnow describe it as a button.Backwards compatibility
Compatible: the strip shows and hides exactly as before; the only change is that a click on it scrolls the list it sits under.
Removes nothing: the label, its visibility rules and every row stay; the new prop is required at both call sites, and both pass it.
Tests
SidePanelLayout.tabListScrollCue.test.tsx: the rail's strip is the button named "More below"; a click callsscrollByon the tab list with 80% of its height, smooth, and withbehavior: 'auto'under reduced motion; the rows are still real buttons; a focused strip that hides at the end of the list hands focus to the last row.SettingsSubNav.railPin.test.tsx: the capped section list's strip is that button too, and a click scrolls that list's box the same way.origin/main's components (2 failed, 8 passed) and pass with the fix (10 passed). Determinism: 20 serial repeats of both files green, and a shuffled run (--sequence.shuffle --sequence.seed=19969) green.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Ran the built dashboard gateway-free (stubbed API) at 1280x600 on
/settings, dark and light: the rail is clipped and shows "More below"; one click scrolls the rows up with Shortcuts and Skills still in view; a second click reaches Developer, Releases and About, and the label hides at the end.Screenshots / video
Settings rail at 1280x600, cropped to the rail. Before the click, after one click, and at the end of the list:
Recording of the two clicks (dark):
Related Issues
Closes #21588
Sibling sweep
Swept: git grep -n "more_below|MoreBelowCue|MORE_BELOW_MASK" -- website/src
Sibling: website/src/components/SidePanelLayout.tsx -- changed here
Sibling: website/src/components/SettingsSubNav.tsx -- changed here
Sibling: website/src/components/ModelEffortDropdown.tsx -- not affected -- MORE_BELOW_MASK is a fade with no label, nothing invites a click
Pattern harvest
Not generalizable: one shared component styled like a control with no action; both of its hosts are fixed here.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license (see CONTRIBUTING.md).