Skip to content

fix(schedule): keep the job dialog honest while a save is in flight - #32036

Merged
bolichen97 merged 1 commit into
mainfrom
fix/10307-schedule-dialog-inflight-honesty
Nov 7, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/10307-schedule-dialog-inflight-honesty

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On the Schedule page, closing the job dialog while a save is in flight tells the truth about that save, and the save's late answer can no longer close or swallow anything.

Closing the job dialog cannot cancel a save that was already sent, but mid-save the dialog still offered Cancel and said nothing, so a user who closed it believed the schedule was not created. When that save answered later, the closed dialog's success path still ran and closed whatever dialog the user had opened since, typed work included. A save that failed after its dialog closed was lost with the unmounted form. Nothing stopped a page leave or browser Back from dropping typed work in the dialog.

This is part 2 of #10307. Part 1 (a schedule created from /schedule for a Bot stores member_id) already shipped with the job form's Runs as switch (#22055).

Why it matters

Anyone who creates or edits a schedule from /schedule and closes the dialog before the save answers: on a slow gateway that is a schedule they think they cancelled but that exists and runs, a second dialog that closes under them with its draft lost, or a failure they never see.

Not a goal

  • Part 1 of the issue (member_id from /schedule): already on main through the Runs as switch.
  • Refusing a dismissal mid-save. A POST cannot be un-sent, so the dialog says so instead.
  • Extracting a shared dialog host. The Bot drawer's create dialog this pattern came from is no longer on main (Bot schedules are created in the Profile card's inline CrewWakeSection), so there is one caller.
  • A discard confirm when the dialog itself is closed with typed work, or a beforeunload prompt.
  • Reporting a late failure after the user has left /schedule: the notices live on the page.
  • Splitting SchedulePage.tsx, which is already over the 1,600-line working target (1,964 lines after this change, 36 under the 2,000 cap); moving the job dialog to a sibling module is its own change.

What changed (motivation → approach → change)

While a save is in flight, or after the dialog closed Before After
Footer exit Cancel, as if it cancelled Close, with a strip above the footer: "Closing won't cancel this — the schedule may still be created." (edit: "your changes may still be saved")
A late success refreshed the list and closed the dialog open now refreshes the list only
A late failure lost with the unmounted form a page notice per save with the server's message: "The schedule “X” wasn't saved." when the server refused it, or "…may or may not have been saved — the server didn't confirm it." when nothing confirmed the outcome; each dismissable
Switching an edit to Logs mid-save unmounted the form, so its result was shown nowhere Logs is locked while saving, and Save is off on Logs, where no form is on screen
Page leave or Back with typed work in the dialog, an edited alert threshold or time zone included left the page, draft lost refused; the draft stays in the dialog on screen

The dialog knows whether it is still mounted, and only a mounted dialog closes itself on success or leaves an error to its own form; the Logs lock keeps that form mounted for as long as the dialog is. The page hears late failures through JobForm's existing onSubmitError and typed work through its onDirtyChange; JobForm's dirty check counts the alert threshold and the picked time zone, the two editable fields it left out, so editing only one of them is guarded too; the zone counts what was picked, never the default the picker shows. The leave guard refuses rather than asks because the registry needs a synchronous answer and the dashboard bans browser-native confirms. Four catalog keys are added to every catalog under website/src/i18n/locales/ (all 12 languages, plus the regenerated en-XA.json pseudolocale), and the cron dashboard spec gets one paragraph describing the dialog's in-flight behaviour. late_save_unconfirmed matches the confirm-key sweep in destructiveConfirm.test.ts by name only, so it is listed there as a notice, not a confirm prompt.

Backwards compatibility

Compatible: no API, wire or stored shape changes; only the Schedule page's own job dialog behaves differently while a save is in flight, and a zone-only edit in the job form counts as typed work.

Removes nothing: JobDetailDialog is module-private and its one caller passes onChanged where it passed onSaved; no control, route or key is removed.

Tests

website/src/test/SchedulePage.inflightClose.test.tsx, against the real page and JobForm with the API mocked:

  • a create held in flight shows Close (no Cancel) and the may-still-be-created strip; after Close and opening another job, the late success re-reads the list and that other dialog stays open
  • a failure while its dialog is open stays in the dialog (no page notice); two creates closed in flight and failing late give two page notices in order: a 400 reads "wasn't saved", a dropped connection reads "may or may not have been saved", each with its message; dismissing one leaves the other
  • the page publishes no stake and allows a leave with a clean dialog, and publishes a stake and refuses once a field is typed
  • on an existing job, Save is disabled on Logs; mid-save the Logs tab cannot unmount the form, and the save's failure shows in the form

website/src/test/JobForm.alertAfterFailures.test.tsx: changing only the alert threshold reports the form dirty.

website/src/test/JobForm.timezone.test.tsx: changing only the zone reports the form dirty; the default zone loading does not.

Mutation check: reverting the mounted-only close, the mounted-only hand-off, the published stake, the Logs lock, the Save-on-Logs lock, or the threshold or zone term in the dirty check each turns a test red. Determinism: each of the three files passed 10 of 10 shuffled runs (--sequence.shuffle, seeds 11 to 101). The existing SchedulePage.test.tsx and the related set (138 files, the CrewWakeSection hosts included) pass, as do the i18n catalog, style and pseudolocale checks and npm run i18n:check with the base ref.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Rendered the real SchedulePage from the capture entry with every /api/** answered locally and the create POST held open: the strip and Close show while saving (dark and light); after Close, answering the POST with a 400 put the late-failure notice above the list. Each frame asserted its state before it was written.

Screenshots / video

In flight, dark and light:

Create in flight, dark

Create in flight, light

A create that failed after its dialog was closed:

Late failure notice

Related Issues

Closes #10307

Sibling sweep

Swept: git grep -n "<JobForm" -- website/src
Sibling: website/src/components/CrewWakeSection.tsx -- not affected -- its toggle is disabled while the create is in flight and its late success only collapses its own inline form; it reads the same dirty check, so a zone-only edit in its create form counts as typed work too
Sibling: website/src/pages/SchedulePage.tsx -- changed here

Swept: git grep -nE "= useState(.*(init|defaults)" -- website/src/components/JobForm.tsx
Sibling: website/src/components/JobForm.tsx -- changed here

Pattern harvest

Rule candidate: review-prompt
Pattern: an async completion handler from a dialog that has since closed still calls the host's close or reset, so it acts on whatever dialog is open by then

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 7, 2026 03:23
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 896cb62689262fb15223d8c5edf2a9b9721dfe2f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The fix uses mechanisms that already exist (onSubmitError, NavigationLeaveGuard). Nothing blocks. The leave guard and the wider dirty check go past the frozen Goal.

Notes

  • Item 6 — oversized: The Goal covers "closing the job dialog while a save is in flight". The leave guard (useRegisterNavigationLeaveGuard(() => !draftDirty)) refuses a page leave whenever the dialog holds typed work, with or without a save. That is the discard-guard area ## Not a goal sets aside. Subtraction: remove draftDirty, the two guard hooks and onDirtyChange={setDraftDirty}. Clears when: the mechanism is removed, or a human amends the Goal.
  • Item 7 — rides along: the alertAfter/tz terms only matter to item 6's guard. Inside this PR they also change what CrewWakeSection treats as dirty. Subtraction: drop initialTz and the two terms along with item 6.

What this change ships

Inventory (8 items) — 5 justified

Intent: when someone closes the Schedule job dialog mid-save, they are told the save may still go through, and the late answer is never lost and never closes the wrong dialog. FIX (#10307).

  1. While a save is in flight, the footer shows Close instead of Cancel, with a "may still be created/saved" strip — justified
  2. A late success refreshes the list and no longer closes the dialog open by then — justified
  3. A late failure shows as a dismissable page notice, one per save, worded "wasn't saved" or "may or may not have been saved" — justified
  4. The Logs tab is locked while saving — justified
  5. Save is disabled on the Logs tab — justified
  6. A page leave or browser Back is refused while the dialog holds typed work — oversized
  7. A threshold-only or zone-only edit now counts as dirty, in CrewWakeSection too — rides along
  8. The late-failure notice shows the server's raw error text — undeclared

[FIRST-PRINCIPLES-REVIEWED] 896cb62

Description read

[DESCRIPTION-READ] eb83c74e0dde6dd4569ffebf5728de81aa8d8ca5dbb05be08616cf69f29c76e3

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 896cb62689262fb15223d8c5edf2a9b9721dfe2f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the fix is at the cause (a closed dialog's late callbacks act on the dialog open by then), stays inside the one page, takes nothing away, and evidence is attached.

Notes

  • The leave guard refuses silently. A Back press that does nothing reads as a broken button unless the guard's refusal is visible somewhere. Worth checking against how other useRegisterNavigationLeaveGuard callers show a refusal.

[DESIGN-REVIEWED] 896cb62

Description read

[DESCRIPTION-READ] be385e966cd508d0622051cc5f02a95d7e418d5876b2a500770bae0e0ac524ad

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 896cb62689262fb15223d8c5edf2a9b9721dfe2f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 896cb62

Verdict parsed from the review's SHA-scoped output markers for commit 896cb62689262fb15223d8c5edf2a9b9721dfe2f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 896cb62689262fb15223d8c5edf2a9b9721dfe2f false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 896cb62689262fb15223d8c5edf2a9b9721dfe2f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the edit-mode in-flight dialog, its locked Logs tab, Save turned off on Logs, and the "may or may not have been saved" notice. The PR adds all four states and no screenshot shows them.

Evidence gaps

  • Editing an existing job while its save is in flight. No screenshot shows the edit-mode strip ("Closing won't cancel this — your changes may still be saved.") or the Logs tab turned off by disabled: saving. One shot of an existing job mid-save would cover both.
  • Save turned off on the Logs tab (disabled={saving || detailTab === 'logs'}). No screenshot shows this. Add a shot of an existing job's Logs tab with the footer in view.
  • The late-save notice when the server never confirmed (late_save_unconfirmed: "…may or may not have been saved — the server didn't confirm it."). shot-03 shows only the "wasn't saved" version. Add a shot with the connection dropped.

Notes

  • The blind reader would hesitate on "Close" because the strip "leaves me unsure whether I'll end up with the job or not". Add the follow-up to close_wont_cancel_create/_edit, e.g. "…may still be created. If it fails, you'll see why on this page."
  • In shot-03 the reader read "every 0m" as contradicting the "1 hours" they had entered. It is a mocked fixture message, but it makes the screenshot look like a bug. Reshoot with a 400 whose message fits the form.

[UX-REVIEWED] 896cb62

Description read

[DESCRIPTION-READ] ec6e4cb6ee820876a5983f315639ebf7a4a111d82da59688113078ac1bc7e8f2

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 896cb62689262fb15223d8c5edf2a9b9721dfe2f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 896cb62

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 896cb62689262fb15223d8c5edf2a9b9721dfe2f false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 7, 2026 03:43
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97
bolichen97 force-pushed the fix/10307-schedule-dialog-inflight-honesty branch from 182c1ac to 1441562 Compare November 7, 2026 04:21
@bolichen97

bolichen97 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=8eacc61ffa7a Alert-threshold edits bypass the new leave guard

fixed in 1441562: JobForm's dirty check compares alertAfter with initialAlertAfter, the same shape as the autoPause term beside it, so an edit to only "Alert after failures" reports the form dirty and the Schedule page's leave guard refuses Back.
Class swept: the two fields with their own open-time baseline (initialAutoPause, initialAlertAfter); the threshold was the only one missing. CrewWakeSection hosts only the create form, where the threshold field is hidden.
Test: JobForm.alertAfterFailures.test.tsx "marks the form dirty when only the threshold changed" is red without the term and green with it.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/learn-cron-dashboard.md and the website/src/i18n/locales/*.json catalogs since this head's CI ran (a5664dd -> 2552c90); CI re-running.
[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/10307-schedule-dialog-inflight-honesty branch from 1441562 to 50cc50c Compare November 7, 2026 07:25
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=8eacc61ffa7a Timezone-only edits bypass the new navigation guard

fixed in 50cc50c: JobForm's dirty check compares the picked zone tz with initialTz, captured once when the form opens (the initialAutoPause shape), so a zone-only edit reports the form dirty and the Schedule page's leave guard refuses Back.
It reads tz, the picker's own value, never shownTz, so the default zone the server reports later is not an edit.
Class swept: every JobForm state seeded from the opening value (init/defaults); the zone was the only one outside the check.
Test: JobForm.timezone.test.tsx "marks the form dirty when only the zone changed, not when the default loads" is red without the term and green with it.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/learn-cron-dashboard.md, website/src/i18n/destructiveConfirm.test.ts and the 13 catalogs under website/src/i18n/locales/ since this head went green (2552c90 -> b65af1a); CI re-running.
[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] The red Backend Tests shard 2 (Linux and Windows) and the Coverage Gate that depends on it fail on test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget (assert 34855 <= 34845). That test is red on main too: the security package on origin/main (0795ebc) measures 34,855 lines against a 34,845 budget, and this PR changes no backend code. #32183 raises the budget to main's size. This PR waits for that to land, then re-syncs onto main and re-runs.

@bolichen97
bolichen97 force-pushed the fix/10307-schedule-dialog-inflight-honesty branch from 50cc50c to 6d5aac3 Compare November 7, 2026 13:25
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/learn-cron-dashboard.md, website/src/pages/SchedulePage.tsx and the 13 catalogs under website/src/i18n/locales/ since this head's CI ran (b65af1a -> f58c3cf); CI re-running. The new base carries main's security package line-budget fix, so the Backend Tests shard 2 and Coverage Gate reds should clear.
[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
Closing the Schedule page's job dialog mid-save cannot cancel the request,
yet the dialog still offered Cancel with no word that the schedule might
be created anyway. Its late answer then ran the closed dialog's success
path, which closed whatever dialog the user had opened since, and a late
failure vanished with the unmounted form.

While a save is in flight the dialog's Cancel reads Close and a strip
above the footer says the schedule may still be created (or the changes
saved). A late answer only refreshes the list; a late failure is reported
on the page, one dismissable notice per save, worded by whether the
server refused it or never confirmed the outcome. The Logs tab is locked
mid-save and Save is off on Logs, so the form that reports a result stays
mounted, and a page leave or browser Back is refused while the dialog
holds typed work, an edited alert threshold or time zone included.
@bolichen97
bolichen97 force-pushed the fix/10307-schedule-dialog-inflight-honesty branch from 6d5aac3 to 896cb62 Compare November 7, 2026 18:14
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=6862e033f1c3 website/src/pages/SchedulePage.tsx:1792 -- a late edit failure dropped the server's reason

fixed in 896cb62: JobForm's outer catch now hands the thrown error's own message to onSubmitError, so the page notice for an edit that fails after its dialog closed carries the server's reason, the same as a create. The inline "Failed to save" line is unchanged.
Test: SchedulePage.inflightClose.test.tsx "puts the server's reason on the page when an edit fails after its dialog closed" is red on 6d5aac3 and green on 896cb62.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 7, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

APPROVE

What this does for users: on the Schedule page, the job dialog no longer offers "Cancel" while a save is in flight. It shows "Close" and one line saying the save may still go through. A late success refreshes the list without closing whatever dialog the user opened since. A late failure becomes a dismissable page notice with the server's reason, worded differently for a refused save and an unconfirmed one. A page leave or browser Back with typed work in the dialog is refused instead of dropping the draft.

Evidence (head 896cb62):

  • JobDetailDialog (website/src/pages/SchedulePage.tsx:1785-1792) keeps a mounted flag. onSaved always refreshes, and closes the dialog only while it is still mounted. onSubmitError hands the failure to the page only once the dialog is gone, so a live form still shows its own error.
  • The leave guard and stake (SchedulePage.tsx:390-393) follow JobForm's onDirtyChange. JobForm reports false on unmount (website/src/components/JobForm.tsx:474), so closing the dialog by any route releases the guard. A closed dirty dialog cannot leave the page stuck refusing navigation. This is the same NavigationLeaveGuard pattern the Crewmates dialog already uses.
  • The dirty check now counts the alert threshold and the picked zone (JobForm.tsx:464). The zone is compared against the picked value (initialTz), never the default the picker displays, so a late-loading default is not read as an edit.
  • The outer catch now passes e.message to onSubmitError (JobForm.tsx:703). Schedule is the only host of onSubmitError, so no other surface changes. The live form still shows its localized failed_to_save text.
  • Logs is disabled while saving and Save is disabled on Logs. Both are needed because Logs unmounts the form.
  • Copy: all four new keys are present in every catalog under website/src/i18n/locales (12 languages plus the en-XA pseudolocale). Each is one sentence and carries only facts the user cannot otherwise see. The cron dashboard spec (docs/system-specs/modules/learn-cron-dashboard.md) gains a paragraph in the same commit.

Tests: SchedulePage.inflightClose, JobForm.alertAfterFailures, JobForm.timezone, SchedulePage and destructiveConfirm passed 96 of 96 locally.

Mutations, run one at a time with the tree restored after each:

  • Closing on a late success regardless of mount state failed "SchedulePage job dialog while a save is in flight > offers Close with the may-still-be-created line, and a late success leaves the dialog open now alone".
  • A leave guard that always allows failed "SchedulePage job dialog while a save is in flight > refuses a page leave only while the dialog holds typed work".

CI: 94 check runs at this head, 83 success and 11 skipped, none failing. PR Readiness and both CodeBuild statuses are success. Opus, GPT, Design, First Principles and UX lanes all pass. git merge-tree against main is clean.

Source-only: I checked no live UI or screenshots, and I did not check how a refused browser Back looks. The refusal is silent by design, with the draft left on screen in the modal, as on the other hosts of this guard.

Follow-ups (non-blocking), from the UX lane:

  1. Add screenshots of the edit-mode in-flight strip with the locked Logs tab, and of the "may or may not have been saved" notice.
  2. The blind reader was unsure what happens after Close. The UX lane suggests the close_wont_cancel line say that a failure will show on this page. That is a wording choice for the owner, not a defect.

@bolichen97
bolichen97 merged commit f3ca014 into main Nov 7, 2026
99 checks passed
@bolichen97
bolichen97 deleted the fix/10307-schedule-dialog-inflight-honesty branch November 7, 2026 19:45
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026
buluoray pushed a commit that referenced this pull request Nov 8, 2026
…32036)

Closing the Schedule page's job dialog mid-save cannot cancel the request,
yet the dialog still offered Cancel with no word that the schedule might
be created anyway. Its late answer then ran the closed dialog's success
path, which closed whatever dialog the user had opened since, and a late
failure vanished with the unmounted form.

While a save is in flight the dialog's Cancel reads Close and a strip
above the footer says the schedule may still be created (or the changes
saved). A late answer only refreshes the list; a late failure is reported
on the page, one dismissable notice per save, worded by whether the
server refused it or never confirmed the outcome. The Logs tab is locked
mid-save and Save is off on Logs, so the form that reports a result stays
mounted, and a page leave or browser Back is refused while the dialog
holds typed work, an edited alert threshold or time zone included.

(cherry picked from commit f3ca014)
buluoray pushed a commit that referenced this pull request Nov 8, 2026
…32036)

Closing the Schedule page's job dialog mid-save cannot cancel the request,
yet the dialog still offered Cancel with no word that the schedule might
be created anyway. Its late answer then ran the closed dialog's success
path, which closed whatever dialog the user had opened since, and a late
failure vanished with the unmounted form.

While a save is in flight the dialog's Cancel reads Close and a strip
above the footer says the schedule may still be created (or the changes
saved). A late answer only refreshes the list; a late failure is reported
on the page, one dismissable notice per save, worded by whether the
server refused it or never confirmed the outcome. The Logs tab is locked
mid-save and Save is off on Logs, so the form that reports a result stays
mounted, and a page leave or browser Back is refused while the dialog
holds typed work, an edited alert threshold or time zone included.

(cherry picked from commit f3ca014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schedule page's job dialog: bind member_id, and adopt the dismissal-honesty pattern from #10223

2 participants