Repository navigation
fix(a11y): expose open state on the schedule job message toggle - #32276
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the PR adds one ARIA attribute to an existing toggle, and nothing on screen changes. [DESIGN-REVIEWED] 100db37 Description read[DESCRIPTION-READ] 8516446a2822a1b63e0df8e4eb794dbb5190e2d95494e04579442b807a145712 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: let a screen-reader user hear whether a Schedule job's message is expanded or collapsed. This is a FIX (#32271).
[FIRST-PRINCIPLES-REVIEWED] 100db37 Description read[DESCRIPTION-READ] 973bac796b8e8a098773cbe32786ca4bce9e9e17992e3a6edce391eeecfd97d4 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the only change is an [UX-REVIEWED] 100db37 Description read[DESCRIPTION-READ] de7c546f010aa1c011b4038c8e40d3ea91623bf084e51c0a638cebf7de3e5ac8 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Each Schedule page job row shows its message as a preview button that expands the full text, but it carries no aria-expanded, so a screen reader cannot tell whether the full message is showing. It now does.
d99b0db to
100db37
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds aria-expanded to the schedule job message toggle so its open state is announced, with a test.
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed at 100db37. Thank you, a clean accessibility fix: the message toggle on the schedule page now sets aria-expanded from its open state, so a screen reader hears whether the full message is showing, and the test checks both states.
Gates at this head: every check passes (the one red Publish readiness signal row is an older attempt that hit a rate limit; its newer run passed), there is no regex in product code, and no change request is open. Approving; the auto-merge you set stays as it is.
Problem / Motivation
Goal: A screen-reader user can tell whether a Schedule page job message is expanded.
Each job row shows its message as a one-line preview button that expands the full text below it. The button carries no
aria-expanded, so the open state is not announced.Why it matters
A screen-reader user reading the job list cannot tell whether the full message is showing below the row or only the preview.
Not a goal
What changed (motivation → approach → change)
Symptom: no open or closed state on the message toggle. Cause: the button carries no ARIA state.
pages/SchedulePage.tsx: theCollapsibleMessagetoggleBtncarriesaria-expanded={open};Btnpasses it through to its<button>.Backwards compatibility
Compatible: the button expands and collapses the same text; only an ARIA attribute is added.
Removes nothing: no key, prop, export or behaviour is taken away.
Tests
CollapsibleMessage.test.tsx: the toggle startsaria-expanded="false", reportstrueonce the full message shows, andfalseagain after a second press.It fails against
origin/mainand passes here (run with--no-cache).Proof: not provable -- frontend test (prove.py runs Python only)
Gate:
tsc -p tsconfig.app.json, eslint on changed files,check_file_line_cap.py, and every test file that mentionsSchedulePageorCollapsibleMessage(68 files, 817 tests) pass.Determinism: no timers, sleeps or ports; the test clicks and reads the DOM synchronously.
Overlap: open PRs #32036 and #32000 also edit
SchedulePage.tsx, in the page body and the job dialog. No hunks overlap, andgit merge-treeof this head with each reports no conflict.Manual verification
N/A — unit coverage sufficient: only an ARIA attribute is added, and the test reads it from the rendered DOM.
Screenshots / video
Why no screenshot: the button renders the same pixels; only an
aria-expandedattribute is added.Related Issues
Fixes #32271
Sibling sweep
Swept: git grep -nE "setOpen(v => !v)" -- website/src/pages/SchedulePage.tsx
Sibling: website/src/pages/SchedulePage.tsx -- changed here
Pattern harvest
Rule candidate: review-prompt
Pattern: a preview button that expands a block below it but carries no aria-expanded
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)