Skip to content

fix(a11y): expose open state on the schedule job message toggle - #32276

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/schedule-msg-aria-r11
Nov 7, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/schedule-msg-aria-r11

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A screen-reader user can tell whether a Schedule page job message is expanded.

Each job row shows its message as a one-line preview button that expands the full text below it. The button carries no aria-expanded, so the open state is not announced.

Why it matters

A screen-reader user reading the job list cannot tell whether the full message is showing below the row or only the preview.

Not a goal

  • Changing the preview, the full-message block, or how a click reaches the row.
  • Other toggles on this page; this PR covers this one.

What changed (motivation → approach → change)

Symptom: no open or closed state on the message toggle. Cause: the button carries no ARIA state.

  • pages/SchedulePage.tsx: the CollapsibleMessage toggle Btn carries aria-expanded={open}; Btn passes it through to its <button>.

Backwards compatibility

Compatible: the button expands and collapses the same text; only an ARIA attribute is added.

Removes nothing: no key, prop, export or behaviour is taken away.

Tests

  • CollapsibleMessage.test.tsx: the toggle starts aria-expanded="false", reports true once the full message shows, and false again after a second press.

It fails against origin/main and passes here (run with --no-cache).

Proof: not provable -- frontend test (prove.py runs Python only)

Gate: tsc -p tsconfig.app.json, eslint on changed files, check_file_line_cap.py, and every test file that mentions SchedulePage or CollapsibleMessage (68 files, 817 tests) pass.

Determinism: no timers, sleeps or ports; the test clicks and reads the DOM synchronously.

Overlap: open PRs #32036 and #32000 also edit SchedulePage.tsx, in the page body and the job dialog. No hunks overlap, and git merge-tree of this head with each reports no conflict.

Manual verification

N/A — unit coverage sufficient: only an ARIA attribute is added, and the test reads it from the rendered DOM.

Screenshots / video

Why no screenshot: the button renders the same pixels; only an aria-expanded attribute is added.

Related Issues

Fixes #32271

Sibling sweep

Swept: git grep -nE "setOpen(v => !v)" -- website/src/pages/SchedulePage.tsx
Sibling: website/src/pages/SchedulePage.tsx -- changed here

Pattern harvest

Rule candidate: review-prompt
Pattern: a preview button that expands a block below it but carries no aria-expanded

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 7, 2026 11:13
@RohanK6
RohanK6 requested a review from tim-finnigan November 7, 2026 11:13
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 100db3788f8cf79802f474744c1254bc63539f80 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the PR adds one ARIA attribute to an existing toggle, and nothing on screen changes.

[DESIGN-REVIEWED] 100db37

Description read

[DESCRIPTION-READ] 8516446a2822a1b63e0df8e4eb794dbb5190e2d95494e04579442b807a145712

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 100db3788f8cf79802f474744c1254bc63539f80 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: let a screen-reader user hear whether a Schedule job's message is expanded or collapsed. This is a FIX (#32271).

  1. A screen reader now announces the open or closed state of the job message preview button. — justified
  2. A test checks that the state reads false, then true, then false as the button is pressed. — justified

[FIRST-PRINCIPLES-REVIEWED] 100db37

Description read

[DESCRIPTION-READ] 973bac796b8e8a098773cbe32786ca4bce9e9e17992e3a6edce391eeecfd97d4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 100db3788f8cf79802f474744c1254bc63539f80 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the only change is an aria-expanded attribute on the existing message toggle, so the page looks the same and no screenshot could show the difference.

[UX-REVIEWED] 100db37

Description read

[DESCRIPTION-READ] de7c546f010aa1c011b4038c8e40d3ea91623bf084e51c0a638cebf7de3e5ac8

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 100db3788f8cf79802f474744c1254bc63539f80 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 100db37

Verdict parsed from the review's SHA-scoped output markers for commit 100db3788f8cf79802f474744c1254bc63539f80.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 100db3788f8cf79802f474744c1254bc63539f80 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 100db3788f8cf79802f474744c1254bc63539f80 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 100db37

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 100db3788f8cf79802f474744c1254bc63539f80 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 7, 2026 12:04
Each Schedule page job row shows its message as a preview button that
expands the full text, but it carries no aria-expanded, so a screen
reader cannot tell whether the full message is showing. It now does.
@RohanK6
RohanK6 force-pushed the crew/conductor/schedule-msg-aria-r11 branch from d99b0db to 100db37 Compare November 7, 2026 12:11
@RohanK6

RohanK6 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto bab2387 (head 100db37). The only reds on d99b0db came from main. Backend shard 2 (3.12 and Windows) failed test_the_package_stays_within_its_line_budget, and Coverage Gate and readiness failed downstream of it. #32252 fixed that on main. The diff is unchanged.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds aria-expanded to the schedule job message toggle so its open state is announced, with a test.

@RohanK6
RohanK6 merged commit 0600f3b into main Nov 7, 2026
95 of 99 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/schedule-msg-aria-r11 branch November 7, 2026 13:07
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 100db37. Thank you, a clean accessibility fix: the message toggle on the schedule page now sets aria-expanded from its open state, so a screen reader hears whether the full message is showing, and the test checks both states.

Gates at this head: every check passes (the one red Publish readiness signal row is an older attempt that hit a rate limit; its newer run passed), there is no regex in product code, and no change request is open. Approving; the auto-merge you set stays as it is.

buluoray added a commit that referenced this pull request Nov 8, 2026
Each Schedule page job row shows its message as a preview button that
expands the full text, but it carries no aria-expanded, so a screen
reader cannot tell whether the full message is showing. It now does.

(cherry picked from commit 0600f3b)

Original author: Rohan Khanderia (#32276).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schedule page: the job message expand toggle has no aria-expanded

3 participants