Skip to content

refactor: backport the agents.py effort-levels split to 0.12.1 (batch 29) - #32184

Merged
buluoray merged 1 commit into
release/0.12.0from
crew/slack/0.12.1-batch-29
Nov 7, 2026
Merged

buluoray merged 1 commit into
release/0.12.0from
crew/slack/0.12.1-batch-29

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring #32123, which moves the effort-levels route out of src/kiro_crew/dashboard/handlers/agents.py, onto release/0.12.0 as one commit, so that file is back under the 2,000-line cap after #32112 (the #31569 backport) took it to 2,002 lines.

Why it matters

PR What it fixes on this branch
#32123 agents.py is 2,002 lines on release/0.12.0, over the 2,000-line cap that scripts/check_file_line_cap.py enforces, because #32112 carried #31569 here as merged on main. This is the follow-up #32112's body names.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change. Cutting v0.12.1-rc.N and the bare tag follow docs/build/release.md and stay with the maintainers.
  • No behaviour change: the route moves whole into a new module, and agents.py keeps the import path callers use.

What changed (motivation → approach → change)

The main squash commit was cherry-picked with -x onto release/0.12.0 @ 4d9f6b123e, keeping its original author.

PR main commit release commit Pick
#32123 move the effort-levels route out of agents.py under the line cap a3fb5af23d 0a10a0fc0a clean

No hunk was resolved by hand; the pick's added and removed lines are identical to its main commit. api_effort_levels moves to src/kiro_crew/dashboard/handlers/agents_effort_levels.py. agents.py goes from 2,002 to 1,979 lines, and scripts/check_file_line_cap.py passes on this branch.

builder-security checked: the route keeps its path, method and auth; only the module that defines it changes.

Backwards compatibility

Compatible: the change is the one already merged on main, and its own compatibility note applies unchanged. The route answers as before.

Removes nothing: no route, setting or behaviour that 0.12.0 accepts is removed.

Tests

Proof: not provable -- other: a backport of a main commit whose proof ran on its own PR

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file plus every test file that imports the agents handler or the effort-levels route, 121 files, one pytest process per batch of 20, -n 0. 5852 passed, none failed.
  • scripts/check_file_line_cap.py: 0 failures.
  • flake8 passes on the changed Python files.

Manual verification

N/A - the change was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: backend-only change.

Related Issues

Backport to the 0.12 line for 0.12.1 of #32123. Follow-up to #32112.

Sibling sweep

Siblings: none -- the source PR carried its own sibling sweep; this PR only carries that change.

Pattern harvest

Not generalizable: this PR only carries a change already on main.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

…e cap (#32123)

agents.py reached 2,002 lines on main, over the 2,000-line cap, so the
line-cap ratchet fails every PR. GET /api/effort-levels moves whole into
handlers/agents_effort_levels.py, a plain module outside the owner
composition; agents.py binds the same object, so routes, the handlers
package and callers keep their import path. No behavior change.

(cherry picked from commit a3fb5af)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 07:29
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 7, 2026 07:29
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0a10a0fc0a7944eb56b000bddd62831f58fd3999 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0a10a0fc0a7944eb56b000bddd62831f58fd3999 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: this is a clean backport of an already-merged split that moves one route and keeps the facade binding and route identity, with nothing patching the moved function's dependencies through the facade.

[DESIGN-REVIEWED] 0a10a0f

Description read

[DESCRIPTION-READ] d9a82eea9d125443bd382c11d967d407492e329bdce26288e9ddfcd2d676a948

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 0a10a0fc0a7944eb56b000bddd62831f58fd3999 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is a clean, behaviour-neutral move that AGENTS.md's 2,000-line cap requires on the release branch.

What this change ships

Inventory (4 items) — 4 justified

Intent: get agents.py on release/0.12.0 back under the line cap by backporting #32123. FIX (unwedges a gate).

  1. The GET /api/effort-levels handler moves into handlers/agents_effort_levels.py, and agents.py still exports it under the same name — justified
  2. agents.py keeps its get_reasoning_effort_ordered import as a re-export (noqa: F401) — justified
  3. The composition-contract test now knows about sibling modules and pins that the facade binds the same object — justified
  4. The owner prose in the feature-map and learn-cron-dashboard spec names the new module — justified

[FIRST-PRINCIPLES-REVIEWED] 0a10a0f

Description read

[DESCRIPTION-READ] cde637eef3298e7667ac73a7564fe5fdffe0a3b875dd2a9cfbd78937d949bc28

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0a10a0fc0a7944eb56b000bddd62831f58fd3999 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0a10a0f

Verdict parsed from the review's SHA-scoped output markers for commit 0a10a0fc0a7944eb56b000bddd62831f58fd3999.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0a10a0fc0a7944eb56b000bddd62831f58fd3999 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0a10a0fc0a7944eb56b000bddd62831f58fd3999 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0a10a0f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0a10a0fc0a7944eb56b000bddd62831f58fd3999 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@buluoray
buluoray merged commit eb92e05 into release/0.12.0 Nov 7, 2026
20 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-29 branch November 7, 2026 09:16
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant