Repository navigation
feat: add a default-off visual refresh feature preview flag - #32377
bolichen97 wants to merge 1 commit into
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The change only adds things: a default-off flag built on the existing preview-flag mechanism, with screenshots of the new row attached. Notes
[DESIGN-REVIEWED] dd89308 Description read[DESCRIPTION-READ] b771f030fc4cc0336061dc72472b5eb05a112ffdb1e20e2f4760ed0a94f004b8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The Visual refresh switch has no reader. Nothing in the dashboard changes when it is flipped, so shipping nothing loses nobody anything. The flag should land with the first restyle piece that reads it. What this change shipsInventory (5 items) — 2 justifiedIntent: let the dashboard refresh merge in pieces behind a default-off preview switch. ADDITION.
BlockersItem 1–3 — a preview switch with no reader (zero consumers) [FIRST-PRINCIPLES-REVIEWED] dd89308 Description read[DESCRIPTION-READ] 368fad2202c390d93966b5eea60f69a984c42510bbb39c88b49208aa55976bb0 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader understood the one new control, the Visual refresh switch, and would use it. All three screenshots show it, off in both themes and on. Notes
[UX-REVIEWED] dd89308 Description read[DESCRIPTION-READ] 0d25621c5d8f66183866c4b976347b29454402073d8f2598f28cb94b32934c76 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
ae83e8b to
1f62e59
Compare
|
[operator: bolichen97] Rebased onto main 21597a3 at 1f62e59 to clear the merge conflict in The Frontend Tests (1) red on ae83e8b was this PR's own French string: |
1f62e59 to
c43bc15
Compare
|
[operator: bolichen97] Rebased again onto main 95695ba at c43bc15: main moved in |
c43bc15 to
ba19cca
Compare
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for |
|
Re-sync budget reset: this PR is inside its 48-hour keep-green watch, and main conflicted with it again in the generated UI index, so it needs one more re-sync to stay mergeable. [operator: bolichen97] |
cb709ac to
79f5b59
Compare
|
Rebased: main moved in The PR was conflicting with main again, in the generated UI index only. Main relabeled the crew_oauth preview as MCP sign-in and added the [operator: bolichen97] |
|
self-added: no
|
Code change approver recommendation: ApproveWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. The PR adds a default-off Visual refresh feature-preview flag using the existing mechanism. The browser key mc-preview-visual-refresh maps to the gateway name visual_refresh in FEATURE_PREVIEW_FLAGS, and test_feature_previews_config.py keeps the two lists equal. Code that loops over every flag (loader, LTS locks, config schema, change-card catalog) picks up the new name, and the change-card catalog files every preview flag as safe because it only decides what the dashboard shows. Absent or unknown values read as off. LTS builds hide the row and leave it out of Settings search. The new tests cover the default-off state, the toggle writing only its own key, and the LTS search exclusion. Frontend tests, the i18n check and the regenerated files pass in CI; the remaining non-bot failures are infrastructure problems. The First Principles bot's 'zero consumers' block is a scope disagreement with the PR's stated, maintainer-endorsed goal of landing the gate first, not a code defect. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
79f5b59 to
bdef1b0
Compare
|
Rebased: main moved in The last run went red only in Fast Gate's docs lint, on [operator: bolichen97] |
|
self-added: no
[operator: bolichen97] |
|
/ai-review override first-principles bdef1b0 owner-decision: agent: the default-off flag lands first and the restyle PRs read it later, per the maintainer decision #32377 (comment) [operator: bolichen97] |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Adds a Visual refresh switch to Settings > Developer > Feature Previews (mc-preview-visual-refresh, kept on the gateway as dashboard.feature_previews.visual_refresh), so the dashboard restyle can land on main in pieces without changing what anyone sees. Off is the dashboard as it is today; nothing reads the flag yet. Closes #24595
|
[operator: bolichen97] Rebased onto current main to resolve the merge conflict in |
bdef1b0 to
dd89308
Compare
|
self-added: no
[operator: bolichen97] |
Problem / Motivation
Goal: Let the dashboard visual refresh land on
mainin pieces behind a default-off Feature Previews switch, so nobody sees it until it is ready.A visual refresh of the dashboard is starting. Without a gate, every piece that merges changes what every user sees, before the new look is finished or agreed.
Why it matters
The refresh can be built and reviewed on
mainin small PRs instead of a long-lived branch, while the dashboard everyone uses stays exactly as it is.Not a goal
What changed (motivation → approach → change)
Settings > Developer > Feature Previews gets a Visual refresh switch, in the Chats and Dashboards group. It is off by default and changes nothing in this build: its one-line summary reads "A new look for the dashboard. Nothing changes yet.", and its info tip says pieces appear as they land.
It reuses the existing preview flag mechanism, the same shape as the other switches on that page:
PREVIEW_VISUAL_REFRESH(mc-preview-visual-refresh) inwebsite/src/utils/previewFlags.ts, read withusePreviewFlag. Like every switch, it is kept on the gateway underdashboard.feature_previews.visual_refresh, so the name joinsPREVIEW_FLAGSand the gateway'sFEATURE_PREVIEW_FLAGS(config/sections_dashboard.py, pinned equal bytest_feature_previews_config.py), andsrc/kiro_crew/docs/configuration.mdlists it. An absent or unknown value reads as off.Like the other preview rows, an LTS build does not draw it, and Settings search there does not offer it: its id is in
PREVIEW_FLAG_SETTING_IDS(commandPalette/settingsSearchCore.ts).The row is toggle-only in
FeaturePreviewsSection.tsx. Its label, summary and info-tip text are in all twelve catalogs, with translator context inen.context.json;en-XA,config-baseline.json, the settings registry (settings-registry.generated.json,commandPalette/settingsRegistry.gen.ts) and the UI index (ui-index.generated.json) are regenerated.Backwards compatibility
Compatible: a new, unset switch reads as off on the gateway and in the browser cache, so every existing install renders the dashboard unchanged.
Removes nothing: the diff only adds a flag, a settings row, its strings, the gateway's name for it and its LTS search entry.
Tests
website/src/test/previewSurfaces.test.tsx: a new test pins that Visual refresh starts off, turns on when clicked, and writes onlymc-preview-visual-refreshamong preview keys. The section's row table (FEATURE_PREVIEW_ROWS) gains aVisual refreshrow with an info tip, so the drawn-rows check and the computed info-tip total cover it.website/src/test/ltsFeaturePreviewsOff.test.tsx: a new test pins that Settings search on an LTS build does not offer the Visual refresh row. It fails without thePREVIEW_FLAG_SETTING_IDSentry (expected true to be false).The Feature Previews tests (
-t "Feature Previews") and the LTS test file each passed 5 times in shuffled order (--sequence.shuffle).test_feature_previews_config.pykeeps the two flag lists pinned equal; the i18n suite (npm run i18n:checkwithI18N_BASE_REFat the merge base),tsc -p tsconfig.app.jsonand the settings-registry and UI-index tests pass.Manual verification
On Linux (Ubuntu 24.04), built the dashboard (
npm run build) and served it withwebsite/scripts/lib/serve-dist.mjsandstub-dashboard-api.mjsin Playwright at/settings/developer/feature-previews: the row renders in both themes, reads off by default, flips on when clicked, and the click writesmc-preview-visual-refresh.Screenshots / video
Settings > Developer > Feature Previews with this change, real built SPA with a stubbed API. The Visual refresh row is the last row of the Chats and Dashboards group, after Send pending approvals to chat apps.
Off (default), light:
Off (default), dark:
On after a click, light:
Related Issues
Closes #24595
Builds on #24618 by @dodgeblaster.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)