Repository navigation
feat(settings): fold Agent Harness details behind a summary so the picker comes first - #32849
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Folding the security lines reverses a rule from the spec and the file header, not from a Notes
[DESIGN-REVIEWED] 928b563 Description read[DESCRIPTION-READ] b070319d65f3f62c90dbb0475fd0cacebf28050ff2aef56f8e12371648801d8f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The reversed "never behind a disclosure" rule is named in the description and attributed to an owner decision tied to #32847. Two riders and three stale comments are below as notes. Notes
What this change shipsInventory (9 items) — 7 justifiedIntent: let a person choose and switch the agent harness without first reading 30 lines of reference text. This is an ADDITION (a layout change).
[FIRST-PRINCIPLES-REVIEWED] 928b563 Description read[DESCRIPTION-READ] 64a80442b308574deb894f816a9580627fdf35181f75d9fe843462aaade7fc5d That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader correctly identified all three new folds (About, Kiro sign-in, "Don't see an agent?") and was willing to open each one. Screenshots show both states of the sign-in and About folds. Notes
[UX-REVIEWED] 928b563 Description read[DESCRIPTION-READ] e3b5ae46d24418d31b5f96d987fc89c6acdfc81b9a618dbd7b31b2e7f813b4c7 That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
b4b9b49 to
45a399d
Compare
|
UX Review on b4b9b49, addressed in 45a399d:
|
45a399d to
e13e0a2
Compare
|
Opus 5.5 Review BLOCK on 45a399d (feature-map-correctness), fixed in e13e0a2 — docs only, verified against the code:
|
|
UX Review on e13e0a2:
|
e13e0a2 to
980a32e
Compare
|
UX Review BLOCK on e13e0a2, addressed in this push:
|
|
GPT 6.1 BLOCK on 980a32e ( The warning span no longer has The other reds on 980a32e were the installation token's primary rate limit (HTTP 403 at 07:08Z) and passed on one rerun at 08:05Z: UX PASS, Opus no blocking findings. |
980a32e to
dcace4a
Compare
|
Correction to the GPT reply above: the fix commit is dcace4a (current head), not 82ba98f8b8d5. |
dcace4a to
215eab8
Compare
215eab8 to
928b563
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving 928b563. In Settings, Agent Harness, the open harness row now shows the state block and the Use button first, and the capability card sits in one closed "About " fold below them. The Kiro sign-in section folds too (open while the person must sign in or the status read failed, closed to "Signed in with " once signed in, and re-opened if the sign-in lapses), and the "listed set is fixed at gateway start" note moves under "Don't see an agent?". No fact is removed from the page.
I read the whole diff. The folded safety lines stay findable: the always-visible summary counts them (security notes, Claude's own-permissions caveat, an unverified approval, the whole-server tool-off rule, and each tool-limiting agent-file setting that will not take effect), and it turns warning-coloured with the written words "Some tools may run without asking" for an unverified approval or Claude's own pre-approved tools. The chat's sign-in deep link opens the row and the fold through openRequest, reported handled so a remount does not force it open again. The new strings are in all 13 locale files, with the plural forms each language needs, the plural key is registered in pluralKeys.json, and the tests cover the summary text, the warning marker, the plural count, and the sign-in fold's open, close and re-open paths. The capture script and page are dev helpers. No regex in product code and no new restriction, and all 97 checks pass on this head, including Publish readiness signal after its rerun on the installation API rate limit.
Problem / Motivation
Goal: Settings → Agent Harness shows the picker, the status of the checked harness and its Use button first, with everything else one click away.
Today the open harness row holds about 30 lines before the next harness name: the full Kiro sign-in chooser (also when already signed in), the tool-approval line, caveats, security notes, the 7-line capability list, MCP notes and a gateway-start footer. The control the page exists for is buried.
Why it matters
The page is where a person picks which agent new sessions run. When the switch and the harness list are under a wall of reference text, people miss which harness is in use, what is broken, and how to switch.
Not a goal
What changed (motivation → approach → change)
Goal → put a summary in front of reference text → three folds, all native
<details>/<summary>(one tab stop, Enter/Space toggle, expanded state announced):AgentBackendTab.tsxfacts): approval, caveats, security notes, capability list, "Other differences", MCP rule/exception, ineffective agent-file settings and the credential note move into one closed fold under the Use button. Its summary is always visible:About Kiro Agent · 7 of 7 features · 2 safety notes.safetyCount): server security notes + Claude's own-permissions caveat + the whole-server MCP deny rule + anunverifiedapproval mechanism + each agent-file limit that will not take effect here (denied_tools,tool_allowlist,permission_mode,hooks,hooks_pre_tool_use).runsWithoutAsking): only anunverifiedapproval mechanism or Claude's own pre-approved tools. The summary turns warning-coloured AND says⚠ Some tools may run without asking, never colour alone. Crew's sandbox standing down and the whole-server MCP deny are counted, not marked: the server sends no host condition for the first (it holds only on Windows and macOS-with-sandbox), and the second keeps the denied tool denied (UX review).KiroSignInCard.tsxcompact form): open while the person must sign in (signed out, lapsed, status read failed); closed toKiro sign-in · Signed in with Googleonce signed in; re-opens if the sign-in lapses later; the chat deep link (?highlight=) opens it via a one-shotopenRequest. Keepsdata-setting-key/data-setting-id, anaria-labeland an<h3>inside the summary.Intro shortened in all 12 locales: "New sessions use this agent. Open sessions keep the one they started with." New keys (summary, plural safety-note count, warning marker, missing-agent summary) added in all locales with each language's plural categories;
pluralKeys.jsonupdated;en-XAregenerated.capture/settings-agent-harness.tsxtakes?lang=andscripts/capture-agent-harness-levels.mjsproduces the screenshots below from realbackend_cards.card_payload()output.Backwards compatibility
Compatible: frontend layout only; no API, config or stored-state change.
Removes nothing: every line still renders, now inside a fold whose summary is always visible; no key, function, route or record is removed.
Tests
AgentBackendTab.detailCard.test.tsx: card lines live in the closed About fold and the summary carries the count; security note counted without the marker; credential note counted without the marker; Claude andunverifiedmarked 'Some tools may run without asking'; an ineffectivehookssetting counted (plural "2 safety notes"); deny rule/exception inside the fold, counted, not marked; footer under "Don't see an agent?".KiroSignInCard.test.tsx: compact form folds once signed in, user toggle survives re-render, no duplicate provider line when open, heading kept; open when signed out; re-opens on lapse and on a second lapse after the person closed it; open on a failed status read; deep-link request opens it and is reported handled.SettingsPage.agentHarnessSignIn.test.tsx: the deep link lands on the fold and opens it.Proof: not provable -- frontend test (prove.py runs Python only)
Local:
vitestharness + sign-in files 189/189,src/i18n1212/1212,eslintclean,tscclean,i18n:checkpass,i18n:renderwithI18N_BASE_REF=origin/main: PASS [vs-base] — no surface got worse. Local GPT and Opus reviews run; all findings fixed in this commit.Manual verification
Rendered through the real
SettingsPagecapture entry at 1280px and 375px, en and zh-CN, with real card payloads. Keyboard and screen-reader behaviour come from native<details>/<summary>; not hand-tested with a screen reader.Screenshots / video
Before (left) / after (right), Kiro Agent in use, signed out:
Claude Code checked, 375px:
Signed in (sign-in folds to one line):
All 8 widths/locales and the opened About fold
Related Issues
Fixes #32847
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.