Repository navigation
fix(service): five service install and cli output fixes from the sweep - #33125
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: each of the five fixes targets the cause it names, and moving Notes
[DESIGN-REVIEWED] cfa0ad2 Description read[DESCRIPTION-READ] 4b900ac67deef293d9b96a93f88863216b463d2b35683776994e39f005d7b1cc That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Each fix traces back to a reproduction in #33056. The one second spelling has a stated reason: its re-read skips the cache, which the cached reader cannot do. Notes
What this change shipsInventory (10 items) — 8 justifiedIntent: let an operator install and run the Kiro Crew service on hosts where it now fails silently or misleadingly, and read CLI failures plainly. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] cfa0ad2 Description read[DESCRIPTION-READ] 871ca8f50fc8102c0d636b0f910c4dd415d226166905af25e0b40cae44719976 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
ed2b35d to
025a4c7
Compare
|
self-added: yes
|
025a4c7 to
db2f18c
Compare
|
self-added: yes
|
|
self-added: yes
|
|
self-added: yes
|
|
self-added: no
|
|
[operator: bolichen97] Cross-Platform Portability: added
|
db2f18c to
ab72d71
Compare
Five fixes for `kirocrew service install`, the gateway it installs and two CLI outputs, each found by the sweep and proven on a DevSpace: - The MCP search and runtime PATH puts KIROCREW_NODE_BIN_DIR first, even when the inherited PATH lists it behind nvm's bin, and the glibc-2.17 Node ahead of nvm's newest version, and service install carries KIROCREW_NODE_BIN_DIR into the unit, so npx servers on Amazon Linux 2 run on a Node that loads. - service install and kirocrew doctor name the AWS container credential, region and fixed-path ssh-agent variables the service will not inherit, names only, with a 0600 .env remedy, so MCP servers and cron scripts no longer fail under the service with no hint. doctor builds the note before it asks for the unit path, so a shell with nothing to report spawns no systemctl probe. - service install refuses a Linux host that systemd did not boot (no /run/systemd/system) before any sudo or write, and resolves User= from the uid when USER and LOGNAME are unset (non-interactive ssh) instead of refusing with "Could not determine current user". - kirocrew spawn list takes a finished run's icon from its outcome: a failed run shows a cross with its error and a stopped run a stop icon, instead of a success check mark for both. - A subagent failure names a cause whose text its wrapper already quotes by class only, so the KAS engine refusal no longer repeats the same remedy three times.
ab72d71 to
cfa0ad2
Compare
|
self-added: yes
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approving. Review of head cfa0ad2 covered: the systemd check in install() runs before any sudo prompt or write; the passwd fallback still refuses root; augmented_path keeps the override and this install's Node dirs ahead on a second pass; spawn list icons now come from outcome; the first error-chain link keeps Type: message; and the .env name check now uses the same loader.parse_env_lines as the boot load. Mutation runs confirmed the systemd refusal, the uid fallback, the lead ordering and the socket segment check each red their named test.
Security: the new warnings print variable names, the .env path and fixed hint text, never a value. The inline bearer token is left out when its _FILE form is set. The pasted remedy is one && chain that appends nothing if chmod fails, and tests run that chain in sh to prove it. The two clear-text-logging code scanning alerts trace to names only and show as fixed on this PR's merge ref.
Done well: new logic lives in new modules (env_node_pins.py, service/inherited_env.py) instead of growing env.py, and the _booted_with_systemd fixture removes a host dependency from the install suites.
Optional:
headless_auth_warning's KIRO_API_KEY remedy chain (service/common.py:296) has no test, so reverting it to the old two-line form reds nothing. Parametrizing the twosh-executing remedy tests over both warnings would pin it.- The spawn list fallback for a row with no
outcomebut anerror(cli_commands_gateway_api.py:159) is unpinned. Two small cases would cover it. - When
service installitself runs undersudo -u, the dropped-variable warning sees the reset environment and prints nothing. This could fold into #33338.
#33125) Five fixes for `kirocrew service install`, the gateway it installs and two CLI outputs, each found by the sweep and proven on a DevSpace: - The MCP search and runtime PATH puts KIROCREW_NODE_BIN_DIR first, even when the inherited PATH lists it behind nvm's bin, and the glibc-2.17 Node ahead of nvm's newest version, and service install carries KIROCREW_NODE_BIN_DIR into the unit, so npx servers on Amazon Linux 2 run on a Node that loads. - service install and kirocrew doctor name the AWS container credential, region and fixed-path ssh-agent variables the service will not inherit, names only, with a 0600 .env remedy, so MCP servers and cron scripts no longer fail under the service with no hint. doctor builds the note before it asks for the unit path, so a shell with nothing to report spawns no systemctl probe. - service install refuses a Linux host that systemd did not boot (no /run/systemd/system) before any sudo or write, and resolves User= from the uid when USER and LOGNAME are unset (non-interactive ssh) instead of refusing with "Could not determine current user". - kirocrew spawn list takes a finished run's icon from its outcome: a failed run shows a cross with its error and a stopped run a stop icon, instead of a success check mark for both. - A subagent failure names a cause whose text its wrapper already quotes by class only, so the KAS engine refusal no longer repeats the same remedy three times. Backport note: release keeps its own longer docstrings and comments, which main had shortened in docs-only PRs not on release. The new KIROCREW_NODE_BIN_DIR paragraph and bullet, the systemd-booted refusal sentence, the one && chain comment, the parse_env_lines docstring and the KIROCREW_NODE_BIN_DIR clause in acp-client.md are added beside release's text. Code is as on main. (cherry picked from commit df434a0)
#33125) Five fixes for `kirocrew service install`, the gateway it installs and two CLI outputs, each found by the sweep and proven on a DevSpace: - The MCP search and runtime PATH puts KIROCREW_NODE_BIN_DIR first, even when the inherited PATH lists it behind nvm's bin, and the glibc-2.17 Node ahead of nvm's newest version, and service install carries KIROCREW_NODE_BIN_DIR into the unit, so npx servers on Amazon Linux 2 run on a Node that loads. - service install and kirocrew doctor name the AWS container credential, region and fixed-path ssh-agent variables the service will not inherit, names only, with a 0600 .env remedy, so MCP servers and cron scripts no longer fail under the service with no hint. doctor builds the note before it asks for the unit path, so a shell with nothing to report spawns no systemctl probe. - service install refuses a Linux host that systemd did not boot (no /run/systemd/system) before any sudo or write, and resolves User= from the uid when USER and LOGNAME are unset (non-interactive ssh) instead of refusing with "Could not determine current user". - kirocrew spawn list takes a finished run's icon from its outcome: a failed run shows a cross with its error and a stopped run a stop icon, instead of a success check mark for both. - A subagent failure names a cause whose text its wrapper already quotes by class only, so the KAS engine refusal no longer repeats the same remedy three times. Backport note: release keeps its own longer docstrings and comments, which main had shortened in docs-only PRs not on release. The new KIROCREW_NODE_BIN_DIR paragraph and bullet, the systemd-booted refusal sentence, the one && chain comment, the parse_env_lines docstring and the KIROCREW_NODE_BIN_DIR clause in acp-client.md are added beside release's text. Code is as on main. (cherry picked from commit df434a0)
Problem / Motivation
Goal:
kirocrew service installrefuses a host systemd did not boot before any sudo prompt, finds the service account whenUSERis unset, and names the shell variables the service will not inherit;npxMCP servers on Amazon Linux 2 start on a Node that loads; andkirocrew spawn listand subagent errors report a failure plainly and once.This PR bundles five fixes to
kirocrew service install, the gateway it installs, and two CLI outputs. Each one was observed on its own (#33056 lists them with steps):service installasked for sudo, wrote the root-owned unit and the overrides file, and failed only atsystemctl daemon-reload. WhenSUDO_USER,USERandLOGNAMEwere all unset on a host systemd did boot, it stopped with "Could not determine current user".npxservers. The MCP search and runtime PATH put nvm's newest Node first. On glibc 2.26 that Node 22 does not load, sonpxMCP servers never started, even withKIROCREW_NODE_BIN_DIRpointing at a Node that does. The installed unit also droppedKIROCREW_NODE_BIN_DIR.SSH_AUTH_SOCKfrom the installing shell never reached the service gateway's MCP servers, cron scripts and agent sessions, and nothing said so.kirocrew spawn list. Every finished run showed the success check mark, failed and stopped runs included.GET /api/spawnand the bell.Why it matters
USERnorLOGNAMEfailed outright, although it ran as a real account.npxMCP server fails to start, and the operator's own fix (KIROCREW_NODE_BIN_DIR) had no effect on MCP servers.spawn listtakes a failed or stopped subagent for a finished one.Not a goal
KIROCREW_HOMEin the installed service (kirocrew service install drops KIROCREW_HOME: the service starts a new, empty crew in ~/.kiro/crew with no warning #32366). Open PR fix(service): bake KIROCREW_HOME into the installed service #32493 fixes it in the same function, so this PR leaves it out./usr/binin the service PATH (service_path()), which open PR fix(service): put nvm's Node ahead of /usr/bin in the service PATH #32108 changes./etc/kirocrew/kirocrew.env. Both are readable by every local user, so the fix only names the variables.current_platform(). Uninstall still dispatches to systemd on a host systemd did not boot, so it can remove a stale unit file there.What changed (motivation → approach → change)
service installrefuses a host systemd did not boot before it asks for sudo, instead of leaving a unit that can never start, and takes the service account from the uid when no variable names it. It names the shell variables the service will not inherit, so the operator knows what to copy into.env. On Amazon Linux 2, MCP servers start on a Node chosen for the host (KIROCREW_NODE_BIN_DIR, which the unit now carries, or the glibc-2.17 Node) instead of nvm's newest, which does not load there.kirocrew spawn listshows how each run ended instead of a check mark for every run, and a subagent error states each cause once instead of three times.systemctlon PATH was the only test, and a container or WSL ships itinstall()inservice/linux_install.pyasks sd_booted(3)'s question (/run/systemd/system) first and refuses with nothing written. The marker moves toservice/linux_unit.pyso install and uninstall read one constantUser=withUSERunset_current_user()read onlySUDO_USER,USERandLOGNAMEservice/linux_unit.py); uid 0 still resolves torootand is still refusednpxserversenv.augmented_pathranked every version-manager dir newest first and never checked one loadsenv_node_pins.py: an executableKIROCREW_NODE_BIN_DIRgoes right after this install's own dir, ahead of the inherited PATH too (a copy of it there is dropped, so it never anchors behind nvm's bin), and the glibc-2.17 treeensure-node.shunpacks goes just ahead of the version-manager dirs. With the override set, an inherited copy of this install's own dir is dropped too, so a second pass over a PATHaugmented_pathalready built keeps it ahead of the override.service_environment()inservice/common.pybakesKIROCREW_NODE_BIN_DIRwhenenv._validated_bin_diraccepts it, the same check the MCP search path appliesservice_environment()onlyservice/inherited_env.pynames each variable the shell sets that neither the service environment,~/.kiro/crew/.envnor, under systemd,/etc/kirocrew/kirocrew.envsupplies, leaving out anSSH_AUTH_SOCKat a path agent sessions search themselves;service/controller.pyprints it after install, anddoctor_checks/services.pyprints it inkirocrew doctor, called fromcli_doctor.py. That doctor row and theKIRO_API_KEYrow beside it build their note before asking for the unit path, so a shell with nothing to report spawns nosystemctl --user showspawn listiconcli_commands_gateway_api.pygave every finished row the check mark_spawn_done_status()readsoutcome: completed keeps the check mark, stopped shows a stop icon, anything else a cross with the error on one line.cli_commands.pymirrors the new name_describe_exceptioninsubagent_parts/run_output.pyprinted every chain link asType: messageThe variable warning prints names only, never values, and its remedy is one
&&chain: it makes.envmode0600, ends a last line written without a newline (echo >>), then appendsNAME=$NAMElines for the shell to expand, so nothing is appended when thechmodfails.headless_auth_warningprints itsKIRO_API_KEYremedy the same way.common._names_defined_in_env_filenow reads.envthroughloader.parse_env_lines, the parserload_credentials()uses, so a later blankNAME=clears an earlier value there as it does at boot;headless_auth_warningreads it too. Neither the warning nor the doctor row can fail an install or a doctor run. Each Node dir counts only when it holds an executablenode, and a caller that pins another account's home gets neither, so with no such dir the PATH is unchanged.The specs and guides describe each change:
cli.mdanddocs/guides/install.mdfor install,docs/architecture/mcp.mdandacp-client.mdfor the Node order,src/kiro_crew/docs/troubleshooting.mdfor the variable warning, andsubagent.mdfor thespawn listicons.Backwards compatibility
Compatible: on a host systemd did not boot the old install could never finish (it failed at
daemon-reloadafter writing the unit), so refusing it first stops nothing that worked. Every other change adds output, adds a PATH entry only when it holds an executablenode(an inherited copy ofKIROCREW_NODE_BIN_DIRmoves to the front instead of staying where it was), or adds anEnvironment=line only when the installer setsKIROCREW_NODE_BIN_DIRto one absolute dir.Removes nothing:
_SYSTEMD_BOOTED_DIRmoves fromservice/linux_uninstall.pytoservice/linux_unit.py, and both modules and theservice.linuxfacade still expose it; no function, key or field is removed.Tests
The full backend and frontend suites run in CI. On a Linux DevSpace (Amazon Linux 2023, not booted by systemd), every other local gate of the profile passed on head
b3a4e9f9ab39(59 gates, plus the flake-pattern ratchet and the diff-scoped semgrep scan, all exit 0). The union of the PR's changed and added test files, the suites of theKIROCREW_HOMEchange this PR leaves out, and the suites that exerciseaugmented_path, the doctor rows and the error chain ran on the same head:PYTHONPATH=src python -m pytest test/test_env_explicit_node_dirs.py test/test_service_environment_node_bin_dir.py test/test_service_inherited_env.py test/test_service.py test/test_linux_facade.py test/test_service_apparmor.py test/test_service_linux_status.py test/test_service_selinux.py test/test_cli_gateway_client.py test/test_subagent_error_detail.py test/test_service_environment.py test/test_service_headless_api_key.py test/e2e/scenarios/test_service_install_dry_run.py test/test_env.py test/test_env_homebrew_keg_node.py test/test_own_kirocrew_link.py test/test_node_toolchain_resolution.py test/test_acp_launch_mcp_path_dirs.py test/test_mcp_gateway_daemon_path.py test/test_cli_doctor_refactor_report.py test/test_cli_doctor_refactor_facade.py test/test_env_file_bom.py test/test_host_isolation_floor.py test/test_subagent_parts_composition_contract.py test/test_acp_client_spawn.py test/test_mcp_resolve_once.py test/test_dev_fleet_node_toolchain.py -n0 -p no:cacheprovider: 1474 passed, 2 skipped, 0 failed. Both skips are the e2e dry-run scenario, which runs only withKIROCREW_E2E_SCENARIOS=1and needs pods and a systemd user bus.Rebased onto main after review; git range-diff shows the patch unchanged; related tests re-run on a DevSpace: the same pytest command on the rebased head
ed2b35d2df57exited 0, 1474 passed, 2 skipped, 0 failed.Determinism, on the same head, for the ten changed and added test files (382 tests; the autouse marker fixture touches every test in the service suites): 20 sequential runs at
-n0, 382 passed each time; 10 runs at-n 4 --dist loadgroup --max-worker-restart=2with the ten files as each other's co-tenants, all green; and one run in a shuffled node-id order (seed 575), 382 passed.Proof: PROVEN test/test_cli_gateway_client.py::TestSpawnCliAuth::test_spawn_list_failed_run_is_not_shown_as_success, test/test_cli_gateway_client.py::TestSpawnCliAuth::test_spawn_list_stopped_run_is_not_shown_as_success, test/test_cli_gateway_client.py::TestSpawnCliAuth::test_spawn_list_unknown_outcome_is_not_shown_as_success, test/test_cli_gateway_client.py::TestSpawnCliAuth::test_spawn_list_failed_error_prints_no_terminal_controls, test/test_env_explicit_node_dirs.py::TestOverrideLeads::test_every_mcp_composition_inherits_the_override (head 5f36a498a6e6)
With the production hunks reverted, 15 tests fail an assertion, covering all five fixes. The line above names the first five. The others are
test_an_override_the_inherited_path_lists_behind_nvm_is_never_an_anchorintest/test_env_explicit_node_dirs.py,test_install_refuses_on_a_host_not_booted_with_systemdandtest_current_user_falls_back_to_the_uid_ownerintest/test_service.py,test_the_patched_names_are_read_across_the_familyintest/test_linux_facade.py, five cases intest/test_service_inherited_env.py, andtest_a_cause_its_wrapper_already_quotes_is_named_not_repeatedintest/test_subagent_error_detail.py. Five new cases pin a narrower rule inside a fix (the overrides file, an agent socket sessions find again, the socket paths pinned to the resolver, the doctor probe order, a short cause). They pass on pre-PR code, where nothing is reported or deduplicated at all, and each fails with only its own hunk of the fix reverted.What each test file locks in:
test/test_service.py: install refuses a host without/run/systemd/systemwith no sudo call and nothing written;_current_user()falls back to the uid's passwd entry.test/service_helpers.pyandtest/test_service_selinux.pypoint the marker at an existing directory, so the suites that run the realinstall()keep testing what they test on a runner systemd did not boot;test/test_linux_facade.pycovers the moved constant.test/test_env_explicit_node_dirs.py(new):npxresolves to the override, not nvm's newest; every MCP composition inherits it; it leads an nvm dir the inherited PATH lists first; an inherited copy of it behind nvm's bin is never an anchor, so it still leads nvm, appears once, and~/.local/binkeeps its rank; a pinned home gets none; an unusable override changes nothing; the glibc-2.17 tree ranks ahead of every nvm version; with neither present the PATH is unchanged.test/test_service_environment_node_bin_dir.py(new): an absolute dir is baked; an unset, relative, colon-joined or blank value is not.test/test_service_inherited_env.py(new): install names each dropped variable for systemd and launchd,SSH_AUTH_SOCKunder systemd only; a blank value, a name.envsupplies, a name the service environment carries and, under systemd only, a name/etc/kirocrew/kirocrew.envsets are not named; an agent socket at a path sessions search is not named, and those paths are pinned equal to the ones_resolve_ssh_auth_sockglobs; the inline token is left out when its_FILEform is set; the remedy tightens permissions first, references each variable rather than its value, survives a crew home with spaces, and names an undecodable.env; no dropped variable is baked into the service environment; doctor reports it only for an installed service, and with nothing to report neither doctor row asks for the unit path; a failing check breaks neither install nor doctor.test/test_cli_gateway_client.py: failed, stopped and unknown outcomes are not shown as success, completed is, and a failed run's error prints no terminal controls.test/test_subagent_error_detail.py: a cause its wrapper already quotes is named, not repeated; a short cause that appears in its wrapper by chance keeps its text.Review round 2 (reviewed locally as 793cbf01b0, then rebased onto origin/main with git range-diff showing the patch unchanged; on the rebased head the ten changed and added test files plus the readers below pass, 437 tests): the printed remedy and both
troubleshooting.mdexamples putecho >> "$P"before the append, andcommon._names_defined_in_env_filereads the final map.test_remedy_keeps_a_last_line_without_a_newline_wholeruns the printed snippet inshon a.envwhose last line has no newline and parses the result; it fails on the previous head and passes here.test_a_name_a_later_blank_assignment_clears_is_still_namedfails on the previous head and passes here.inherited_env.pynow takes the uid fromplatform_compat.effective_uid()and splits socket paths withPurePosixPath(...).parts. Run locally:test_service_inherited_env,test_service,test_env_file_bom,test_service_selinux,test_linux_facade,test_service_controller,test_service_headless_api_keyandtest_flake_pattern_ratchetat-n 2: all passed; flake8, isort, mypy and semgrep exit 0.Review round 3:
test_remedy_appends_nothing_when_the_chmod_failsruns the printed snippet with achmodthat fails and checks.envis unchanged; it fails on the round-2 head and passes here.test_a_second_augmentation_keeps_this_install_ahead_of_the_overrideaugments the PATH twice; it fails on the round-2 head and passes here. Rebased onto main again (patch unchanged by git range-diff); the twelve service, env, cli and subagent test files re-run there: 461 passed.Review round 4:
common._with_home_noteis renamed_with_crew_home_caveat. CodeQL's private-data name heuristic readhome_noas a home phone number, so every warning joined through it,headless_auth_warningon main included, was flagged as clear-text logging; the text never carried a value. No behavior change; and the service, env, headless, cli and controller suites pass. Round 5:service_environment()validatesKIROCREW_NODE_BIN_DIRthroughenv._validated_bin_dir, the same accepted values on POSIX, sotest_service_environment_node_bin_dir.pypasses unchanged. Reviewed as 5f36a498a6, rebased onto main with the patch unchanged, and the related suites re-run there: 289 passed. Undersudo -E -Hboth.envwarnings name root's file, asheadless_auth_warningalready does on main: tracked in #33338, not changed here.End-to-end repro for each fix on the same DevSpace, each from a fresh worktree of head
b3a4e9f9ab39:User=: exit 0. On this DevSpace, which systemd did not boot,service installrefused before any sudo call with "systemd is not running as this host's init system (no /run/systemd/system)" and wrote nothing. WithUSERandLOGNAMEunset, a run inside a rootless namespace that gives the install a/run/systemd/systemreached the unit write withUser=set to the uid's account.spawn list: exit 0. A subagent the gateway records asoutcome='failed'lists as❌ <id> Reply PONG (failed: kiro_crew.acp.client.AcpAuthRequired: ...).kirocrew doctorandkirocrew service installboth name all six variables the unit drops (AWS_CONTAINER_CREDENTIALS_FULL_URI,AWS_CONTAINER_AUTHORIZATION_TOKEN,AWS_REGION,AWS_DEFAULT_REGION,AWS_EC2_METADATA_DISABLED,SSH_AUTH_SOCK), neither report prints a value, and after the printed remedy the repro finds nothing still missing under the service.spawn runoutput,GET /api/spawnand the bell each state the cause sentence once and the remedy once (697 characters in the API, 880 in the bell). An offline engine fetch failure does the same.Manual verification
The end-to-end runs under Tests are the manual check. The Amazon Linux 2 Node fix was not run end to end: it needs a glibc 2.26 host, and this DevSpace has glibc 2.34, where nvm's Node 22 loads anyway. Its unit tests above pass on this head.
Screenshots / video
N/A: the diff touches no dashboard or website surface. The CLI output is shown under Tests.
Related Issues
Fixes #33056
Sibling sweep
Swept: git grep -nE 'which(\s*"systemctl"' -- src/kiro_crew
Swept: git grep -nE 'environ.get("(USER|LOGNAME)")' -- src/kiro_crew
Swept: git grep -n "_node_all_bin_dirs|def service_path" -- src/kiro_crew
Swept: git grep -n "service_environment(" -- src/kiro_crew
Swept: git grep -n '"✅"' -- 'src/kiro_crew/.py'
Swept: git grep -n "caused by|cause" -- 'src/kiro_crew/.py'
Swept: git grep -nE 'override_bin_dirs|_own_kirocrew_dirs()' -- src/kiro_crew
Swept: git grep -nE '_names_defined_in_env_file(' -- src/kiro_crew
Swept: git grep -nE 'installed_unit_path()' -- src/kiro_crew/doctor_checks
Sibling: src/kiro_crew/service/linux_install.py -- changed here
Sibling: src/kiro_crew/service/linux_unit.py -- changed here
Sibling: src/kiro_crew/env.py -- changed here
Sibling: src/kiro_crew/service/inherited_env.py -- changed here
Sibling: src/kiro_crew/cli_commands_gateway_api.py -- changed here
Sibling: src/kiro_crew/subagent_parts/run_output.py -- changed here
Sibling: src/kiro_crew/doctor_checks/install.py:378 -- not affected -- the unit path is that check's input, since it reads the program the unit starts
Sibling: src/kiro_crew/service/common.py -- changed here
Sibling: src/kiro_crew/pod/runtime.py -- not affected -- a pod start requires a live user session bus before it writes anything, and its account lookup falls back to the uid
Sibling: src/kiro_crew/doctor_checks/services.py -- not affected -- the pods row probes the user bus next and writes nothing, and its linger check falls back to the uid, which loginctl accepts
Sibling: src/kiro_crew/apps/builtins/dev_fleet/runtime.py:112 -- not affected -- it only marks pods available; a pod start then needs the user bus
Sibling: src/kiro_crew/slack/gateway_runtime/subagent_report.py:131 -- not affected -- it picks the icon from the run's ending, failed and reaped included
Sibling: src/kiro_crew/subagent_manager/monitoring.py:837 -- not affected -- it marks only a run whose result is whole
Sibling: src/kiro_crew/agent_spec_pin_ops.py:335 -- not affected -- it walks the chain only to find one exception type and renders no message
Sibling: src/kiro_crew/browser_harness/chromium.py:402 -- not affected -- it walks the chain only to test for a certificate error and renders no message
Pattern harvest
Rule candidate: review-prompt
Pattern: a status or choice taken from a coarse signal (a run is done,
systemctlis on PATH, a version dir is newest) when a precise one is already at hand (its outcome,/run/systemd/system, a Node that loads or that the operator named)Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)