Repository navigation
fix: say why a goal loop paused on failing or declined cycles - #33190
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The fix adds two missing entries to the popover's existing lookup and to its existing error-notice set. No new mechanism, and no default changes. Notes
What this change shipsInventory (4 items) — 4 justifiedIntent: when the service stops a goal loop because its cycles kept failing or the model declined one, the user is told why instead of seeing a bare "Paused". This is a FIX (Closes #32530).
[FIRST-PRINCIPLES-REVIEWED] 76d2da3 Description read[DESCRIPTION-READ] 2a245ac57964d3f14a8a0f1bbac21376acad02eee88bbfc67ef23fee610ca542 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: it adds two lookup entries the backend already emits ( Notes
[DESIGN-REVIEWED] 76d2da3 Description read[DESCRIPTION-READ] f550906f627f01fe8f25eba02e606445907b3c4f43c78c0f175ff0b35d86821d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The new notices are shown in light and dark, and the blind reader read both correctly. Only the next steps are left for the user to work out. Notes
[UX-REVIEWED] 76d2da3 Description read[DESCRIPTION-READ] d36434e88d94a3db047d1a00931fb57a64d87dfc88b1e97ddff954424f0f9016 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
A goal loop the service stood down on consecutive_failures (several cycles in a row failed) or model_refused (the model declined a cycle) showed only the bare "Paused" line in the warn tone, because the goal popover's status lookup knew neither reason. Both reasons now have their own line in every locale and render through ErrorNotice, with no hand-off beside the unsaved goal fields, like the other failed-cycle reasons. Closes #32530
402e17b to
76d2da3
Compare
|
Rebased: main moved in src/kiro_crew/acp/kas_cli_settings.py since this head's CI ran (ec255d3 -> b306a0b); CI re-running. The red |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (15 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a goal loop paused for consecutive failures or a model refusal now shows its reason as an error notice, with the two new strings in every locale and a test for both reasons.
A goal loop the service stood down on consecutive_failures (several cycles in a row failed) or model_refused (the model declined a cycle) showed only the bare "Paused" line in the warn tone, because the goal popover's status lookup knew neither reason. Both reasons now have their own line in every locale and render through ErrorNotice, with no hand-off beside the unsaved goal fields, like the other failed-cycle reasons. Closes #32530 Original author: Bolin Chen (cherry picked from commit 0bca0bc)
Problem / Motivation
Goal: A goal loop the service stopped because its cycles kept failing, or because the model declined a cycle, tells the user why in an error notice instead of a bare "Paused".
When the service stands a goal loop down on
consecutive_failures(several delivered cycles in a row ended in an error or a timeout) or onmodel_refused(the model declined the cycle), the goal popover shows only "Paused" in the warn tone: the same line a loop shows when nobody recorded why it paused. Nothing says a failure happened.Why it matters
A user who opens the popover cannot tell a loop that is failing from one that is resting. They get no reason, no alert and no next step, so a loop that cannot make progress just sits there, and the user has no cue to look at the chat for the error or change the goal.
Not a goal
What changed (motivation → approach → change)
The popover now says why the loop stopped, in the same red error notice it already uses for a cycle that could not run:
stopped_reasonconsecutive_failuresmodel_refusedThe bare "Paused" came from a lookup that knew neither reason, so it fell back to the plain line in the warn box. Both reasons are now in that lookup (
PAUSED_STATUS_KEYinAutoNudgePopover.tsx) and in the set of reasons that render throughErrorNotice(FAILED_CYCLE_REASONS), with no hand-off, asstructural_terminal,session_start_failuresandclaim_unsavedalready do. The two lines are new catalog keys in every shipped language (en.manual.jsonplus the 11 translations) and in the generateden-XApseudolocale.Backwards compatibility
Compatible: two catalog keys and two lookup entries are added; every other stop reason renders exactly as before.
Removes nothing: no key, route, field or behaviour is taken away; an unlisted stop reason still falls back to the bare "Paused".
Tests
website/src/test/AutoNudgePopover.test.tsx: a paused loop stopped onconsecutive_failures, and one stopped onmodel_refused, each renders its own line as therole="alert"error notice, not in the warn box, with no "ask the agent" button and the title still "Paused". WithAutoNudgePopover.tsxreverted to main both cases fail (main renders the bare "Paused" warn line). The existing parity tests hold every locale to the new keys.Determinism: the two new cases passed 20 runs in a row, and the whole file passes under
--sequence.shufflewith seeds 48780 and 70223.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Built
website/distfrom1e99b45e37(this head is the same patch re-synced onto main, which changed no popover code in between) and captured the whole popover with a throwaway gateway-free Playwright script (serveDist+stubDashboardApi, one loop per stop reason). Before each shot the script checks the status text, that it carriesrole="alert", and that the Play (resume) control is enabled and inside the frame.Screenshots / video
The whole goal popover from that build, so the controls under the notice stay in frame: Clear stopped goal on the left, Pause and Play (resume) on the right.
consecutive_failures, lightconsecutive_failures, darkmodel_refused, lightmodel_refused, darkRelated Issues
Closes #32530
Sibling sweep
Swept: git grep -nE "structural_terminal|session_start_failures" -- website/src
Sibling: website/src/pages/members/CrewOnItsOwn.tsx:51 -- not affected -- its FAILURE_STOP_KEYS already maps model_refused and consecutive_failures to an error line
Pattern harvest
Rule candidate: review-prompt
Pattern: a frontend lookup keyed by a backend enum (here
stopped_reason) falls back silently to generic copy, so a new backend value ships unworded; a new persisted reason should land with its UI mapping or a test that enumerates the backend's codes.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)