Skip to content

fix: backport 0.12.1 error-notice batch (#30664, #31481, #33029) - #33193

Merged
buluoray merged 4 commits into
release/0.12.0from
crew/slack/0.12.1-error-notice
Nov 8, 2026
Merged

buluoray merged 4 commits into
release/0.12.0from
crew/slack/0.12.1-error-notice

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring #30664 and #31481 onto release/0.12.0 together with their main follow-up fixes #33029 and #33204, one commit each, in a PR of its own.

Why it matters

Both fixes change behaviour a 0.12.0 user can run into today. They were dropped from an earlier batch because review found that each one swallowed an error. #33029 fixed that on main, so all three can now go in together.

PR Area What a 0.12.0 user sees today
#30664 apps A released former built-in's route shows the compiled page instead of not-installed
#31481 Issue Radar Refresh issues buttons lose focus while they refresh
#33029 apps, Issue Radar A failed refresh or release lookup fails silently
#33204 Issue Radar A failed refresh started from the Overview fails silently

Not a goal

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ df6b9d769b, in merge order on main, one commit each. Each commit names its original author.

# PR main commit release commit
1 #30664 show not-installed at a released former built-in's route 2c799d84c1 4c8e35a052
2 #31481 keep focus on the Refresh issues buttons while they refresh b0857653c2 4d566b20a7
3 #33029 show a failed issue refresh and app release lookup in an error notice e43f72c7e2 5b9cf87eb8
4 #33204 show a failed refresh on the overview in an error notice e44f139063 6405185b83

#30664, #31481 and #33204 applied cleanly. #33204 fixes the Overview refresh that review of this batch found still failing silently after #33029. #33029 needed two hand fixes, both written in its commit message:

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: the 9 apps-routes and builtin-adoption test files gave 372 passed.
  • Frontend, after rebasing onto df6b9d769b: tsc -p tsconfig.app.json passes, and the 107 vitest files that touch BuiltinAppRoute or Issue Radar gave 2,427 passed.
  • flake8, black and eslint pass on the changed files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30664, #31481, #33029, #33204.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 13:35
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 13:35
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 6405185b8362f0a2d5501b55d9a4c7a34cfd162c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the three new error notices and the not-installed page for a released former built-in. The blind read was not performed because the PR supplies no image.

Evidence gaps

  • Not-installed page: the not-installed state at a released former built-in's route (InstalledAppSurface app={null} in BuiltinAppRoute.tsx). Needs a screenshot of that route after the app was uninstalled.
  • Failed release lookup: the ErrorNotice shown above the compiled page when the lookup fails (BuiltinAppRoute.tsx, className="m-4"). Needs a screenshot with the lookup failing.
  • Issue Radar Overview: the new <ErrorNotice message={issuesError?.message} askAgent /> shown after a failed refresh, sitting above the cached numbers. Needs a screenshot of the Overview after a refresh fails.
  • Issue and PR lists: the ErrorNotice moved outside the list region (IssueList.tsx, PrList.tsx, flex-shrink-0), shown over cached rows. Needs a screenshot of each list after a failed refresh.
  • Refresh button while busy: the "Refresh issues" button while a refresh runs, now using aria-disabled:opacity-30 / aria-disabled:opacity-40 with a default cursor, plus a visible focus ring that stays on it. Needs a screenshot of that state.

"The main PRs show it" does not count as evidence: none of those images was admitted for this revision. Attach them to this PR's description.

Notes

  • The failed-release-lookup notice shows the raw releasedLookupError.message. Nothing tells the user that the page may be running without its app's backend, even though the code comment says that is the risk. The notice should state it, for example: "Couldn't check whether this app is installed, so this page may show empty data."

[UX-REVIEWED] 6405185

Description read

[DESCRIPTION-READ] f8eff1681e91e916ad9802eb36451865f80e406a05ebf27cc2c6c4ca2f201192

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 6405185b8362f0a2d5501b55d9a4c7a34cfd162c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Every item is a merged main fix carried over unchanged, plus the one-line ErrorNotice import the description declares.

What this change ships

Inventory (8 items) — 8 justified

Intent: give 0.12.x users three fixes already merged on main: a released former built-in's route shows not-installed, Refresh keeps focus, and refresh/lookup failures show an error. FIX.

  1. The route of a former built-in uninstalled after adoption shows the not-installed state instead of a compiled page with nothing behind it — justified
  2. GET /api/apps/{name} 404 carries code: "app_released" for a released name — justified
  3. When the release check fails, a notice above the compiled page says the page may not be backed — justified
  4. Issue and PR list refresh errors now sit outside the card region, so cached cards no longer cover them — justified
  5. A failed manual issue refresh now shows as the issues error, and clears when the repo or state changes — justified
  6. The Overview shows a failed refresh in an error notice above the cached tiles — justified
  7. The Refresh issues buttons (list and Overview) keep keyboard focus while a refresh runs, and a press then does nothing — justified
  8. The installed-apps list reads "not loaded yet" as different from "empty" — justified

[FIRST-PRINCIPLES-REVIEWED] 6405185

Description read

[DESCRIPTION-READ] 9aac24d2203a08edfd5c7f5e1cd5f74bccb85c1d38674185098f9730cd205685

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 6405185b8362f0a2d5501b55d9a4c7a34cfd162c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing screenshot of the not-installed state at a released former built-in's route, or of the new ErrorNotice placements on the 0.12 branch. The evidence list has no image or recording.

Blockers

No rendered evidence of this revision for the UI it changes
Trigger: the diff changes what three surfaces render on release/0.12.0. BuiltinAppRoute.tsx swaps in <InstalledAppSurface app={null} …> under "#released" and adds an <ErrorNotice … askAgent className="m-4"/> above the compiled page. OverviewView.tsx adds <ErrorNotice message={issuesError?.message} askAgent />. IssueList.tsx moves its notice out of the card region. Meanwhile the description says "the frontend picks carry the same rendered change as their main PRs, which show it".
Outcome: the release branch has different surrounding UI from main (#30667 was not picked, and BuiltinAppRoute.tsx needed a hand-added import) → main-PR screenshots do not show how these surfaces render on 0.12 → the layout of the not-installed swap and of the notice above the compiled page goes unreviewed and lands in a stable release.
Fix: attach screenshots taken from this branch's build.
Clears when: the description carries github.com/user-attachments images captured on this branch showing (1) a released former built-in's route in the not-installed state, (2) the ErrorNotice above a compiled built-in page after a failed release lookup, and (3) the Issue Radar Overview and IssueList with a failed refresh over cached data.

Notes

  • The return type of useLoadedInstalledApps changes from [] to undefined. BuiltinAppRoute.tsx is its only production reader, so this is safe. The "Removes nothing" claim holds.

[DESIGN-REVIEWED] 6405185

Description read

[DESCRIPTION-READ] 19248b113905dbcf3a0e05c832ff645f6335d2e266326d575b8b6470f46c45a5

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6405185b8362f0a2d5501b55d9a4c7a34cfd162c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6405185

Verdict parsed from the review's SHA-scoped output markers for commit 6405185b8362f0a2d5501b55d9a4c7a34cfd162c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6405185b8362f0a2d5501b55d9a4c7a34cfd162c false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6405185b8362f0a2d5501b55d9a4c7a34cfd162c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6405185

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6405185b8362f0a2d5501b55d9a4c7a34cfd162c false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
A former built-in uninstalled after adoption has no record and the
gateway mounts none of its wheel routes, yet its legacy dashboard
route still rendered the compiled page: empty lists and 404s while
the app's data waited on disk for a reinstall.

GET /api/apps/{name} now answers a released name with no record with
a 404 carrying code app_released, reusing the existing fail-closed
release check in manager_builtins. BuiltinAppRoute asks it only when
the loaded apps list holds no record for the page's app. That answer
swaps in AppHost's not-installed state, which points at Apps; any
other 404 keeps the compiled page as before, and a lookup that failed
is retried and asked again on the next visit rather than cached.

Part of #26967

Original author: Bolin Chen
(cherry picked from commit 2c799d8)
… refresh (#31481)

Original author: Rohan Khanderia
(cherry picked from commit b085765)
…or notice (#33029)

* fix(ui): show a failed issue refresh and app release lookup in an error notice

Issue Radar's Refresh ran through a mutation whose error nothing read, so a
failed refresh just stopped the spinner and left stale rows as if it had
worked. Its failure now reaches issuesError, which IssueList already shows
in an ErrorNotice, the way pullsError reports a failed PR refresh.

BuiltinAppRoute's release lookup kept only the query's data, so a lookup
that kept failing showed nothing while the compiled page rendered against a
backend that may not be there. Once its retries are spent the error shows
in an ErrorNotice above the page; the page itself still renders.

Refs #30664, #31481

* test(ui): expect the release lookup notice after a failed lookup

The legacy-route test pinned no alert after a failed release lookup,
which was the silent behaviour this PR replaces with an ErrorNotice.

Release resolution: docs/system-specs/modules/app-kit-platform.md keeps
release's surrounding text; only the failed-lookup sentence changes.
Release resolution: BuiltinAppRoute.tsx adds the ErrorNotice import, which
main got from #30667 (not on release; too wide to pick for one import).
(cherry picked from commit e43f72c)
…otice (#33204)

The Overview refresh button calls the same refresh as the issue list,
but only the list rendered its error, and the list is not mounted on
Overview. A failed refresh there stopped the spinner and left the
cached numbers with no sign that they may be out of date.

(cherry picked from commit e44f139)
@buluoray
buluoray force-pushed the crew/slack/0.12.1-error-notice branch from a52b85c to 6405185 Compare November 8, 2026 18:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 8, 2026
@buluoray
buluoray merged commit 2196761 into release/0.12.0 Nov 8, 2026
28 of 35 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-error-notice branch November 8, 2026 18:40
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant