Repository navigation
fix: backport 0.12.1 error-notice batch (#30664, #31481, #33029) - #33193
Conversation
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the three new error notices and the not-installed page for a released former built-in. The blind read was not performed because the PR supplies no image. Evidence gaps
"The main PRs show it" does not count as evidence: none of those images was admitted for this revision. Attach them to this PR's description. Notes
[UX-REVIEWED] 6405185 Description read[DESCRIPTION-READ] f8eff1681e91e916ad9802eb36451865f80e406a05ebf27cc2c6c4ca2f201192 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every item is a merged What this change shipsInventory (8 items) — 8 justifiedIntent: give 0.12.x users three fixes already merged on
[FIRST-PRINCIPLES-REVIEWED] 6405185 Description read[DESCRIPTION-READ] 9aac24d2203a08edfd5c7f5e1cd5f74bccb85c1d38674185098f9730cd205685 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing screenshot of the not-installed state at a released former built-in's route, or of the new BlockersNo rendered evidence of this revision for the UI it changes Notes
[DESIGN-REVIEWED] 6405185 Description read[DESCRIPTION-READ] 19248b113905dbcf3a0e05c832ff645f6335d2e266326d575b8b6470f46c45a5 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
A former built-in uninstalled after adoption has no record and the
gateway mounts none of its wheel routes, yet its legacy dashboard
route still rendered the compiled page: empty lists and 404s while
the app's data waited on disk for a reinstall.
GET /api/apps/{name} now answers a released name with no record with
a 404 carrying code app_released, reusing the existing fail-closed
release check in manager_builtins. BuiltinAppRoute asks it only when
the loaded apps list holds no record for the page's app. That answer
swaps in AppHost's not-installed state, which points at Apps; any
other 404 keeps the compiled page as before, and a lookup that failed
is retried and asked again on the next visit rather than cached.
Part of #26967
Original author: Bolin Chen
(cherry picked from commit 2c799d8)
…or notice (#33029) * fix(ui): show a failed issue refresh and app release lookup in an error notice Issue Radar's Refresh ran through a mutation whose error nothing read, so a failed refresh just stopped the spinner and left stale rows as if it had worked. Its failure now reaches issuesError, which IssueList already shows in an ErrorNotice, the way pullsError reports a failed PR refresh. BuiltinAppRoute's release lookup kept only the query's data, so a lookup that kept failing showed nothing while the compiled page rendered against a backend that may not be there. Once its retries are spent the error shows in an ErrorNotice above the page; the page itself still renders. Refs #30664, #31481 * test(ui): expect the release lookup notice after a failed lookup The legacy-route test pinned no alert after a failed release lookup, which was the silent behaviour this PR replaces with an ErrorNotice. Release resolution: docs/system-specs/modules/app-kit-platform.md keeps release's surrounding text; only the failed-lookup sentence changes. Release resolution: BuiltinAppRoute.tsx adds the ErrorNotice import, which main got from #30667 (not on release; too wide to pick for one import). (cherry picked from commit e43f72c)
…otice (#33204) The Overview refresh button calls the same refresh as the issue list, but only the list rendered its error, and the list is not mounted on Overview. A failed refresh there stopped the spinner and left the cached numbers with no sign that they may be out of date. (cherry picked from commit e44f139)
a52b85c to
6405185
Compare
Problem / Motivation
Goal: Bring #30664 and #31481 onto
release/0.12.0together with their main follow-up fixes #33029 and #33204, one commit each, in a PR of its own.Why it matters
Both fixes change behaviour a 0.12.0 user can run into today. They were dropped from an earlier batch because review found that each one swallowed an error. #33029 fixed that on
main, so all three can now go in together.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.mainbrought theErrorNoticeimport intoBuiltinAppRoute.tsx; see the hand fixes below.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@df6b9d769b, in merge order onmain, one commit each. Each commit names its original author.2c799d84c14c8e35a052b0857653c24d566b20a7e43f72c7e25b9cf87eb8e44f1390636405185b83#30664, #31481 and #33204 applied cleanly. #33204 fixes the Overview refresh that review of this batch found still failing silently after #33029. #33029 needed two hand fixes, both written in its commit message:
docs/system-specs/modules/app-kit-platform.mdconflicted, becausemain's side also carries a legacy-route paragraph that release does not have. The resolution keeps release's surrounding text and changes only the failed-lookup sentence to the fix(ui): show a failed issue refresh and app release lookup in an error notice #33029 wording.ErrorNoticeimport instead of fix(apps): keep an adopted app's rail entry once its pin row is gone #30667. On release,website/src/apps/BuiltinAppRoute.tsxdid not importErrorNotice, so the pick failedtsc(Cannot find name 'ErrorNotice'). Onmainthe import came from fix(apps): keep an adopted app's rail entry once its pin row is gone #30667 (02ff92efc2), which changes 30+ files across backend, config and locales. Picking it for one import is too wide, so the pick adds that one import line.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the direct test modules were run here: the 9 apps-routes and builtin-adoption test files gave 372 passed.df6b9d769b:tsc -p tsconfig.app.jsonpasses, and the 107 vitest files that touchBuiltinAppRouteor Issue Radar gave 2,427 passed.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30664, #31481, #33029, #33204.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.