Skip to content

fix(issue-radar): show a failed refresh on the overview in an error notice - #33204

Merged
bolichen97 merged 1 commit into
mainfrom
crew/slack/overview-refresh-notice
Nov 8, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/slack/overview-refresh-notice

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A failed Issue Radar refresh started from the Overview tells the user, instead of failing silently.

Overview's Refresh issues button calls the same refresh() as the issue list. Its failure lands in issuesError, which #33029 made the refresh mutation report. Only IssueList renders that error, and the list is not mounted on Overview. So a failed refresh from Overview stops the spinner and leaves the cached numbers on screen, as if it had worked. The blocking errors-use-error-notice review rule forbids this. Review of the 0.12.1 batch #33193 found it, and it is on main.

Why it matters

The 0.12.1 batch #33193 (#30664, #31481, #33029) is blocked on this finding. It can go to release once this lands.

Not a goal

  • Changing what a refresh does on success.
  • Any other silent error path in Issue Radar.

What changed (motivation → approach → change)

  • OverviewView.tsx reads issuesError from the Issue Radar context and renders it in the shared ErrorNotice (agent hand-off) under the refresh row, above the cached tiles. With no error the notice renders nothing.

Backwards compatibility

Compatible: nothing changes on success; a failure now shows the shared ErrorNotice where it showed nothing.

Removes nothing: no setting, route, key or caller is removed.

Tests

  • OverviewView.coverage.test.tsx › "shows a failed refresh in an error notice, above the cached numbers": no alert without an error; with issuesError set, the alert shows its message and the cached tiles stay.
  • Removing the ErrorNotice line turns this test red ("Unable to find an accessible element with the role alert"). All 74 Issue Radar test files give 1,647 passed. tsc -p tsconfig.app.json and eslint on the touched files pass.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: the path is a failure branch driven by a context error, which is how it is reached in the test above.

Screenshots / video

The Overview after a failed Refresh issues, in the default Kiro theme. The notice and its Ask the agent control sit under the refresh row, and the cached KPI tiles stay below it.

Light:

Overview after a failed refresh, light

Dark:

Overview after a failed refresh, dark

Captured from the real OverviewView in a Storybook build with the dashboard stylesheet and theme attributes, fed a fixed Issue Radar context whose issuesError is a 502. The story and its context stub were local only and are not in this PR.

Related Issues

Refs #31481, #33029

Sibling sweep

Swept: grep -rnE '\brefresh(Pulls)?\(\)' --include='*.tsx' website/src/apps/issue-radar for refresh buttons whose view does not render the refresh error
Sibling: website/src/apps/issue-radar/views/OverviewView.tsx -- changed here
Sibling: website/src/apps/issue-radar/components/IssueList.tsx -- not affected -- it already renders issuesError
Sibling: website/src/apps/issue-radar/components/PrList.tsx -- not affected -- it already renders pullsError

Pattern harvest

Rule candidate: review-prompt
Pattern: when a fix makes a shared action report its error, every view that can trigger that action must render the error, not only the first one found.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 14:01
@buluoray
buluoray requested a review from tim-finnigan November 8, 2026 14:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 67d89f70ff21f1b957f7d06569e811b1837884a6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the shared notice says the refresh failed and offers a next step, and the blind reader correctly read it as an error.

Notes

  • The reader said the strip "doesn't tell me whether the numbers below are old, or what I should do", and didn't know "502 Bad Gateway". The notice passes on the raw issuesError.message as-is. Wrap it in a line written for the user, for example "Couldn't refresh issues. The numbers below are from the last successful refresh.", and put the raw code after that line or demote it.

[UX-REVIEWED] 67d89f7

Description read

[DESCRIPTION-READ] 45a97a3d3e562a1defded9c0c1b5aae7461429e169c185313ad620344c0e649b

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 67d89f70ff21f1b957f7d06569e811b1837884a6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the Overview now shows refresh failures through the shared ErrorNotice, the same way IssueList already does. Issue Radar is not pinned in apps/adoption-pins.json, so fixing it here in core is allowed.

Notes

  • issuesError is issuesQuery.error ?? refreshMutation.error. The Overview will also show initial-load failures, not only failed refreshes. That is the correct behaviour, but it is wider than the description says.

[DESIGN-REVIEWED] 67d89f7

Description read

[DESCRIPTION-READ] 8f2488c10e763462886a198ed6dafb179e7fce029dce8c33981901c4a325e1d6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 67d89f70ff21f1b957f7d06569e811b1837884a6 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. It is one fix at mechanism level, and it reuses the shared ErrorNotice exactly as IssueList.tsx:121 already does.

What this change ships

Inventory (2 items) — 2 justified

Intent: a person who refreshes Issue Radar from the Overview tab learns when the refresh failed, instead of reading the stale numbers as current. This is a FIX.

  1. A failed refresh started from Overview now shows an error notice, with the agent hand-off, above the cached KPI tiles. — justified
  2. A test pins the notice and checks that the cached tiles stay visible. — justified

[FIRST-PRINCIPLES-REVIEWED] 67d89f7

Description read

[DESCRIPTION-READ] 91fec41d3a7d3e2426b70b6361b13c3499730a183d61a91720d56f267919af2d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 67d89f70ff21f1b957f7d06569e811b1837884a6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 67d89f7

Verdict parsed from the review's SHA-scoped output markers for commit 67d89f70ff21f1b957f7d06569e811b1837884a6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 67d89f70ff21f1b957f7d06569e811b1837884a6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 67d89f70ff21f1b957f7d06569e811b1837884a6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 67d89f7

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 67d89f70ff21f1b957f7d06569e811b1837884a6 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
…otice

The Overview refresh button calls the same refresh as the issue list,
but only the list rendered its error, and the list is not mounted on
Overview. A failed refresh there stopped the spinner and left the
cached numbers with no sign that they may be out of date.
@buluoray
buluoray force-pushed the crew/slack/overview-refresh-notice branch from 83bcff5 to 67d89f7 Compare November 8, 2026 15:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The code change is small and correct, and it matches the IssueList pattern. One thing is missing before it can merge.

  1. website/src/apps/issue-radar/views/OverviewView.tsx:163: this head adds <ErrorNotice message={issuesError?.message} askAgent /> to the Overview, which showed no notice before. The PR body waives screenshots with <!-- no-visual-delta -->, but the Overview now shows a new alert with an agent hand-off control after a failed load. So the change has a rendered delta, and nobody has reviewed it as rendered. The UX review for this head says "cannot evaluate: missing a screenshot of the Overview with a failed refresh". Fix: attach one light and one dark screenshot of the Overview after a failed Refresh issues. Show the notice, its Ask the agent control and the KPI tiles below it. Then let the UX review run again on that evidence. No code change is needed.

Optional:

  • The new test does not check that the notice sits above the tiles, as its name says, and it does not check the askAgent control. You could assert the order with compareDocumentPosition and query the control, or drop "above" from the test name.
  • The notice also shows initial-load and background-refetch failures, not only a failed refresh. That behaviour is correct. The code comment could say "a failed issue load" to match.
  • This is inherited from #33029 and is out of scope here: a failed manual refresh keeps its notice after a later background poll succeeds. A follow-up in context.tsx could reset the refresh mutation once fresh data arrives.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 8, 2026
@buluoray
buluoray dismissed KiroCrewCaptain’s stale review November 8, 2026 18:07

Addressed: the requested light and dark screenshots were added to the PR body at ~17:05Z and UX Review re-passed at 17:08Z. Dismissed at the maintainer's request to unblock the 0.12.1 batch #33193.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 8, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 67d89f7 as maintainer. All 109 checks pass.

The Issue Radar overview now shows a failed refresh through the shared ErrorNotice, above the KPI tiles, reading issuesError from the existing context. The cached numbers stay, so the notice is what tells the person they may be stale. With no error, message is undefined and nothing renders. The new test pins both: no alert at first, then the alert with the message while "Open issues" still shows.

@bolichen97
bolichen97 merged commit e44f139 into main Nov 8, 2026
113 of 114 checks passed
@bolichen97
bolichen97 deleted the crew/slack/overview-refresh-notice branch November 8, 2026 18:14
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
…otice (#33204)

The Overview refresh button calls the same refresh as the issue list,
but only the list rendered its error, and the list is not mounted on
Overview. A failed refresh there stopped the spinner and left the
cached numbers with no sign that they may be out of date.

(cherry picked from commit e44f139)
buluoray added a commit that referenced this pull request Nov 8, 2026
…otice (#33204)

The Overview refresh button calls the same refresh as the issue list,
but only the list rendered its error, and the list is not mounted on
Overview. A failed refresh there stopped the spinner and left the
cached numbers with no sign that they may be out of date.

(cherry picked from commit e44f139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants