Repository navigation
fix(issue-radar): show a failed refresh on the overview in an error notice - #33204
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the shared notice says the refresh failed and offers a next step, and the blind reader correctly read it as an error. Notes
[UX-REVIEWED] 67d89f7 Description read[DESCRIPTION-READ] 45a97a3d3e562a1defded9c0c1b5aae7461429e169c185313ad620344c0e649b That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the Overview now shows refresh failures through the shared Notes
[DESIGN-REVIEWED] 67d89f7 Description read[DESCRIPTION-READ] 8f2488c10e763462886a198ed6dafb179e7fce029dce8c33981901c4a325e1d6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. It is one fix at mechanism level, and it reuses the shared What this change shipsInventory (2 items) — 2 justifiedIntent: a person who refreshes Issue Radar from the Overview tab learns when the refresh failed, instead of reading the stale numbers as current. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 67d89f7 Description read[DESCRIPTION-READ] 91fec41d3a7d3e2426b70b6361b13c3499730a183d61a91720d56f267919af2d That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…otice The Overview refresh button calls the same refresh as the issue list, but only the list rendered its error, and the list is not mounted on Overview. A failed refresh there stopped the spinner and left the cached numbers with no sign that they may be out of date.
83bcff5 to
67d89f7
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Thanks for this. The code change is small and correct, and it matches the IssueList pattern. One thing is missing before it can merge.
website/src/apps/issue-radar/views/OverviewView.tsx:163: this head adds<ErrorNotice message={issuesError?.message} askAgent />to the Overview, which showed no notice before. The PR body waives screenshots with<!-- no-visual-delta -->, but the Overview now shows a new alert with an agent hand-off control after a failed load. So the change has a rendered delta, and nobody has reviewed it as rendered. The UX review for this head says "cannot evaluate: missing a screenshot of the Overview with a failed refresh". Fix: attach one light and one dark screenshot of the Overview after a failed Refresh issues. Show the notice, its Ask the agent control and the KPI tiles below it. Then let the UX review run again on that evidence. No code change is needed.
Optional:
- The new test does not check that the notice sits above the tiles, as its name says, and it does not check the askAgent control. You could assert the order with
compareDocumentPositionand query the control, or drop "above" from the test name. - The notice also shows initial-load and background-refetch failures, not only a failed refresh. That behaviour is correct. The code comment could say "a failed issue load" to match.
- This is inherited from #33029 and is out of scope here: a failed manual refresh keeps its notice after a later background poll succeeds. A follow-up in
context.tsxcould reset the refresh mutation once fresh data arrives.
Addressed: the requested light and dark screenshots were added to the PR body at ~17:05Z and UX Review re-passed at 17:08Z. Dismissed at the maintainer's request to unblock the 0.12.1 batch #33193.
bolichen97
left a comment
There was a problem hiding this comment.
Approving 67d89f7 as maintainer. All 109 checks pass.
The Issue Radar overview now shows a failed refresh through the shared ErrorNotice, above the KPI tiles, reading issuesError from the existing context. The cached numbers stay, so the notice is what tells the person they may be stale. With no error, message is undefined and nothing renders. The new test pins both: no alert at first, then the alert with the message while "Open issues" still shows.
…otice (#33204) The Overview refresh button calls the same refresh as the issue list, but only the list rendered its error, and the list is not mounted on Overview. A failed refresh there stopped the spinner and left the cached numbers with no sign that they may be out of date. (cherry picked from commit e44f139)
…otice (#33204) The Overview refresh button calls the same refresh as the issue list, but only the list rendered its error, and the list is not mounted on Overview. A failed refresh there stopped the spinner and left the cached numbers with no sign that they may be out of date. (cherry picked from commit e44f139)
Problem / Motivation
Goal: A failed Issue Radar refresh started from the Overview tells the user, instead of failing silently.
Overview's Refresh issues button calls the same
refresh()as the issue list. Its failure lands inissuesError, which #33029 made the refresh mutation report. OnlyIssueListrenders that error, and the list is not mounted on Overview. So a failed refresh from Overview stops the spinner and leaves the cached numbers on screen, as if it had worked. The blockingerrors-use-error-noticereview rule forbids this. Review of the 0.12.1 batch #33193 found it, and it is onmain.Why it matters
The 0.12.1 batch #33193 (#30664, #31481, #33029) is blocked on this finding. It can go to release once this lands.
Not a goal
What changed (motivation → approach → change)
OverviewView.tsxreadsissuesErrorfrom the Issue Radar context and renders it in the sharedErrorNotice(agent hand-off) under the refresh row, above the cached tiles. With no error the notice renders nothing.Backwards compatibility
Compatible: nothing changes on success; a failure now shows the shared
ErrorNoticewhere it showed nothing.Removes nothing: no setting, route, key or caller is removed.
Tests
OverviewView.coverage.test.tsx› "shows a failed refresh in an error notice, above the cached numbers": no alert without an error; withissuesErrorset, the alert shows its message and the cached tiles stay.ErrorNoticeline turns this test red ("Unable to find an accessible element with the role alert"). All 74 Issue Radar test files give 1,647 passed.tsc -p tsconfig.app.jsonand eslint on the touched files pass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the path is a failure branch driven by a context error, which is how it is reached in the test above.
Screenshots / video
The Overview after a failed Refresh issues, in the default Kiro theme. The notice and its Ask the agent control sit under the refresh row, and the cached KPI tiles stay below it.
Light:
Dark:
Captured from the real
OverviewViewin a Storybook build with the dashboard stylesheet and theme attributes, fed a fixed Issue Radar context whoseissuesErroris a 502. The story and its context stub were local only and are not in this PR.Related Issues
Refs #31481, #33029
Sibling sweep
Swept:
grep -rnE '\brefresh(Pulls)?\(\)' --include='*.tsx' website/src/apps/issue-radarfor refresh buttons whose view does not render the refresh errorSibling: website/src/apps/issue-radar/views/OverviewView.tsx -- changed here
Sibling: website/src/apps/issue-radar/components/IssueList.tsx -- not affected -- it already renders
issuesErrorSibling: website/src/apps/issue-radar/components/PrList.tsx -- not affected -- it already renders
pullsErrorPattern harvest
Rule candidate: review-prompt
Pattern: when a fix makes a shared action report its error, every view that can trigger that action must render the error, not only the first one found.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.