Repository navigation
fix(kas): name kiro-cli's chat.defaultModel when a KAS chat does not start on it - #33222
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this only adds a notice row. Model selection and pins are unchanged, so a revert walks it back cleanly. Notes
[DESIGN-REVIEWED] ea22b7e Description read[DESCRIPTION-READ] 280728ddaab91a8be591500a94dc147927207ab280d8845f166dcfd8da5b64d3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This change only adds a notice. The description says it sits at the symptom level and leaves the real fix, carrying the setting onto the session, to #33023. It reads What this change shipsInventory (4 items) — 4 justifiedIntent: users moving from kiro-cli to KAS should find out that their
[FIRST-PRINCIPLES-REVIEWED] ea22b7e Description read[DESCRIPTION-READ] 76ed79bf67e1d4a6623ab18f5cfe0dec0fac1af9dfd7888e2048126b3dfcb993 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)GPT 6.1 flagged blocking issues on This comment is updated in place on each push. Review detailsBLOCKING -- src/kiro_crew/providers/acp_runtime_start.py:1027 -- Suppress the mismatch notice when the session already serves the configured default
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — LOW. The finding is wrong only in what one notice says. The session runs the right model either way, and following the notice's advice changes nothing. All of these must be true for it to happen:
There is no recovery path because none is needed: the session already serves the model the notice suggests, and picking it again does nothing. The real fix is cheap but not free. It needs a served-model comparison plus a second wording for the case where KAS switched the session to a substitute model, which ties this notice to the substitute logic for good. Either way it is more than a one-off mislabelled notice in a rare account setup is worth blocking on. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
…start on it KAS reads no cli.json, and carrying chat.defaultModel safely needs a pin mark on the session handle (#33023). Until then an unpinned KAS chat keeps main's model behaviour, and the session gets one notice that names the kiro-cli default model and says how to pick it in Crew.
a858c61 to
ea22b7e
Compare
|
Disposition for the GPT 6.1 block on The finding is in |
|
Correction to my comment above: the GPT 6.1 lane on Downgraded finding,
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approving. On this head the review checked several things. The new notice only reads settings: it sends no model and writes no pin, and the test asserts that the set_model calls do not change. The cli.json read reuses the existing credential-gated reader, runs off the event loop, and catches the full unreadable-settings error set. The harness check is a positive == ACP_BACKEND_KAS. Reverting the provider assignment or the notice row makes the new tests fail. The branch also merges cleanly onto current main, which already has #33221.
Done well: the PR keeps its scope honest. It leaves the real carry of chat.defaultModel to #33023 and gives a concrete reason, so it does not ship a half fix.
Optional:
acp_runtime_start.py:1027does not compare the setting with the model the session is actually serving. So when the served-default fallback already picked that model, the notice can still say "pick it". One way to fix this is to skip the row when the two match.test/test_acp_provider.py:1089: add a parametrize row with a non-Kiro, non-KAS backend (for example the Claude backend). Then loosening the guard to "not kiro" would make the test fail.test/test_acp_provider.py:1106: have thedefault_model_noticestub record its argument and assert that it is the session folder. Today, passingNonewould drop the workspace cli.json and the tests would still pass.
…start on it (#33222) KAS reads no cli.json, and carrying chat.defaultModel safely needs a pin mark on the session handle (#33023). Until then an unpinned KAS chat keeps main's model behaviour, and the session gets one notice that names the kiro-cli default model and says how to pick it in Crew. Original author: Joe Guo (cherry picked from commit 04fbd9e)
Problem / Motivation
Goal: A KAS chat that does not start on the user's kiro-cli default model says so, names that model, and says how to pick it in Crew.
kiro-cli starts a chat on its
cli.jsonchat.defaultModelwhen nothing pins a model. KAS reads nocli.json, so on KAS an unpinned chat silently starts on KAS's own default instead (P1-37 in the kiro-cli -> KAS migration list).Why it matters
Users moving from kiro-cli to KAS lose their chosen default model with no sign of it. They see answers from a different model and do not know why or how to get theirs back.
Not a goal
chat.defaultModelonto the session. Four local review rounds each found a real defect where an inherited model becomes the session's pin. The last one was the engine-fallback promotion atacp/engine_fallback.py:468-469. A full carry needs the pin mark to live with the session handle; that design stays open in KAS ignores kiro-cli's chat.defaultModel #33023.What changed (motivation → approach → change)
Symptom: an unpinned KAS chat runs on KAS's default with no explanation. Root cause: KAS reads no
cli.json, and Crew does not yet carry the setting. Change, notice only:acp/kas_cli_settings.py:kiro_cli_default_modelreadschat.defaultModelthrough the same credential-gated reader as the telemetry opt-out. The workspace file wins, as in kiro-cli. A value that is not a plain model id, or an unreadable file, is skipped.default_model_noticebuilds the sentence.providers/acp_runtime_start.py: on a KAS cold start whose configured model is empty orauto, the setting is read off the event loop, and the notice is put on the new session provider (kas_default_model_notice). Nothing else on the start path changes: no model is sent, no pin is written, andengine_fallback.pyis untouched.providers/acp.py(kiro_cli_model_notice) anddashboard/chat_turn/turn_spec_hooks._notice_steer_upgrade: the notice is one more session-start row, shown once per new session, like the other KAS notices.docs/system-specs/modules/acp-client.md, new section "kiro-clichat.defaultModelon KAS".Backwards compatibility
Compatible: the only new behavior is a notice row on unpinned KAS chats whose kiro-cli settings name a default model. Model selection is unchanged.
Removes nothing: the diff adds a reader, a provider field and property, and a notice row.
Tests
test/test_acp_provider.py::test_an_unpinned_kas_start_names_kiro_cli_chat_default_model: an unpinned KAS start (empty orauto) records the notice and sends no model. A Crew pin, or the kiro backend, records none, and the pin still goes out as before.test/test_kas_cli_settings.py: the workspace file wins; bad values and unreadable files are skipped; the notice names the model and the picker; the notice reaches the session-start row.test/test_acp_bindings.py: the newkiro_cli_model_noticeproperty row.Proof: PROVEN test/test_acp_bindings.py::test_the_member_set_is_the_frozen_inventory (head a858c61)
Manual verification
N/A — unit coverage sufficient: the change is a notice string and the condition that records it, both asserted on the real start path and the real row function.
Related Issues
Part of #33023. That issue stays open for carrying the setting; the four review findings and every model reader and writer are listed in this comment.
Sibling sweep
Swept: git grep -n "chat.defaultModel" -- src/kiro_crew
Siblings: none -- kiro-cli reads its own cli.json, and no other Crew harness reads chat.defaultModel
Pattern harvest
Not generalizable: one setting that one engine does not read; the general carry problem is tracked in #33023.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.