Skip to content

fix(i18n): let each language place the repo name in the working-on line - #33344

Merged
bolichen97 merged 1 commit into
mainfrom
fix/33103-current-repo-trans
Nov 8, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/33103-current-repo-trans

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Every dashboard language can say which repository Auto Improvement is working on in its own word order.

Once a repository is connected, the Auto Improvement setup panel shows a line like "Working on owner/repo". The panel builds it by putting a translated "Working on" label in front of the repository name, so the name always comes last. Japanese, Korean, Hindi and Bengali put it first, and read in English word order there.

Why it matters

Anyone running the dashboard in one of those languages reads a broken phrase on the line that tells them which repository the loop will change.

Not a goal

What changed (motivation → approach → change)

The repository line in every language now reads as one phrase, with the name where that language puts it: "「owner/repo」で作業中" in Japanese, "owner/repo पर काम हो रहा है" in Hindi, and still "Working on owner/repo" in English.

The line was a translated label followed by the name, so no catalog could move the name. It is now one message, autoImprovement.currentRepoLine (Working on <repo/>), rendered with <Trans>. The name stays the slot's own child, never a translated value, so a repository name is shown exactly as stored. Every shipped catalog in website/src/i18n/locales/ carries the message, and the old autoImprovement.currentRepo label is gone.

Backwards compatibility

Compatible: the panel looks the same in English; only the catalog key behind the line changes.

Reader: website/src/apps/auto-improvement/SetupPanel.tsx:SetupPanel -- app -- reads autoImprovement.currentRepoLine in place of the removed autoImprovement.currentRepo, its only reader on origin/main; SetupPanel.coverage.test.tsx "puts the repo name where the language places it in the current-repo line"

Tests

  • SetupPanel.coverage.test.tsx "puts the repo name where the language places it in the current-repo line": gives Japanese a message that puts <repo/> first, and requires the rendered line to start with the repository name, still in its accent span. Run on the parent commit it fails with Received: "Working on owner/repopush disabled".
  • Determinism: the whole SetupPanel.coverage.test.tsx file passed 10 runs out of 10 with vitest run --sequence.shuffle, seeds 101, 202, ..., 1010.
  • The catalog parity, QA, pseudolocale and per-language style suites pass with the new message in all twelve catalogs, and npm run i18n:check against the merge base reports 0 findings.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Rendered the built dashboard with a scripted Playwright harness that serves the build over loopback and answers the API from fixtures (no gateway), with a connected repository, in English, Japanese, Korean and Hindi; each run asserts the line's text before the frame is taken. Korean is left out of the pictures because the capture host has no Hangul font, so its glyphs would not render; its line text asserted as ‘kirodotdev/KiroCrew’ 작업 중.

Screenshots / video

English, dark: the line is unchanged.

Auto Improvement setup panel in English showing "Working on kirodotdev/KiroCrew"

Japanese, dark: the repository name comes first.

Auto Improvement setup panel in Japanese with the repository name first

Hindi, light: the repository name comes first.

Auto Improvement setup panel in Hindi with the repository name first

Related Issues

Part of #33103

Sibling sweep

Swept: git grep -nE "{i18nT('[^']+')}:? <(span|strong|code|b)\b" -- website/src
Sibling: website/src/apps/issue-radar/views/settings/RepoSettings.tsx:419 -- tracked in #32029
Sibling: website/src/apps/issue-radar/components/IssueDetail.tsx:346 -- tracked in #33210
Sibling: website/src/apps/issue-radar/components/PrDetail.tsx:394 -- tracked in #33210
Sibling: website/src/apps/issue-radar/ConnectPanel.tsx:1017 -- tracked in #33069
Sibling: website/src/apps/issue-radar/views/settings/GeneralSettings.tsx:62 -- tracked in #33069
Sibling: website/src/apps/dev-fleet/DevFleetPageNotices.tsx:56 -- tracked in #33210
Sibling: website/src/apps/dev-fleet/DevFleetPageRow.tsx:100 -- not affected -- a field label before its value is a label and value row, not a sentence
Sibling: website/src/apps/crew-companion/PackEditor.tsx:631 -- not affected -- a section label followed by a separate optional tag, not one sentence
Sibling: website/src/apps/auto-research/ResearchLabPage.tsx:263 -- not affected -- a mode name followed by its own descriptor tag, not one sentence

Pattern harvest

Rule candidate: lint
Pattern: an i18nT() call followed by a JSX element in the same text run builds one sentence in English word order

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

The auto improvement setup panel built its current-repository line by
gluing a translated "Working on" label in front of the repository name,
so every language had to read in English word order. Korean, Japanese,
Hindi and other languages that put the object first could not say it
naturally.

Render the line from one message with a repo slot instead, so each
catalog decides where the name goes, and translate it in every shipped
language. The repository name stays a component child, never a
translated value.

Part of #33103
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 8, 2026 18:30
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 73c2424b40839dbd0bebea83655e66a04a6ded54 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (3 items) — 3 justified

Intent: A person using the dashboard in any language reads the "working on " line in that language's own word order. This is a FIX.

  1. The Auto Improvement line that names the repository now puts the name where each language puts it (first in Japanese, Korean and Hindi; unchanged in English) — justified
  2. The catalog key autoImprovement.currentRepo is replaced by autoImprovement.currentRepoLine in all twelve catalogs. It has one reader, and the old key has none left (0 hits for autoImprovement.currentRepo\b outside the catalogs) — justified
  3. A test that puts the repository name first in Japanese and checks the rendered line follows — justified

[FIRST-PRINCIPLES-REVIEWED] 73c2424

Description read

[DESCRIPTION-READ] 3eaecda7fa81218052241a0a9839d1f965d81bc11f16da501975953bd5b859f0

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 73c2424b40839dbd0bebea83655e66a04a6ded54 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The removed autoImprovement.currentRepo key had no reader besides SetupPanel, auto-improvement is not in the adoption pins, and the description includes rendered screenshots of this revision.

[DESIGN-REVIEWED] 73c2424

Description read

[DESCRIPTION-READ] 3bb76c4c4d3f510e3f4326a8bfced0faf3411e1cfe9d46afaeedde4dc5b1a198

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 73c2424b40839dbd0bebea83655e66a04a6ded54 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The only changed element, the "working on" repository line, appears in all three screenshots, and the blind reader read it the same way in English, Japanese and Hindi.

[UX-REVIEWED] 73c2424

Description read

[DESCRIPTION-READ] b62278e3bccb954d6838190b73106157f902025af99da3787dd61fd9b18766e5

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 73c2424b40839dbd0bebea83655e66a04a6ded54 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 73c2424

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 73c2424b40839dbd0bebea83655e66a04a6ded54 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 73c2424b40839dbd0bebea83655e66a04a6ded54 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 73c2424

Verdict parsed from the review's SHA-scoped output markers for commit 73c2424b40839dbd0bebea83655e66a04a6ded54.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 73c2424b40839dbd0bebea83655e66a04a6ded54 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 8, 2026 18:44
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 8, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed read-only at 73c2424: the working-on line becomes a Trans string with a repo slot, all locales updated, a test pins Japanese order. Approving.

@bolichen97
bolichen97 merged commit 7480905 into main Nov 8, 2026
98 checks passed
@bolichen97
bolichen97 deleted the fix/33103-current-repo-trans branch November 8, 2026 19:28
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
…ne (#33344)

The auto improvement setup panel built its current-repository line by
gluing a translated "Working on" label in front of the repository name,
so every language had to read in English word order. Korean, Japanese,
Hindi and other languages that put the object first could not say it
naturally.

Render the line from one message with a repo slot instead, so each
catalog decides where the name goes, and translate it in every shipped
language. The repository name stays a component child, never a
translated value.

Part of #33103

Original author: Bolin Chen
(cherry picked from commit 7480905)
KiroCrewCaptain added a commit to KiroCrewCaptain/kirocrew-app-auto-improvement that referenced this pull request Nov 13, 2026
Ports two wheel-copy fixes of the setup panel.

kirodotdev/KiroCrew#33128: the Clone button stays in the tab order
while a clone runs (aria-disabled instead of disabled), a second press
in the same tick starts no second clone, and a request that fails
outright is announced in an alert.

kirodotdev/KiroCrew#33344: the current-repository line is one message
with a <repo/> slot, translated in all 12 locales, so each language
places the repository name where its word order puts it. The bundle
has no react-i18next, so tSlot in ui/src/i18n.ts renders the slot.

Co-authored-by: KiroCrewCaptain <312312717+KiroCrewCaptain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants