Repository navigation
fix(i18n): let each language place the repo name in the working-on line - #33344
Conversation
The auto improvement setup panel built its current-repository line by gluing a translated "Working on" label in front of the repository name, so every language had to read in English word order. Korean, Japanese, Hindi and other languages that put the object first could not say it naturally. Render the line from one message with a repo slot instead, so each catalog decides where the name goes, and translate it in every shipped language. The repository name stays a component child, never a translated value. Part of #33103
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (3 items) — 3 justifiedIntent: A person using the dashboard in any language reads the "working on " line in that language's own word order. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 73c2424 Description read[DESCRIPTION-READ] 3eaecda7fa81218052241a0a9839d1f965d81bc11f16da501975953bd5b859f0 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The removed [DESIGN-REVIEWED] 73c2424 Description read[DESCRIPTION-READ] 3bb76c4c4d3f510e3f4326a8bfced0faf3411e1cfe9d46afaeedde4dc5b1a198 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The only changed element, the "working on" repository line, appears in all three screenshots, and the blind reader read it the same way in English, Japanese and Hindi. [UX-REVIEWED] 73c2424 Description read[DESCRIPTION-READ] b62278e3bccb954d6838190b73106157f902025af99da3787dd61fd9b18766e5 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
…ne (#33344) The auto improvement setup panel built its current-repository line by gluing a translated "Working on" label in front of the repository name, so every language had to read in English word order. Korean, Japanese, Hindi and other languages that put the object first could not say it naturally. Render the line from one message with a repo slot instead, so each catalog decides where the name goes, and translate it in every shipped language. The repository name stays a component child, never a translated value. Part of #33103 Original author: Bolin Chen (cherry picked from commit 7480905)
Ports two wheel-copy fixes of the setup panel. kirodotdev/KiroCrew#33128: the Clone button stays in the tab order while a clone runs (aria-disabled instead of disabled), a second press in the same tick starts no second clone, and a request that fails outright is announced in an alert. kirodotdev/KiroCrew#33344: the current-repository line is one message with a <repo/> slot, translated in all 12 locales, so each language places the repository name where its word order puts it. The bundle has no react-i18next, so tSlot in ui/src/i18n.ts renders the slot. Co-authored-by: KiroCrewCaptain <312312717+KiroCrewCaptain@users.noreply.github.com>
Problem / Motivation
Goal: Every dashboard language can say which repository Auto Improvement is working on in its own word order.
Once a repository is connected, the Auto Improvement setup panel shows a line like "Working on owner/repo". The panel builds it by putting a translated "Working on" label in front of the repository name, so the name always comes last. Japanese, Korean, Hindi and Bengali put it first, and read in English word order there.
Why it matters
Anyone running the dashboard in one of those languages reads a broken phrase on the line that tells them which repository the loop will change.
Not a goal
What changed (motivation → approach → change)
The repository line in every language now reads as one phrase, with the name where that language puts it: "「owner/repo」で作業中" in Japanese, "owner/repo पर काम हो रहा है" in Hindi, and still "Working on owner/repo" in English.
The line was a translated label followed by the name, so no catalog could move the name. It is now one message,
autoImprovement.currentRepoLine(Working on <repo/>), rendered with<Trans>. The name stays the slot's own child, never a translated value, so a repository name is shown exactly as stored. Every shipped catalog inwebsite/src/i18n/locales/carries the message, and the oldautoImprovement.currentRepolabel is gone.Backwards compatibility
Compatible: the panel looks the same in English; only the catalog key behind the line changes.
Reader: website/src/apps/auto-improvement/SetupPanel.tsx:SetupPanel -- app -- reads
autoImprovement.currentRepoLinein place of the removedautoImprovement.currentRepo, its only reader on origin/main; SetupPanel.coverage.test.tsx "puts the repo name where the language places it in the current-repo line"Tests
SetupPanel.coverage.test.tsx"puts the repo name where the language places it in the current-repo line": gives Japanese a message that puts<repo/>first, and requires the rendered line to start with the repository name, still in its accent span. Run on the parent commit it fails withReceived: "Working on owner/repopush disabled".SetupPanel.coverage.test.tsxfile passed 10 runs out of 10 withvitest run --sequence.shuffle, seeds 101, 202, ..., 1010.npm run i18n:checkagainst the merge base reports 0 findings.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Rendered the built dashboard with a scripted Playwright harness that serves the build over loopback and answers the API from fixtures (no gateway), with a connected repository, in English, Japanese, Korean and Hindi; each run asserts the line's text before the frame is taken. Korean is left out of the pictures because the capture host has no Hangul font, so its glyphs would not render; its line text asserted as
‘kirodotdev/KiroCrew’ 작업 중.Screenshots / video
English, dark: the line is unchanged.
Japanese, dark: the repository name comes first.
Hindi, light: the repository name comes first.
Related Issues
Part of #33103
Sibling sweep
Swept: git grep -nE "{i18nT('[^']+')}:? <(span|strong|code|b)\b" -- website/src
Sibling: website/src/apps/issue-radar/views/settings/RepoSettings.tsx:419 -- tracked in #32029
Sibling: website/src/apps/issue-radar/components/IssueDetail.tsx:346 -- tracked in #33210
Sibling: website/src/apps/issue-radar/components/PrDetail.tsx:394 -- tracked in #33210
Sibling: website/src/apps/issue-radar/ConnectPanel.tsx:1017 -- tracked in #33069
Sibling: website/src/apps/issue-radar/views/settings/GeneralSettings.tsx:62 -- tracked in #33069
Sibling: website/src/apps/dev-fleet/DevFleetPageNotices.tsx:56 -- tracked in #33210
Sibling: website/src/apps/dev-fleet/DevFleetPageRow.tsx:100 -- not affected -- a field label before its value is a label and value row, not a sentence
Sibling: website/src/apps/crew-companion/PackEditor.tsx:631 -- not affected -- a section label followed by a separate optional tag, not one sentence
Sibling: website/src/apps/auto-research/ResearchLabPage.tsx:263 -- not affected -- a mode name followed by its own descriptor tag, not one sentence
Pattern harvest
Rule candidate: lint
Pattern: an
i18nT()call followed by a JSX element in the same text run builds one sentence in English word orderChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.