Repository navigation
test: count the 140 lazy imports the server owners now hold - #33383
Conversation
#33088 and #29509 each added one entry to _LAZY_IMPORTS from the same 138 base and each raised the pin to 139, so the merge kept 139 while the table holds 140. The new entry, crewmate_harness_notice, is a deliberate in-function import that the table already records; only the count was stale, which turned a backend shard red on main.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a one-line test pin brought back in line with a table that already passes the matches-the-code assertion. [DESIGN-REVIEWED] 853217d Description read[DESCRIPTION-READ] 4a08e4987c10260ae4cdce0e98a1115c6dc43e5d9de464fc1fe5b3dda01811f5 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Thanks for the precise diagnosis. Main already has this change, so merging this PR would now do nothing. Leaving a note rather than a change request, since the code is correct.
The review also confirmed that the fix is correct. The Optional: #33203 moves the same pin to 141 for its own new entry. It needs a rebase onto the 140 pin that is now on main. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that raises the pinned lazy-import table size in test_dashboard_server_composition_contract.py from 139 to 140 to match the table on main.
Problem / Motivation
Goal:
mainpassestest_the_lazy_imports_stay_inside_the_functions_that_need_themagain, so the backend shard that runs it goes green on every PR.The test checks two things: every in-function import in the dashboard server's owners matches the
_LAZY_IMPORTStable, and the table holds a pinned number of names. #33088 and #29509 each started from 138 names, each added one entry to the table, and each raised the pin to 139. Both merged, so the table now holds 140 names while the pin says 139.mainfails withassert 140 == 139.Why it matters
Every PR into
mainfails that backend shard and the Coverage Gate after it, whatever it changes, while more PRs are landing.Not a goal
crewmate_harness_noticeout of its function. The import inconfig_watch._alarm_crewmate_harness_fallbackis the deliberate in-function kind the table records, and feat(crew): a Crew bot's harness follows Settings -> Agent Harness when unset #29509 already listed it there; the test's first assertion, that the table matches the code, passes.What changed (motivation → approach → change)
test_dashboard_server_composition_contract.py: the pin goes from 139 to 140, the size of the table both PRs left behind.Backwards compatibility
Compatible: test-only change; nothing shipped changes.
Removes nothing: no setting, route, key or caller is removed.
Tests
main0a53e02b65, and still on012380ad54: the test fails withassert 140 == 139.git bisectbetween6bdfdfabaa(pass) and0a53e02b65(fail) names3cd4522fe5(feat(crew): a Crew bot's harness follows Settings -> Agent Harness when unset #29509) as the first failing commit.test_dashboard_server_composition_contract.pywithtest_flake_pattern_ratchet.pygives 113 passed. flake8 is clean.Proof: not provable -- other: a test-only pin; the proof is the contract test passing on main with the new count
Manual verification
N/A — unit coverage sufficient: the change is a test constant.
Related Issues
Refs #29509, #33088
Sibling sweep
Swept:
grep -rn "assert len(expected) ==" test/for other count pins over a table two PRs could both growSibling: test/test_dashboard_server_composition_contract.py -- changed here
Sibling: test/test_memory_v2_facet_read.py -- not affected -- passes on main
012380ad54Sibling: test/test_source_corpus.py -- not affected -- passes on main
012380ad54Pattern harvest
Not generalizable: a merge race between two PRs that each raised the same pin; the pin itself caught it, as designed.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.