Skip to content

test: count the 140 lazy imports the server owners now hold - #33383

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
crew/slack/lazy-import-pin
Nov 8, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
crew/slack/lazy-import-pin

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: main passes test_the_lazy_imports_stay_inside_the_functions_that_need_them again, so the backend shard that runs it goes green on every PR.

The test checks two things: every in-function import in the dashboard server's owners matches the _LAZY_IMPORTS table, and the table holds a pinned number of names. #33088 and #29509 each started from 138 names, each added one entry to the table, and each raised the pin to 139. Both merged, so the table now holds 140 names while the pin says 139. main fails with assert 140 == 139.

Why it matters

Every PR into main fails that backend shard and the Coverage Gate after it, whatever it changes, while more PRs are landing.

Not a goal

What changed (motivation → approach → change)

  • test_dashboard_server_composition_contract.py: the pin goes from 139 to 140, the size of the table both PRs left behind.

Backwards compatibility

Compatible: test-only change; nothing shipped changes.

Removes nothing: no setting, route, key or caller is removed.

Tests

Proof: not provable -- other: a test-only pin; the proof is the contract test passing on main with the new count

Manual verification

N/A — unit coverage sufficient: the change is a test constant.

Related Issues

Refs #29509, #33088

Sibling sweep

Swept: grep -rn "assert len(expected) ==" test/ for other count pins over a table two PRs could both grow
Sibling: test/test_dashboard_server_composition_contract.py -- changed here
Sibling: test/test_memory_v2_facet_read.py -- not affected -- passes on main 012380ad54
Sibling: test/test_source_corpus.py -- not affected -- passes on main 012380ad54

Pattern harvest

Not generalizable: a merge race between two PRs that each raised the same pin; the pin itself caught it, as designed.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

#33088 and #29509 each added one entry to _LAZY_IMPORTS from the same
138 base and each raised the pin to 139, so the merge kept 139 while
the table holds 140. The new entry, crewmate_harness_notice, is a
deliberate in-function import that the table already records; only
the count was stale, which turned a backend shard red on main.
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 20:05
@buluoray
buluoray requested a review from tim-finnigan November 8, 2026 20:05
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 853217d3b9ee45403be77f953058de03a325786a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 853217d3b9ee45403be77f953058de03a325786a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 853217d3b9ee45403be77f953058de03a325786a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a one-line test pin brought back in line with a table that already passes the matches-the-code assertion.

[DESIGN-REVIEWED] 853217d

Description read

[DESCRIPTION-READ] 4a08e4987c10260ae4cdce0e98a1115c6dc43e5d9de464fc1fe5b3dda01811f5

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 853217d3b9ee45403be77f953058de03a325786a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 853217d

Verdict parsed from the review's SHA-scoped output markers for commit 853217d3b9ee45403be77f953058de03a325786a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 853217d3b9ee45403be77f953058de03a325786a false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 853217d3b9ee45403be77f953058de03a325786a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 853217d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 853217d3b9ee45403be77f953058de03a325786a false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Thanks for the precise diagnosis. Main already has this change, so merging this PR would now do nothing. Leaving a note rather than a change request, since the code is correct.

  1. test/test_dashboard_server_composition_contract.py:491: test: re-pin the server lazy-import count to 140 after #29509 #33377 merged the same edit, assert len(expected) == 139 to == 140, as commit 0bdd18d. The result on main is byte-identical to this PR. Line 491 on current main already reads assert len(expected) == 140, and the diff between main and this PR's head is empty for this file. So the goal, test_the_lazy_imports_stay_inside_the_functions_that_need_them passing on main again, is already met. Smallest fix: close this PR as a duplicate of test: re-pin the server lazy-import count to 140 after #29509 #33377. No code change is needed.

The review also confirmed that the fix is correct. The _LAZY_IMPORTS table at this head holds exactly 140 distinct names, and the table-equals-code assertion stays intact. The merge-race explanation (#29509 and #33088 each raised the pin from 138 to 139) and the bisect to 3cd4522 check out.

Optional: #33203 moves the same pin to 141 for its own new entry. It needs a rebase onto the 140 pin that is now on main.

@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 8, 2026 21:01

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that raises the pinned lazy-import table size in test_dashboard_server_composition_contract.py from 139 to 140 to match the table on main.

@KiroCrewCaptain
KiroCrewCaptain merged commit 89abe81 into main Nov 8, 2026
97 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the crew/slack/lazy-import-pin branch November 8, 2026 21:02
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants