Repository navigation
test: re-pin the server lazy-import count to 140 after #29509 - #33377
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a one-line test re-pin that matches a table change already on main, and the set check is unchanged. [DESIGN-REVIEWED] 9c77166 Description read[DESCRIPTION-READ] 969b9a5d7a04504fadf87d5b36082818277b7e67e8b35bdd63a1be9d9461594f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approve at 9c77166. This turns main green again.
Main has been red since 0a53e02. test_the_lazy_imports_stay_inside_the_functions_that_need_them fails with assert 140 == 139 on Backend Tests (3.12, 6) and Backend Tests (Windows) (6), and Coverage Gate fails closed behind them.
Cause: #29509 (3cd4522) added crewmate_harness_notice to the kiro_crew row of _LAZY_IMPORTS. The table now has 140 names, but the pinned count still says 139. The local == expected assert above it already passes, so the count line is the only stale part.
Checked: I put this one-line change on a fresh tree of current main and ran test/test_dashboard_server_composition_contract.py. All 45 tests passed.
Note: #33383 makes the same one-line change. This PR opened first, so it is the one to land. #33383 can close once this merges.
Problem / Motivation
Goal: Main's backend tests pass again after one merge grew the server's lazy-import table without moving the length pin.
Main CI at d60b8c9 is red on
test/test_dashboard_server_composition_contract.py::test_the_lazy_imports_stay_inside_the_functions_that_need_themwithassert 140 == 139(failing job).#29509 (3cd4522, "a Crew bot's harness follows Settings -> Agent Harness when unset") added
crewmate_harness_noticeto thekiro_crewrow of_LAZY_IMPORTS, so the table now lists 140 names, but the length pin still says 139.Why it matters
Every PR that merges main inherits this red test, so readiness goes red on PRs that did not cause it.
Not a goal
What changed (motivation → approach → change)
Stale pin → follows the table that already merged:
_LAZY_IMPORTSlength pin goes from 139 to 140. The name itself is already in the table (added by feat(crew): a Crew bot's harness follows Settings -> Agent Harness when unset #29509), so the set check is unchanged. Same shape as test(dashboard): count sweep_interrupted_updates in the server lazy-import pin #30984 and test: re-pin the lazy-import count and the monitor wake's turn start #32606.Backwards compatibility
Compatible: test-only; no runtime code changes.
Removes nothing: the change only moves one existing test pin to match code already on main.
Tests
Proof: not provable -- test-only change
pytest test/test_dashboard_server_composition_contract.py→ 45 passed on head 9c77166 (run against this branch'ssrc).