Skip to content

test: re-pin the server lazy-import count to 140 after #29509 - #33377

Merged
iamwhatever merged 1 commit into
mainfrom
test/repin-lazy-import-140
Nov 8, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
test/repin-lazy-import-140

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Main's backend tests pass again after one merge grew the server's lazy-import table without moving the length pin.

Main CI at d60b8c9 is red on test/test_dashboard_server_composition_contract.py::test_the_lazy_imports_stay_inside_the_functions_that_need_them with assert 140 == 139 (failing job).

#29509 (3cd4522, "a Crew bot's harness follows Settings -> Agent Harness when unset") added crewmate_harness_notice to the kiro_crew row of _LAZY_IMPORTS, so the table now lists 140 names, but the length pin still says 139.

Why it matters

Every PR that merges main inherits this red test, so readiness goes red on PRs that did not cause it.

Not a goal

  • Changing which imports the dashboard server makes lazily.

What changed (motivation → approach → change)

Stale pin → follows the table that already merged:

Backwards compatibility

Compatible: test-only; no runtime code changes.

Removes nothing: the change only moves one existing test pin to match code already on main.

Tests

Proof: not provable -- test-only change

pytest test/test_dashboard_server_composition_contract.py → 45 passed on head 9c77166 (run against this branch's src).

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 8, 2026 19:52
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 9c77166158375f05c5e80171edae0e53fcf25e17 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 9c77166158375f05c5e80171edae0e53fcf25e17 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 9c77166158375f05c5e80171edae0e53fcf25e17 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a one-line test re-pin that matches a table change already on main, and the set check is unchanged.

[DESIGN-REVIEWED] 9c77166

Description read

[DESCRIPTION-READ] 969b9a5d7a04504fadf87d5b36082818277b7e67e8b35bdd63a1be9d9461594f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 9c77166158375f05c5e80171edae0e53fcf25e17 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 9c77166

Verdict parsed from the review's SHA-scoped output markers for commit 9c77166158375f05c5e80171edae0e53fcf25e17.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 9c77166158375f05c5e80171edae0e53fcf25e17 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 9c77166158375f05c5e80171edae0e53fcf25e17 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9c77166

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 9c77166158375f05c5e80171edae0e53fcf25e17 false-positive: <reason, 20 to 500 characters>

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approve at 9c77166. This turns main green again.

Main has been red since 0a53e02. test_the_lazy_imports_stay_inside_the_functions_that_need_them fails with assert 140 == 139 on Backend Tests (3.12, 6) and Backend Tests (Windows) (6), and Coverage Gate fails closed behind them.

Cause: #29509 (3cd4522) added crewmate_harness_notice to the kiro_crew row of _LAZY_IMPORTS. The table now has 140 names, but the pinned count still says 139. The local == expected assert above it already passes, so the count line is the only stale part.

Checked: I put this one-line change on a fresh tree of current main and ran test/test_dashboard_server_composition_contract.py. All 45 tests passed.

Note: #33383 makes the same one-line change. This PR opened first, so it is the one to land. #33383 can close once this merges.

@buluoray
buluoray enabled auto-merge (squash) November 8, 2026 20:07
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@iamwhatever
iamwhatever disabled auto-merge November 8, 2026 20:41
@iamwhatever
iamwhatever merged commit 0bdd18d into main Nov 8, 2026
106 of 107 checks passed
@iamwhatever
iamwhatever deleted the test/repin-lazy-import-140 branch November 8, 2026 20:41
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants