Skip to content

feat(lts): turn Feature Previews and Debug tools off in the LTS edition - #33592

Merged
kyleseaman merged 1 commit into
mainfrom
feat/lts-previews-off
Nov 9, 2026
Merged

kyleseaman merged 1 commit into
mainfrom
feat/lts-previews-off

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: In the LTS edition, every Feature Preview is off and cannot be turned on, and Settings > Developer > Debug tools is hidden.

Today an LTS build shows every Feature Preview switch, and the gateway reads dashboard.feature_previews.<name> as stored. A flag can also be set in the browser (Developer > Storage, devtools), through the CLI, or by editing config. Debug tools (the scroll inspector overlay) is shown too.

Why it matters

LTS means long-term stable. A Feature Preview is a surface that ships before it is finished, and Debug tools are for people building Crew. The owner decided on 2026-11-09 that neither belongs in an LTS build. Hiding the switches alone would leave every other way to turn a preview on still open.

Not a goal

  • Changing the oss edition.
  • Hiding the other Developer pages. Logs, System, Telemetry, Storage, Memory, Config and Archive stay (see the review table below).
  • Hiding the other cards on the Feature Previews page: Automatic cards, Shared Crew, remote dispatch, the KAS engine, Decisions, Crewmates, default MCP sets and the desktop Gateway switch stay where they are.
  • The "App developer mode" control (capabilities.app_dev_mode), which stays off as before.
  • Deleting stored preview values. The gateway's copy is kept, and an oss build reads it as before.

What changed (motivation → approach → change)

Owner decision → enforce where flags are read, on both sides, not only by hiding the switches → one pull request with the RFC amendment and the code.

Gateway. edition_locks gains two locked controls, feature_previews and debug_tools, and a helper feature_previews() that answers {} in LTS. Every server reader of a preview goes through it: connections/crew_oauth.enabled, crew_mode.mate_sessions_hidden, dashboard_agentic.stale_fields_enabled, dashboard/stale_wake.switch_state and session_harness_preview.session_harness_enabled. config_path_locked covers dashboard.feature_previews and every path under it. So PATCH /api/config/kirocrew refuses a preview path with 409 locked_by_policy, a change card refuses to offer one, and GET /api/config/schema marks every preview path lockedByPolicy. GET and every PATCH reply share one body builder, _config_body. In LTS it reports the previews off and lists locked_controls: ["debug_tools"], a field only an LTS build sends; Debug tools has no config path, so this field is how the dashboard learns of it.

Dashboard. The new file utils/editionLocks.ts holds the locked controls, and keeps a browser cache of them for the first paint. usePreviewFlagServerSync takes the preview lock from the schema's lockedByPolicy and the Debug tools lock from locked_controls; a read that has not answered keeps its control as it is. In LTS, readPreviewFlag answers off, and setPreviewFlag and cachePreviewFlag refuse. A browser key still saying on is removed. The Feature Previews page drops every preview card, their "See what it looks like" intros, the section caveat and the edition rows. Settings search offers no preview card. Debug tools leaves the rail, /developer?tab=debug-tools and /settings/developer/debug-tools land on the first page, and the scroll inspector reads off. Debug tools has no gateway route, so that part is a dashboard check only. Milestones sit behind the Explore preview, so they are out of reach in LTS; the owner accepted that because the feature is not finished.

Files: src/kiro_crew/edition_locks.py, src/kiro_crew/connections/crew_oauth.py, src/kiro_crew/crew_mode.py, src/kiro_crew/dashboard_agentic.py, src/kiro_crew/dashboard/stale_wake.py, src/kiro_crew/session_harness_preview.py, src/kiro_crew/dashboard/change_cards.py, src/kiro_crew/dashboard/handlers/core.py, docs/system-specs/modules/platform-context.md, src/kiro_crew/dashboard/handlers/core_config_view.py, src/kiro_crew/dashboard/handlers/core_config_patch.py, src/kiro_crew/dashboard/change_cards_settings.py, src/kiro_crew/docs/configuration.md (the dashboard.feature_previews row says LTS reads it off), website/src/utils/editionLocks.ts, website/src/utils/previewFlags.ts, website/src/hooks/usePreviewFlag.ts, website/src/hooks/usePreviewFlagServerSync.ts, website/src/dev/scrollInspector.ts, website/src/components/commandPalette/settingsSearchCore.ts, website/src/pages/DeveloperPage.tsx, website/src/pages/settings/DeveloperPanel.tsx, website/src/pages/settings/FeaturePreviewsSection.tsx, website/src/pages/settings/developerSubs.ts. docs/request-for-change/rfc-crew-lts-edition.md records this as D12, updates the 2026-11-05 milestones note, and adds a decision-log entry.

Developer sub-tabs in LTS

Developer sub-tab LTS
Feature Previews kept; every preview card and intro removed
Logs kept: read-only log viewer for diagnosing a fault
System kept: read-only health view
Telemetry kept: shows what is collected; D3's endpoint lock already governs sending
Storage kept (owner); a changed mc-preview-* key is harmless, pinned by a test
Memory kept: read-only view of this machine's memory
Config kept: writes go through the config PATCH, which refuses preview paths
Debug tools off (owner): hidden, old link lands on the first page, inspector reads off
Archive kept: the user's own history

Backwards compatibility

Compatible: the oss edition is unchanged. The config GET and PATCH bodies are byte-identical there, with no locked_controls field. No LTS build has shipped. In an LTS build, preview switches that were on read off; their stored values stay in config.

Tests

  • test/test_lts_feature_previews_off.py: in LTS, every server reader reads off with every switch stored on, and in oss they follow the switch. The PATCH refuses every preview path with 409 and writes nothing. GET and a PATCH reply both report the previews off and list only debug_tools; the oss GET carries no locked_controls. A change card (both resolve_setting and setting_spec) refuses a preview path in LTS and offers it in oss.
  • test/test_lts_unkeyed_locks.py: the schema marks the preview paths lockedByPolicy in LTS.
  • website/src/test/ltsFeaturePreviewsOff.test.tsx: the preview lock comes from the schema, not the config body, and a read that has not answered keeps the other's lock. In LTS every flag reads off with the cache saying on, and every write is refused with nothing sent to the gateway. An open switch turns off when the lock arrives. A key flipped in Developer > Storage or devtools turns nothing on, and deleting the lock cache in Storage does not unlock the page. A stale key is cleared, and lifting the lock puts readers back on their value. The page keeps its sub-tab and other cards but has no preview card or intro. Settings search offers no preview card, and every id in that list exists in the registry. Debug tools leaves the rail, its page path heals, the old link lands on the default page, and the inspector stays off. The oss edition is unchanged.

Manual verification

Captured with scripted Playwright against an isolated loopback gateway built from this branch. The LTS frames were captured before the lock signal moved to the schema; they rewrite the config read to carry the lock list and previews {}. The rendered page is the same, and the unit tests pin the schema path. The prerequisite gate is stubbed ready, because this host has no OS sandbox.

Screenshots

oss (unchanged): Debug tools listed, preview cards shown.

oss

LTS: no Debug tools, no preview cards; Automatic cards, Shared Crew, remote dispatch, KAS engine and Decisions stay.

lts

LTS: /developer?tab=debug-tools lands on the Developer tab's first page.

lts debug tools link

Issue link

Closes #33523

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 9, 2026 02:04
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2f7ce80ef6c722eb4511b65425a37636dcea6c56 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. Every server reader of a preview now goes through edition_locks.feature_previews, writes are refused at the PATCH and change-card seams, and the oss edition is unchanged.

Notes

  • Debug tools is locked only in the dashboard. The description says so, and since it has no gateway route that is enough. A future preview reader must call feature_previews(), or it will quietly read the stored value in LTS. A test that greps for direct .dashboard.feature_previews reads would keep that seam from being bypassed.

[DESIGN-REVIEWED] 2f7ce80

Description read

[DESCRIPTION-READ] ad49020715746183a8e36834cd88df5e665f3af616e5789512b268ebd6982092

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@iamwhatever overrode this lane for 2f7ce80ef6c722eb4511b65425a37636dcea6c56 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 2f7ce80ef6c722eb4511b65425a37636dcea6c56 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the change only removes controls, and the screenshots show the oss page before, the LTS page after, and the old Debug tools link landing on the first page.

Notes

  • In LTS the "Feature Previews" sub-tab still has its name but holds no Feature Preview. The blind reader saw shot-01 and shot-02 as "the same page… but the list underneath is completely different… Nothing on screen says why." A follow-up could rename the tab for LTS so the name matches what is left on it (Automatic cards, Shared Crew, remote dispatch, KAS engine, Decisions).

[UX-REVIEWED] 2f7ce80

Description read

[DESCRIPTION-READ] 80d59f414e7c17cb369684c0c428e2648520e05efc4475905aa4cf0405098d68

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2f7ce80ef6c722eb4511b65425a37636dcea6c56 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2f7ce80

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2f7ce80ef6c722eb4511b65425a37636dcea6c56 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2f7ce80ef6c722eb4511b65425a37636dcea6c56 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2f7ce80

Verdict parsed from the review's SHA-scoped output markers for commit 2f7ce80ef6c722eb4511b65425a37636dcea6c56.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2f7ce80ef6c722eb4511b65425a37636dcea6c56 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 9, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-previews-off branch from 543af9a to bfd444d Compare November 9, 2026 05:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-previews-off branch from bfd444d to c25adf3 Compare November 9, 2026 06:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-previews-off branch from c25adf3 to 4e85b9a Compare November 9, 2026 08:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 9, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-previews-off branch from 4e85b9a to 159d8ec Compare November 9, 2026 13:08
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-previews-off branch from 159d8ec to 5262a77 Compare November 9, 2026 14:05
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
An LTS build ships no Feature Preview (RFC rfc-crew-lts-edition D12):

- Gateway: every server reader of dashboard.feature_previews (crew_oauth,
  mate sessions, out-of-date dashboard fields) takes it through
  edition_locks.feature_previews, which answers {} in LTS. The config PATCH
  refuses a preview path with locked_by_policy (409), and a change card
  does not offer one. The config schema marks every preview path
  lockedByPolicy. The config read and every PATCH reply share one body
  builder, report the previews off, and list locked_controls
  ["debug_tools"], a field only an LTS build sends.
- Dashboard: utils/editionLocks.ts holds the locked controls: previews
  from the schema's lockedByPolicy, Debug tools from locked_controls.
  readPreviewFlag reads every flag off and setPreviewFlag /
  cachePreviewFlag refuse, so a key flipped in Developer > Storage or
  devtools turns nothing on. The Feature Previews page keeps its other
  cards but draws no preview card or intro, and Settings search offers
  none.
- Debug tools is hidden: its rail item goes, an old
  /developer?tab=debug-tools link lands on the first page, and the scroll
  inspector reads off. It has no gateway route.

Milestones sit behind the Explore preview, so they are out of reach in LTS;
the owner accepted that because the feature is not finished. The oss
edition is unchanged.

Closes #33523
@iamwhatever
iamwhatever force-pushed the feat/lts-previews-off branch from 5262a77 to 2f7ce80 Compare November 9, 2026 15:32
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Owner decision (2026-11-09): the LTS edition turns Feature Previews and Debug tools off, recorded as RFC D12. Milestones stay out of LTS because the feature is unfinished; Developer > Storage stays. I chose to land the RFC record and the code together in this one PR.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 2f7ce80 owner-decision: the owner decided that LTS turns Feature Previews and Debug tools off (RFC D12) and chose to land the RFC record and the code in one PR: #33592 (comment)

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 2f7ce80ef6c722eb4511b65425a37636dcea6c56.

the owner decided that LTS turns Feature Previews and Debug tools off (RFC D12) and chose to land the RFC record and the code in one PR: #33592 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@kyleseaman
kyleseaman merged commit ad55351 into main Nov 9, 2026
103 of 113 checks passed
@kyleseaman
kyleseaman deleted the feat/lts-previews-off branch November 9, 2026 17:49
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LTS: turn Feature Previews and Debug tools off

2 participants