Repository navigation
feat(lts): turn Feature Previews and Debug tools off in the LTS edition - #33592
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Every server reader of a preview now goes through Notes
[DESIGN-REVIEWED] 2f7ce80 Description read[DESCRIPTION-READ] ad49020715746183a8e36834cd88df5e665f3af616e5789512b268ebd6982092 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the change only removes controls, and the screenshots show the oss page before, the LTS page after, and the old Debug tools link landing on the first page. Notes
[UX-REVIEWED] 2f7ce80 Description read[DESCRIPTION-READ] 80d59f414e7c17cb369684c0c428e2648520e05efc4475905aa4cf0405098d68 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
543af9a to
bfd444d
Compare
bfd444d to
c25adf3
Compare
c25adf3 to
4e85b9a
Compare
4e85b9a to
159d8ec
Compare
159d8ec to
5262a77
Compare
An LTS build ships no Feature Preview (RFC rfc-crew-lts-edition D12):
- Gateway: every server reader of dashboard.feature_previews (crew_oauth,
mate sessions, out-of-date dashboard fields) takes it through
edition_locks.feature_previews, which answers {} in LTS. The config PATCH
refuses a preview path with locked_by_policy (409), and a change card
does not offer one. The config schema marks every preview path
lockedByPolicy. The config read and every PATCH reply share one body
builder, report the previews off, and list locked_controls
["debug_tools"], a field only an LTS build sends.
- Dashboard: utils/editionLocks.ts holds the locked controls: previews
from the schema's lockedByPolicy, Debug tools from locked_controls.
readPreviewFlag reads every flag off and setPreviewFlag /
cachePreviewFlag refuse, so a key flipped in Developer > Storage or
devtools turns nothing on. The Feature Previews page keeps its other
cards but draws no preview card or intro, and Settings search offers
none.
- Debug tools is hidden: its rail item goes, an old
/developer?tab=debug-tools link lands on the first page, and the scroll
inspector reads off. It has no gateway route.
Milestones sit behind the Explore preview, so they are out of reach in LTS;
the owner accepted that because the feature is not finished. The oss
edition is unchanged.
Closes #33523
5262a77 to
2f7ce80
Compare
|
Owner decision (2026-11-09): the LTS edition turns Feature Previews and Debug tools off, recorded as RFC D12. Milestones stay out of LTS because the feature is unfinished; Developer > Storage stays. I chose to land the RFC record and the code together in this one PR. |
|
/ai-review override first-principles 2f7ce80 owner-decision: the owner decided that LTS turns Feature Previews and Debug tools off (RFC D12) and chose to land the RFC record and the code in one PR: #33592 (comment) |
Human judgment recorded@iamwhatever recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: In the LTS edition, every Feature Preview is off and cannot be turned on, and Settings > Developer > Debug tools is hidden.
Today an LTS build shows every Feature Preview switch, and the gateway reads
dashboard.feature_previews.<name>as stored. A flag can also be set in the browser (Developer > Storage, devtools), through the CLI, or by editing config. Debug tools (the scroll inspector overlay) is shown too.Why it matters
LTS means long-term stable. A Feature Preview is a surface that ships before it is finished, and Debug tools are for people building Crew. The owner decided on 2026-11-09 that neither belongs in an LTS build. Hiding the switches alone would leave every other way to turn a preview on still open.
Not a goal
ossedition.capabilities.app_dev_mode), which stays off as before.ossbuild reads it as before.What changed (motivation → approach → change)
Owner decision → enforce where flags are read, on both sides, not only by hiding the switches → one pull request with the RFC amendment and the code.
Gateway.
edition_locksgains two locked controls,feature_previewsanddebug_tools, and a helperfeature_previews()that answers{}in LTS. Every server reader of a preview goes through it:connections/crew_oauth.enabled,crew_mode.mate_sessions_hidden,dashboard_agentic.stale_fields_enabled,dashboard/stale_wake.switch_stateandsession_harness_preview.session_harness_enabled.config_path_lockedcoversdashboard.feature_previewsand every path under it. SoPATCH /api/config/kirocrewrefuses a preview path with409 locked_by_policy, a change card refuses to offer one, andGET /api/config/schemamarks every preview pathlockedByPolicy. GET and every PATCH reply share one body builder,_config_body. In LTS it reports the previews off and listslocked_controls: ["debug_tools"], a field only an LTS build sends; Debug tools has no config path, so this field is how the dashboard learns of it.Dashboard. The new file
utils/editionLocks.tsholds the locked controls, and keeps a browser cache of them for the first paint.usePreviewFlagServerSynctakes the preview lock from the schema'slockedByPolicyand the Debug tools lock fromlocked_controls; a read that has not answered keeps its control as it is. In LTS,readPreviewFlaganswers off, andsetPreviewFlagandcachePreviewFlagrefuse. A browser key still saying on is removed. The Feature Previews page drops every preview card, their "See what it looks like" intros, the section caveat and the edition rows. Settings search offers no preview card. Debug tools leaves the rail,/developer?tab=debug-toolsand/settings/developer/debug-toolsland on the first page, and the scroll inspector reads off. Debug tools has no gateway route, so that part is a dashboard check only. Milestones sit behind the Explore preview, so they are out of reach in LTS; the owner accepted that because the feature is not finished.Files:
src/kiro_crew/edition_locks.py,src/kiro_crew/connections/crew_oauth.py,src/kiro_crew/crew_mode.py,src/kiro_crew/dashboard_agentic.py,src/kiro_crew/dashboard/stale_wake.py,src/kiro_crew/session_harness_preview.py,src/kiro_crew/dashboard/change_cards.py,src/kiro_crew/dashboard/handlers/core.py,docs/system-specs/modules/platform-context.md,src/kiro_crew/dashboard/handlers/core_config_view.py,src/kiro_crew/dashboard/handlers/core_config_patch.py,src/kiro_crew/dashboard/change_cards_settings.py,src/kiro_crew/docs/configuration.md(thedashboard.feature_previewsrow says LTS reads it off),website/src/utils/editionLocks.ts,website/src/utils/previewFlags.ts,website/src/hooks/usePreviewFlag.ts,website/src/hooks/usePreviewFlagServerSync.ts,website/src/dev/scrollInspector.ts,website/src/components/commandPalette/settingsSearchCore.ts,website/src/pages/DeveloperPage.tsx,website/src/pages/settings/DeveloperPanel.tsx,website/src/pages/settings/FeaturePreviewsSection.tsx,website/src/pages/settings/developerSubs.ts.docs/request-for-change/rfc-crew-lts-edition.mdrecords this as D12, updates the 2026-11-05 milestones note, and adds a decision-log entry.Developer sub-tabs in LTS
mc-preview-*key is harmless, pinned by a testBackwards compatibility
Compatible: the
ossedition is unchanged. The config GET and PATCH bodies are byte-identical there, with nolocked_controlsfield. No LTS build has shipped. In an LTS build, preview switches that were on read off; their stored values stay in config.Tests
test/test_lts_feature_previews_off.py: in LTS, every server reader reads off with every switch stored on, and inossthey follow the switch. The PATCH refuses every preview path with 409 and writes nothing. GET and a PATCH reply both report the previews off and list onlydebug_tools; theossGET carries nolocked_controls. A change card (bothresolve_settingandsetting_spec) refuses a preview path in LTS and offers it inoss.test/test_lts_unkeyed_locks.py: the schema marks the preview pathslockedByPolicyin LTS.website/src/test/ltsFeaturePreviewsOff.test.tsx: the preview lock comes from the schema, not the config body, and a read that has not answered keeps the other's lock. In LTS every flag reads off with the cache saying on, and every write is refused with nothing sent to the gateway. An open switch turns off when the lock arrives. A key flipped in Developer > Storage or devtools turns nothing on, and deleting the lock cache in Storage does not unlock the page. A stale key is cleared, and lifting the lock puts readers back on their value. The page keeps its sub-tab and other cards but has no preview card or intro. Settings search offers no preview card, and every id in that list exists in the registry. Debug tools leaves the rail, its page path heals, the old link lands on the default page, and the inspector stays off. Theossedition is unchanged.Manual verification
Captured with scripted Playwright against an isolated loopback gateway built from this branch. The LTS frames were captured before the lock signal moved to the schema; they rewrite the config read to carry the lock list and previews
{}. The rendered page is the same, and the unit tests pin the schema path. The prerequisite gate is stubbed ready, because this host has no OS sandbox.Screenshots
oss(unchanged): Debug tools listed, preview cards shown.LTS: no Debug tools, no preview cards; Automatic cards, Shared Crew, remote dispatch, KAS engine and Decisions stay.
LTS:
/developer?tab=debug-toolslands on the Developer tab's first page.Issue link
Closes #33523