Skip to content

feat: add a Home and side list to the Artifacts page on desktop - #34776

Merged
dodgeblaster merged 1 commit into
mainfrom
feat/artifacts-page
Nov 16, 2026
Merged

dodgeblaster merged 1 commit into
mainfrom
feat/artifacts-page

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a desktop, the Artifacts page opens on a Home that separates what you made or kept from session output that cleanup will remove, with a side list for folders and cards that line up.

The page mixes deliberate work with what sessions produced as a by-product (auto-saved widgets, images, unsaved files), and nothing on screen tells them apart. A folder card previews its contents, so it reads like a document. The masonry gallery's uneven card heights make the library hard to scan, and nothing says that unstarred output is cleared once there are more than 200.

Why it matters

Most of a typical library is output nobody chose to keep. Without a visible split, a person cannot see what will survive, and the few things they made on purpose are buried among chat by-products.

Not a goal

  • The phone layout. It keeps today's folder cards, masonry and split button; moving it to All artifacts with a folder picker, and retiring those pieces, is the follow-up named in feat: Artifacts page Home and side list on desktop #34774.
  • Changing what cleanup deletes or its 200 cap.
  • Canvas or other new artifact kinds.

What changed (motivation → approach → change)

A side list on desktop picks what the page shows: Home, All artifacts, or one folder from the tree. The choice rides the URL (?scope=all, ?folder=<id>, nothing for Home), and every entry accepts a dragged card.

Area Change
Home (ArtifactsPageHome.tsx) Recent lists what was made or kept; Recent output lists what cleanup could remove plus unsaved session documents, with "N of 200" and a star to keep each. Gallery stacks them; Table puts them side by side.
Cards All artifacts and a folder draw the same equal-height cards as Home, at most four a row, in place of the masonry on desktop. A card keeps what the masonry card showed (the publication mark, the live public-web link, a sync failure, the description and the tags, each on one line when present) and holds two controls: the star and a ⋯ menu with pop-out and remove. Home's table rows carry the publication mark and the live link. A preview loads only near the viewport, and a preview whose content cannot be read says so through ErrorNotice rather than drawing blank. The kind is a small shared KindPill, also used in the library table.
Create (ArtifactsPageQuickCreate.tsx) A Doc tile under the title, with New folder and Import in a more-ways-to-add menu beside it, replaces the desktop split button and New folder button, and file into the selected folder in either view (useArtifactsPageCreate.ts).
Side list (ArtifactsPageSideNav.tsx) Home, All artifacts with a count, the folder tree with direct counts, rename/move/colour/delete through the existing folder menu. A folder row has two controls: the folder button, which opens and expands it (and collapses it when already open), and its menu. A rename draws its field only where it was opened, so a folder shown in both the side list and the main column keeps one editor.
API (library_reads.py, types/index.artifacts.ts) GET /api/artifacts marks each record sweepable with the sweep's own _is_sweepable_auto_widget, and returns output_cap. Home reads the split from the server, so a tag, comment, folder or edit keeps a record off Recent output exactly as it keeps it from the sweep.
UI locations artifacts.new names the Doc tile and artifacts.add-menu the menu trigger, with artifacts.new-folder and artifacts.import under it; a phone's New artifact button is artifacts.new-mobile, sharing the search terms, so the phone keeps a registered placement. artifacts.list moves to one region around every view, each card carries its guide pick, and Home reports the picker available whenever the library holds a record, so "choose the artifact" guides find their target on desktop. A guide that picks an artifact opens All artifacts, and an artifact already open stays open (guide/guideActions.ts alreadyAt counts a sub-route as already there). The index (ui-index.generated.json) and guide plans (guidePlans.gen.ts) are regenerated.
i18n (website/src/i18n/locales/, en.context.json) New strings in every catalog and translator context for the short labels.

A folder move refetches the artifact lists (hooks/useArtifactFolders.ts), since the server re-derives sweepable from the folder. ArtifactMiniThumb moves to components/library/ArtifactThumbs.tsx so the folder cards and Home share it. docs/system-specs/modules/artifacts.md documents the layout and the two list fields, and the Artifact library row in docs/feature-map/README.md names the new owners and fields.

Backwards compatibility

Compatible: sweepable and output_cap are added fields; an older client ignores them and an older gateway's list leaves Home counting with no cap.

Reader: website/src/pages/ArtifactsPage.tsx:desktop split button and New folder button -- entry: crew page -- the Doc tile, the more-ways-to-add menu (New folder, Import) and the side list's + run the same handlers, and artifacts.add-menu / artifacts.import keep their ids; ArtifactsPage.narrowHeader.test.tsx and ArtifactsPageCoverage.test.tsx cover them.
Reader: website/src/pages/ArtifactsPageGallery.tsx:LibraryMasonry artifacts.list marker -- entry: crew page -- the marker moves to the page's list region, which encloses the masonry on a phone and Home or the card grid on desktop; ArtifactsPage.home.test.tsx pins the region around Home.
Reader: website/src/pages/ArtifactsPage.tsx:desktop root folder cards and masonry -- entry: crew page -- the side list lists the folders and the card grid lists the artifacts; the phone keeps both, and the suites that pin them run on the phone layout.

Tests

  • ArtifactsPage.home.test.tsx (new): Home splits on sweepable; output shows "N of 200" and falls back without a cap; starring keeps an output without opening it; Table puts the groups side by side; no Starred filter on Home; the side list opens a folder and All artifacts lists every record flat; Home sits inside the artifacts.list region and offers a pick when every record is filed (red with the old root-scoped count); a preview that cannot be read shows its error; a card folds pop-out and remove into its ⋯ menu and keeps the publication mark, description and tags; a side-list rename stays open while the folder also shows in the table (red with one shared rename state, green with the fix).
  • ArtifactsPage.liveLink.test.tsx runs once on the phone layout and once on desktop, where it covers the card grid and Home's table rows; the desktop half fails with the live link removed from the new card.
  • test_artifacts_list_sweepable.py (new): the list flags only unclaimed auto-registered records with the sweep's own verdict, and reports the cap.
  • Desktop tests for the old controls now assert the tiles, the Home heading, the card grid in page flow, and creating a folder inside the selected one. Suites pinning the folder-card browse layout run on the phone layout, where it still ships.

Proof: not provable -- frontend test (prove.py runs Python only)

Local: tsc, eslint, jscpd and the restyle ratchet clean; 1,934 frontend tests (Artifacts page, UI locations, i18n, library components) and 465 find_ui tests pass.

Manual verification

Ran the branch in a pod with seeded artifacts and folders: Home in Gallery and Table, a folder, All artifacts, starring an output, and New doc filing into the open folder.

Screenshots / video

Same pod and data; before is main's frontend, after is this branch.

Before After
Desktop, gallery (opens on Home) before gallery after gallery, create menu open
Desktop, table before table after table
All artifacts before all after all, card menu open
A folder — after folder selected
Phone (unchanged by design) before phone after phone

The table above was taken on an earlier head, eb143a694a, before the Recent output warning was reworded. Those shots still show the gallery's create menu (New folder, Import from a file) and a card's menu (Pop out, Remove from library), but their warning line is the old wording. The shots below show what this head ships.

On this head (68640b920d), real pod gateway, 1440×900 at 2×:

Empty library: both Home empty states, "No folders yet", and the warning "Unstarred output is deleted once there are more than 200 (0 now). Star one to keep it."
01-home-empty

Side list, New folder open (name field and colours).
02-new-folder-open

Home with items in both groups. The warning reads "Unstarred output is deleted once there are more than 200 (4 now). Star one to keep it."
03-home-capped

Side list, a folder's ⋯ menu open (Rename, Move to folder, Color, Delete).
04-folder-menu-open

Side list, folder rename open.
05-folder-rename-open

A card whose preview failed: "Couldn't load this preview" with "Ask the agent".
06-preview-failed

How the data was made: the sample artifacts were created through the pod's POST /api/artifacts; four of them were then marked as session output in their stored record so Recent output has items. For shot 06, the browser fulfilled that one artifact's detail request with a 500 so the error tile renders; every other request went to the pod.

Related Issues

Closes #34774

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@dodgeblaster
dodgeblaster requested review from a team and KiroCrewCaptain as code owners November 10, 2026 20:23
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 10, 2026
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 68640b920d090d8d2daeebf39c70819839ef79a8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the screenshots cover this revision, the new fields are additive, and Home gets its split from the sweep's own check.

Notes

  • alreadyAt now treats any sub-route as "already there", whatever its query, for every guide, not only Artifacts. Today only /artifacts/:slug is affected. A future route like /x?tab=y that has /x/<id> pages would stop navigating to the tab, so the test should pin which routes this applies to.

[DESIGN-REVIEWED] 68640b9

Description read

[DESCRIPTION-READ] eced50f34db0ef577b6ba272fcede72ea3418be6b4af4f1870525c830b0e369a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 68640b920d090d8d2daeebf39c70819839ef79a8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the blind reader read Home, All artifacts, the folder rows, the Doc tile, the ⋯ add menu, the star and "Recent output" the way the diff means them, and every new control appears in a screenshot.

Notes

  • Shots 02, 04 and 06 show a subtitle that is no longer in this diff ("10 of 200 before the oldest clear"); the shipped recent_output_subtitle_cap appears only in shot 12. Replace those three shots with ones taken at the current HEAD so the description matches what ships.
  • Side-list counts are direct-only, so a folder that holds only subfolders shows "one 0" while its card says "1 artifact · 1 folder". The reader called this "contradictory". Count the contents of subfolders too, or show the subfolder count next to the folder.
  • The reader could not say what decides whether something lands in "Recent" or "Recent output". Rewrite recent_subtitle "Things you made or kept" to say it: e.g. "Starred, filed, tagged or edited by you".

[UX-REVIEWED] 68640b9

Description read

[DESCRIPTION-READ] 4deafbb827276d20358fef79a31bcb211a359c59064522887adb9ce75f1aadf0

That sha256 names everything this verdict read: the PR description, plus the 18 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for 68640b920d090d8d2daeebf39c70819839ef79a8 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 68640b920d090d8d2daeebf39c70819839ef79a8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 68640b9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 68640b920d090d8d2daeebf39c70819839ef79a8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 68640b920d090d8d2daeebf39c70819839ef79a8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 68640b9

Verdict parsed from the review's SHA-scoped output markers for commit 68640b920d090d8d2daeebf39c70819839ef79a8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 68640b920d090d8d2daeebf39c70819839ef79a8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 10, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=8170a41ca5de Desktop views lose the artifacts.list guide target

fixed in 8384038: artifacts.list (with the your_artifacts aria-label) moved off LibraryMasonry onto one page region that encloses Home, the card grid, the masonry and the table, so one render site serves every view. Each ArtifactCard root carries guidePick(a.name, …). ArtifactsPage.home.test.tsx pins Home inside the region.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=50fbf833defc A folder in both the side list and the main column cannot be renamed

fixed in 8384038: the rename state records the site that opened it (nav or main); the side list gets its own FolderActions copy and the tree rows and folder cards another, each drawing the editor only for its own site. A new test renames from the side list while the folder shows as a table row: red with one shared rename state, green with the fix.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=047e70333dc6 Quick-create row holds three peer buttons

fixed in 8384038: the row is Doc and Folder tiles plus a more-ways-to-add overflow trigger whose menu holds Import from a file, so artifacts.add-menu and artifacts.import (menu-item) keep main's ids.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=d9910c9f94b2 Library card row holds three icon buttons

fixed in 8384038: a card holds the star and one ⋯ DropdownMenu trigger with Pop out and Remove; a test opens the menu and finds both items.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=6a209bfe0df4 Recent output subtitle is cut off

fixed in 8384038: GroupHeading's subtitle no longer truncates; it wraps, so "N of 200 before the oldest clear" stays readable in the half-width table column.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=fdae0e3fe5db Missing rendered evidence

fixed: before/after screenshots of desktop Home (gallery and table), All artifacts, a folder and the phone width are attached in the description, taken from this branch in a pod with seeded data.

@KiroCrewCaptain

KiroCrewCaptain commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 20% chance that this change introduces a defect, above the 12% limit for approving on its own.

The desktop Artifacts page gets a side list (Home / All artifacts / folder tree) and a Home view split into Recent and Recent output. The backend marks each record sweepable by calling the sweep's own predicate, which is cheap (it only stats a sidecar for auto-registered records), and reports output_cap, the 200 that prune_auto_widgets keeps. Both fields are additive and covered by a new backend test. State checks hold up. Home reads the unfiltered all-tags query. pinMut invalidates ['artifacts'], so a starred output moves once the server re-derives the flag. The folder-move refetch is now unconditional, and the stateful moveUndo mock was updated for it. On a phone, openFolder still goes to the bare URL; on desktop it goes to ?scope=all. The side-list drop targets use the generic folder-drop data type, so the existing drag-end handler covers them. Create and import file into the selected folder, with tests. The alreadyAt change only affects /artifacts/ today: /capabilities and the /settings/?highlight routes have no sub-routes. The recorded SVG shadow-root decision is preserved, because the mini thumb draws through the same ContentThumb/SvgShadow. The phone layout is

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 68640b920d · 2650 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Both points were real, fixed in 5835cbc:

  • Lost card details on desktop. The equal-height card now carries what the masonry card showed: the publication mark (shared PublicationMark, extracted from the masonry card so both draw the same one), LiveSiteLink, the publication sync error, the description and the tags, each on one line when present. Home's table rows carry the publication mark and the live link.
  • Live-link suite moved off desktop. ArtifactsPage.liveLink.test.tsx now runs once per layout (phone and desktop). With LiveSiteLink removed from the new card and row, the four desktop cases fail; with it, all 14 pass. A Home test pins the publication mark, description and tags on the desktop card.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 10, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=0b04ae0e7ff3 Home reports an empty guide picker while displaying filed artifacts

fixed in 19243d1: useGuideSelection('artifact_open') reads Home's own list (every record, filed ones included) when Home is drawn, and the drawn view's entries otherwise. A test files the only artifact and asserts the picker reads none, not empty; it fails with the old root-scoped count.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=268e07be8718 The existing phone document-creation guide becomes unavailable

fixed in 19243d1: the phone's split-button New artifact carries artifacts.new-mobile, placed on the toolbar with a mobile viewport requirement and sharing artifacts.new's search terms, so a phone query and its guide resolve to the button that phone draws. One id names one render site, so the desktop Doc tile keeps artifacts.new.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=5c3116487742 Thumbnail request failures silently become empty previews

fixed in 19243d1: ArtifactMiniThumb renders a failed content read through an inline ErrorNotice (title, message, agent hand-off) that takes pointer events back from the click-through tile. A test rejects the read and asserts the notice.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=5615b976a333 The new quick-create row exceeds the two-control limit

fixed in 19243d1: the row is the Doc tile plus one more-ways-to-add trigger; New folder and Import are menu items under it (artifacts.new-folder / artifacts.import under artifacts.add-menu). A test asserts the row holds exactly two buttons.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=8170a41ca5de Home's guide availability ignores filed artifacts

fixed in 19243d1: same change as the GPT finding on this class. When Home is drawn, availability reads Home's list, which includes filed records; the regression test fails with the old gridEntries.length count.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 10, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles aeb5cb9 owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on aeb5cb95d74967733197f1c6f53440a1909ac415.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: fixed-height preview error tile with overflow-hidden

  • span=5c3116487742 Folder preview errors clip their recovery action

fixed in bad5aae: the preview error tile scrolls (overflow-auto, overscroll-contain) instead of clipping, so a wrapped notice in an 84px folder tile or a 140px Home card keeps "Ask the agent" reachable. Pinned in "says a preview that could not be read instead of drawing it blank", which fails on the old class.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles bad5aae owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on bad5aaec547868dcfedb5be827c3cf120f2da6ca.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 6ef382b owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 6ef382b4795c21bcc6da582149e11e01111ac11f.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 6) on head 6ef382b fails in test/metrics/test_kiro_export_destination.py::TestOffOffer (3 tests). That red is main's, not this PR's: the same 3 tests fail on a clean origin/main checkout (55b2e4a5e0), because #37460 and #37463 merged 26 minutes apart and the new off-offer tests run on a non-default home. This PR touches no metrics code. Waiting on the fix in #37545, then rebasing onto it.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 9c5e9d0 owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 9c5e9d02ec9f0f7d04eb457ff1f94b72d12c9df4.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: Home table row rendered without a draggable wrapper

  • span=38a0ad91cd64 Home’s Table view loses drag-to-folder

fixed in e6e5d6c: ArtifactRow (both Recent and Recent output) is wrapped in DndDraggable with the artifact move data the gallery card carries, composes setNodeRef through guidePick and forwards the listeners. Pinned by ArtifactsPage.homeTableDrag.test.tsx, which fails on the old row.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: add-menu New folder opened its autofocused field straight from onSelect

  • span=047e70333dc6 New folder from the add menu closes its name field before typing

fixed in e6e5d6c: the item calls useMenuOpensDialog().openLayer(onNewFolder) and the menu content takes its onCloseAutoFocus, the seam FolderMenu rename already uses, so the close no longer pulls focus out of the field. Pinned by "keeps the new-folder name field open when the add menu opens it", which fails on the old item.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles e6e5d6c owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on e6e5d6c57b2966b3788fc0a81c59cb350d1bec9b.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: Home and side-list controls that unmount while focused

  • span=38a0ad91cd64 Replacing focused controls loses keyboard navigation position

fixed in f0da114: keeping an output (star or a chat document) notes the focused control and, once it leaves the page, focuses the moved entry star in Recent unless focus went elsewhere; the side-list rename passes onClose to hand focus back to its folder button on Enter/Escape, as the folder card does. Pinned by two tests that fail on the old code.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=4464213526e3 The feature-map row names a Folder tile the page does not render

fixed in f0da114: the row now reads "a Doc tile and a more-ways-to-add menu (New folder, Import) create into the selected folder", matching ArtifactsPageQuickCreate.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles f0da114 owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on f0da114212cd507be9c8210e02f5e5f0c0d1d66f.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 68640b9 owner-decision: gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 68640b920d090d8d2daeebf39c70819839ef79a8.

gjjnn accepted the product shape as a UI refactor of the existing Artifacts page with design and UX sign-off, no RFC needed: #34776 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. One thing blocks merge on this head: the UX evidence does not match what the code ships.

  1. Missing evidence for the shipped copy (website/src/i18n/locales/en.manual.json:5594, rendered in website/src/pages/ArtifactsPageHome.tsx:414).
    Trigger: the UX lane ran on 68640b9 and reported "cannot evaluate: missing the shipped Recent output warning". CI posted it as PASS only because the comment had no Trigger or Outcome line. Under the review rules, a verdict that cannot be reached for lack of evidence counts as a BLOCK.
    Outcome: the PR body says the after shots come from this head, but the caption quotes "...10 of 200 before the oldest clear." That string is not in this head. This head ships "Unstarred output is deleted once there are more than {{cap}} ({{used}} now). Star one to keep it." No screenshot shows how this data-loss warning renders, and it is the main thing this PR adds.
    Smallest fix: attach screenshots taken on 68640b9 of Home with the capped Recent output line, Home with an empty library (both empty-state lines), a card whose preview failed, and the side list with rename open, new folder open, "No folders yet", and the folder menu open. Then correct the caption and re-run the UX lane. No code change is needed for this item.

After that, this still needs a design sign-off from a maintainer, because the linked issue changes the desktop page that people already use.

Optional:

  • website/src/pages/chat/ActivityViewer.tsx:1045: "Browse all (N)" goes to bare /artifacts, which is now Home on desktop and not the full list. Should it point at /artifacts?scope=all?
  • website/src/pages/ArtifactsPageHome.tsx:389: the deletion sentence also covers unsaved session documents, and the cleanup never deletes those. Consider giving them their own label without that sentence.
  • website/src/test/ArtifactsPage.home.test.tsx:104: a synchronous getByText('plan.md') reads the session-docs query after waiting only for the artifacts query. findByText or a waitFor would make it deterministic, and the dedup checks at lines 387-388 have the same gap.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

@KiroCrewCaptain thanks. Item 1 (missing evidence for the shipped copy) is addressed in the description, with no code change, on head 68640b9:

  • Six new screenshots taken on 68640b9 against the real pod gateway: Home with the capped Recent output line ('Unstarred output is deleted once there are more than 200 (4 now). Star one to keep it.'), an empty library (both empty-state lines plus 'No folders yet'), a card whose preview failed, and the side list with new folder open, the folder menu open, and rename open.
  • The caption no longer quotes the old '...10 of 200 before the oldest clear.' string. The older before/after table is labelled as taken on eb143a6, before the rewording.
  • How the sample data and the failed-preview state were produced is stated under the shots.

I've re-run the UX lane on this head.

On design sign-off: @gjjnn will follow up on that.

The optional notes (Browse all link target, the deletion sentence over unsaved session docs, findByText in the home test) are left out of this PR to keep its scope; happy to take them in a follow-up.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

@KiroCrewCaptain this has been signed off by the design team.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 68640b9. The desktop Artifacts Home splits kept work from output that cleanup can delete, using the server's own cleanup check, and reuses the existing sandboxed previews; targeted tests pass, the new screenshots match the shipped warning, and the design was accepted by a maintainer. Decisive lines: src/kiro_crew/dashboard/handlers/artifacts_parts/library_reads.py:285, src/kiro_crew/dashboard/handlers/artifacts_parts/library_reads.py:417, website/src/pages/ArtifactsPageHome.tsx:377-380, website/src/pages/ArtifactsPageHome.tsx:414, website/src/components/library/ArtifactThumbs.tsx:492-530, website/src/hooks/useArtifactFolders.ts:120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Artifacts page Home and side list on desktop

4 participants