Skip to content

fix(i18n): german first-run copy uses du, umlauts and durchlauf - #35328

Merged
bolichen97 merged 1 commit into
mainfrom
fix/32059-de-informal-address
Nov 12, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/32059-de-informal-address

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A German user's first screens and the top bar speak to them as du in one voice, with real umlauts, and a chat turn reads as "Durchlauf" instead of "Zug".

On a fresh German install the setup screen, the import and Customize steps and the AWS consent card mix the formal Sie with du on one screen: "Wählen Sie Ihr Erscheinungsbild" sits next to "Lege dein Aussehen fest". The top bar says "Command Bar oeffnen" and "Befehl ausfuehren". A chat turn is "Zug", which reads as a train or a move in a game: "Letzter Zug wurde unterbrochen", "Max. Züge pro Subagent".

Why it matters

The first screens decide whether the translation feels finished. Switching register from line to line and ASCII umlauts read as an unreviewed machine translation, and "Zug" makes chat errors hard to understand. The German style guide already asks for du, but nothing held the old values to it.

Not a goal

What changed (motivation → approach → change)

What a German user sees Before After
Setup, import, Customize, AWS consent, top bar Sie and du mixed du throughout
Umlauts oeffnen, ausfuehren, bestaetigen öffnen, ausführen, bestätigen
A chat turn Zug / Züge Durchlauf / Durchläufe

The style guide website/src/i18n/style/de.md asks for du, but deStyle.test.ts only judged the values a branch changed, so the inherited Sie strings, the ASCII spellings and "Zug" were never checked.

de.json now addresses the reader as du in every value under app., apps.commandBar., components.agentImportFlow., components.awsConsentGate., components.kiroPrerequisiteGate. and components.onboardingFlow.. Every ASCII umlaut spelling in the catalog is written out, and every value whose English says "turn" uses Durchlauf. A value edited only for its turn word moves to du too, because the existing changed-values check refuses Sie in any value a branch writes. de.md gains a spelling and terminology section that records Durchlauf. deStyle.test.ts gains three catalog-wide checks with no ceiling: du in those blocks, no ae/oe/ue spelling of a word the catalog also spells with its umlaut, and no Zug where the English says turn. The generated UI location index src/kiro_crew/docs/ui-index.generated.json is regenerated, because it carries four of the renamed German labels. Values matching the formal-address pattern drop from 471 to 435 catalog-wide; every one left is outside those blocks and stays for the next part.

Backwards compatibility

Compatible: only German catalog values change; no key is added, removed or renamed, and every placeholder is kept.

Removes nothing: the diff rewrites translated text and adds tests; no key, path or behaviour is taken away.

Tests

  • deStyle.test.ts › "addresses the reader as du throughout the converted blocks": no formal address in the six first-run blocks.
  • deStyle.test.ts › "writes umlauts, never ae / oe / ue": no ASCII umlaut spelling of a word the catalog also writes with its umlaut.
  • deStyle.test.ts › "renders 'turn' as Durchlauf, never Zug": no Zug where the English value says turn.

Replayed with the same patterns on origin/main's de.json, the three checks find 38, 13 and 172 violations; on this head they find none, and the existing German style checks still pass.

Determinism: the checks read only the committed catalogs, with no clock, network or file order; three runs with --sequence.shuffle (seeds 1, 2, 3) pass 7 of 7.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Loaded this branch's built dashboard in Chromium in German with the repo's gateway-free capture harness (stubbed API) and walked the setup screen, the import step, Customize 1 of 2 and 2 of 2, and Settings > Chat; the screenshots below are from that run.

Screenshots / video

Captured with scripted Playwright from this branch's built dashboard (the repo's website/scripts/lib capture harness, gateway-free, stubbed API), Chromium in German, light theme.

Setup screen (Kiro CLI not installed): du throughout, "Lass diese Seite geöffnet."

Setup screen in German

Import setup, 1 of 4: "Nimm deine Crew mit." beside "Wähle die Quellen".

Import step in German

Customize 1 of 2: "Wähle dein Erscheinungsbild" beside "Lege dein Aussehen fest".

Customize 1 of 2 in German

Customize 2 of 2: "Erzähle Kiro von dir", "Deine Rolle", "Wie technisch bist du?".

Customize 2 of 2 in German

Settings > Chat > Erweitert: the turn group reads "Durchläufe" and "Zeitlimit pro Durchlauf".

Settings turn limit in German

Related Issues

Part of #32059

Sibling sweep

Swept: git grep -nE '(Sie|Ihnen|Ihr|Ihre)' -- website/src/i18n/locales/de.json
Sibling: website/src/i18n/locales/de.json -- tracked in #32059

Pattern harvest

Not generalizable: a translation debt in one catalog; the three German rules it broke are now held catalog-wide by deStyle.test.ts instead of only on changed values.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 11, 2026 14:24
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 5a93ffce7f3e36e85774e60c66bd79db9b1df813 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: only German text changes, no keys move, the catalog-wide tests now hold the corrected values, and five screenshots of this revision are attached.

[DESIGN-REVIEWED] 5a93ffc

Description read

[DESCRIPTION-READ] 99819cbafbc7a120119fc4148791c70ef05b342393b2cb3e3846e3368f51257a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 5a93ffce7f3e36e85774e60c66bd79db9b1df813 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a translation fix to the German catalog only, held in place by three checks that fail on base. Every item has a named harm and none duplicates an existing gate.

What this change ships

Inventory (6 items) — 6 justified

Intent: A German user's first screens and top bar should address them consistently as du, with real umlauts, and call a chat turn "Durchlauf". This is a FIX.

  1. The setup, import, Customize, AWS consent and top-bar screens use du throughout, where they used to mix in Sie — justified
  2. ASCII umlaut spellings ("oeffnen", "ausfuehren") are written with real umlauts across the catalog — justified
  3. A chat turn reads "Durchlauf"/"Durchläufe" instead of "Zug"/"Züge", including in settings and error messages — justified
  4. The German style guide gains a spelling and terminology section, and its enforcement table gains three rows — justified
  5. A new test fails if Sie returns in the six converted blocks, if an ASCII umlaut spelling returns, or if a turn is called "Zug" — justified
  6. The generated UI location index is regenerated to carry four renamed German labels — justified

[FIRST-PRINCIPLES-REVIEWED] 5a93ffc

Description read

[DESCRIPTION-READ] f3c0ff22002e122b2886dffa9cca7b045348f841e6d4f000ac3a81db7a0ce0ea

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 5a93ffce7f3e36e85774e60c66bd79db9b1df813 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the PR changes only German wording. No control is added, moved or changed in behaviour, and screenshots cover the first-run screens and the Settings turn group.

Notes

[UX-REVIEWED] 5a93ffc

Description read

[DESCRIPTION-READ] 0717be2764d7fafd55f28f1d9351ac4499d2d68d44cf636089cec81e1d289ed6

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 5a93ffce7f3e36e85774e60c66bd79db9b1df813 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5a93ffc

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 5a93ffce7f3e36e85774e60c66bd79db9b1df813 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 5a93ffce7f3e36e85774e60c66bd79db9b1df813 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5a93ffc

Verdict parsed from the review's SHA-scoped output markers for commit 5a93ffce7f3e36e85774e60c66bd79db9b1df813.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 5a93ffce7f3e36e85774e60c66bd79db9b1df813 false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

KiroCrewCaptain commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 534 lines, more than the 400 it may approve on its own.

This PR changes only German text values and keeps every key and placeholder. I checked that the six du blocks in de.json no longer use Sie anywhere. Every edited value passes the existing changed-values Sie check. The only "Zug" left in the catalog is the browser loop's "moves", which the new turn check skips on purpose. No ASCII umlaut spellings remain. No test or other file hard-codes the old strings. The regenerated ui-index has no Zug left. The new catalog-wide checks have no ceiling and fit the zero-tolerance approach in i18n-gates.md. Frontend test jobs were still pending at review time.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 5a93ffce7f · 534 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@bolichen97
bolichen97 enabled auto-merge (squash) November 11, 2026 14:48
buluoray
buluoray previously approved these changes Nov 11, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 08a1d0f. German-only copy fix: du in the six first-run blocks and the top bar, real umlauts, and Zug -> Durchlauf for "turn". Keys, placeholders and key order are unchanged, no other locale changed, and each new check turns red when its rule is broken. Decisive lines: website/src/i18n/locales/de.json (225 values changed in place, 0 keys added/removed/reordered); website/src/i18n/style/deStyle.test.ts:113-165 (three new catalog-wide checks)

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 11, 2026
@bolichen97
bolichen97 force-pushed the fix/32059-de-informal-address branch from 08a1d0f to 578254f Compare November 11, 2026 23:21
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/docs/ui-index.generated.json, website/src/i18n/locales/de.json since this head went green (72347f7 -> d80dd05); CI re-running.

The rebase conflicted only in the generated index, which was rebuilt from the new tree. Main had meanwhile added one German value that says "Zug" for a turn (pages.chat.assistantMessage.turn_cache_rewritten_hint); it now says "Durchlauf", as this PR's catalog-wide check requires.

[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] One red in the local related-test run on this head belongs to main, not this change: test/test_find_ui_auto.py::test_the_generated_auto_tier_answers_labels_only_it_carries[continue with github-en-Continue with GitHub-path0] fails the same way on a clean main checkout (6e3cdf2) and is tracked in #32670. CI skips that case (its backend jobs have no website/node_modules), so it does not gate this PR.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 11, 2026
The German setup, onboarding, import and AWS consent screens mixed the
formal Sie with du on one screen, the top bar and command bar spelled
umlauts as oe/ue/ae, and a chat turn read as "Zug" (a train or a game
move). Those blocks now address the reader as du, every ASCII umlaut
spelling in the catalog is written out, and "turn" is "Durchlauf"
throughout, recorded in the German style guide.

deStyle.test.ts holds the converted blocks to du catalog-wide, and the
whole catalog to written-out umlauts and Durchlauf for a turn. The rest
of the catalog's Sie values stay for the next part of #32059.

Part of #32059
@bolichen97
bolichen97 force-pushed the fix/32059-de-informal-address branch from 578254f to 5a93ffc Compare November 12, 2026 06:18
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/de.json and the other locale catalogs since this head went green (d80dd05 -> 4dd046d); CI re-running.

The new base carries #35625, which fixes the two backend reds on the previous head that are not this PR's: test_updates_handlers_facade.py::test_every_name_served_from_outside_the_family_is_visible_to_type_checkers and test_wait_discipline_ratchet.py::test_the_scan_matches_known_sites. The patch is unchanged (git range-diff reports =); main's three new German values already use du.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 12, 2026
@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Nov 12, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: German first-run and top-bar copy uses du, umlauts and Durchlauf, with style checks that hold it.

@bolichen97
bolichen97 merged commit c6a8856 into main Nov 12, 2026
97 of 98 checks passed
@bolichen97
bolichen97 deleted the fix/32059-de-informal-address branch November 12, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants