Repository navigation
fix(i18n): german first-run copy uses du, umlauts and durchlauf - #35328
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: only German text changes, no keys move, the catalog-wide tests now hold the corrected values, and five screenshots of this revision are attached. [DESIGN-REVIEWED] 5a93ffc Description read[DESCRIPTION-READ] 99819cbafbc7a120119fc4148791c70ef05b342393b2cb3e3846e3368f51257a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a translation fix to the German catalog only, held in place by three checks that fail on base. Every item has a named harm and none duplicates an existing gate. What this change shipsInventory (6 items) — 6 justifiedIntent: A German user's first screens and top bar should address them consistently as du, with real umlauts, and call a chat turn "Durchlauf". This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 5a93ffc Description read[DESCRIPTION-READ] f3c0ff22002e122b2886dffa9cca7b045348f841e6d4f000ac3a81db7a0ce0ea That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the PR changes only German wording. No control is added, moved or changed in behaviour, and screenshots cover the first-run screens and the Settings turn group. Notes
[UX-REVIEWED] 5a93ffc Description read[DESCRIPTION-READ] 0717be2764d7fafd55f28f1d9351ac4499d2d68d44cf636089cec81e1d289ed6 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 534 lines, more than the 400 it may approve on its own. This PR changes only German text values and keeps every key and placeholder. I checked that the six du blocks in de.json no longer use Sie anywhere. Every edited value passes the existing changed-values Sie check. The only "Zug" left in the catalog is the browser loop's "moves", which the new turn check skips on purpose. No ASCII umlaut spellings remain. No test or other file hard-codes the old strings. The regenerated ui-index has no Zug left. The new catalog-wide checks have no ceiling and fit the zero-tolerance approach in i18n-gates.md. Frontend test jobs were still pending at review time. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
buluoray
left a comment
There was a problem hiding this comment.
Approve on 08a1d0f. German-only copy fix: du in the six first-run blocks and the top bar, real umlauts, and Zug -> Durchlauf for "turn". Keys, placeholders and key order are unchanged, no other locale changed, and each new check turns red when its rule is broken. Decisive lines: website/src/i18n/locales/de.json (225 values changed in place, 0 keys added/removed/reordered); website/src/i18n/style/deStyle.test.ts:113-165 (three new catalog-wide checks)
08a1d0f to
578254f
Compare
|
Rebased: main moved in src/kiro_crew/docs/ui-index.generated.json, website/src/i18n/locales/de.json since this head went green (72347f7 -> d80dd05); CI re-running. The rebase conflicted only in the generated index, which was rebuilt from the new tree. Main had meanwhile added one German value that says "Zug" for a turn ( [operator: bolichen97] |
|
[operator: bolichen97] One red in the local related-test run on this head belongs to main, not this change: |
The German setup, onboarding, import and AWS consent screens mixed the formal Sie with du on one screen, the top bar and command bar spelled umlauts as oe/ue/ae, and a chat turn read as "Zug" (a train or a game move). Those blocks now address the reader as du, every ASCII umlaut spelling in the catalog is written out, and "turn" is "Durchlauf" throughout, recorded in the German style guide. deStyle.test.ts holds the converted blocks to du catalog-wide, and the whole catalog to written-out umlauts and Durchlauf for a turn. The rest of the catalog's Sie values stay for the next part of #32059. Part of #32059
578254f to
5a93ffc
Compare
|
Rebased: main moved in website/src/i18n/locales/de.json and the other locale catalogs since this head went green (d80dd05 -> 4dd046d); CI re-running. The new base carries #35625, which fixes the two backend reds on the previous head that are not this PR's: [operator: bolichen97] |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: German first-run and top-bar copy uses du, umlauts and Durchlauf, with style checks that hold it.
Problem / Motivation
Goal: A German user's first screens and the top bar speak to them as du in one voice, with real umlauts, and a chat turn reads as "Durchlauf" instead of "Zug".
On a fresh German install the setup screen, the import and Customize steps and the AWS consent card mix the formal Sie with du on one screen: "Wählen Sie Ihr Erscheinungsbild" sits next to "Lege dein Aussehen fest". The top bar says "Command Bar oeffnen" and "Befehl ausfuehren". A chat turn is "Zug", which reads as a train or a move in a game: "Letzter Zug wurde unterbrochen", "Max. Züge pro Subagent".
Why it matters
The first screens decide whether the translation feels finished. Switching register from line to line and ASCII umlauts read as an unreviewed machine translation, and "Zug" makes chat errors hard to understand. The German style guide already asks for du, but nothing held the old values to it.
Not a goal
Rundefor a turn: they read correctly and move to Durchlauf in a later pass.What changed (motivation → approach → change)
oeffnen,ausfuehren,bestaetigenöffnen,ausführen,bestätigenZug/ZügeDurchlauf/DurchläufeThe style guide
website/src/i18n/style/de.mdasks for du, butdeStyle.test.tsonly judged the values a branch changed, so the inherited Sie strings, the ASCII spellings and "Zug" were never checked.de.jsonnow addresses the reader as du in every value underapp.,apps.commandBar.,components.agentImportFlow.,components.awsConsentGate.,components.kiroPrerequisiteGate.andcomponents.onboardingFlow.. Every ASCII umlaut spelling in the catalog is written out, and every value whose English says "turn" uses Durchlauf. A value edited only for its turn word moves to du too, because the existing changed-values check refuses Sie in any value a branch writes.de.mdgains a spelling and terminology section that records Durchlauf.deStyle.test.tsgains three catalog-wide checks with no ceiling: du in those blocks, no ae/oe/ue spelling of a word the catalog also spells with its umlaut, and no Zug where the English says turn. The generated UI location indexsrc/kiro_crew/docs/ui-index.generated.jsonis regenerated, because it carries four of the renamed German labels. Values matching the formal-address pattern drop from 471 to 435 catalog-wide; every one left is outside those blocks and stays for the next part.Backwards compatibility
Compatible: only German catalog values change; no key is added, removed or renamed, and every placeholder is kept.
Removes nothing: the diff rewrites translated text and adds tests; no key, path or behaviour is taken away.
Tests
deStyle.test.ts› "addresses the reader as du throughout the converted blocks": no formal address in the six first-run blocks.deStyle.test.ts› "writes umlauts, never ae / oe / ue": no ASCII umlaut spelling of a word the catalog also writes with its umlaut.deStyle.test.ts› "renders 'turn' as Durchlauf, never Zug": no Zug where the English value says turn.Replayed with the same patterns on
origin/main'sde.json, the three checks find 38, 13 and 172 violations; on this head they find none, and the existing German style checks still pass.Determinism: the checks read only the committed catalogs, with no clock, network or file order; three runs with
--sequence.shuffle(seeds 1, 2, 3) pass 7 of 7.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Loaded this branch's built dashboard in Chromium in German with the repo's gateway-free capture harness (stubbed API) and walked the setup screen, the import step, Customize 1 of 2 and 2 of 2, and Settings > Chat; the screenshots below are from that run.
Screenshots / video
Captured with scripted Playwright from this branch's built dashboard (the repo's
website/scripts/libcapture harness, gateway-free, stubbed API), Chromium in German, light theme.Setup screen (Kiro CLI not installed): du throughout, "Lass diese Seite geöffnet."
Import setup, 1 of 4: "Nimm deine Crew mit." beside "Wähle die Quellen".
Customize 1 of 2: "Wähle dein Erscheinungsbild" beside "Lege dein Aussehen fest".
Customize 2 of 2: "Erzähle Kiro von dir", "Deine Rolle", "Wie technisch bist du?".
Settings > Chat > Erweitert: the turn group reads "Durchläufe" and "Zeitlimit pro Durchlauf".
Related Issues
Part of #32059
Sibling sweep
Swept:
git grep -nE '(Sie|Ihnen|Ihr|Ihre)' -- website/src/i18n/locales/de.jsonSibling: website/src/i18n/locales/de.json -- tracked in #32059
Pattern harvest
Not generalizable: a translation debt in one catalog; the three German rules it broke are now held catalog-wide by
deStyle.test.tsinstead of only on changed values.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)