Skip to content

fix(dashboard): leave the untitled placeholder out of window titles - #36419

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/32059-tab-title-placeholder
Nov 20, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/32059-tab-title-placeholder

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A user whose session has no title yet sees the browser tab and the chat popout window named in their own language, never with the backend's English placeholder "New Session…".

Every new chat starts untitled. Until its first title arrives, the browser tab reads New Session… — Chat — Kiro Crew and its popout window New Session… — Kiro Crew, in German, Japanese and Chinese alike.

Why it matters

Everyone who opens a new chat sees it, and the tab title stays on screen the whole time they work in that chat; the popout's title names its window in the taskbar. On a translated dashboard an English phrase in the tab reads as an unfinished translation. The onboarding runs reported it in five German, Japanese and Chinese runs.

Not a goal

What changed (motivation → approach → change)

Window, untitled session Before After
Main tab New Session… — Chat — Kiro Crew Chat — Kiro Crew
Chat popout New Session… — Kiro Crew Sitzung — Kiro Crew in German, Session — Kiro Crew in English

The backend sends an open untitled session with the title New Session…. The session list and the other session surfaces already read that as no title through isUntitledSession (utils/sessionDisplayTitle.ts). The two window titles, in shell/appShell.tsx and pages/PopoutFrame.tsx, counted only a title equal to the slot key as no title, so the placeholder passed through as a name.

Both window titles use isUntitledSession and keep the fallback they already had: the main tab names the panel alone, as with no session open, and the popout its translated generic label. The main tab's title also names the Back/Forward history entry, which reads Chat for an untitled session. A session with a real title keeps it. docs/system-specs/modules/history.md records the rule.

Backwards compatibility

Compatible: only the text of two window titles changes, and only for an untitled session; no key, route or API changes.

Removes nothing: the placeholder was never the session's name, and a titled session keeps its title in both windows.

Tests

  • App.tabTitle.test.tsx › "names Chat alone while the active session still carries the backend placeholder": the main tab reads Chat — Kiro Crew.
  • PopoutFrameCov80.test.tsx › "falls back to a generic label when the slot still carries the backend placeholder": the popout reads Session — Kiro Crew.

Both fail on the base (received New Session… — Chat — Kiro Crew and New Session… — Kiro Crew) and pass with the fix.

Determinism: the tests read only the store and document.title, with no clock or network; both files pass 17 of 17 with --sequence.shuffle seeds 1, 2 and 3 and in five plain repeats.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Served this change's dashboard from an isolated gateway (a fresh data home, a loopback port) on Linux (Ubuntu), and drove it with headed Chromium in German on the untitled session that /chat opens, before and after the fix:

[before] main tab page.title() = "New Session… — Chat — Kiro Crew"
[before] popout tab page.title() = "New Session… — Kiro Crew"
[after] main tab page.title() = "Chat — Kiro Crew"
[after] popout tab page.title() = "Sitzung — Kiro Crew"
[after] titled main tab page.title() = "Login-Seite reparieren — Chat — Kiro Crew"

The last line renamed the session first: a real title still names the tab.

Real-machine verification

Machine: EC2 m7i.2xlarge, Ubuntu 24.04.5 LTS, x86_64, 8 vCPU / 30 GiB; Node v24.22.3, Chromium 145.0.7632.6 (Playwright) headed under Xvfb 1400x900x24; a disposable verification host with no inbound rules
Before (main 5c9bf25): xvfb-run -a -s '-screen 0 1400x900x24' node drive.mjs before <port> <token> <out> <website> against an isolated gateway (fresh data home, loopback port, German UI) -> main tab New Session… — Chat — Kiro Crew, popout New Session… — Kiro Crew; with only the two test files' hunks applied, npx vitest run src/test/App.tabTitle.test.tsx src/test/PopoutFrameCov80.test.tsx -t "backend placeholder" -> 2 failed | 15 skipped
After (head 61cc475): the same smoke command with after, and npx vitest run on both whole test files, run on tree cb36adf0486f (base 5c9bf25), which differs from this head only by main's later commits, none in this PR's code files -> main tab Chat — Kiro Crew, popout Sitzung — Kiro Crew, and after a rename Login-Seite reparieren — Chat — Kiro Crew; vitest 17 passed (17)
Cleanup: both gateways stopped by their pid, both throwaway data homes and the scratch worktree deleted (ls: No such file or directory); no key pair (session access only); the host is a shared disposable instance that the idle reaper terminates, not one launched for this PR alone

Screenshots / video

Whole browser windows of headed Chromium (Xvfb) on Linux, dashboard in German: the tab strip, the address bar and the page with its nav rail and session list.

Before, untitled session: the tab reads New Session… — Chat — Ki….

Main window before

After, same session: Chat — Kiro Crew.

Main window after

Popout after: Sitzung — Kiro Crew.

Popout window after

Popout before, and a titled session after

Popout before: New Session… — Kiro Crew.

Popout window before

After, titled session: Login-Seite reparieren — Ch… keeps its title.

Titled session window after

Related Issues

Part of #32059
Part of #34715

Sibling sweep

Swept: git grep -nE "title && [a-zA-Z?.]*title !== [a-zA-Z.]*(key|Key|sid|slot)\b" -- website/src
Sibling: website/src/shell/appShell.tsx -- changed here
Sibling: website/src/pages/PopoutFrame.tsx -- changed here
Sibling: website/src/pages/chat-sidebar/SessionRow.tsx -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/chat-sidebar/rows.ts -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat/SessionFlyout.tsx -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat-sidebar/sessionCleanup.tsx -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat-sidebar/FolderCleanupPanel.tsx -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat/command-center/model.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/chat/useChatPageSessionController.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/ChatPage.tsx -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/utils/chatPopout.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/utils/shareUrl.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/utils/sessionKeys.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/chat-sidebar/dnd/useSidebarDrag.ts -- not affected -- reads isUntitledSession on main since #36482

Pattern harvest

Rule candidate: lint
Pattern: a session's "has a real title" test written by hand as title && title !== key instead of isUntitledSession, which misses the backend placeholder

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Both window titles (main tab in appShell.tsx, popout in PopoutFrame.tsx) now use the shared isUntitledSession check instead of comparing the title to the slot key, so the backend's English placeholder "New Session…" counts as no title and the existing localized fallbacks are shown. The other reader of activeSessionTitle, the Back/Forward history label, now reads "Chat" for an untitled session, as the description says. Each change has a regression test that would fail on the base branch. No limit or trust boundary is touched. The CI failures come from rate limits and merge-base read errors, not from the code.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 1567aeadb4 · 30 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@bolichen97
bolichen97 enabled auto-merge (squash) November 13, 2026 05:50
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 13, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/history.md, website/src/shell/appShell.tsx, website/src/test/App.tabTitle.test.tsx since this head went green (2f7e9f2 -> 89438fd); CI re-running.

The branch conflicted with main in one history.md paragraph: #36482 listed the places that ask isUntitledSession and ended by saying the two window titles were not among them yet. That sentence now states this PR's rule instead. Main's appShell.tsx and App.tabTitle.test.tsx changes since the old base (among them #36571, which adds dashboard.instance_label to the tab title, #39331, which removes the privacy first-run step, and #38064) do not touch the tab-title selector, and the patch applies to them unchanged. The change was re-gated on a Linux verification machine on base 910f01f: the profile gates, semgrep, the two added tests red on the base and green on the fix (17 of 17 in both files, shuffled and repeated), and a headed-Chromium smoke in German (Chat — Kiro Crew, Sitzung — Kiro Crew); the description's screenshots are re-captured from it and its Real-machine verification section records the run. Main's later commits up to 89438fd touch none of this PR's code files.

[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/32059-tab-title-placeholder branch from 1567aea to a6b62b2 Compare November 19, 2026 11:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: both window titles now use the same isUntitledSession check as the other session views, and no new surface comes with it.

[DESIGN-REVIEWED] 61cc475

Description read

[DESCRIPTION-READ] ac2e87bc0e3b8d8fb0b0ef2e74576115006523059ea6ad6171d25657310bb16e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Two window titles now use the existing isUntitledSession instead of a hand-written key-only check. That fixes the mechanism, and the PR's tests fail on base.

Inventory (3 items) — 3 justified

Intent: let a user with an untitled session see the browser tab and the popout window titled in their own language, without the English "New Session…" placeholder. This is a FIX.

  1. The main tab and its Back/Forward history entry read Chat — Kiro Crew for an untitled session, not New Session… — Chat — Kiro Crew. — justified
  2. The chat popout window reads the translated Session label for an untitled session, not the placeholder. — justified
  3. The history.md spec now says both window titles ask isUntitledSession, where it used to say "not among them yet". — justified

[FIRST-PRINCIPLES-REVIEWED] 61cc475

Description read

[DESCRIPTION-READ] 1434c89f01834b5154b669af680ef2110dddac249f03c0e5eb0aee4e38baaabb

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 61cc475

Verdict parsed from the review's SHA-scoped output markers for commit 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. Only two window-title strings change for untitled sessions, and shots 01–05 show every before/after state.

Notes

  • When a session has no title, the main tab falls back to Chat — Kiro Crew and the popout to Sitzung — Kiro Crew (in German), so one conversation gets two different names. The blind reader noticed: "'Chat' in one tab and 'Sitzung' in the other seem to mean the same conversation". In a follow-up, give both windows the same untitled label, for example the localized "Unbenannte Sitzung" already shown on the page.

[UX-REVIEWED] 61cc475

Description read

[DESCRIPTION-READ] 5de50733d45fc5926f5cfe014c84f9a5fcfb61f70c5c7657ac81635fc2833d23

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 61cc475

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 61cc4757f59938b4839c0a1d2e6bbb8d5bd08047 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 19, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Backend Tests (3.12, 7) is red on this head (https://github.com/kirodotdev/KiroCrew/actions/runs/44515237377/job/135533917265): test/test_source_link_github_case.py::TestOneChipPerObject (assert 0 == 1, assert (0 == 3)). This is the source-link flake tracked in #39460. It was red on main at this PR's base too (run 44514765616 on 89438fd), and #39470 fixed it on main. The PR does not touch source links.

Every main commit that has #39470 also has the process-cache ratchet red (#39478), and its fix #39479 has not merged yet. This PR rebases once #39479 lands, so the new head picks up both fixes and does not bring in a second red from main. Coverage Gate is red only because it requires that shard.

The backend names every open untitled slot "New Session…", an English
placeholder rather than a title. The main tab title and the chat
popout's window title treated only a title equal to the slot key as
no title, so an untitled session put the English placeholder in the
browser tab ("New Session… — Chat — Kiro Crew") in every language.

Both sites use isUntitledSession, the check the session list already
uses: an untitled session leaves its name out of the main tab
("Chat — Kiro Crew") and gives the popout its localized generic label
("Sitzung — Kiro Crew" in German). The history spec records the rule.

Part of #32059
@bolichen97
bolichen97 force-pushed the fix/32059-tab-title-placeholder branch from a6b62b2 to 61cc475 Compare November 19, 2026 22:08
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/history.md, website/src/shell/appShell.tsx since this head went green (89438fd -> e48b116); CI re-running.

The new base carries #39470 and #39479, the two main fixes this PR was waiting on for the Backend Tests (3.12, 7) red. The patch applies unchanged. Main's changes to this PR's files do not touch the tab-title selector or the history paragraph this PR edits: #38469 changes the rail-width effect in appShell.tsx, and #36520 and #38024 add history paragraphs elsewhere in the spec.

The change was re-gated on a Linux verification machine on base 5c9bf25. That run covered the profile gates, local-gate.py, semgrep and the flake ratchet. The two added tests were red on the base and green on the fix, and both files passed 17 of 17 in shuffled and repeated runs. A headed-Chromium smoke in German showed Chat — Kiro Crew and Sitzung — Kiro Crew. Main's later commits up to e48b116 touch none of this PR's code files.

The description's five screenshots were re-captured from that run as whole browser windows. Its Real-machine verification section records the run.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 19, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed head 61cc475. The main tab title and the chat popout window title now use the shared isUntitledSession check, so the backend's untitled placeholder no longer reaches the window title. A session that is genuinely titled still shows its title, and a title equal to the slot key still falls back as before. Both changed test files pass on this head (17 of 17). Each new test fails when only that file's code change is reverted, so the tests catch the regression. The change is limited to two display strings plus the matching spec sentence, and I found nothing that blocks.

@KiroCrewCaptain
KiroCrewCaptain merged commit 7df8909 into main Nov 20, 2026
101 of 104 checks passed
auto-merge was automatically disabled November 20, 2026 00:55

Pull Request is not mergeable

@KiroCrewCaptain
KiroCrewCaptain deleted the fix/32059-tab-title-placeholder branch November 20, 2026 00:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants