Repository navigation
fix(dashboard): leave the untitled placeholder out of window titles - #36419
Conversation
Code change approver recommendation: ApproveWhy: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Both window titles (main tab in appShell.tsx, popout in PopoutFrame.tsx) now use the shared isUntitledSession check instead of comparing the title to the slot key, so the backend's English placeholder "New Session…" counts as no title and the existing localized fallbacks are shown. The other reader of activeSessionTitle, the Back/Forward history label, now reads "Chat" for an untitled session, as the description says. Each change has a regression test that would fail on the base branch. No limit or trust boundary is touched. The CI failures come from rate limits and merge-base read errors, not from the code. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Rebased: main moved in docs/system-specs/modules/history.md, website/src/shell/appShell.tsx, website/src/test/App.tabTitle.test.tsx since this head went green (2f7e9f2 -> 89438fd); CI re-running. The branch conflicted with main in one [operator: bolichen97] |
1567aea to
a6b62b2
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: both window titles now use the same [DESIGN-REVIEWED] 61cc475 Description read[DESCRIPTION-READ] ac2e87bc0e3b8d8fb0b0ef2e74576115006523059ea6ad6171d25657310bb16e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Two window titles now use the existing Inventory (3 items) — 3 justifiedIntent: let a user with an untitled session see the browser tab and the popout window titled in their own language, without the English "New Session…" placeholder. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 61cc475 Description read[DESCRIPTION-READ] 1434c89f01834b5154b669af680ef2110dddac249f03c0e5eb0aee4e38baaabb That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. Only two window-title strings change for untitled sessions, and shots 01–05 show every before/after state. Notes
[UX-REVIEWED] 61cc475 Description read[DESCRIPTION-READ] 5de50733d45fc5926f5cfe014c84f9a5fcfb61f70c5c7657ac81635fc2833d23 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
[operator: bolichen97] Every |
The backend names every open untitled slot "New Session…", an English
placeholder rather than a title. The main tab title and the chat
popout's window title treated only a title equal to the slot key as
no title, so an untitled session put the English placeholder in the
browser tab ("New Session… — Chat — Kiro Crew") in every language.
Both sites use isUntitledSession, the check the session list already
uses: an untitled session leaves its name out of the main tab
("Chat — Kiro Crew") and gives the popout its localized generic label
("Sitzung — Kiro Crew" in German). The history spec records the rule.
Part of #32059
a6b62b2 to
61cc475
Compare
|
Rebased: main moved in docs/system-specs/modules/history.md, website/src/shell/appShell.tsx since this head went green (89438fd -> e48b116); CI re-running. The new base carries #39470 and #39479, the two The change was re-gated on a Linux verification machine on base 5c9bf25. That run covered the profile gates, The description's five screenshots were re-captured from that run as whole browser windows. Its Real-machine verification section records the run. [operator: bolichen97] |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 61cc475. The main tab title and the chat popout window title now use the shared isUntitledSession check, so the backend's untitled placeholder no longer reaches the window title. A session that is genuinely titled still shows its title, and a title equal to the slot key still falls back as before. Both changed test files pass on this head (17 of 17). Each new test fails when only that file's code change is reverted, so the tests catch the regression. The change is limited to two display strings plus the matching spec sentence, and I found nothing that blocks.
Pull Request is not mergeable
Problem / Motivation
Goal: A user whose session has no title yet sees the browser tab and the chat popout window named in their own language, never with the backend's English placeholder "New Session…".
Every new chat starts untitled. Until its first title arrives, the browser tab reads
New Session… — Chat — Kiro Crewand its popout windowNew Session… — Kiro Crew, in German, Japanese and Chinese alike.Why it matters
Everyone who opens a new chat sees it, and the tab title stays on screen the whole time they work in that chat; the popout's title names its window in the taskbar. On a translated dashboard an English phrase in the tab reads as an unfinished translation. The onboarding runs reported it in five German, Japanese and Chinese runs.
Not a goal
Rundefor a turn, and the gateway-side English (the Claude Code sign-in sentence, tips).What changed (motivation → approach → change)
New Session… — Chat — Kiro CrewChat — Kiro CrewNew Session… — Kiro CrewSitzung — Kiro Crewin German,Session — Kiro Crewin EnglishThe backend sends an open untitled session with the title
New Session…. The session list and the other session surfaces already read that as no title throughisUntitledSession(utils/sessionDisplayTitle.ts). The two window titles, inshell/appShell.tsxandpages/PopoutFrame.tsx, counted only a title equal to the slot key as no title, so the placeholder passed through as a name.Both window titles use
isUntitledSessionand keep the fallback they already had: the main tab names the panel alone, as with no session open, and the popout its translated generic label. The main tab's title also names the Back/Forward history entry, which readsChatfor an untitled session. A session with a real title keeps it.docs/system-specs/modules/history.mdrecords the rule.Backwards compatibility
Compatible: only the text of two window titles changes, and only for an untitled session; no key, route or API changes.
Removes nothing: the placeholder was never the session's name, and a titled session keeps its title in both windows.
Tests
App.tabTitle.test.tsx› "names Chat alone while the active session still carries the backend placeholder": the main tab readsChat — Kiro Crew.PopoutFrameCov80.test.tsx› "falls back to a generic label when the slot still carries the backend placeholder": the popout readsSession — Kiro Crew.Both fail on the base (received
New Session… — Chat — Kiro CrewandNew Session… — Kiro Crew) and pass with the fix.Determinism: the tests read only the store and
document.title, with no clock or network; both files pass 17 of 17 with--sequence.shuffleseeds 1, 2 and 3 and in five plain repeats.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Served this change's dashboard from an isolated gateway (a fresh data home, a loopback port) on Linux (Ubuntu), and drove it with headed Chromium in German on the untitled session that
/chatopens, before and after the fix:The last line renamed the session first: a real title still names the tab.
Real-machine verification
Machine: EC2 m7i.2xlarge, Ubuntu 24.04.5 LTS, x86_64, 8 vCPU / 30 GiB; Node v24.22.3, Chromium 145.0.7632.6 (Playwright) headed under Xvfb 1400x900x24; a disposable verification host with no inbound rules
Before (main 5c9bf25):
xvfb-run -a -s '-screen 0 1400x900x24' node drive.mjs before <port> <token> <out> <website>against an isolated gateway (fresh data home, loopback port, German UI) -> main tabNew Session… — Chat — Kiro Crew, popoutNew Session… — Kiro Crew; with only the two test files' hunks applied,npx vitest run src/test/App.tabTitle.test.tsx src/test/PopoutFrameCov80.test.tsx -t "backend placeholder"-> 2 failed | 15 skippedAfter (head 61cc475): the same smoke command with
after, andnpx vitest runon both whole test files, run on tree cb36adf0486f (base 5c9bf25), which differs from this head only by main's later commits, none in this PR's code files -> main tabChat — Kiro Crew, popoutSitzung — Kiro Crew, and after a renameLogin-Seite reparieren — Chat — Kiro Crew; vitest 17 passed (17)Cleanup: both gateways stopped by their pid, both throwaway data homes and the scratch worktree deleted (
ls: No such file or directory); no key pair (session access only); the host is a shared disposable instance that the idle reaper terminates, not one launched for this PR aloneScreenshots / video
Whole browser windows of headed Chromium (Xvfb) on Linux, dashboard in German: the tab strip, the address bar and the page with its nav rail and session list.
Before, untitled session: the tab reads
New Session… — Chat — Ki….After, same session:
Chat — Kiro Crew.Popout after:
Sitzung — Kiro Crew.Popout before, and a titled session after
Popout before:
New Session… — Kiro Crew.After, titled session:
Login-Seite reparieren — Ch…keeps its title.Related Issues
Part of #32059
Part of #34715
Sibling sweep
Swept:
git grep -nE "title && [a-zA-Z?.]*title !== [a-zA-Z.]*(key|Key|sid|slot)\b" -- website/srcSibling: website/src/shell/appShell.tsx -- changed here
Sibling: website/src/pages/PopoutFrame.tsx -- changed here
Sibling: website/src/pages/chat-sidebar/SessionRow.tsx -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/chat-sidebar/rows.ts -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat/SessionFlyout.tsx -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat-sidebar/sessionCleanup.tsx -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat-sidebar/FolderCleanupPanel.tsx -- not affected -- reads sessionDisplayTitle on main since #36482
Sibling: website/src/pages/chat/command-center/model.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/chat/useChatPageSessionController.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/ChatPage.tsx -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/utils/chatPopout.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/utils/shareUrl.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/utils/sessionKeys.ts -- not affected -- reads isUntitledSession on main since #36482
Sibling: website/src/pages/chat-sidebar/dnd/useSidebarDrag.ts -- not affected -- reads isUntitledSession on main since #36482
Pattern harvest
Rule candidate: lint
Pattern: a session's "has a real title" test written by hand as
title && title !== keyinstead ofisUntitledSession, which misses the backend placeholderChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits