Skip to content

fix(dashboard): treat the untitled placeholder as no title everywhere - #36482

Merged
bolichen97 merged 1 commit into
mainfrom
crew/conductor/untitled-placeholder
Nov 14, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/conductor/untitled-placeholder

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An open untitled session never shows the backend's English New Session… placeholder, in any language.

The backend sends every open untitled session with the title New Session…. isUntitledSession already reads that as no title, so sidebar rows, tabs and the palette say "Untitled session". Other sites compared the title with the key only, so the English placeholder passed through as a title: the rename box opened pre-filled with it, a row's scroll stub, the collapsed sidebar's flyout and the two cleanup lists showed it, a Bot thread's tooltip read <Bot>: New Session…, and the chat, share and popout URLs got a /new-session slug.

Why it matters

Every non-English reader sees English text where the session's name should be, and a share link names a session "new-session" when it has no name.

Not a goal

  • The browser tab title and the popout window title (shell/appShell.tsx, PopoutFrame.tsx): fix(dashboard): leave the untitled placeholder out of window titles #36419.
  • Telling a session a person deliberately named New Session… apart from an untitled one. isUntitledSession already reads that exact text as no title on main for the rows, tabs and palette; carrying the backend's untitled state as a flag would be a new field on the slot payload.

What changed (motivation → approach → change)

Cause: each site spelled its own title && title !== key test, which knows nothing of the placeholder. Change: each now asks isUntitledSession, the one check the rows already use.

  • Session lists a reader picks from read "Untitled session", as the sidebar row does: chat/SessionFlyout.tsx, chat-sidebar/rows.ts (a row's scroll stub, so the stub and the row agree), chat-sidebar/sessionCleanup.tsx, chat-sidebar/FolderCleanupPanel.tsx.
  • The phone top bar (chat/page/MobileTopBar.tsx) reads the chat page's title through sessionDisplayTitle, as the desktop title row (SessionTitleControl) already does: the chat page now hands it the key for an untitled session, which the bar would otherwise show raw.
  • Every other site keeps its own fallback and only stops taking the placeholder as a title: the rename box opens empty (SessionRow.tsx, both entry points), the Bot tooltip keeps the Bot's name alone, a dragged session reference carries the key (SessionRow.tsx, dnd/useSidebarDrag.ts), the command center node title (command-center/model.ts), the chat page title (ChatPage.tsx), the URL slugs (useChatPageSessionController.ts, utils/shareUrl.ts, utils/chatPopout.ts) and a short-name match (utils/sessionKeys.ts).

Spec: docs/system-specs/modules/history.md.

Backwards compatibility

Compatible: a titled session reads exactly as before; only the placeholder stops being taken as a title, and the four session lists show the label where they showed the key.

Removes nothing: no key, prop, route or export is removed.

Tests

  • src/test/untitledPlaceholderSlug.test.ts (new): the share link and popout URL carry no slug for either ellipsis spelling, a real title still slugs, and a short-name match is titled by the key. 4 of its 5 tests fail on main.
  • src/test/MobileTopBar.untitledTitle.test.tsx (new): the phone bar reads "Untitled session" for the key or the placeholder, and a real title as it is. 2 of its 3 tests fail without the bar's change.
  • src/pages/chat-sidebar/rows.test.ts: the stub is titled the way its row is, the placeholder included (fails on main).
  • 249 related test files run; the only other failure, ArtifactDetailPage.test.tsx, fails on main too.

Proof: not provable -- frontend test

Manual verification

The cleanup list rendered with the app's CSS and i18n through a local harness, before and after, in English and German (below).

Screenshots / video

Before (main), German: the untitled session reads New Session….

before, de

After, German: it reads "Unbenannte Sitzung", as the sidebar row does.

after, de

English

before, en

after, en

Related Issues

Fixes #36412

Sibling sweep

Swept: git grep -nE "title !== [a-zA-Z.]*(key|Key|slot|Slot)" -- website/src
Sibling: website/src/shell/appShell.tsx -- tracked in #36419
Sibling: website/src/pages/chat-sidebar/SessionRow.tsx -- changed here
Sibling: website/src/pages/chat-sidebar/dnd/useSidebarDrag.ts -- changed here

Pattern harvest

Rule candidate: lint
Pattern: a title !== key comparison outside utils/sessionDisplayTitle.ts, which misses the backend's untitled placeholder.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 13, 2026 07:40
@RohanK6
RohanK6 requested a review from mbriones98 November 13, 2026 07:40
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: every site now uses the existing isUntitledSession check, and rendered before/after evidence is attached.

Notes

  • ChatPage.tsx:1253 (steerWorker) still takes raw currentSlot.title, so a Crew worker steer label can read New Session…. This is the same class of bug and the PR's sibling sweep regex misses it.

[DESIGN-REVIEWED] 11e4e62

Description read

[DESCRIPTION-READ] 638ec61c591563ffdfe9f86b6b487bc3adfac7e763e51fc54614a9cc1d3fa23a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Every site now goes through the existing isUntitledSession check. The one remaining title !== key test (shell/appShell.tsx:1008) is out of scope under ## Not a goal and tracked in #36419.

What this change ships

Inventory (9 items) — 9 justified

Intent: a non-English reader never sees the backend's English New Session… placeholder as a session's name. This is a FIX (#36412).

  1. The collapsed sidebar's session flyout reads "Untitled session" instead of the placeholder or the key — justified
  2. A row's scroll stub is titled the same way as its row — justified
  3. Both cleanup lists show "Untitled session" for an untitled session — justified
  4. The phone top bar shows "Untitled session" instead of the raw key or the placeholder — justified
  5. The rename box opens empty for an untitled session, from both entry points — justified
  6. A Bot thread's tooltip shows the Bot's name alone, not <Bot>: New Session… — justified
  7. Chat, share and popout URLs carry no /new-session slug — justified
  8. A dragged session reference, a short-name match and a command-center node no longer take the placeholder as a title — justified
  9. The history spec gains a paragraph listing the sites that now read the label — justified

[FIRST-PRINCIPLES-REVIEWED] 11e4e62

Description read

[DESCRIPTION-READ] cca538b467bf310a15cc84ae249b8f98ac8923e58d25831482a19afcd8bd2be8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the phone top bar, the collapsed-sidebar flyout and the rename box. The diff changes what each of them shows, but the only screenshots are of the session-cleanup dialog.

Evidence gaps

  • Phone top bar (MobileTopBar.tsx, sessionDisplayTitle({ key: activeSlot, title })): no screenshot shows the bar reading "Untitled session" for an untitled chat. A phone-width before/after screenshot would close this gap.
  • Collapsed-sidebar flyout (SessionFlyout.tsx, const label = sessionDisplayTitle(slot)): no screenshot shows an untitled row in the flyout. One screenshot of the flyout open with an untitled session in it would close this.
  • Rename box opening empty (SessionRow.tsx, onRenameStart(..., '' ...)): this is a new state that no screenshot shows. A screenshot of the rename box opened on an untitled session would close it. Check that the empty field still makes clear it is waiting for a name.

Notes

  • The blind reader only got a clear reading from the after shots. They took "New Session..." to be "a 'make a new chat' button or something still loading" and said they "wouldn't click that line". With "Untitled session" they read it as an existing chat and were "more willing" to archive. So the cleanup-list fix works for readers.
  • The folder cleanup panel's path (FolderCleanupPanel.tsx) uses the same label as the screenshotted dialog. It needs no extra screenshot unless the path is cut short in a way that hides the label.

[UX-REVIEWED] 11e4e62

Description read

[DESCRIPTION-READ] f29d0f00290b0c5e04946da1908969341ab59e7d4b5f99c596cd34545a4276da

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 11e4e62

Verdict parsed from the review's SHA-scoped output markers for commit 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 11e4e62

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 11e4e62c557a9169f4e9a9a11c8cf35f09eff1ff false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

KiroCrewCaptain commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Every changed site swaps its own title && title !== key check for the shared isUntitledSession/sessionDisplayTitle helpers. These count the backend's New Session… placeholder, in either ellipsis spelling, as no title, and titled sessions read as before. When a session is untitled, ChatPage now passes the key instead of the placeholder. SessionTitleControl and the phone bar both handle that key correctly. An untitled session's URL now has no slug (/chat?sid=), and createdChatView's page matching handles that. The only raw comparison left is appShell.tsx:982, which is out of scope and tracked in #36419. New tests cover the slugs, the short-name match, the phone bar and the row stub. No regression found.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 3cdce35d94 · 189 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@RohanK6
RohanK6 force-pushed the crew/conductor/untitled-placeholder branch from 47ba62b to a7d0b9c Compare November 13, 2026 08:16
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/untitled-placeholder branch from a7d0b9c to 6e69187 Compare November 13, 2026 10:33
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 13, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/untitled-placeholder branch from 6e69187 to 3cdce35 Compare November 13, 2026 16:22
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 13, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/untitled-placeholder branch from 3cdce35 to 1893ae6 Compare November 13, 2026 18:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 13, 2026
The backend sends an open untitled session with the English title
'New Session…'. isUntitledSession already reads that as no title for
the sidebar rows, but other sites compared the title with the key
only, so the placeholder showed through in every language: the rename
box, a row's scroll stub, the collapsed sidebar's flyout, the cleanup
lists, a Bot thread's tooltip, the command center, and the chat,
share and popout URL slugs. Each now asks isUntitledSession; the
session lists read 'Untitled session' like the row, and the rest keep
their own fallback.
@RohanK6
RohanK6 force-pushed the crew/conductor/untitled-placeholder branch from 1893ae6 to 11e4e62 Compare November 13, 2026 22:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the whole diff on this head, and all checks are green.

  • Each changed site swaps a hand-written title !== key test for main's own isUntitledSession or sessionDisplayTitle (website/src/utils/sessionDisplayTitle.ts on main). That helper also counts the backend's exact New Session… / New Session... placeholder and an empty title as untitled, and it uses plain equality, with no regex. A real title, "New Session Planning" included, behaves as before.
  • Display sites (the flyout, row stub, both cleanup lists, phone top bar) now show the localized "Untitled session" label the row already shows, instead of the key or the English placeholder.
  • Sites that need a value keep their own fallback: the rename box opens empty, a dragged reference and a short-name match keep the key, and the share and popout URLs get no slug. So an untitled session's link no longer reads /chat/new-session.
  • Identity is untouched: keys still drive navigation and actions everywhere.
  • Frontend only, no new refusal. The tests cover the stub label, the phone bar, the URL slugs and the short-name match, and the history spec says what is still left (the browser tab and popout window titles).

Approving.

@bolichen97
bolichen97 merged commit 9030de0 into main Nov 14, 2026
97 of 98 checks passed
@bolichen97
bolichen97 deleted the crew/conductor/untitled-placeholder branch November 14, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Untitled sessions show the English "New Session…" placeholder in the rename box, row stub, flyout and cleanup lists

3 participants