Repository navigation
fix(dashboard): treat the untitled placeholder as no title everywhere - #36482
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: every site now uses the existing Notes
[DESIGN-REVIEWED] 11e4e62 Description read[DESCRIPTION-READ] 638ec61c591563ffdfe9f86b6b487bc3adfac7e763e51fc54614a9cc1d3fa23a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every site now goes through the existing What this change shipsInventory (9 items) — 9 justifiedIntent: a non-English reader never sees the backend's English
[FIRST-PRINCIPLES-REVIEWED] 11e4e62 Description read[DESCRIPTION-READ] cca538b467bf310a15cc84ae249b8f98ac8923e58d25831482a19afcd8bd2be8 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the phone top bar, the collapsed-sidebar flyout and the rename box. The diff changes what each of them shows, but the only screenshots are of the session-cleanup dialog. Evidence gaps
Notes
[UX-REVIEWED] 11e4e62 Description read[DESCRIPTION-READ] f29d0f00290b0c5e04946da1908969341ab59e7d4b5f99c596cd34545a4276da That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Every changed site swaps its own An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
47ba62b to
a7d0b9c
Compare
a7d0b9c to
6e69187
Compare
6e69187 to
3cdce35
Compare
3cdce35 to
1893ae6
Compare
The backend sends an open untitled session with the English title 'New Session…'. isUntitledSession already reads that as no title for the sidebar rows, but other sites compared the title with the key only, so the placeholder showed through in every language: the rename box, a row's scroll stub, the collapsed sidebar's flyout, the cleanup lists, a Bot thread's tooltip, the command center, and the chat, share and popout URL slugs. Each now asks isUntitledSession; the session lists read 'Untitled session' like the row, and the rest keep their own fallback.
1893ae6 to
11e4e62
Compare
bolichen97
left a comment
There was a problem hiding this comment.
I read the whole diff on this head, and all checks are green.
- Each changed site swaps a hand-written
title !== keytest for main's ownisUntitledSessionorsessionDisplayTitle(website/src/utils/sessionDisplayTitle.tson main). That helper also counts the backend's exactNew Session…/New Session...placeholder and an empty title as untitled, and it uses plain equality, with no regex. A real title, "New Session Planning" included, behaves as before. - Display sites (the flyout, row stub, both cleanup lists, phone top bar) now show the localized "Untitled session" label the row already shows, instead of the key or the English placeholder.
- Sites that need a value keep their own fallback: the rename box opens empty, a dragged reference and a short-name match keep the key, and the share and popout URLs get no slug. So an untitled session's link no longer reads
/chat/new-session. - Identity is untouched: keys still drive navigation and actions everywhere.
- Frontend only, no new refusal. The tests cover the stub label, the phone bar, the URL slugs and the short-name match, and the history spec says what is still left (the browser tab and popout window titles).
Approving.
Problem / Motivation
Goal: An open untitled session never shows the backend's English
New Session…placeholder, in any language.The backend sends every open untitled session with the title
New Session….isUntitledSessionalready reads that as no title, so sidebar rows, tabs and the palette say "Untitled session". Other sites compared the title with the key only, so the English placeholder passed through as a title: the rename box opened pre-filled with it, a row's scroll stub, the collapsed sidebar's flyout and the two cleanup lists showed it, a Bot thread's tooltip read<Bot>: New Session…, and the chat, share and popout URLs got a/new-sessionslug.Why it matters
Every non-English reader sees English text where the session's name should be, and a share link names a session "new-session" when it has no name.
Not a goal
shell/appShell.tsx,PopoutFrame.tsx): fix(dashboard): leave the untitled placeholder out of window titles #36419.New Session…apart from an untitled one.isUntitledSessionalready reads that exact text as no title on main for the rows, tabs and palette; carrying the backend's untitled state as a flag would be a new field on the slot payload.What changed (motivation → approach → change)
Cause: each site spelled its own
title && title !== keytest, which knows nothing of the placeholder. Change: each now asksisUntitledSession, the one check the rows already use.chat/SessionFlyout.tsx,chat-sidebar/rows.ts(a row's scroll stub, so the stub and the row agree),chat-sidebar/sessionCleanup.tsx,chat-sidebar/FolderCleanupPanel.tsx.chat/page/MobileTopBar.tsx) reads the chat page's title throughsessionDisplayTitle, as the desktop title row (SessionTitleControl) already does: the chat page now hands it the key for an untitled session, which the bar would otherwise show raw.SessionRow.tsx, both entry points), the Bot tooltip keeps the Bot's name alone, a dragged session reference carries the key (SessionRow.tsx,dnd/useSidebarDrag.ts), the command center node title (command-center/model.ts), the chat page title (ChatPage.tsx), the URL slugs (useChatPageSessionController.ts,utils/shareUrl.ts,utils/chatPopout.ts) and a short-name match (utils/sessionKeys.ts).Spec:
docs/system-specs/modules/history.md.Backwards compatibility
Compatible: a titled session reads exactly as before; only the placeholder stops being taken as a title, and the four session lists show the label where they showed the key.
Removes nothing: no key, prop, route or export is removed.
Tests
src/test/untitledPlaceholderSlug.test.ts(new): the share link and popout URL carry no slug for either ellipsis spelling, a real title still slugs, and a short-name match is titled by the key. 4 of its 5 tests fail on main.src/test/MobileTopBar.untitledTitle.test.tsx(new): the phone bar reads "Untitled session" for the key or the placeholder, and a real title as it is. 2 of its 3 tests fail without the bar's change.src/pages/chat-sidebar/rows.test.ts: the stub is titled the way its row is, the placeholder included (fails on main).ArtifactDetailPage.test.tsx, fails on main too.Proof: not provable -- frontend test
Manual verification
The cleanup list rendered with the app's CSS and i18n through a local harness, before and after, in English and German (below).
Screenshots / video
Before (main), German: the untitled session reads
New Session….After, German: it reads "Unbenannte Sitzung", as the sidebar row does.
English
Related Issues
Fixes #36412
Sibling sweep
Swept: git grep -nE "title !== [a-zA-Z.]*(key|Key|slot|Slot)" -- website/src
Sibling: website/src/shell/appShell.tsx -- tracked in #36419
Sibling: website/src/pages/chat-sidebar/SessionRow.tsx -- changed here
Sibling: website/src/pages/chat-sidebar/dnd/useSidebarDrag.ts -- changed here
Pattern harvest
Rule candidate: lint
Pattern: a
title !== keycomparison outsideutils/sessionDisplayTitle.ts, which misses the backend's untitled placeholder.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.