Skip to content

fix: four 0.12.2-rc.1 release-line reds - #35623

Merged
bolichen97 merged 1 commit into
release/0.12.0from
fix/0.12.2-rc1-reds
Nov 11, 2026
Merged

bolichen97 merged 1 commit into
release/0.12.0from
fix/0.12.2-rc1-reds

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Clear the four reds that failed the v0.12.2-rc.1 release run on release/0.12.0, so v0.12.2-rc.2 can be tagged.

Run 43102437814 failed its builds and two test shards on the 0.12.2 version commit 3d06d4604b.

Why it matters

No stable 0.12.2 can ship without a green same-commit prerelease run, and every desktop build and the wheel failed to compile.

Not a goal

What changed (motivation → approach → change)

  • website/src/components/UpdateModal.tsx: the batch 6 backport carried main's setDismissed('ready'); release's dismiss state is a boolean, so it is setDismissed(true) here (TS2345 in every build).
  • src/kiro_crew/dashboard/handlers/updates.py: the facade's type-checking block names _running_version, which updates_step_up.py now serves (test_updates_handlers_facade.py).
  • test/test_update_boot_apply.py: the SIGTERM test's wait gets the 30 s ceiling the wait-discipline ratchet requires.
  • setup.cfg: markdown-it-py>=3,<4.3, as main has since fix: clear the two main breaks in backend tests #34646. 4.3.0 (2026-11-10) reads an HTML block opener as ASCII only and fails test_session_markdown; this was red on release before batch 6 too.

Backwards compatibility

No behaviour change. The dependency range narrows to the versions 0.12.1 already ran on.

Tests

test_updates_handlers_facade.py, test_update_boot_apply.py and test_wait_discipline_ratchet.py pass locally on this tree, one file at a time. test_session_markdown.py[long-s] was reproduced on a DevSpace: it fails with markdown-it-py 4.3.0 on this tree, on the tree before batch 6 and on v0.12.1, and passes with 4.0, 4.1 and 4.2. The full suites run on the v0.12.2-rc.2 release run.

Proof: not provable -- other: release-line build and test fixes; the release run is the proof

Manual verification

N/A: build and test fixes.

Screenshots / video

N/A: no visual change.

Related Issues

0.12.2 hotfix; release run 43102437814.

Pattern harvest

Not generalizable: release-line backport fallout and a dependency drift main already pinned.

Checklist

  • At most two commits, with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

The backport of the update fix used main's string dismiss state in
UpdateModal, which is a boolean on release, so tsc failed the wheel and
desktop builds. The updates facade's type-checking block lacked the
_running_version name the step-up module now serves, and the boot apply
SIGTERM test waited 10 s, under the 30 s wait-ratchet ceiling.

markdown-it-py 4.3.0 (2026-11-10) reads an HTML block opener as ASCII
only, which fails test_session_markdown on a fresh install. Keep it below
4.3, as main does since #34646.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 11, 2026 22:15
@bolichen97
bolichen97 requested review from buluoray and removed request for a team November 11, 2026 22:15
@bolichen97
bolichen97 merged commit b659923 into release/0.12.0 Nov 11, 2026
16 of 21 checks passed
@bolichen97
bolichen97 deleted the fix/0.12.2-rc1-reds branch November 11, 2026 22:15
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 0abd464559dd14b9338a70775d41bd600d06bb61 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The only frontend change is a one-token type fix: setDismissed('ready') becomes setDismissed(true) in UpdateModal.tsx. It adds and changes no control, label or state that a user would see.

[UX-REVIEWED] 0abd464

Description read

[DESCRIPTION-READ] 69a65a93d345d99368e233fa4374685af22768027ca15db37c5e7e4c870ce76a

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 0abd464559dd14b9338a70775d41bd600d06bb61 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

All four items fix release-run reds that a failing build, a failing test or a ratchet pins. None of them changes the product's shape.

What this change ships

Inventory (4 items) — 4 justified

Intent: Make the 0.12.2 release line green so v0.12.2-rc.2 can be tagged. This is a FIX.

  1. The dashboard and desktop builds compile again: the update modal's "ask agent" handoff dismisses using the boolean state the release branch has — justified
  2. Type checkers and the facade test see _running_version re-exported from the updates handler facade — justified
  3. The boot-apply SIGTERM test now waits up to 30 s for its start signal instead of 10 s, as the wait-discipline ratchet requires — justified
  4. Installs now reject markdown-it-py 4.3 and later, matching main's fix: clear the two main breaks in backend tests #34646 pin, because 4.3.0 fails test_session_markdown — justified

[FIRST-PRINCIPLES-REVIEWED] 0abd464

Description read

[DESCRIPTION-READ] 057aec02483bc1898a8b9ff0775ff3a6ecf9871e3534b724ace9ac6cc02a7ec7

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0abd464559dd14b9338a70775d41bd600d06bb61 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design concerns: four small fixes to backport fallout on the release line. The only thing removed is markdown-it-py 4.3 and later, which the description gives a reason for, and the same pin is already on main.

Notes

[DESIGN-REVIEWED] 0abd464

Description read

[DESCRIPTION-READ] a05dd3ddc1c9dc4a4bb8c6047829517aaaf304048eebd224e45e93e79d96de97

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0abd464559dd14b9338a70775d41bd600d06bb61 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0abd464

Verdict parsed from the review's SHA-scoped output markers for commit 0abd464559dd14b9338a70775d41bd600d06bb61.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0abd464559dd14b9338a70775d41bd600d06bb61 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 0abd464559dd14b9338a70775d41bd600d06bb61. Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging.

This comment is updated in place on each push.

BLOCKING -- test/test_update_boot_apply.py:335 -- Replace the raised literal with a derived lost-run ceiling

await asyncio.wait_for(started.wait(), timeout=30)
Trigger: The POSIX SIGTERM test schedules apply_armed_update_at_boot() and awaits its patched child’s startup event with a literal deadline increased from 10 to 30 seconds.
Outcome: The test triples its failure deadline without the measurement-backed ceiling required by tests-are-deterministic D8; a missing startup signal now occupies the worker for 20 additional seconds.
Anchor: tests-are-deterministic
Fix: Await the same startup event through await_until, using its runner-derived deadline, or use a named lost-run ceiling with the required measurement.

[BLOCK-MERGE] 0abd464
[GPT-REVIEWED] 0abd464

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 — The finding is anchored to tests-are-deterministic, which is marked blocking: true in .review-base-rules/AUTOSDE.yaml:369-370. That rule's D8 clause (:422-429) explicitly flags a diff that "RAISES a literal" timeout. The diff does exactly that at test/test_update_boot_apply.py:335, raising wait_for(..., timeout=10) to 30 with no cited measurement. The rule's flag outranks any harm-versus-cost weighing here.

[ADJUDICATION] 0abd464559dd14b9338a70775d41bd600d06bb61 total=1 uphold=1 downgrade=0
UPHOLD F1 test/test_update_boot_apply.py:335 reason=autosde-blocking-rule
[GPT-ADJUDICATED] 0abd464559dd14b9338a70775d41bd600d06bb61

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0abd464559dd14b9338a70775d41bd600d06bb61 false-positive: <reason, 20 to 500 characters>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant