Repository navigation
fix: four 0.12.2-rc.1 release-line reds - #35623
Conversation
The backport of the update fix used main's string dismiss state in UpdateModal, which is a boolean on release, so tsc failed the wheel and desktop builds. The updates facade's type-checking block lacked the _running_version name the step-up module now serves, and the boot apply SIGTERM test waited 10 s, under the 30 s wait-ratchet ceiling. markdown-it-py 4.3.0 (2026-11-10) reads an HTML block opener as ASCII only, which fails test_session_markdown on a fresh install. Keep it below 4.3, as main does since #34646.
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The only frontend change is a one-token type fix: [UX-REVIEWED] 0abd464 Description read[DESCRIPTION-READ] 69a65a93d345d99368e233fa4374685af22768027ca15db37c5e7e4c870ce76a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS All four items fix release-run reds that a failing build, a failing test or a ratchet pins. None of them changes the product's shape. What this change shipsInventory (4 items) — 4 justifiedIntent: Make the 0.12.2 release line green so
[FIRST-PRINCIPLES-REVIEWED] 0abd464 Description read[DESCRIPTION-READ] 057aec02483bc1898a8b9ff0775ff3a6ecf9871e3534b724ace9ac6cc02a7ec7 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design concerns: four small fixes to backport fallout on the release line. The only thing removed is markdown-it-py 4.3 and later, which the description gives a reason for, and the same pin is already on main. Notes
[DESIGN-REVIEWED] 0abd464 Description read[DESCRIPTION-READ] a05dd3ddc1c9dc4a4bb8c6047829517aaaf304048eebd224e45e93e79d96de97 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- test/test_update_boot_apply.py:335 -- Replace the raised literal with a derived lost-run ceiling
[BLOCK-MERGE] 0abd464 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — The finding is anchored to False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Clear the four reds that failed the
v0.12.2-rc.1release run onrelease/0.12.0, sov0.12.2-rc.2can be tagged.Run 43102437814 failed its builds and two test shards on the 0.12.2 version commit
3d06d4604b.Why it matters
No stable 0.12.2 can ship without a green same-commit prerelease run, and every desktop build and the wheel failed to compile.
Not a goal
mainbeyond what main already has (the markdown-it-py pin is main's fix: clear the two main breaks in backend tests #34646; the wait ceiling goes to main in its own PR).What changed (motivation → approach → change)
website/src/components/UpdateModal.tsx: the batch 6 backport carried main'ssetDismissed('ready'); release's dismiss state is a boolean, so it issetDismissed(true)here (TS2345 in every build).src/kiro_crew/dashboard/handlers/updates.py: the facade's type-checking block names_running_version, whichupdates_step_up.pynow serves (test_updates_handlers_facade.py).test/test_update_boot_apply.py: the SIGTERM test's wait gets the 30 s ceiling the wait-discipline ratchet requires.setup.cfg:markdown-it-py>=3,<4.3, as main has since fix: clear the two main breaks in backend tests #34646. 4.3.0 (2026-11-10) reads an HTML block opener as ASCII only and failstest_session_markdown; this was red on release before batch 6 too.Backwards compatibility
No behaviour change. The dependency range narrows to the versions 0.12.1 already ran on.
Tests
test_updates_handlers_facade.py,test_update_boot_apply.pyandtest_wait_discipline_ratchet.pypass locally on this tree, one file at a time.test_session_markdown.py[long-s]was reproduced on a DevSpace: it fails with markdown-it-py 4.3.0 on this tree, on the tree before batch 6 and on v0.12.1, and passes with 4.0, 4.1 and 4.2. The full suites run on thev0.12.2-rc.2release run.Proof: not provable -- other: release-line build and test fixes; the release run is the proof
Manual verification
N/A: build and test fixes.
Screenshots / video
N/A: no visual change.
Related Issues
0.12.2 hotfix; release run 43102437814.
Pattern harvest
Not generalizable: release-line backport fallout and a dependency drift main already pinned.
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.