Skip to content

fix(update): list _running_version in the updates facade's type-checking imports - #35614

Closed
CrysisDeu wants to merge 1 commit into
mainfrom
crew/build-watcher/wait-boot-apply-main
Closed

CrysisDeu wants to merge 1 commit into
mainfrom
crew/build-watcher/wait-boot-apply-main

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Keep main's updates-facade test green after the boot-apply change landed.

Since 5638488 (#35088), src/kiro_crew/dashboard/handlers/updates_step_up.py imports __version__ as _running_version, but the facade's TYPE_CHECKING list of names served from outside the family does not name it. test/test_updates_handlers_facade.py::test_every_name_served_from_outside_the_family_is_visible_to_type_checkers fails: Right contains 1 more item: {'_running_version': ('kiro_crew', '__version__')}. Seen on the v0.12.2-rc.1 release run (43102437814, Test Release Candidate SHA (4)); main has the same files.

Why it matters

The next Nightly and every full test run of main go red on this test. PR CI runs it only when a PR touches the update modules, so it stays hidden until then.

Not a goal

What changed (motivation → approach → change)

Facade test red → the facade's manifest is missing one served name → add from kiro_crew import __version__ as _running_version # noqa: F401 # isort: skip at the end of the "names it serves from outside the family" block in src/kiro_crew/dashboard/handlers/updates.py. The isort: skip is needed because isort folds two aliases of one name into a single line and drops the second noqa, which makes flake8 report F401; release/0.12.0's copy of this line (#35623) has that isort red.

Backwards compatibility

Compatible: one TYPE_CHECKING-only import that never runs.

Removes nothing: the facade only gains a type-checking name.

Tests

  • test/test_updates_handlers_facade.py: the facade manifest now matches the names it serves.

Proof: not provable -- other: the change is a TYPE_CHECKING import read only by an AST scan test

Local checks: isort --check-only, flake8 and black --check pass on the file.

Manual verification

N/A — static manifest change; CI runs the facade test.

Related Issues

Wait-ceiling fix for the same merge: #35625.

Sibling sweep

Swept: git grep -n "import version as _" -- src/kiro_crew/dashboard/handlers/
Siblings: none -- updates_step_up.py is the only updates owner that binds a new alias of version

Pattern harvest

Not generalizable: the facade test already catches this class; it ran only after merge because PR CI skipped it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 11, 2026 21:49
@CrysisDeu
CrysisDeu requested a review from buluoray November 11, 2026 21:49
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 58f66032d18d56af33b127261916a3e4609dbcc1 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 58f66032d18d56af33b127261916a3e4609dbcc1 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (1 items) — 1 justified

Intent: keep main's updates-facade manifest test green after #35088 added a new served name. This is a FIX.

  1. The updates facade's type-checking list now names _running_version, the alias updates_step_up.py:18 already binds — justified

[FIRST-PRINCIPLES-REVIEWED] 58f6603

Description read

[DESCRIPTION-READ] 3fcc94ce3418f4a63f25681e711c50afcb8a52e889e7d7696a45deab7f1469e8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 58f66032d18d56af33b127261916a3e4609dbcc1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is one TYPE_CHECKING-only import that adds the missing name to the updates facade's manifest of names served from outside the family, which is what the failing test is about. It changes nothing at runtime and removes nothing.

[DESIGN-REVIEWED] 58f6603

Description read

[DESCRIPTION-READ] 68d9a20936ab5537554f821b620267dbcecd94ad8dfd465c95f64033520205e8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 58f66032d18d56af33b127261916a3e4609dbcc1 — this comment is updated in place on each push.

Review details

A TYPE_CHECKING-only import; no runtime effect.

No findings.

[OPUS-REVIEWED] 58f6603

Verdict parsed from the review's SHA-scoped output markers for commit 58f66032d18d56af33b127261916a3e4609dbcc1.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 58f66032d18d56af33b127261916a3e4609dbcc1 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 58f66032d18d56af33b127261916a3e4609dbcc1 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 58f6603

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 58f66032d18d56af33b127261916a3e4609dbcc1 false-positive: <reason, 20 to 500 characters>

@CrysisDeu
CrysisDeu force-pushed the crew/build-watcher/wait-boot-apply-main branch from 7510b35 to 644e589 Compare November 11, 2026 22:04
@CrysisDeu CrysisDeu changed the title test(update): wait on the boot apply's start signal, not a 10s ceiling test(update): wait on the boot apply's start signal and list _running_version in the updates facade Nov 11, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 11, 2026
@CrysisDeu
CrysisDeu force-pushed the crew/build-watcher/wait-boot-apply-main branch from 644e589 to a00c946 Compare November 11, 2026 22:37
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 11, 2026
@CrysisDeu
CrysisDeu force-pushed the crew/build-watcher/wait-boot-apply-main branch from a00c946 to 58f6603 Compare November 11, 2026 22:37
@CrysisDeu CrysisDeu changed the title test(update): wait on the boot apply's start signal and list _running_version in the updates facade fix(update): list _running_version in the updates facade's type-checking imports Nov 11, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approve at 58f6603. Together with #35625 this turns main's backend tests green again.

Main is red since #35088: test_updates_handlers_facade.py::test_every_name_served_from_outside_the_family_is_visible_to_type_checkers fails on Backend Tests (3.12, 6) and (Windows) (4). On current main the failure reads Right contains 1 more item: {'_running_version': ('kiro_crew', '__version__')}, so the facade serves _running_version but does not list it where type checkers can see it.

Checked: I merged this PR and #35625 onto current main (e8283ce) and ran test_updates_handlers_facade.py, test_update_boot_apply.py and test_wait_discipline_ratchet.py: 81 passed. With this PR alone the facade test passes and the two wait-ratchet tests still fail, as the description says; #35625 covers those.

The change is one import line at the end of the block in dashboard/handlers/updates.py that lists, for type checkers, the names the facade serves from other modules. No behaviour change.

@bolichen97

Copy link
Copy Markdown
Contributor

The same _running_version TYPE_CHECKING import landed on main in #35625 (e1b079c), so this PR now conflicts and has nothing left to add. Leaving it to you to close. [operator: bolichen97]

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 12, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Superseded by #35625, which merged the same updates facade line and the wait fix into main. Closing; branch kept.

@CrysisDeu CrysisDeu closed this Nov 12, 2026
auto-merge was automatically disabled November 12, 2026 02:18

Pull request was closed

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants