Repository navigation
fix(dashboard): keep the Bots nav dot beside a long name, not over it - #35648
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a small, reversible CSS change, and the PR includes rendered evidence of this revision. Notes
[DESIGN-REVIEWED] 2cefa5f Description read[DESCRIPTION-READ] ddb8edb53e02ab8569f12e2f8f668716aa1107239daa1b96ad5af7656fca4b3d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: a mechanism-level fix with a linked issue (#35633), a test that fails on base, and no new surface. What this change shipsInventory (4 items) — 4 justifiedIntent: A starred Bot's dot sits beside its name in the expanded nav, and a long name ends in "…" before the dot instead of being covered by it. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 2cefa5f Description read[DESCRIPTION-READ] 3513bbeb10db6772b37668bd6479aa58ba4939ea3eee22a893ef6656663c33cc That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The dot now sits in its own space beside the name in every expanded state the screenshots show (light, dark, hover). The collapsed rail looks the same before and after, as the PR intends. Notes
[UX-REVIEWED] 2cefa5f Description read[DESCRIPTION-READ] 6a8100ffce4e0ca583aa55df8dc049092d8a263198ecd80947b9c43dff017ba3 That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This is a small CSS fix and it does what it says. In The touch and collapsed branches in The old class string appears nowhere else in the repo, so no other test or snapshot depended on it. The new tests check the expanded dot's structure (not An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Inherited red from main, not this diff (frontend-only): Backend Tests (Windows) (2) |
The expanded rail drew the Bots row dot and the Settings update dot absolute at right-2. An absolute box takes no room in the row's flex line, so the truncating label ran under the dot. Both dots are now in-flow shrink-0 siblings after the label, like NavBadge's own marks. Collapsed and phone-tile dots stay in the icon corner. Closes #35633
454c6bf to
2cefa5f
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: frontend bug fix that moves the expanded nav unread dot into the flex line so a long Bot name truncates before it, with tests pinning the layout classes.
Problem / Motivation
Goal: A Bot's dot in the left nav sits beside its name, and a long name ends in "…" before the dot instead of under it.
In the expanded left nav, a starred Bot with an unread reply, a turn that needs you, or work running shows a small dot. When the Bot's name reaches the row's right edge, the dot is drawn on top of the last letters ("Kiro Web Developmen●"). The Sessions row's count pill, by contrast, sits cleanly beside its label.
Why it matters
Anyone who stars a Bot with a longer name sees its name cut by the dot in every theme. The Bots section is persistent chrome on every page, so the glitch is always on screen while a Bot has news.
Not a goal
What changed (motivation → approach → change)
Dot drawn over the name → the dot was
absolute right-2, which takes no room in the row's flex line, so theflex-1 truncatelabel ran under it → the expanded dot is now an in-flowshrink-0sibling after the label. The label shrinks and truncates before the dot, the same wayNavBadge's count pill already does.matesDock.tsx)navRail.tsx)The Settings dot had the same placement and gets the same fix. With today's short English label it shows no change, but a label long enough to reach the edge (a longer translation) would run under it. The
navRow.tsxcomment that said caller-supplied badges are absolute now says expanded badges must be in flow.Backwards compatibility
Compatible: only the expanded dot's CSS position changes; the dot's role, label and when it shows are the same.
Removes nothing: no prop, key, path or data is removed or narrowed.
Tests
matesDock.test.tsx: the wide row's dot is in flow (shrink-0, notabsolute), shares the name's flex line and comes after the truncating name; the narrow row's dot staysabsolutein the corner.Proof: not provable -- frontend test (prove.py runs Python only)
Reverting the three production files by hand makes the new wide-row test fail (1 failed, 42 passed); with the fix all 43 pass.
vitest relatedon the changed files: 538 files passed.Manual verification
Built the SPA and captured the real dock with a stubbed gateway (as
capture/shoot-dock-mate-signals.mjsdoes), with long and short names, unread dots on two rows, light and dark, hover, and the collapsed rail. Before: the dot covers "Development". After: the name ends in "…" and the dot sits apart. Collapsed rail unchanged.Screenshots / video
Settings row with its update dot. The English label is short, so before and after look the same; the dot now holds its own space for a longer label.
Hovered row (light) and collapsed rail
Related Issues
Closes #35633
Sibling sweep
Swept: git grep -nE "absolute[^'"]*right-[0-9][^'"]*rounded-full" -- website/src/shell website/src/pages/chat-sidebar
Sibling: website/src/shell/nav/navRail.tsx:408 -- changed here
Sibling: website/src/shell/nav/navRow.tsx:21 -- not affected -- collapsed arms only (lines 21 and 127); the expanded arms are already in flow
Sibling: website/src/shell/topbar/shellHeader.tsx:137 -- not affected -- badge on an icon-only button with no text to cover
Sibling: website/src/pages/chat-sidebar/SessionRow.tsx:1549 -- not affected -- a drag drop-line spanning the row, not a dot
Pattern harvest
Rule candidate: lint
Pattern: a
NavItembadgewhose expanded (non-collapsed) arm isabsoluteoverlaps the truncating label; expanded badges must be in-flowshrink-0.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement