Skip to content

fix(dashboard): keep the Bots nav dot beside a long name, not over it - #35648

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
crew/kiro-crew-contribution/dock-dot-overlap
Nov 12, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
crew/kiro-crew-contribution/dock-dot-overlap

Conversation

@dwu96

@dwu96 dwu96 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Bot's dot in the left nav sits beside its name, and a long name ends in "…" before the dot instead of under it.

In the expanded left nav, a starred Bot with an unread reply, a turn that needs you, or work running shows a small dot. When the Bot's name reaches the row's right edge, the dot is drawn on top of the last letters ("Kiro Web Developmen●"). The Sessions row's count pill, by contrast, sits cleanly beside its label.

Why it matters

Anyone who stars a Bot with a longer name sees its name cut by the dot in every theme. The Bots section is persistent chrome on every page, so the glitch is always on screen while a Bot has news.

Not a goal

  • No change to when a dot shows, its colour, or its accessible name.
  • No change to the collapsed rail or the phone rail: their dot sits in the icon's corner, where no name is drawn.

What changed (motivation → approach → change)

Dot drawn over the name → the dot was absolute right-2, which takes no room in the row's flex line, so the flex-1 truncate label ran under it → the expanded dot is now an in-flow shrink-0 sibling after the label. The label shrinks and truncates before the dot, the same way NavBadge's count pill already does.

Row Expanded rail Collapsed / phone
Bots row (matesDock.tsx) in flow, after the name unchanged, icon corner
Settings update dot (navRail.tsx) in flow, after the name unchanged, icon corner

The Settings dot had the same placement and gets the same fix. With today's short English label it shows no change, but a label long enough to reach the edge (a longer translation) would run under it. The navRow.tsx comment that said caller-supplied badges are absolute now says expanded badges must be in flow.

Backwards compatibility

Compatible: only the expanded dot's CSS position changes; the dot's role, label and when it shows are the same.

Removes nothing: no prop, key, path or data is removed or narrowed.

Tests

  • matesDock.test.tsx: the wide row's dot is in flow (shrink-0, not absolute), shares the name's flex line and comes after the truncating name; the narrow row's dot stays absolute in the corner.

Proof: not provable -- frontend test (prove.py runs Python only)

Reverting the three production files by hand makes the new wide-row test fail (1 failed, 42 passed); with the fix all 43 pass. vitest related on the changed files: 538 files passed.

Manual verification

Built the SPA and captured the real dock with a stubbed gateway (as capture/shoot-dock-mate-signals.mjs does), with long and short names, unread dots on two rows, light and dark, hover, and the collapsed rail. Before: the dot covers "Development". After: the name ends in "…" and the dot sits apart. Collapsed rail unchanged.

Screenshots / video

Before After
Light before light after light
Dark before dark after dark

Settings row with its update dot. The English label is short, so before and after look the same; the dot now holds its own space for a longer label.

Before After
Settings, light before settings light after settings light
Settings, dark before settings dark after settings dark
Hovered row (light) and collapsed rail
Before After
Hover before hover after hover
Collapsed before collapsed after collapsed

Related Issues

Closes #35633

Sibling sweep

Swept: git grep -nE "absolute[^'"]*right-[0-9][^'"]*rounded-full" -- website/src/shell website/src/pages/chat-sidebar
Sibling: website/src/shell/nav/navRail.tsx:408 -- changed here
Sibling: website/src/shell/nav/navRow.tsx:21 -- not affected -- collapsed arms only (lines 21 and 127); the expanded arms are already in flow
Sibling: website/src/shell/topbar/shellHeader.tsx:137 -- not affected -- badge on an icon-only button with no text to cover
Sibling: website/src/pages/chat-sidebar/SessionRow.tsx:1549 -- not affected -- a drag drop-line spanning the row, not a dot

Pattern harvest

Rule candidate: lint
Pattern: a NavItem badge whose expanded (non-collapsed) arm is absolute overlaps the truncating label; expanded badges must be in-flow shrink-0.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@dwu96
dwu96 requested review from a team and KiroCrewCaptain as code owners November 11, 2026 23:17
@dwu96
dwu96 requested a review from cruisercohen November 11, 2026 23:17
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2cefa5f1ec85714a7ed5703000e618aa6551a482 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a small, reversible CSS change, and the PR includes rendered evidence of this revision.

Notes

  • The PR proposes a lint rule as a pattern-harvest follow-up. A narrower option: give NavItem one in-flow dot slot instead of having each caller pass a class string.

[DESIGN-REVIEWED] 2cefa5f

Description read

[DESCRIPTION-READ] ddb8edb53e02ab8569f12e2f8f668716aa1107239daa1b96ad5af7656fca4b3d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2cefa5f1ec85714a7ed5703000e618aa6551a482 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: a mechanism-level fix with a linked issue (#35633), a test that fails on base, and no new surface.

What this change ships

Inventory (4 items) — 4 justified

Intent: A starred Bot's dot sits beside its name in the expanded nav, and a long name ends in "…" before the dot instead of being covered by it. This is a FIX.

  1. In the expanded nav, a Bot row's dot now takes its own space after the name, and a long name truncates before it. — justified
  2. In the expanded nav, the Settings update dot now takes its own space after the label the same way, so a long translated label truncates before it. — justified
  3. The navRow.tsx comment now says an expanded badge must be in flow, replacing the old note that caller badges are absolute. — justified
  4. New tests pin that the wide row's dot is in flow after the name and the collapsed row's dot stays in the corner. — justified

[FIRST-PRINCIPLES-REVIEWED] 2cefa5f

Description read

[DESCRIPTION-READ] 3513bbeb10db6772b37668bd6479aa58ba4939ea3eee22a893ef6656663c33cc

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2cefa5f1ec85714a7ed5703000e618aa6551a482 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2cefa5f

Verdict parsed from the review's SHA-scoped output markers for commit 2cefa5f1ec85714a7ed5703000e618aa6551a482.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2cefa5f1ec85714a7ed5703000e618aa6551a482 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 2cefa5f1ec85714a7ed5703000e618aa6551a482 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The dot now sits in its own space beside the name in every expanded state the screenshots show (light, dark, hover). The collapsed rail looks the same before and after, as the PR intends.

Notes

  • The blind reader could not say what the purple dot means ("new? unread? busy? needs attention?"). The dot already worked this way before this PR, so it is not a finding here. A follow-up could show its existing aria-label (for example "Unread message") as a title on the Bot rows, as the Settings dot already does.

[UX-REVIEWED] 2cefa5f

Description read

[DESCRIPTION-READ] 6a8100ffce4e0ca583aa55df8dc049092d8a263198ecd80947b9c43dff017ba3

That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2cefa5f1ec85714a7ed5703000e618aa6551a482 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2cefa5f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2cefa5f1ec85714a7ed5703000e618aa6551a482 false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

KiroCrewCaptain commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This is a small CSS fix and it does what it says. In NavItem the row is a flex line, and the label is a flex-1 min-w-0 truncate span with {badge} rendered last. Before, the expanded dot was absolutely positioned, so it took no room and was drawn over the label's last letters. It is now an in-flow shrink-0 sibling, so the label shrinks and ends in "…" before the dot.

The touch and collapsed branches in matesDock.tsx, the collapsed branch in navRail.tsx, and the collapsed-only Settings dot in App.tsx are all unchanged, which matches the PR's stated non-goals. The dot's role, aria-label and the conditions for showing it are unchanged.

The old class string appears nowhere else in the repo, so no other test or snapshot depended on it. The new tests check the expanded dot's structure (not absolute, has shrink-0, shares the name's parent and comes after it) and that the collapsed dot stays absolute. Per the PR's own run, the expanded test fails without the fix. The rewritten navRow.tsx comment now describes the real requirement correctly.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 2cefa5f1ec · 35 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@dwu96

dwu96 commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Inherited red from main, not this diff (frontend-only): Backend Tests (Windows) (2) test_wait_discipline_ratchet.py::test_the_scan_matches_known_sites and (Windows) (4) test_updates_handlers_facade.py::test_every_name_served_from_outside_the_family_is_visible_to_type_checkers. Both fail on clean main at 619d46a, tracked in #35660 (facade half in #35614). Waiting for the fix to land, then rebasing; no override for this red.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 12, 2026
The expanded rail drew the Bots row dot and the Settings update dot
absolute at right-2. An absolute box takes no room in the row's flex
line, so the truncating label ran under the dot. Both dots are now
in-flow shrink-0 siblings after the label, like NavBadge's own marks.
Collapsed and phone-tile dots stay in the icon corner.

Closes #35633
@dwu96
dwu96 force-pushed the crew/kiro-crew-contribution/dock-dot-overlap branch from 454c6bf to 2cefa5f Compare November 12, 2026 02:38
@dwu96

dwu96 commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main e1b079c, which carries #35625: it fixes the two inherited Windows backend reds (#35660). New head 2cefa5f; CI is re-running. No change to this PR's diff.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 12, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 12, 2026 05:03

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: frontend bug fix that moves the expanded nav unread dot into the flex line so a long Bot name truncates before it, with tests pinning the layout classes.

@KiroCrewCaptain
KiroCrewCaptain merged commit d9c01ba into main Nov 12, 2026
101 of 102 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the crew/kiro-crew-contribution/dock-dot-overlap branch November 12, 2026 05:04
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bots nav row: the unread dot covers the end of a long Bot name

2 participants