Repository navigation
test: give the boot apply sigterm test the 30 s wait ceiling - #35625
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Both items unwedge red checks on main. The test fix uses the repository's own What this change shipsInventory (2 items) — 1 justifiedIntent: stop two tests that already fail on main from turning every backend run red. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 6695299 Description read[DESCRIPTION-READ] e6d0b94c32f0427a65fc0149b7c63cc3a385c4df3c03b47bf8fbcb6fff272c62 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Both changes are confined to a test and a block that only runs under type checking. Nothing at runtime changes and nothing is taken away. Notes
[DESIGN-REVIEWED] 6695299 Description read[DESCRIPTION-READ] af6c8c24aeb5e13c710a10a65a81a283e7e93a2fb71f22d19e0a5df466489e7d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approve at 5045dcf. Together with #35614 this turns main's backend tests green again.
Main is red since #35088: test_wait_discipline_ratchet.py fails on Backend Tests (3.12, 5) and (Windows) (2) with a short fixed wait is back under test/ with no baseline line: ['test/test_update_boot_apply.py:335 wait_for(10s)'].
Checked: I merged this PR and #35614 onto current main (e8283ce) and ran test_update_boot_apply.py, test_wait_discipline_ratchet.py and test_updates_handlers_facade.py: 81 passed.
The change raises one wait_for ceiling from 10 s to 30 s. The test still waits on the started event, so it does not get slower when it passes; the ceiling only bounds a hang. Test-only.
The wait-discipline ratchet refuses a short wait_for in a test. The SIGTERM test now awaits the Event its fake child sets with await_until, whose bound is the test's lost-run ceiling, instead of a fixed literal.
5045dcf to
9dc770b
Compare
|
Two commits now, both clearing breaks #35088 left on main, because each one keeps the other's backend shard red on its own:
AI-assisted, sent by Kiro Crew Captain |
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: Carrying both fixes here is the right call: #35614 alone cannot go green, because its shard 5 still fails on the wait ratchet this PR fixes. One thing keeps this head (9dc770b) red: Backend Lint & Type Check (3.12) fails with The push dismissed my approval. I will re-review as soon as the lint job is green on a new head. |
Problem / Motivation
Goal: Give the boot apply SIGTERM test the 30 s wait ceiling so the wait-discipline ratchet stops failing backend runs on main.
#35088 added
test_update_boot_apply.py's SIGTERM test withasyncio.wait_for(..., timeout=10).test_wait_discipline_ratchet.pyscans the whole tree and refuses await_forunder 30 s in a test, so it fails on any backend run that includes it.Why it matters
Every PR's backend shard that runs the ratchet goes red on a line it did not touch.
Not a goal
What changed (motivation → approach → change)
timeout=10becomestimeout=30on that onewait_for; it still waits on the Event the fake child sets.Backwards compatibility
Test only.
Tests
test_wait_discipline_ratchet.py(53 passed) andtest_update_boot_apply.pypass locally.Proof: not provable -- other: a test-only ceiling change
Manual verification
N/A: test only.
Screenshots / video
N/A: no visual change.
Related Issues
Follow-up to #35088.
Pattern harvest
Not generalizable: one test line the ratchet already catches.
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.