Repository navigation
docs(rfc): a code channel's Stop also stops its helper agents - #35935
Conversation
Records the decision before the code: Stop in a code channel stops the channel's own session and every helper agent the gateway's records tie to it, says how many it stopped, keeps a stopped helper stopped, and restart resume never resumes a turn a Stop ended. Docs only; the code follows after #21993.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only decision record; no design-level concerns. Notes
[DESIGN-REVIEWED] 9c82724 Description read[DESCRIPTION-READ] 74560b10f074f7852663a288e70dfbcff0af14e2a826dff1bca9dc6330e45e4f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Docs-only RFC amendment that records the decision that Stop in a Slack code channel also stops the channel's helper agents and their sub-agents, and that nothing restarts until a person sends a message. The claims about today's behaviour check out in the code: _stop_bound only checks the bound slot and posts "Nothing running." when idle (routing.py:1837-1864), the native Stop passes say_idle=False (routing.py:1942), and the store records helper agents at birth (store.py:708 record_worker). The trust boundary is unchanged (owner-only Stop; release only on a gateway-recorded person's message), and the lifecycle after a Stop, including restart resume, is covered. Status stays in-progress, with no code or behaviour change. Design Review passed; UX and First Principles skipped it as docs-only, and the Opus, GPT and Security Scope review lanes were still pending. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
bolichen97
left a comment
There was a problem hiding this comment.
Approving, docs only. I read the RFC hunks and the index row.
Design brief
- What it decides. Stop (
!stopor Slack's Stop) in a code channel stops the channel's own turn, every helper agent the gateway's own code-channel store ties to that session, and their sub-agents. Afterwards nothing restarts on its own (no patrol, timer, report wake or scheduled job) until a person sends a message, and whose message it is comes from the gateway's record, not the text. - Pros. Stop becomes a real brake. Today an idle channel session answers "Nothing running." while its helpers keep editing code. Who may press Stop is unchanged (owner only, admitted conversation and workspace), so it adds no security strictness.
- Cons. A person who wanted only the channel's own turn stopped now stops the helpers too. A per-helper Stop is left to #22928's Workers tab, which covers that.
- Long-term debt. Low. It builds on the store the code channels already keep. The code follows in its own PR after #21993.
The front-matter refresh (audited-at: 6ded84fc02, implementation-prs: [21425, 21410, 22001]) matches what has shipped.
Direction signed by maintainer (bolichen97).
|
This RFC changes what the shipped code-channel Stop does (it would also stop the helper agents), so a maintainer needs to accept it before it can merge. A maintainer will post the decision here. Review result: no blocking findings on this head. This is a docs-only change to two files under docs/request-for-change/. The review checked each claim about today's behaviour against main:
The updated Optional:
|
Slack's Stop and !stop in a code channel now stop the channel's own running turn, the running turn of every helper agent the code-channel store ties to that session, and the sub-agents those turns started, and say how many they stopped, naming each stopped helper the work board shows. Nothing is held afterwards: a queued wake or a patrol can start a stopped helper again until the follow-up hold change lands. Implements the brake of RFC #35935.
Slack's Stop and !stop in a code channel now stop the channel's own running turn, the running turn of every helper agent the code-channel store ties to that session, and the sub-agents those turns started, and say how many they stopped, naming each stopped helper the work board shows. Nothing is held afterwards: a queued wake or a patrol can start a stopped helper again until the follow-up hold change lands. Implements the brake of RFC #35935.
Slack's Stop and !stop in a code channel now stop the channel's own running turn, the running turn of every helper agent the code-channel store ties to that session, and the sub-agents those turns started, and say how many they stopped, naming each stopped helper the work board shows. Nothing is held afterwards: a queued wake or a patrol can start a stopped helper again until the follow-up hold change lands. Implements the brake of RFC #35935.
Slack's Stop and !stop in a code channel now stop the channel's own running turn, the running turn of every helper agent the code-channel store ties to that session, and the sub-agents those turns started, and say how many they stopped, naming each stopped helper the work board shows. Nothing is held afterwards: a queued wake or a patrol can start a stopped helper again until the follow-up hold change lands. Implements the brake of RFC #35935. Co-authored-by: Kyle Seaman <kseam@dev-dsk-kseam-1b-55230d27.us-east-1.amazon.com>
Problem / Motivation
Goal: Record the decision that Stop in a Slack code channel stops the channel's own session and its helper agents, before any code for it is written.
Today Stop in a code channel (Slack's Stop button or
!stop) stops only the channel's own session. If that session is idle while its helper agents are running,!stopanswers "Nothing running.", Slack's Stop button says nothing, and every helper agent keeps going:_stop_boundinslack/code_channels/routing.pylooks up only the channel's bound slot (verified on main6ded84fc02).Why it matters
Stop is the person's brake. A Stop that leaves agents editing code is wrong, and the person has no way to see from the channel that they kept going.
The owner left this call to the Slack Code team lead, who decided it. On #22001 the First Principles lane blocked every head because the restart-resume RFC text arrived in the same diff as its code, so the owner had to re-post an override on each push. This time the decision lands first, as a docs-only change the owner approves and merges, and the code pull request then has a recorded decision on main behind it.
Not a goal
src/ortest/change is in this pull request. The code follows in its own pull request after feat(slack): conductor work board in code channels #21993, which edits the same Stop function.What changed (motivation → approach → change)
The decision is recorded in
docs/request-for-change/rfc-slack-code-channels.md, which main already carries asin-progress. A new "Stop" item in §3 (code channels) says:The document's status line gets a dated amendment line saying who decided and that nothing is built yet. The front matter's
last-audited,audited-atandimplementation-prsare brought up to date (#21425, #21410 and #22001 are merged). The index row indocs/request-for-change/README.mdrecords the amendment.Backwards compatibility
Compatible: documentation only; no code, config or behaviour changes.
Removes nothing: the change only adds text and corrects the RFC's audit fields; no section, decision or reader goes away.
Tests
Proof: not provable -- docs or config only
Docs lint and the prepush gate pass on this head.
Manual verification
N/A — documentation only. Every statement about today's behaviour was checked in the code on main
6ded84fc02.Related Issues
None. This records a decision; the code pull request follows after #21993.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.