Repository navigation
Conversation
Clicking option chips joined the draft and each pick with ", ", which
produced "Looks good., Merge it now" and "Merge it now, Show me the
diff". A draft that already ends with punctuation now gets only a
space, a capitalised pick starts a new sentence (". "), and a
lowercase pick keeps ", ". Labels are never re-cased.
3d6d5c8 to
a45cca5
Compare
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: every item is part of the one stated Goal, and the defect is reproduced in the description ("Looks good., Merge it now"). What this change shipsInventory (4 items) — 4 justifiedIntent: let people click several option chips and send the composer text without fixing its punctuation by hand. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] a45cca5 Description read[DESCRIPTION-READ] 9346849b6e398055ffc2ef879537d7fbddcda4c9281301517d66f1ccca64d441 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: this changes only the punctuation that chip picks write into the composer. Screenshots show the before and after for both cases and for dark mode, and the blind reader read the new joins as clean sentences. Notes
[UX-REVIEWED] a45cca5 Description read[DESCRIPTION-READ] e1c8f11d1d9bd2034f26c1b6135d7744e8178773375285668377af2e1ca934e0 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a small, reversible change to a pure render function, the owned-span model is untouched, and screenshots of this revision are attached. Notes
[DESIGN-REVIEWED] a45cca5 Description read[DESCRIPTION-READ] d3a993cf2167f8114d9811cc2d2640cda3d4fafd877b09342b70124c8da2203b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: the title's category is not one of fix, test, chore, refactor. renderTail now chooses the separator before each piece: a space after existing punctuation, '. ' before a capitalised piece, otherwise ', '. The function is pure and gives the same result for the same input, and every caller (append, remove, single-select ownership checks in ChatPane, followUpChips and the useComposerDraft single-select path) compares against the same renderTail, so the owned-span model and the edited-tail check still work. Nothing else in the repo reads chip text back by ', '. The SDK multi-select path is untouched, as the description says. The code matches the description's table, and the new unit tests cover each separator rule and re-rendering after a middle removal. CI is green apart from the Publish readiness signal meta-check. Tier: 2, held for a person: the title's category is not one of fix, test, chore, refactor. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result on this head: no blocking findings. PR Readiness is green. The change stays inside Optional:
|
Problem / Motivation
Goal: Picking several follow-up options fills the composer with text that reads like sentences.
The option chips joined the draft and every pick with
,. Two capitalised picks read "Merge it now, Show me the diff", and a draft that already ended a sentence got a second separator: "Looks good., Merge it now".Why it matters
The composer text is what gets sent. People who type a short note and then click one or more chips have to fix the punctuation by hand before they send.
Not a goal
CR-123,Kiro), so a lowercased first letter would change them.app-sdk/useComposerDraft.ts). It reads picks back from the draft by their,separators, so changing it needs its own change to that read-back. Its single-select path already goes throughfollowUpToggleand gets the new rule.What changed (motivation → approach → change)
renderTailinlib/followUpToggle.tsnow picks the separator before each piece instead of always using,:.!?;:,or…, with optional closing quotes or brackets.,The owned-span model is unchanged: the tail is still rendered from
{ base, options }, so removing a pick re-renders the separators around it and the "user edited the tail" check still compares against the exact rendered text.Backwards compatibility
Compatible. No setting, API or stored state changes. Only the text a chip click writes into the composer changes.
Tests
followUpToggle.test.ts: a draft ending with a period, a question mark, a comma, or a closing quote after a period gets only a space; two capitalised picks join with.; a lowercase pick joins with,; removing the middle of three picks re-renders the separators; a label ending with.gets only a space before the next pick.ChatPage.followUpToggle,ChatPane.followUpOptionsanduseComposerDraft(single-select): expected strings updated to the new separators. The comma-bearing label tests (fix(chat): remove only the complete generated suffix on a ChatPane chip un-toggle #7616 F1) use lowercase labels and keep,.Local gates:
tsc -p tsconfig.app.json, eslint on the changed files, and vitest on the follow-up, composer, ChatEmbed and QuickSend test files all pass.Manual verification
Built SPA in two isolated pods with fake data, one on
mainand one on this branch. One session ends with[OPTIONS: Merge it now | Show me the diff | Run the tests].Screenshots / video
Dark theme, two picks:
Related Issues
N/A: no issue filed.
Checklist