Skip to content

chore(settings): label the crew_oauth preview as MCP sign-in, not GitHub sign-in - #36300

Merged
iamwhatever merged 1 commit into
mainfrom
chore/crew-oauth-generic-label
Nov 13, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
chore/crew-oauth-generic-label

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Feature preview switch for dashboard.feature_previews.crew_oauth says what it really turns on: Crew-owned MCP sign-in, not only GitHub.

Settings > Developer > Feature previews shows the switch as "GitHub sign-in by Kiro Crew", and its description and hint name only GitHub. The switch governs every MCP sign-in Crew holds for Kiro Agent (KAS) chats: GitHub, Asana, the Google Connections, the DCR cards, and owner-added servers (#35692).

Why it matters

An owner who wants Crew to sign in to Asana, Google or their own MCP server has no reason to turn on a switch labelled "GitHub". The label hides the feature.

Not a goal

  • Renaming the config key crew_oauth or dashboard.feature_previews.crew_oauth (persisted config).
  • Any behavior change: which servers Crew signs in to, or how.
  • Changing the Connections page or its path text.

What changed (motivation → approach → change)

The switch is now called "MCP sign-in by Kiro Crew". Its description lists GitHub, Asana, Google and servers you add. Its hint says Crew passes the sign-in to chats on a harness it supports, such as Kiro Agent, Claude or Codex, and kiro-cli chats sign in as before.

Part Change
Label, description, hint new text in en.manual.json and all 11 translated catalogs; en-XA regenerated
Settings registry, UI index (settingsRegistry.gen.ts, src/kiro_crew/docs/settings-registry.generated.json, src/kiro_crew/docs/ui-index.generated.json) regenerated with npm run gen:settings and npm run gen:ui
Search id the label-derived id becomes developer.mcp-sign-in-by-kiro-crew; settingsSearchCore.ts's preview id list follows it, so LTS still hides the search hit; useSettingHighlight.ts maps the old id to the new one, so old ?highlight= links still land on the row
Docs src/kiro_crew/docs/connections.md names the preview by its new label
Code comments two comments in previewFlags.ts and FeaturePreviewsSection.tsx say MCP sign-in for bridged harnesses, not GitHub sign-in for KAS

Backwards compatibility

Compatible: the config key and its stored value are untouched; only display text and the generated search id change.

Removes nothing: the switch, its key and its behavior stay; the old search id is aliased to the new one in LEGACY_ID_EXACT, and its one other reader, PREVIEW_FLAG_SETTING_IDS, is updated.

Tests

No new test: text-only change. Related tests pass locally: npm run i18n:check, and vitest on catalogParity, changedValueQa, settingsSearchGovernance, ltsFeaturePreviewsOff, previewSurfaces, FeaturePreviewsEditionRows, featurePreviewsSectionNotice, FeaturePreviewIntro, settingHighlightAliases, useSettingHighlightLegacyReuse, useSettingHighlightKeyPrefix (11 files); tsc -p tsconfig.app.json clean.

Manual verification

Built the dist and rendered Settings > Developer > Feature previews with the gateway-free stub harness: the row reads "MCP sign-in by Kiro Crew" with the new description, and hovering its ⓘ shows the new hint.

Screenshots / video

Feature previews row after

The row's hint tooltip open

Related Issues

Closes #36292
Refs #35692

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 8) fails on test/test_reply_format_once.py::TestEveryMessageWhereTheBlockCannotBeTakenOut::test_the_table_names_every_selectable_harness (missing mimocode row). That is main's red, tracked in #36279 with fix PRs #36290 and #36315; this PR does not touch that table. The review lanes, PR Policy and Dependency License Gate failed on the installation-token rate limit. This PR waits for the main fix, then rebases once.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 13, 2026
@iamwhatever
iamwhatever force-pushed the chore/crew-oauth-generic-label branch from f7d8b48 to 3cdb5dd Compare November 13, 2026 03:29
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/* (same files as this PR) and carries the main-red fix #36290 since this head ran CI (9b32941 -> 27e9359); generators re-run clean, related tests green; CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only renames the label and text, the config key stays the same, and the one reader of the old search id outside generated files is aliased.

Notes

  • The search id comes from the label, so any later rename will again need a new LEGACY_ID_EXACT alias and a matching PREVIEW_FLAG_SETTING_IDS edit. A stable id keyed on crew_oauth would stop that, but it belongs in a follow-up.

[DESIGN-REVIEWED] 087b27a

Description read

[DESCRIPTION-READ] 85056acdd8cd597fba3bac226fc6a0329e8b201c381182f7aa2a3745c932cb83

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The relabel fixes a defect that connections/crew_oauth.py confirms: the switch already covers Asana, Google and DCR cards. The old "GitHub" label hid that.

Notes

  • Item 3 — undeclared: the hint's new claim, "passes the sign-in to chats on a harness it supports, such as Kiro Agent, Claude or Codex", adds harness promises that the Goal ("not only GitHub") does not ask for. Subtraction: cut the hint back to "Kiro Crew signs in to MCP servers itself. Disconnect a server on Connections to remove access." That drops the harness list and the kiro-cli sentence, which would otherwise have to stay in sync with backend support across 12 catalogs.

What this change ships

Inventory (5 items) — 4 justified

Intent: let an owner see that the Feature preview switch turns on Crew-owned sign-in for every MCP server, not only GitHub. FIX (relabel).

  1. Feature preview label reads "MCP sign-in by Kiro Crew" in all locales — justified
  2. Description lists GitHub, Asana, Google and servers you add — justified
  3. Hint names supported harnesses (Kiro Agent, Claude, Codex) and says kiro-cli chats sign in as before — undeclared; goes past the Goal
  4. Settings search id becomes developer.mcp-sign-in-by-kiro-crew, and old ?highlight= links still land on the row — justified
  5. connections.md and two code comments use the new name — justified

[FIRST-PRINCIPLES-REVIEWED] 087b27a

Description read

[DESCRIPTION-READ] dbbfd62a830b05e45350e5a7cfc409209a3266d757bd40e6d7f8022a092d0b45

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader understood the renamed switch correctly, and both screenshots show the new label, description and hint.

Notes

  • The new hint reads "passes the sign-in to chats on a harness it supports, such as Kiro Agent, Claude or Codex. kiro-cli chats sign in as before." The blind reader couldn't follow "harness", "Kiro Agent", "Claude", "Codex" or "kiro-cli". They also read "harness" as clashing with the "Agent Harness" settings tab. Suggested hint: "Kiro Crew signs in to MCP servers for you and shares that sign-in with chats. Disconnect a server on Connections to remove access."
  • "MCP" in the label is never spelled out, and the reader said so: "I don't know what 'MCP' means". The description could open with "MCP servers (tools such as GitHub, Asana, Google)…" so the examples explain the term.
  • The description says "connect them in Settings > Connections". The reader couldn't find "Connections" in either visible menu column. If that page is somewhere other than a Settings tab, the path should name where it really is.

[UX-REVIEWED] 087b27a

Description read

[DESCRIPTION-READ] 86f9dd644854b355e5666d2cd55fe0ef50b5dc8f4da08a8348ba5965903cfea8

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 087b27a

Verdict parsed from the review's SHA-scoped output markers for commit 087b27ab7f7c2967418da2a7d35acf2e1555c9e6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 087b27a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 087b27ab7f7c2967418da2a7d35acf2e1555c9e6 false-positive: <reason, 20 to 500 characters>

…Hub sign-in

The dashboard.feature_previews.crew_oauth switch governs every MCP server
sign-in Crew holds for Kiro Agent chats (GitHub, Asana, Google, DCR cards,
owner-added servers), but its label, description and hint named only GitHub.
Text only: the config key is unchanged.

Part of #36292
@iamwhatever
iamwhatever force-pushed the chore/crew-oauth-generic-label branch from 3cdb5dd to 087b27a Compare November 13, 2026 03:46
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=5ef05ce21ab4 The Kiro-Agent-only claim misstates which chats receive signed-in connections

fixed in 087b27a: crew_oauth_desc and crew_oauth_desc_summary no longer say Kiro Agent only; the hint says Crew passes the sign-in to chats on a harness it supports (Kiro Agent, Claude, Codex), matching ACP_BACKENDS_CREW_OAUTH_BRIDGE, and keeps that kiro-cli chats sign in as before. All 12 catalogs and both registries regenerated.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=1eace6a1a3b3 crew_oauth_desc says for Kiro Agent chats only

fixed in 087b27a: the hint drops the 'only' claim and names bridged harnesses (Kiro Agent, Claude, Codex) per serves_backend / ACP_BACKENDS_CREW_OAUTH_BRIDGE; kiro-cli stays excluded. Every locale and both generated registries updated; the connections.md:303 note now names the preview 'MCP sign-in by Kiro Crew'.

@iamwhatever

iamwhatever commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=4e31c4064052 "MCP sign-in by Kiro Crew" leads with an unexplained acronym

Rebutted (owner ruling): the owner explicitly asked for an MCP-based name for this switch ("Crew-owned MCP OAuth") and ruled to keep "MCP sign-in by Kiro Crew" unchanged.
The dashboard already uses MCP as the user-facing term for these servers: the "MCP Servers" page under Customize.
The description right under the label names GitHub, Asana and Google in plain words, so a reader who does not know the acronym still sees what the switch covers.
Evidence gap closed in 087b27a: a second screenshot shows the hint tooltip open with the new text.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@iamwhatever
iamwhatever enabled auto-merge (squash) November 13, 2026 05:49

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the whole diff at 087b27a, tests included. The twelve locale files were checked by their changed lines.

This is a label and description rename only. The feature preview for Crew-owned sign-in is renamed from "GitHub sign-in by Kiro Crew" to "MCP sign-in by Kiro Crew", with a description that says it covers the MCP servers Kiro Crew signs in to (GitHub, Asana, Google and servers the owner adds), passes the sign-in to chats on a harness it supports, and leaves kiro-cli chats signing in as before. That matches what the linked bug reports: the preview already governs every Crew-owned MCP sign-in, and its old name only said GitHub.

What I checked:

  • No behavior and no default changes. The setting key dashboard.feature_previews.crew_oauth is unchanged and stays off by default. No file that reads the key, and nothing in the connections code, is touched. The edits are the settings registry, the generated UI index, the command-palette entries, the locale strings, a comment, and one docs table cell.
  • The setting id changes with the label (developer.github-sign-in-by-kiro-crew becomes developer.mcp-sign-in-by-kiro-crew). A legacy-id mapping is added so an old highlight link or saved search still lands on the preview, and the preview-flag id set uses the new id.
  • Across the twelve locale files, the only changed lines are the three crew_oauth strings in each (78 lines in all), and nothing else in them moves.
  • No regex and no new refusal.

All checks are green. Approving without auto, since the author already holds it.

@iamwhatever
iamwhatever merged commit 7b37d72 into main Nov 13, 2026
186 of 204 checks passed
@iamwhatever
iamwhatever deleted the chore/crew-oauth-generic-label branch November 13, 2026 06:08
@adlio adlio mentioned this pull request Nov 13, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature preview 'GitHub sign-in by Kiro Crew' is mislabeled: it governs every Crew-owned MCP sign-in

2 participants