Repository navigation
chore(settings): label the crew_oauth preview as MCP sign-in, not GitHub sign-in - #36300
Conversation
|
Backend Tests (3.12, 8) fails on |
f7d8b48 to
3cdb5dd
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only renames the label and text, the config key stays the same, and the one reader of the old search id outside generated files is aliased. Notes
[DESIGN-REVIEWED] 087b27a Description read[DESCRIPTION-READ] 85056acdd8cd597fba3bac226fc6a0329e8b201c381182f7aa2a3745c932cb83 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The relabel fixes a defect that Notes
What this change shipsInventory (5 items) — 4 justifiedIntent: let an owner see that the Feature preview switch turns on Crew-owned sign-in for every MCP server, not only GitHub. FIX (relabel).
[FIRST-PRINCIPLES-REVIEWED] 087b27a Description read[DESCRIPTION-READ] dbbfd62a830b05e45350e5a7cfc409209a3266d757bd40e6d7f8022a092d0b45 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader understood the renamed switch correctly, and both screenshots show the new label, description and hint. Notes
[UX-REVIEWED] 087b27a Description read[DESCRIPTION-READ] 86f9dd644854b355e5666d2cd55fe0ef50b5dc8f4da08a8348ba5965903cfea8 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…Hub sign-in The dashboard.feature_previews.crew_oauth switch governs every MCP server sign-in Crew holds for Kiro Agent chats (GitHub, Asana, Google, DCR cards, owner-added servers), but its label, description and hint named only GitHub. Text only: the config key is unchanged. Part of #36292
3cdb5dd to
087b27a
Compare
|
|
|
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed the whole diff at 087b27a, tests included. The twelve locale files were checked by their changed lines.
This is a label and description rename only. The feature preview for Crew-owned sign-in is renamed from "GitHub sign-in by Kiro Crew" to "MCP sign-in by Kiro Crew", with a description that says it covers the MCP servers Kiro Crew signs in to (GitHub, Asana, Google and servers the owner adds), passes the sign-in to chats on a harness it supports, and leaves kiro-cli chats signing in as before. That matches what the linked bug reports: the preview already governs every Crew-owned MCP sign-in, and its old name only said GitHub.
What I checked:
- No behavior and no default changes. The setting key
dashboard.feature_previews.crew_oauthis unchanged and stays off by default. No file that reads the key, and nothing in the connections code, is touched. The edits are the settings registry, the generated UI index, the command-palette entries, the locale strings, a comment, and one docs table cell. - The setting id changes with the label (
developer.github-sign-in-by-kiro-crewbecomesdeveloper.mcp-sign-in-by-kiro-crew). A legacy-id mapping is added so an old highlight link or saved search still lands on the preview, and the preview-flag id set uses the new id. - Across the twelve locale files, the only changed lines are the three
crew_oauthstrings in each (78 lines in all), and nothing else in them moves. - No regex and no new refusal.
All checks are green. Approving without auto, since the author already holds it.
Problem / Motivation
Goal: The Feature preview switch for
dashboard.feature_previews.crew_oauthsays what it really turns on: Crew-owned MCP sign-in, not only GitHub.Settings > Developer > Feature previews shows the switch as "GitHub sign-in by Kiro Crew", and its description and hint name only GitHub. The switch governs every MCP sign-in Crew holds for Kiro Agent (KAS) chats: GitHub, Asana, the Google Connections, the DCR cards, and owner-added servers (#35692).
Why it matters
An owner who wants Crew to sign in to Asana, Google or their own MCP server has no reason to turn on a switch labelled "GitHub". The label hides the feature.
Not a goal
crew_oauthordashboard.feature_previews.crew_oauth(persisted config).What changed (motivation → approach → change)
The switch is now called "MCP sign-in by Kiro Crew". Its description lists GitHub, Asana, Google and servers you add. Its hint says Crew passes the sign-in to chats on a harness it supports, such as Kiro Agent, Claude or Codex, and kiro-cli chats sign in as before.
en.manual.jsonand all 11 translated catalogs;en-XAregeneratedsettingsRegistry.gen.ts,src/kiro_crew/docs/settings-registry.generated.json,src/kiro_crew/docs/ui-index.generated.json)npm run gen:settingsandnpm run gen:uideveloper.mcp-sign-in-by-kiro-crew;settingsSearchCore.ts's preview id list follows it, so LTS still hides the search hit;useSettingHighlight.tsmaps the old id to the new one, so old?highlight=links still land on the rowsrc/kiro_crew/docs/connections.mdnames the preview by its new labelpreviewFlags.tsandFeaturePreviewsSection.tsxsay MCP sign-in for bridged harnesses, not GitHub sign-in for KASBackwards compatibility
Compatible: the config key and its stored value are untouched; only display text and the generated search id change.
Removes nothing: the switch, its key and its behavior stay; the old search id is aliased to the new one in
LEGACY_ID_EXACT, and its one other reader,PREVIEW_FLAG_SETTING_IDS, is updated.Tests
No new test: text-only change. Related tests pass locally:
npm run i18n:check, and vitest oncatalogParity,changedValueQa,settingsSearchGovernance,ltsFeaturePreviewsOff,previewSurfaces,FeaturePreviewsEditionRows,featurePreviewsSectionNotice,FeaturePreviewIntro,settingHighlightAliases,useSettingHighlightLegacyReuse,useSettingHighlightKeyPrefix(11 files);tsc -p tsconfig.app.jsonclean.Manual verification
Built the dist and rendered Settings > Developer > Feature previews with the gateway-free stub harness: the row reads "MCP sign-in by Kiro Crew" with the new description, and hovering its ⓘ shows the new hint.
Screenshots / video
Related Issues
Closes #36292
Refs #35692
Checklist