Skip to content

feat(app-kit): offer the project picker to apps through the sdk - #36322

Merged
bolichen97 merged 1 commit into
mainfrom
feat/w4-project-scaffolder
Nov 14, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/w4-project-scaffolder

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An installed app can open the dashboard's own project picker, so Create Folders From Project keeps its Browse picker when it moves to its own repository.

The project picker (Favorites, Recent, Browse, the desktop app's system folder picker, New folder) lives in the dashboard bundle, and only a built-in page can import it. Create Folders From Project opens it from its Choose directory button. A copy of that app installed from its own repository (the campaign in #26967) has no way to reach it, so it would lose the picker and leave the user typing an absolute path.

Why it matters

Moving a built-in out of core must not change what its users see. Without a picker an app can open, the adopted Create Folders page would drop the way most people choose a project directory, and every other app that asks for a project directory would have to rebuild a picker of its own against the same host endpoints.

Not a goal

  • Moving or deleting the Create Folders built-in, its page or its host endpoints (/api/project-scaffold/*): its app repository and its adoption pin are separate steps.
  • Changing the picker itself, or what any existing dashboard surface shows.
  • A picker over the app's scoped transport with its own error copy (see What changed).

What changed (motivation → approach → change)

ProjectPicker (website/src/app-sdk/ProjectPicker.tsx, exported from app-sdk/index.ts and the vendor stub) joins @kirocrew/app-sdk at App Kit level 7. Other seams share that level, so an app feature-detects the export, never the level alone; the level-7 rows in both docs name it. Whether it mounts follows the identity the host published, as the pull-request panel does: a built-in page gets the picker; an external app gets it only once its permissions.api admits every path the picker sends (the module-local PROJECT_PICKER_PATHS, which the SDK does not re-export because an app declares paths in its static manifest: /api/browse-dirs, /api/browse-dirs/create for New folder, /api/recent-projects, /api/favorite-projects), each checked on its own so an exact =/api/browse-dirs entry does not admit New folder's write. Otherwise it sees a refusal naming the missing path, with nothing sent. A page with no app identity fails closed.

The mounted picker keeps the dashboard's client rather than a client over the app's scoped transport. Its failure notices read that client's deadlines, error codes and journaled reports, so a second client would word the same refusal differently in an app. The check before mount covers every request it can send, and a scoped request carries the dashboard user's own authority too, so this grants nothing the scoped transport would not. The export takes no errorHandoff and no footer, and its refusal offers no Ask the agent hand-off: the hand-off navigates to the chat and unmounts the app page, losing the form the picker opens from.

The Create Folders built-in now declares the three bare families (/api/browse-dirs, /api/recent-projects, /api/favorite-projects), which admit all four paths, beside /api/project-scaffold. A built-in approves what it ships, so its adopted copy can declare the same set without E9 calling it a widening. Spec: §18i in app-kit-platform.md; app authors: "Project Picker" in docs/app-kit/api-reference.md. One new catalog string (the refusal, appSdk.projectPicker.not_declared) in all 12 website/src/i18n/locales/ catalogs, with en-XA.json regenerated.

Backwards compatibility

Compatible: the picker and every dashboard surface that opens it are unchanged; the SDK gains one export at its current level, and an app that does not look for it sees nothing new.
Removes nothing: the change only adds an export and three declared paths on one built-in.

Tests

  • website/src/test/AppSdkProjectPicker.test.tsx: the per-path refusal and its message, the exact-entry refusal naming /api/browse-dirs/create, no hand-off on the refusal, the three identity answers (external declared or not, builtin, none), the props passed through (no errorHandoff), nothing rendered while closed; and, against the real picker source and the real dashboard client, that every api. member the picker and its New folder form call sends to a path PROJECT_PICKER_PATHS names itself, so a new endpoint in the picker fails this test until the list names it. Dropping /api/browse-dirs/create from the list, or putting askAgent back on the refusal, turns it red.
  • src/kiro_crew/apps/builtins/project_scaffolder/tests/test_manifest.py: the built-in declares exactly its page's paths, and, through the gateway's own pattern matcher, its three families admit every path in the SDK constant and each family admits one (source checkout only).
  • Existing: the vendor-stub parity tests (appSharedModuleBoundary, chatProtocolBoundary), appSdkTypes, the i18n parity suite and test_app_sdk_level_mirror.py pass with the new export and string.
  • Determinism: test_manifest.py passed 10 repeated runs and one run with its 12 tests in reversed order; AppSdkProjectPicker.test.tsx passed 10 repeated runs and one --sequence.shuffle run (seed 36322).

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

On an isolated loopback gateway from this branch, with the Create Folders app's own repository (KiroCrewCaptain/kirocrew-app-project-scaffolder) adopted in place through a harness pin row: the adopted page loaded its own bundle at /project-scaffolder, Choose directory opened the dashboard's picker through this export (Favorites, Recent, Browse), and a scan from the page worked. A throwaway external app that declares none of the families rendered the refusal and sent no picker request.

Screenshots / video

The dashboard's picker opened from the adopted app's own page (external identity, families declared):

The Create Folders page served from the app's repository, with the dashboard's project picker open on its Browse tab

The same page as the built-in shows it today, for comparison:

The built-in Create Folders page with the same project picker open on its Browse tab

An external app that declares none of the picker's paths gets the refusal, with nothing sent. This capture predates removing the Ask the agent link from the notice; the message text is unchanged, and the test above pins the notice without it:

A test app page showing the inline refusal: This app can't show the project picker: its permissions don't declare /api/browse-dirs

Related Issues

Part of #26967

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 13, 2026 02:34
@bolichen97
bolichen97 enabled auto-merge (squash) November 13, 2026 02:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of e954c5f89918d2d432449034a21ef4b8fbb0256b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the picker is the dashboard's existing one, the blind reader read it correctly, and the new refusal is in a screenshot.

Notes

  • The refusal "This app can't show the project picker: its permissions don't declare {{path}}." only ever shows up for a misconfigured app, and its wording matches the pull-request panel's existing refusal. Still, the blind reader found the part after the colon "gibberish", so an end user shown it has nothing to act on. A follow-up could split it into a plain sentence for users (for example "This app isn't set up to choose folders") with the missing path kept for developers.
  • shot-03 still shows the Ask the agent link, which this PR removes. Re-capture the notice without it so the screenshot matches what ships.

[UX-REVIEWED] e954c5f

Description read

[DESCRIPTION-READ] 95959f675e828fddf9512101aebef26a54a1ce5ae3277eeb103cf745987565bf

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of e954c5f89918d2d432449034a21ef4b8fbb0256b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns. The access check runs before mount and covers every path the picker sends, and a test pins that list against the picker's real source.

Notes

  • The mounted picker sends its requests through the dashboard's client instead of the app's scoped transport, so the gateway's per-app token check never sees them. That is safe only while the PROJECT_PICKER_PATHS source-scan test stays green. A new picker request routed outside api. would get past it.

[DESIGN-REVIEWED] e954c5f

Description read

[DESCRIPTION-READ] 830efb73e8ee30f928b2a3bc5cd6daa016bacb0d7995fa2905ef7f410e66e955

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of e954c5f89918d2d432449034a21ef4b8fbb0256b — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: the export removes a named harm, the adopted Create Folders app losing its Browse picker under #26967, which no existing seam already does.

Not checked: the in-repo consumer count; the only consumer is the external app repository the description names.

Notes

  • Item 1 — zero in-repo consumers: grepping ProjectPicker under website/src/app-sdk and project_scaffolder/ finds only the defining site, the index re-export and tests. The only consumer is the external kirocrew-app-project-scaffolder repository, which the description shows only through manual verification. The no-built-in-apps rule (AGENTS.md) requires that consumer to live outside, so this is not a blocker.

What this change ships

Inventory (5 items) — 5 justified

Intent: let an app installed from its own repository open the dashboard's project picker, so Create Folders keeps Browse after it leaves core. ADDITION.

  1. Apps can open the dashboard's project picker through @kirocrew/app-sdk at level 7 — justified
  2. An external app that does not declare all four picker paths sees a refusal naming the first missing one, and nothing is sent — justified
  3. The refusal has no "Ask the agent" hand-off, unlike the pull-request panel's — justified
  4. The Create Folders built-in now declares the three picker path families in its manifest — justified
  5. One new refusal string, translated in all 12 locale catalogs — justified

[FIRST-PRINCIPLES-REVIEWED] e954c5f

Description read

[DESCRIPTION-READ] b7160fc1242815fb1ee347ee4bebeb8720d94cac4265a7bc04758272e6ac7200

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed e954c5f89918d2d432449034a21ef4b8fbb0256b — this comment is updated in place on each push.

Review details

No findings.

Notes:

  • The spec says in §18i that "A built-in that opens the picker declares the families in its own manifest." That is not true of Issue Radar: RepoSettings.tsx opens components/ProjectPicker, but its app.json declares only /api/apps/issue-radar*. The built-in works as shipped, but the sentence should be narrowed or Issue Radar's manifest updated before it moves out.

[OPUS-REVIEWED] e954c5f

Verdict parsed from the review's SHA-scoped output markers for commit e954c5f89918d2d432449034a21ef4b8fbb0256b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e954c5f89918d2d432449034a21ef4b8fbb0256b false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of e954c5f89918d2d432449034a21ef4b8fbb0256b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e954c5f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e954c5f89918d2d432449034a21ef4b8fbb0256b false-positive: <reason, 20 to 500 characters>

KiroCrewCaptain added a commit to KiroCrewCaptain/kirocrew-app-project-scaffolder that referenced this pull request Nov 13, 2026
* feat: Create Folders From Project as a standalone Kiro Crew app

Port the built-in app from kirodotdev/KiroCrew (src/kiro_crew/apps/builtins/
project_scaffolder and website/src/apps/project-scaffolder at 9b32941be66d)
into a repository of its own, so an existing user's copy can move onto it in
place and a new user can install it from the App Store.

The page is the built-in's, built into a committed ESM bundle: the same
markup, strings and requests, with its requests over the app's scoped client
and the project picker taken from the App SDK (level 7,
kirodotdev/KiroCrew#36322). The manifest keeps the built-in's name,
permissions, platform and defaultEnabled. PORTING.md lists every difference.

* fix: replace process.env in the bundled animation library at build time

The page crashed on its first animated row in a real dashboard: library
mode left framer-motion's process.env.NODE_ENV checks in the bundle, and
a browser has no process. The jsdom tests define one, so only a gateway
run showed it. The bundle now names no process.env, pinned by a test.
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from b9e703d to 86c1558 Compare November 13, 2026 06:33
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • No rendered evidence for the new app-facing picker and its refusal span=e43ad79d1fd0

Rebutted: the evidence is attached; the lane read the description before it was. The body now carries three user-attachments images: the picker open on the adopted Create Folders page (external identity, families declared), the built-in page for comparison, and the inline refusal in an external app that declares none of the families.
The rebase to 86c1558 changes no file of this PR, so those renders still show this revision; the Design lane re-runs on the new head with them in view.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 475 lines, more than the 400 it may approve on its own.

Adds ProjectPicker to @⁠kirocrew/app-sdk at level 7, wrapping the dashboard's components/ProjectPicker. Verified: the host picker and its New folder form make seven api.* calls (browseDirs, browseDrives, createBrowseDir, recentProjects, favoriteProjects, addFavoriteProject, removeFavoriteProject), and all of them go to the four PROJECT_PICKER_PATHS; browseDrives uses /api/browse-dirs?drives=1. Gating copies PullRequestPanel: identity origin 'builtin' (host-assigned, not forgeable through a nested AppApiProvider) mounts directly; otherwise apiPathAllowed checks each path separately and a missing provider fails closed. ErrorNotice defaults askAgent to false, so the refusal has no hand-off. Using the dashboard client instead of the scoped transport matches docs/architecture/app-platform-trust-model.md (frontend scoping is a guardrail, not a boundary). The three families added to the built-in manifest only matter for the adopted copy's E9 parity check (permission_refusal), and nothing else in the repo reads that path list. Vendor stub and index exports were both updated, i18n strings exist in all 12 locales, and tests pin the per-path refusal, the exact-entry refusal, the three identit

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 5bd5469c7c · 475 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Backend Lint & Type Check (3.12) on 86c1558 is main's red, not this diff: mypy src/kiro_crew/cli_commands_memory.py:335 (assignment, bool into list[str]) after #36114 + #36212, tracked in #36458 with the fix in #36457. Coverage Gate fails closed on that lint job. No push or override here for it; this PR rebases onto main once #36457 lands.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from 86c1558 to eef4231 Compare November 13, 2026 19:11
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from eef4231 to ce45245 Compare November 13, 2026 22:54
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 6d61070 to pick up #36804 (the agent_ipc_client.py per-file coverage fix): the old head eef4231 failed Coverage Gate only on that file, which this PR does not touch. The Dependency License Gate and Publish readiness signal reds on eef4231 were the installation API rate limit, and the GPT lane did not publish its pass-2 verdict; all re-run on the new head ce45245. Rebase was clean; the scaffolder manifest tests, the picker vitest file, tsc -p tsconfig.app.json, i18n-check and the pseudolocale check pass locally.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 02bad16 to clear a merge conflict with #36356 (ctx.chat_slots): both PRs append a level-7 seam to the same sentence in docs/app-kit/api-reference.md and docs/system-specs/modules/app-kit-platform.md; the resolution keeps both items. No code changed. Local: docs-lint, i18n-check, the pseudolocale check, tsc -p tsconfig.app.json, the picker / scoped-api / SDK-surface vitest files (98 passed), and the 16 backend test files that read these two docs (424 passed) are green. The test_search_docs main red (#37060, fix #37063) is still on main, so Backend Tests (3.12, 6) is expected red until #37063 lands.

@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from 416bf0c to 1b39665 Compare November 14, 2026 04:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from 1b39665 to 5bd5469 Compare November 14, 2026 10:15
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main at 205d08d, so the head is now 5bd5469. The patch is byte-identical to the judged head 1b39665.

On 1b39665, the red Backend Tests (3.12, 6) and Backend Tests (Windows) (6) shards, and the Coverage Gate that fails closed behind them, came from one test. That test was test/test_search_docs.py::test_search_docs_ranks_the_page_the_query_is_about_first ('task-runner' == 'subagents'). It is a main red, which #37063 fixed. This PR touches no file that test reads. On the rebased tree, test/test_search_docs.py passes locally (43 passed). AppSdkProjectPicker.test.tsx (13), the scaffolder test_manifest.py (12) and tsc --noEmit all pass too.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from 5bd5469 to 0bac453 Compare November 14, 2026 18:53
@bolichen97

Copy link
Copy Markdown
Contributor Author

Synced onto main 66dc266 to clear the merge conflict (two level-7 lines in docs/app-kit/api-reference.md and app-kit-platform.md, kept both sides) and to pick up #37171, which fixes the test/tracing/test_tracing_otlp.py red on Backend Tests shard 2 (Linux + Windows) and the Coverage Gate that followed it. The PR diff is otherwise unchanged; the earlier Publish readiness signal red was the shared installation rate limit. CI re-running on 0bac453.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
An app page that asks for a project directory had no way to open the
dashboard's own picker (Favorites, Recent, Browse, the desktop folder
picker, New folder): the component lives in the host bundle, and only a
built-in page could import it. Create Folders From Project is such a
page, so a copy of it installed from its own repository would lose the
picker and fall back to a typed path.

ProjectPicker joins @kirocrew/app-sdk as App Kit level 7. It mounts the
dashboard's picker for a built-in page, and for an external app only
once its permissions.api declares every endpoint family the picker
calls (PROJECT_PICKER_PATHS); otherwise it renders a refusal naming the
missing path and sends nothing. The Create Folders built-in declares
those families in its own manifest, so an adopted copy declares nothing
the built-in did not.

Part of #26967
@bolichen97

Copy link
Copy Markdown
Contributor Author

Synced onto main f98bf61 to clear a second conflict on the same level-7 lines, this time against #36346 (level 8 for credentialMasks directories); both docs keep the picker under level 7 and name level 8 after it. Diff otherwise unchanged; CI re-running on e954c5f.

@bolichen97
bolichen97 force-pushed the feat/w4-project-scaffolder branch from 0bac453 to e954c5f Compare November 14, 2026 19:08
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 14, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Green on e954c5f (PR Readiness passed). green_age reports main +22 commits (f98bf61 -> 30f3498) in files this PR shares: shared docs and the locale catalogs, plus one test-stem match. I checked the head on that newer main without pushing. It rebases with no conflict onto 30f3498, leaving the same 21 files, +470/-5, and every locale catalog still parses. tsc -p tsconfig.app.json, the picker, app-sdk boundary and i18n vitest suites (147 tests), scripts/docs-lint.sh, and the scaffolder manifest tests, test_app_sdk_level_mirror.py and test_apps_backend_coverage_dependency_install.py (73 tests) all pass on the rebased tree. I am not re-pushing: the overlap is non-conflicting shared files, and a push would only restart CI against a base that keeps moving. Auto-merge stays armed.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review read the whole diff on this head and found no blocking issue. The mount check covers each request the host picker and New folder send: /api/browse-dirs (and ?drives=1), /api/browse-dirs/create, /api/recent-projects and /api/favorite-projects. apiPathAllowed uses the same matcher as the gateway, both hooks run before the early return, and the picker fails closed with no identity. All 13 catalogs keep {{path}}.

Security: the flagged risk is that the picker sends requests through the dashboard client, not the app's scoped transport. The risk is not realized because the picker mounts only when the host-published identity is built-in, or when the app's manifest admits every path in PROJECT_PICKER_PATHS. An app cannot claim built-in identity by wrapping itself, because the host identity wins and AppIdentityProvider is not exported. The project_scaffolder manifest gains three families that its page already calls. The app has no backend and no app token, so this grants nothing new.

Done well: the member sweep calls each picker api. member on the real client and requires the sent path to be in PROJECT_PICKER_PATHS. The backend test checks the built-in's families against that same list through the gateway's matcher, so a new endpoint or a narrowed family turns a test red.

Optional:

  • website/src/app-sdk/ProjectPicker.tsx:89: the refusal ErrorNotice has no onDismiss, so an app that closes only from onOpenChange(false) cannot close it. Passing onDismiss={() => onOpenChange(false)} would fix that.
  • §18i in app-kit-platform.md says each built-in that opens the picker declares the families. Issue Radar and Spec Builder do not declare them yet. Consider wording this as a step to do before adoption. Also, open PR #36967 adds its own §18i, so whichever PR lands second should renumber.
  • docs/app-kit/api-reference.md:803 ties the picker to SDK level 7. Release 0.13.0 ships level 7 without it, and main is at level 8. Feature-detecting the export, as the snippet already does, is the safe guidance.

@bolichen97
bolichen97 merged commit 93fdfd0 into main Nov 14, 2026
99 checks passed
@bolichen97
bolichen97 deleted the feat/w4-project-scaffolder branch November 14, 2026 20:26
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants