Repository navigation
feat(apps): pin five more former built-ins for adoption - #37411
Conversation
|
Catalog rows: kirodotdev/KiroCrewApps#79 switches auto-research, aws-control, dev-fleet and meetings from |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only adds pin data and version bumps to the existing adoption machinery, which already falls back to the wheel copy, and it removes nothing. [DESIGN-REVIEWED] d7dee21 Description read[DESCRIPTION-READ] afdcfd32345dfee7e6475e9e83c18d9093ad2bedd3518b5384ef594f0169098a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Each item applies the existing adoption mechanism to the move-out of built-ins that root What this change shipsInventory (8 items) — 8 justifiedIntent: hosts running five former built-ins switch at restart to each app's own repository and keep their data. ADDITION, of data only; the mechanism already exists.
[FIRST-PRINCIPLES-REVIEWED] d7dee21 Description read[DESCRIPTION-READ] e1a38de22c4164b2fff965c47f869aa50b57d66b0453a94e7476a69aed1f3d3b That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This PR changes only data. It adds five pin rows to adoption-pins.json, copies them into the test table, raises five wheel built-in versions to match each pin (the D12 rule) and adds one adoption paragraph to each owning spec. Checked against the code:
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Backend shards 1, 2, 8 (Linux) and Windows 8 are red on this head (run 43653872010) for a main break this PR does not touch: #36640's row-scrub tests plant an AWS key ID that #29423's detectors keep, and the same 8 node ids fail on a clean |
e2c3ff5 to
7ee6def
Compare
|
Rebased onto |
7ee6def to
9245909
Compare
|
Rebased onto |
|
|
buluoray
left a comment
There was a problem hiding this comment.
Approve on 9245909. This PR adds adoption pins for Research Lab, AWS Control, Dev Fleet, Meetings and Create Folders From Project, so a host running one of them as a built-in moves onto the app's own repository at its next restart. Each built-in's version moves up to the pinned version. All twelve pin rows pass the networked pin verification. Each pinned commit is the head of its repository's main. Each repository manifest declares the same permissions, agent tools and agents as its wheel copy, so the adopted copy asks for nothing new. Every wheel-copy change since each repository's sync point is carried in the port, and no wheel-copy change reached main after the named base. An adopted host keeps the app's data directory, its secret, its grants and its enabled switch. A host that cannot adopt keeps the wheel copy, because the swap refuses a record that still holds files beside the manifest. The new pin rows match the test table exactly. Reverting one version bump turns the version-match test red. One backend shard is red on a timing test that this PR does not touch. That test is tracked separately and has an open fix, and the PR should rebase once that fix lands. Decisive lines: src/kiro_crew/apps/adoption-pins.json:95-158, test/test_builtin_adoption_pins.py:213-262, src/kiro_crew/apps/builtins/{auto_research,aws_control,dev_fleet,meetings,project_scaffolder}/app.json:3, src/kiro_crew/apps/builtin_adoption_apply.py:375-412 (origin/main)
9245909 to
d1c5472
Compare
|
|
d1c5472 to
be3fd54
Compare
|
New head be3fd54 on main c844e1e, which carries the self-module scan fix #37530 (the earlier shard-7 red) and #37450's design-tweak / spec-builder rows, kept as they are with this PR's five rows after them. Main's #37493 changed a comment in aws-control's wheel copy ( |
Research Lab (auto-research), AWS Control, Dev Fleet, Meetings and Create Folders From Project (project-scaffolder) now live in their own repositories under KiroCrewCaptain, ported up to the current wheel copy with green CI on ubuntu, macOS and Windows. Each row is the output of scripts/adoption_pin.py compute and is added to adoption-pins.json and the _SHIPPED_PINS table, so a host whose record is builtin-owned moves onto the app's own tree at its next restart and keeps data/, the app secret, the grants and enabled. Each wheel built-in app.json version moves to the pinned version, since a first-adoption pin must equal it (D12). Every repository declares the same permissions as its wheel copy, so E9 holds nothing back. The owning specs record each adoption. Part of #26967
be3fd54 to
d7dee21
Compare
|
Rebased onto main 2e56b3b for #37545: be3fd54 hit |
buluoray
left a comment
There was a problem hiding this comment.
Approve on d7dee21. This PR adds adoption pins for Research Lab, AWS Control, Dev Fleet, Meetings and Create Folders From Project, so a host running one of them as a built-in moves onto the app's own repository at its next restart. Since the approved revision, the branch was rebased onto a main that already carries the design-tweak and spec-builder pins. Both of those rows are kept as they are, and this PR's five rows follow them in the pin file and in the test table. The only content change is the AWS Control pin. It now names a newer app commit that carries one comment-only change, which main made to the wheel copy's sidecar backup file. All fourteen pin rows pass the networked pin verification, and each of the five pinned commits is the head of its repository's main. The wheel-copy check in PR Hygiene passes on this head. Reverting one version bump turns the version-match test red. Nothing else in the PR changed. Decisive lines: src/kiro_crew/apps/adoption-pins.json (14 rows: 9 from main unchanged, then auto-research, aws-control, dev-fleet, meetings, project-scaffolder), test/test_builtin_adoption_pins.py _SHIPPED_PINS (same 14), src/kiro_crew/apps/builtins/aws_control/crew/runtime/container/sidecar/backup.py:43-48 (origin/main #37493, carried by app commit 8382917ef0ea)
Problem / Motivation
Goal: A host that has Research Lab, AWS Control, Dev Fleet, Meetings or Create Folders From Project as a built-in moves onto the app's own repository at its next restart, keeping everything it had.
All five apps now live in their own repositories under KiroCrewCaptain (
kirocrew-app-auto-research,kirocrew-app-aws-control,kirocrew-app-dev-fleet,kirocrew-app-meetings,kirocrew-app-project-scaffolder), ported up to the current wheel copy, with green CI on ubuntu, macOS and Windows. The wheel's adoption pin table does not name them yet, so no host adopts them and every fix keeps having to land twice.Why it matters
Until a pin row exists, these five apps cannot leave core: every host keeps running the wheel copy, and the removal of the built-ins in #26967 cannot start for them.
Not a goal
src/kiro_crew/apps/builtins/<app>/,website/src/apps/<app>/); only theirapp.jsonversion moves.What changed (motivation → approach → change)
Each row is the output of
scripts/adoption_pin.py compute, copied intoadoption-pins.jsonand the_SHIPPED_PINStable:minAppSdkLevela4688e7331d3ctx.lifecycle)8382917ef0eactx.lifecycle)9eb46b5fa9ce=/api/appsentry;agentToolsneed 2)a1e710690930agentReadOnlyDirs;ctx.turns,ctx.untrusted,agentTurnsneed 2)92b542c07940Each wheel built-in
app.jsonversion moves to the pinned version: a first-adoption pin must equal it (D12), andcomputerefuses the row withversion_mismatchuntil it does. Each repository'sapp.jsondeclares exactly the samepermissionsas its wheel copy (and, for meetings, the same three agents; for dev-fleet, the sameagentTools), so E9 holds nothing back. Dev Fleet'smake-live,restart-gateway,pod-tokenand=/api/appsentries are the ones the wheel copy already declares under the owner ruling of 2026-11-13 (#26967, comment 6841699202); nothing is added. The owning specs record each adoption:knowledge.md(Research Lab),aws-control.md,dev-fleet.md,meetings.md, andapp-kit-platform.md§ 18i for Create Folders From Project, which has no module spec of its own.Each pinned tree carries every change its wheel copy has on
main2e56b3b67221, comment-only ones included. For each app, everyorigin/maincommit touchingsrc/kiro_crew/apps/builtins/<dir>/orwebsite/src/apps/<name>/(andbuiltin_skills/meetings/for Meetings) since the repository's recorded sync point is listed in itsPORTING.md: aws-control carries #24732, #28535, #34888, #33806, #33521, #33196, #33436, #33117, #37370, #37394 and #37493 (all three comments); project-scaffolder carries #36322; the other three had no wheel-copy change since their sync point.The blockers #36446 named for this batch are merged: #36321 (an adoption holds while state sits beside
app.json) for auto-research, #36325 (a seam is handed back to the builtin when its copy unloads) for aws-control, #36322 (the project picker through the SDK) for project-scaffolder, and #36344 (exactpermissions.apientries) for dev-fleet.#36446 (issue-radar and auto-improvement) and #37450 (design-tweak and spec-builder) are merged; this branch sits on both and appends its five rows after those four in both tables, leaving them as they are.
App repo: KiroCrewCaptain/kirocrew-app-auto-research@a4688e7
App repo: KiroCrewCaptain/kirocrew-app-aws-control@8382917
App repo: KiroCrewCaptain/kirocrew-app-dev-fleet@9eb46b5
App repo: KiroCrewCaptain/kirocrew-app-meetings@a1e7106
App repo: KiroCrewCaptain/kirocrew-app-project-scaffolder@92b542c
Wheel-copy base: auto-research@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: aws-control@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: dev-fleet@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: meetings@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: project-scaffolder@2e56b3b6722179a4a35cce025889860cd5c83daf
Backwards compatibility
Compatible: five rows are added and five versions move up. A host whose record is builtin-owned adopts at the next restart and keeps
data/,.app_secret, the grants andenabled; a host that cannot adopt (an older SDK level, a pending config review, a file still besideapp.json) keeps the wheel copy unchanged. No other row changes.Removes nothing: the wheel copies, their routes and every existing pin row stay.
Tests
test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_tabletakes the five new rows and fails with the pin file ofmain;test_every_shipped_pin_matches_its_wheel_built_in_versionholds the version bumps and fails with any one of them reverted (checked with meetings at 0.1.0).Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head d7dee21)
Determinism: no test logic changes, only the pinned data table. On
origin/mainc844e1e5e9aaplus this commit, the adoption suites (everytest/test_builtin_adoption*.py,test/integration/test_builtin_adoption_boot.py,test/test_released_builtin_skill_copies.py,test/test_adopted_wheel_copy_check.py,test/test_app_agent_tools_adopted.py,test/test_harness.py, plustest/test_denied_commands_security_cost.pyandtest/test_legacy_state_moves.py) pass with 660 passed and 4 skipped, and the five apps' own suites (the repo-leveltest/files naming abuiltins/<dir>path of one of them and the wheel copies'tests/) pass with 8361 passed and 26 skipped. Black (at the pinned 26.10.1), flake8, isort, the comment-history, brand-name and line-cap gates andscripts/docs-lint.shpass; the diff has no frontend change.Manual verification
scripts/adoption_pin.py verifyover the network onorigin/main2e56b3b67221plus this commit, with a throwawayHOMEandKIROCREW_HOME: all fourteen rowsokunder main's current tree and seam-level checks. Each pinned commit is the head of its repository'smain, and its check runs are all green (Tests on ubuntu, macOS and Windows, the reproducible UI bundle, README, internal-content-scan with credentials present and every added line checked, plus the crew container suite for aws-control and the manifest parser check for meetings).Related Issues
Part of #26967
Catalog rows: the kirodotdev/KiroCrewApps PR linked in a comment below switches the four
builtinrows togitat the same commits and adds project-scaffolder's first row. It is not auto-merged: the driver merges it right after this PR lands.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.