Skip to content

feat(apps): pin five more former built-ins for adoption - #37411

Merged
bolichen97 merged 1 commit into
mainfrom
feat/w6-pins
Nov 15, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/w6-pins

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A host that has Research Lab, AWS Control, Dev Fleet, Meetings or Create Folders From Project as a built-in moves onto the app's own repository at its next restart, keeping everything it had.

All five apps now live in their own repositories under KiroCrewCaptain (kirocrew-app-auto-research, kirocrew-app-aws-control, kirocrew-app-dev-fleet, kirocrew-app-meetings, kirocrew-app-project-scaffolder), ported up to the current wheel copy, with green CI on ubuntu, macOS and Windows. The wheel's adoption pin table does not name them yet, so no host adopts them and every fix keeps having to land twice.

Why it matters

Until a pin row exists, these five apps cannot leave core: every host keeps running the wheel copy, and the removal of the built-ins in #26967 cannot start for them.

Not a goal

  • Changing the adoption machinery, the D12 equality rule or any app's declared permissions.
  • Deleting the wheel copies (src/kiro_crew/apps/builtins/<app>/, website/src/apps/<app>/); only their app.json version moves.
  • Pinning issue-radar or auto-improvement: feat(apps): pin issue-radar and auto-improvement for adoption #36446 does that, and its rows stay as they are.

What changed (motivation → approach → change)

Each row is the output of scripts/adoption_pin.py compute, copied into adoption-pins.json and the _SHIPPED_PINS table:

App Version Pinned commit minAppSdkLevel
auto-research 0.1.0 to 0.1.2 a4688e7331d3 2 (ctx.lifecycle)
aws-control 0.1.0 to 0.1.2 8382917ef0ea 2 (ctx.lifecycle)
dev-fleet 1.0.0 to 1.0.1 9eb46b5fa9ce 7 (the exact =/api/apps entry; agentTools need 2)
meetings 0.1.0 to 0.1.3 a1e710690930 7 (agentReadOnlyDirs; ctx.turns, ctx.untrusted, agentTurns need 2)
project-scaffolder 0.1.0 to 0.1.1 92b542c07940 7 (the SDK project picker of #36322)

Each wheel built-in app.json version moves to the pinned version: a first-adoption pin must equal it (D12), and compute refuses the row with version_mismatch until it does. Each repository's app.json declares exactly the same permissions as its wheel copy (and, for meetings, the same three agents; for dev-fleet, the same agentTools), so E9 holds nothing back. Dev Fleet's make-live, restart-gateway, pod-token and =/api/apps entries are the ones the wheel copy already declares under the owner ruling of 2026-11-13 (#26967, comment 6841699202); nothing is added. The owning specs record each adoption: knowledge.md (Research Lab), aws-control.md, dev-fleet.md, meetings.md, and app-kit-platform.md § 18i for Create Folders From Project, which has no module spec of its own.

Each pinned tree carries every change its wheel copy has on main 2e56b3b67221, comment-only ones included. For each app, every origin/main commit touching src/kiro_crew/apps/builtins/<dir>/ or website/src/apps/<name>/ (and builtin_skills/meetings/ for Meetings) since the repository's recorded sync point is listed in its PORTING.md: aws-control carries #24732, #28535, #34888, #33806, #33521, #33196, #33436, #33117, #37370, #37394 and #37493 (all three comments); project-scaffolder carries #36322; the other three had no wheel-copy change since their sync point.

The blockers #36446 named for this batch are merged: #36321 (an adoption holds while state sits beside app.json) for auto-research, #36325 (a seam is handed back to the builtin when its copy unloads) for aws-control, #36322 (the project picker through the SDK) for project-scaffolder, and #36344 (exact permissions.api entries) for dev-fleet.

#36446 (issue-radar and auto-improvement) and #37450 (design-tweak and spec-builder) are merged; this branch sits on both and appends its five rows after those four in both tables, leaving them as they are.

App repo: KiroCrewCaptain/kirocrew-app-auto-research@a4688e7
App repo: KiroCrewCaptain/kirocrew-app-aws-control@8382917
App repo: KiroCrewCaptain/kirocrew-app-dev-fleet@9eb46b5
App repo: KiroCrewCaptain/kirocrew-app-meetings@a1e7106
App repo: KiroCrewCaptain/kirocrew-app-project-scaffolder@92b542c

Wheel-copy base: auto-research@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: aws-control@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: dev-fleet@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: meetings@2e56b3b6722179a4a35cce025889860cd5c83daf
Wheel-copy base: project-scaffolder@2e56b3b6722179a4a35cce025889860cd5c83daf

Backwards compatibility

Compatible: five rows are added and five versions move up. A host whose record is builtin-owned adopts at the next restart and keeps data/, .app_secret, the grants and enabled; a host that cannot adopt (an older SDK level, a pending config review, a file still beside app.json) keeps the wheel copy unchanged. No other row changes.

Removes nothing: the wheel copies, their routes and every existing pin row stay.

Tests

test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table takes the five new rows and fails with the pin file of main; test_every_shipped_pin_matches_its_wheel_built_in_version holds the version bumps and fails with any one of them reverted (checked with meetings at 0.1.0).

Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head d7dee21)

Determinism: no test logic changes, only the pinned data table. On origin/main c844e1e5e9aa plus this commit, the adoption suites (every test/test_builtin_adoption*.py, test/integration/test_builtin_adoption_boot.py, test/test_released_builtin_skill_copies.py, test/test_adopted_wheel_copy_check.py, test/test_app_agent_tools_adopted.py, test/test_harness.py, plus test/test_denied_commands_security_cost.py and test/test_legacy_state_moves.py) pass with 660 passed and 4 skipped, and the five apps' own suites (the repo-level test/ files naming a builtins/<dir> path of one of them and the wheel copies' tests/) pass with 8361 passed and 26 skipped. Black (at the pinned 26.10.1), flake8, isort, the comment-history, brand-name and line-cap gates and scripts/docs-lint.sh pass; the diff has no frontend change.

Manual verification

scripts/adoption_pin.py verify over the network on origin/main 2e56b3b67221 plus this commit, with a throwaway HOME and KIROCREW_HOME: all fourteen rows ok under main's current tree and seam-level checks. Each pinned commit is the head of its repository's main, and its check runs are all green (Tests on ubuntu, macOS and Windows, the reproducible UI bundle, README, internal-content-scan with credentials present and every added line checked, plus the crew container suite for aws-control and the manifest parser check for meetings).

Related Issues

Part of #26967

Catalog rows: the kirodotdev/KiroCrewApps PR linked in a comment below switches the four builtin rows to git at the same commits and adds project-scaffolder's first row. It is not auto-merged: the driver merges it right after this PR lands.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Catalog rows: kirodotdev/KiroCrewApps#79 switches auto-research, aws-control, dev-fleet and meetings from builtin to git at the commits pinned here and adds project-scaffolder's first entry. It is not auto-merged: the driver merges it right after this PR lands.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 14, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) November 14, 2026 23:34
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d7dee2172ceb24376f616d81cc82c989dab8403d touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d7dee2172ceb24376f616d81cc82c989dab8403d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only adds pin data and version bumps to the existing adoption machinery, which already falls back to the wheel copy, and it removes nothing.

[DESIGN-REVIEWED] d7dee21

Description read

[DESCRIPTION-READ] afdcfd32345dfee7e6475e9e83c18d9093ad2bedd3518b5384ef594f0169098a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of d7dee2172ceb24376f616d81cc82c989dab8403d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Each item applies the existing adoption mechanism to the move-out of built-ins that root AGENTS.md already requires ("being moved out under #26967"). The version bumps and spec paragraphs follow from D12 and the same-commit spec rule.

What this change ships

Inventory (8 items) — 8 justified

Intent: hosts running five former built-ins switch at restart to each app's own repository and keep their data. ADDITION, of data only; the mechanism already exists.

  1. Research Lab switches at restart to its own repository and keeps data/, the secret, the grants and enabled — justified
  2. AWS Control does the same — justified
  3. Dev Fleet does the same — justified
  4. Meetings does the same, and the bundled meetings skill copy stands down once the host adopts — justified
  5. Create Folders From Project does the same — justified
  6. The wheel copies of the five apps report new versions (0.1.2, 0.1.2, 1.0.1, 0.1.3, 0.1.1) — justified
  7. The specs (knowledge, aws-control, dev-fleet, meetings, app-kit-platform § 18i) each gain an adoption paragraph — justified
  8. The shipped-pin test table names the five new rows — justified

[FIRST-PRINCIPLES-REVIEWED] d7dee21

Description read

[DESCRIPTION-READ] e1a38de22c4164b2fff965c47f869aa50b57d66b0453a94e7476a69aed1f3d3b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d7dee2172ceb24376f616d81cc82c989dab8403d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d7dee21

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d7dee2172ceb24376f616d81cc82c989dab8403d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d7dee2172ceb24376f616d81cc82c989dab8403d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d7dee21

Verdict parsed from the review's SHA-scoped output markers for commit d7dee2172ceb24376f616d81cc82c989dab8403d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d7dee2172ceb24376f616d81cc82c989dab8403d false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

KiroCrewCaptain commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This PR changes only data. It adds five pin rows to adoption-pins.json, copies them into the test table, raises five wheel built-in versions to match each pin (the D12 rule) and adds one adoption paragraph to each owning spec. Checked against the code:

  • Row cap: MAX_PINS is 64 and the table now has 14 rows, so the whole-table drop doesn't fire.
  • Nav entries: every legacyNav route and icon matches the wheel copy's ui.pages entry (FlaskConical, Cloud, Server, CalendarClock, FolderPlus).
  • SDK level: every minAppSdkLevel is at or below the build's APP_SDK_LEVEL of 8.
  • Meetings skill: the bundled builtin_skills/meetings copy declares app: meetings, so it stands down through the generic released_builtin_names check once the app is adopted.
  • Dev Fleet grants: host grants are keyed by installed name and read from BUILTIN_NAMES packages, not from the record's origin, so the spec's claim that an adopted Dev Fleet keeps them holds.
  • Tests: test_every_shipped_pin_matches_its_wheel_built_in_version enforces the version bumps, and the shipped-table test fails against the pin file on main.
  • Rules: the PR has the App repo: lines that AGENTS.md req

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit d7dee2172c · 178 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Backend shards 1, 2, 8 (Linux) and Windows 8 are red on this head (run 43653872010) for a main break this PR does not touch: #36640's row-scrub tests plant an AWS key ID that #29423's detectors keep, and the same 8 node ids fail on a clean origin/main fdf7cbc2ec. Tracked in #37421, fixed by #37423; this PR rebases onto it once it lands.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto 99dc8daacfb5 (#36446 merged; its issue-radar and auto-improvement rows are kept, this PR's five follow them). #37370 changed aws-control's wheel copy (a comment in backup_parts/retention.py) after the pin, so it is ported in KiroCrewCaptain/kirocrew-app-aws-control#7 and the aws-control row moves to 6281dc3a1ece (recomputed with adoption_pin.py compute; verify: all twelve rows ok). The other four pinned trees carry every wheel-copy change on this base. Catalog kirodotdev/KiroCrewApps#79 points aws-control at the same commit. The backend shard reds are still main's (#37421, fixed by #37423).

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto 449920c8ba7d so the run carries the row-scrub test fix #37423. Wheel-copy drift since 99dc8daacfb5: #37394 changed one aws-control comment (crew/runtime/container_tests/test_supervisor_process.py). It is ported in KiroCrewCaptain/kirocrew-app-aws-control#8 (merged as 6e14f7d5fb232c9c5d462a36a2e7d401f08150e2, all seven checks green). The aws-control row is recomputed at that commit, and kirodotdev/KiroCrewApps#79 points at the same commit. scripts/adoption_pin.py verify: all twelve rows ok. The other four apps had no wheel-copy change.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 7) (and the Coverage Gate that folds it) is red twice on 9245909 on test/test_denied_commands_security_cost.py::TestSelfModuleIndexIsLinear::test_the_scan_is_linear_not_quadratic (0.623s, then 0.674s against its 0.5s thread-CPU ceiling). This PR does not touch security.py or that test. The test is in the flake ledger as #37446, where other heads (#37419, #37433) show the same red, and #37451 is its open fix. The one rerun is spent, so this PR waits for #37451, then rebases onto it.

buluoray
buluoray previously approved these changes Nov 15, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 9245909. This PR adds adoption pins for Research Lab, AWS Control, Dev Fleet, Meetings and Create Folders From Project, so a host running one of them as a built-in moves onto the app's own repository at its next restart. Each built-in's version moves up to the pinned version. All twelve pin rows pass the networked pin verification. Each pinned commit is the head of its repository's main. Each repository manifest declares the same permissions, agent tools and agents as its wheel copy, so the adopted copy asks for nothing new. Every wheel-copy change since each repository's sync point is carried in the port, and no wheel-copy change reached main after the named base. An adopted host keeps the app's data directory, its secret, its grants and its enabled switch. A host that cannot adopt keeps the wheel copy, because the swap refuses a record that still holds files beside the manifest. The new pin rows match the test table exactly. Reverting one version bump turns the version-match test red. One backend shard is red on a timing test that this PR does not touch. That test is tracked separately and has an open fix, and the PR should rebase once that fix lands. Decisive lines: src/kiro_crew/apps/adoption-pins.json:95-158, test/test_builtin_adoption_pins.py:213-262, src/kiro_crew/apps/builtins/{auto_research,aws_control,dev_fleet,meetings,project_scaffolder}/app.json:3, src/kiro_crew/apps/builtin_adoption_apply.py:375-412 (origin/main)

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 15, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 7) (and so Coverage Gate) is red on d1c5472 with test/test_denied_commands_security_cost.py::TestSelfModuleIndexIsLinear::test_the_scan_is_linear_not_quadratic (2k tokens took 0.532s). It is not this diff: the same node id fails on #37454, #37457, #37487, #37476, #37209 and #37450 on heads that already carry #37451, because coverage's line tracer is billed to the scan's CPU budget. Ledger: #37515 (this run recorded there). Open fixes: #37530, #37539. One rerun of the failed jobs follows once this run completes; if it reds again, this PR rebases onto whichever fix lands first.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 15, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

New head be3fd54 on main c844e1e, which carries the self-module scan fix #37530 (the earlier shard-7 red) and #37450's design-tweak / spec-builder rows, kept as they are with this PR's five rows after them.

Main's #37493 changed a comment in aws-control's wheel copy (crew/runtime/container/sidecar/backup.py), so the pin drift guard would have failed. It is ported to the app repository (KiroCrewCaptain/kirocrew-app-aws-control#9, CI green, merged as 8382917ef0ea), and the aws-control row is recomputed at that commit. The catalog PR kirodotdev/KiroCrewApps#79 names the same commit. Every Wheel-copy base: line names c844e1e, and scripts/adoption_pin.py verify reports all fourteen rows ok.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 15, 2026
Research Lab (auto-research), AWS Control, Dev Fleet, Meetings and
Create Folders From Project (project-scaffolder) now live in their own
repositories under KiroCrewCaptain, ported up to the current wheel copy
with green CI on ubuntu, macOS and Windows. Each row is the output of
scripts/adoption_pin.py compute and is added to adoption-pins.json and
the _SHIPPED_PINS table, so a host whose record is builtin-owned moves
onto the app's own tree at its next restart and keeps data/, the app
secret, the grants and enabled.

Each wheel built-in app.json version moves to the pinned version, since
a first-adoption pin must equal it (D12). Every repository declares the
same permissions as its wheel copy, so E9 holds nothing back. The
owning specs record each adoption.

Part of #26967
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 2e56b3b for #37545: be3fd54 hit test/metrics/test_kiro_export_destination.py::TestOffOffer (3 tests, assert False is True) in Backend Tests (3.12, 6). Those three fail the same way on clean main c844e1e and pass on 2e56b3b. The wheel copies of the five apps did not change in that range, so the pins stay as they are. Every Wheel-copy base: line names 2e56b3b, and adoption_pin.py verify reports all fourteen rows ok.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 15, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on d7dee21. This PR adds adoption pins for Research Lab, AWS Control, Dev Fleet, Meetings and Create Folders From Project, so a host running one of them as a built-in moves onto the app's own repository at its next restart. Since the approved revision, the branch was rebased onto a main that already carries the design-tweak and spec-builder pins. Both of those rows are kept as they are, and this PR's five rows follow them in the pin file and in the test table. The only content change is the AWS Control pin. It now names a newer app commit that carries one comment-only change, which main made to the wheel copy's sidecar backup file. All fourteen pin rows pass the networked pin verification, and each of the five pinned commits is the head of its repository's main. The wheel-copy check in PR Hygiene passes on this head. Reverting one version bump turns the version-match test red. Nothing else in the PR changed. Decisive lines: src/kiro_crew/apps/adoption-pins.json (14 rows: 9 from main unchanged, then auto-research, aws-control, dev-fleet, meetings, project-scaffolder), test/test_builtin_adoption_pins.py _SHIPPED_PINS (same 14), src/kiro_crew/apps/builtins/aws_control/crew/runtime/container/sidecar/backup.py:43-48 (origin/main #37493, carried by app commit 8382917ef0ea)

@bolichen97
bolichen97 merged commit c4704f9 into main Nov 15, 2026
99 checks passed
@bolichen97
bolichen97 deleted the feat/w6-pins branch November 15, 2026 09:47
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants