Repository navigation
feat(apps): pin design-tweak and spec-builder for adoption - #37450
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this adds two pin rows to the existing adoption machinery, and leaving out crew-companion and ops-mission-control is justified. Notes
[DESIGN-REVIEWED] 81af710 Description read[DESCRIPTION-READ] cfb32a14b580df2d2e2996150e11e2ecae0b84b55ec63f03f6f9145600d58bbc That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This change does what the Not checked: whether the pinned commits and hashes match the external repositories (that needs the network). What this change shipsInventory (4 items) — 4 justifiedIntent: let hosts that have Design Tweak or Spec Builder built in move onto each app's own repository at the next restart, keeping their data and grants. ADDITION, using an existing mechanism.
[FIRST-PRINCIPLES-REVIEWED] 81af710 Description read[DESCRIPTION-READ] b101e71b9753393314ba708bbd8b0a001738a32408558be3705253eabdd9f99d That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Catalog half: kirodotdev/KiroCrewApps#80 adds design-tweak and flips spec-builder to |
55f189b to
192aee2
Compare
…repositories Flips spec-builder and md-notebook from a builtin source to a git source in KiroCrewCaptain and adds design-tweak's first row, each pinned at the commit the Kiro Crew adoption pin table names for it (kirodotdev/KiroCrew#37450): design-tweak 0.10.1 at KiroCrewCaptain/kirocrew-app-design-tweak@deff125f4abf, spec-builder 0.1.1 at KiroCrewCaptain/kirocrew-app-spec-builder@79de0b4e3581 and md-notebook 1.0.1 at KiroCrewCaptain/kirocrew-app-md-notebook@82707e67f2d9. The Kiro Crew org rows (spec-builder, md-notebook) gain the KiroCrewCaptain author URL; design-tweak keeps its person attribution.
|
Superseded: md-notebook was taken back out of this PR (head Scope note: this head ( |
192aee2 to
8121d68
Compare
|
md-notebook is held out of this PR. The head is back to the two pins of its goal: 8121d68 has the same tree as 55f189b. That means 192aee2, which pushed the md-notebook row a few minutes ago, is undone. The md-notebook row will come in a later pin PR, after a core fix. Why it is held: a host from before #36365 keeps its Notes token, Adoption applies on the boot after the staging. So a host whose Notes was disabled at upgrade, or whose move was held by an older-build sandbox on that first boot, would adopt without the move. The adopted backend would then open an empty That move is getting its own core fix PR. The md-notebook pin follows once that fix lands and the app repository's |
Flips spec-builder from a builtin source to a git source in KiroCrewCaptain and adds design-tweak's first row, each pinned at the commit the Kiro Crew adoption pin table names for it (kirodotdev/KiroCrew#37450): design-tweak 0.10.1 at KiroCrewCaptain/kirocrew-app-design-tweak@deff125f4abf and spec-builder 0.1.1 at KiroCrewCaptain/kirocrew-app-spec-builder@79de0b4e3581. The Kiro Crew org row (spec-builder) gains the KiroCrewCaptain author URL; design-tweak keeps its person attribution.
|
The fix is #37451, which bounds the scan by a CPU ratio instead of a wall-clock budget. This PR waits for it and rebases onto it once it lands. No override and no blind rerun for this red. |
Code change approver recommendation: ApproveWhy: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This change is data only. It adds two pin rows (design-tweak and spec-builder) to What I checked:
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
buluoray
left a comment
There was a problem hiding this comment.
Approve on 8121d68. This PR lets hosts that run Design Tweak or Spec Builder as a built-in move onto each app's own repository at the next restart. It adds two rows to the adoption pin table and raises the two wheel copies' versions to match. Both rows were recomputed from the app repositories at the pinned commits and match byte for byte: commit, version, tree and archive digests, minimum SDK level and legacy nav. Each pinned commit is the head of its repository's main. Each repository's app.json asks for the same permissions, agent tools, agents, read-only agent directories and skills as its wheel copy. Both apps keep reading user data from the same places as the wheel copy, so nothing is lost on adoption. The two pin tests turn red when a version or a row is changed. The one red backend shard is a known wall-clock flake in a security cost test this PR does not touch (tracked in #37446, fix in #37451); the PR should rebase after that fix lands. This PR also conflicts textually with #37411 in the pin file and its test table, because both append rows at the same place. If #37411 merges first, as planned, this PR needs a rebase that keeps both sets of rows. Decisive lines: src/kiro_crew/apps/adoption-pins.json:95-119, test/test_builtin_adoption_pins.py:213-232, src/kiro_crew/apps/builtins/design_tweak/app.json:3, src/kiro_crew/apps/builtins/spec_builder/app.json:3
Design Tweak and Spec Builder now live in their own repositories under KiroCrewCaptain, ported up to the current wheel copy with green CI on ubuntu, macOS and Windows. Each row is the output of scripts/adoption_pin.py compute and is added to adoption-pins.json and the _SHIPPED_PINS table, so a host whose record is builtin-owned moves onto the app's own tree at its next restart and keeps data/, the app secret, the grants and enabled. Each wheel built-in app.json version moves to the pinned version, since a first-adoption pin must equal it (D12). Both repositories declare the same permissions as their wheel copy, so E9 holds nothing back. The owning spec records each adoption. Part of #26967
8121d68 to
81af710
Compare
…80) Flips spec-builder from a builtin source to a git source in KiroCrewCaptain and adds design-tweak's first row, each pinned at the commit the Kiro Crew adoption pin table names for it (kirodotdev/KiroCrew#37450): design-tweak 0.10.1 at KiroCrewCaptain/kirocrew-app-design-tweak@deff125f4abf and spec-builder 0.1.1 at KiroCrewCaptain/kirocrew-app-spec-builder@79de0b4e3581. The Kiro Crew org row (spec-builder) gains the KiroCrewCaptain author URL; design-tweak keeps its person attribution.
Problem / Motivation
Goal: A host that has Design Tweak or Spec Builder as a built-in moves onto the app's own repository at its next restart, keeping everything it had.
Both apps now live in their own repositories under KiroCrewCaptain (
kirocrew-app-design-tweak,kirocrew-app-spec-builder), ported up to the current wheel copy, with green CI on ubuntu, macOS and Windows. The wheel's adoption pin table does not name them yet, so no host adopts them and every fix keeps having to land twice.Why it matters
Until a pin row exists, these two apps cannot leave core: every host keeps running the wheel copy, and the removal of the built-ins in #26967 cannot start for them.
Not a goal
src/kiro_crew/apps/builtins/<app>/,website/src/apps/<app>/); only theirapp.jsonversion moves.What changed (motivation → approach → change)
Each row is the output of
scripts/adoption_pin.py compute, copied intoadoption-pins.jsonand the_SHIPPED_PINStable:minAppSdkLeveldeff125f4abf=/api/chatentry landed after the level-7 constant, so 8 is the first level that always carries it;agentToolsneed 2)79de0b4e3581chatSlots,ctx.chat_slots,agentReadOnlyDirs)Each wheel built-in
app.jsonversion moves to the pinned version: a first-adoption pin must equal it (D12), andcomputerefuses the row withversion_mismatchuntil it does. Each repository'sapp.jsondeclares exactly the samepermissionsas its wheel copy (and the sameagentTools,agentReadOnlyDirsandskills), so E9 holds nothing back. Design Tweak's=/api/chatand/api/chat/slotsare the entries the wheel copy already declares under the owner ruling of 2026-11-13 (#26967, comment 6841699202, #36342); nothing is added. The owning spec records each adoption:app-kit-platform.md, "Permission parity of the wheel copies" (Design Tweak) and § 41 "The built-in" (Spec Builder); neither app has a module spec of its own.Each pinned tree carries every change its wheel copy has on
main4c530d0bd2d1. Both repositories'PORTING.mdrecord the sync pointaf94fac51f, and noorigin/maincommit has touchedsrc/kiro_crew/apps/builtins/<dir>/,website/src/apps/<name>/orwebsite/public/app-assets/<name>/since. Their prerequisites are onmain: #36342 and #33141 for Design Tweak, #36128 and #33589 for Spec Builder.Held back, with the reason:
data/secrets/behind acredentialMasksdirectory entry the wheel copy does not declare. The agent tool gate reads the shipped built-ins' declarations only (credential_masks.declared_crew_leaves(installed=False)), so after adoption the new store would be fenced by the sandbox mask alone, while today's<data home>/ops_mission_control_secrets.jsonis fenced by both. It is pinned once that gap is closed.Merge order: #37411 first. Both PRs append rows after
auto-improvementinadoption-pins.jsonand_SHIPPED_PINS; whichever lands second is rebased, keeping the other's rows.App repo: KiroCrewCaptain/kirocrew-app-design-tweak@deff125
App repo: KiroCrewCaptain/kirocrew-app-spec-builder@79de0b4
Wheel-copy base: design-tweak@4c530d0bd2d1465315b7a30b720f82a7a14f116a
Wheel-copy base: spec-builder@4c530d0bd2d1465315b7a30b720f82a7a14f116a
Backwards compatibility
Compatible: two rows are added and two versions move up. A host whose record is builtin-owned adopts at the next restart and keeps
data/,.app_secret, the grants andenabled; a host that cannot adopt (an older SDK level, a pending config review, a file still besideapp.json) keeps the wheel copy unchanged. No other row changes.Removes nothing: the wheel copies, their routes and every existing pin row stay.
Tests
test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_tabletakes the two new rows and fails with the pin file ofmain;test_every_shipped_pin_matches_its_wheel_built_in_versionholds the version bumps.Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head 55f189b)
Determinism: no test logic changes, only the pinned data table. On
origin/main4c530d0bd2d1plus this commit, everytest/test_builtin_adoption_*.py,test/test_design_tweak_*.py,test/test_app_agent_tools_adopted.py,test/test_released_builtin_skill_copies.py,test/test_app_chat_slot_sdk.py,test/test_core_spec_builder_decoupling.pyand both wheel copies'tests/: 2272 passed, 3 skipped;test/test_flake_pattern_ratchet.pypasses. Black, flake8, isort, the comment-history, brand-name and line-cap gates andscripts/docs-lint.shpass; the diff has no frontend change.Manual verification
scripts/adoption_pin.py verifyover the network onorigin/main4c530d0bd2d1plus this commit, with a throwawayHOMEandKIROCREW_HOME: all nine rowsok. Each pinned commit is the head of its repository'smain, and its check runs are all green (Tests on ubuntu, macOS and Windows, the reproducible UI bundle, README, internal-content-scan with every added line checked, plus Design Tweak's tests against the real Kiro Crew host).Related Issues
Part of #26967
Catalog rows: the kirodotdev/KiroCrewApps PR linked in a comment below switches both rows to
gitat the same commits. It is not auto-merged: the driver merges it right after this PR lands.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.