Repository navigation
test(conductor): guard Ultra Mode's team lead reach of shared conductor rules - #36529
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only adds tests and covers a real unguarded path. No product code changes and nothing is taken away. Notes
[DESIGN-REVIEWED] aea80a7 Description read[DESCRIPTION-READ] 2a09f5f8e1a63c1e57eac0a68eac8be82d4c23daef44ce416315bbc86e6657f6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
7387421 to
d9c146b
Compare
d9c146b to
aea80a7
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Read the full diff. Test-only, for #36501. It adds a guard that Ultra Mode's kirocrew-team-lead still reaches every shared _LEDGER_CONDUCTOR_RULES entry through the team-lead -> goal-conductor skill chain.
- Every shared rule key must be either in
ULTRA_SKILL_ANCHORS, with anchor phrases present ingoal-conductor/SKILL.md, or inULTRA_GAPSwith a reason. No key may be in both, and no entry may name a rule that does not exist. - A closed gap must be moved, so the gap list cannot go stale.
- A positive control shows that a lost anchor is reported by its key.
- A last test pins the prompt ->
team-lead->goal-conductorchain and that the installed team-lead spec maps both skills.
No product code changes. LGTM.
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds parity tests for the team lead's reach of shared conductor rules; test file only.
Problem / Motivation
Goal: A test fails when Ultra Mode's team lead stops reaching a shared conductor rule.
Ultra Mode runs
kirocrew-team-lead(crew_mode.DEFAULT_CREW_MODE_AGENT). Its system prompt carries none of_LEDGER_CONDUCTOR_RULES. It reaches them only through two skills:team-leadsays "Readgoal-conductorfirst", andgoal-conductor/SKILL.mdholds the procedure.test/test_mate_conductor_parity.pychecks only the plain conductor against the Bot's conductor, so nothing guards the Ultra path. Its docstring also still nameskirocrew-conductoras the Ultra agent.Why it matters
A shared rule can be added or dropped for the Bot and the plain conductor while the skill never gets it, and Ultra silently runs without it. Three open PRs add or change shared rules right now (#36481
host_pressure, #36312resource_wave, #36302 drift inread_message_detail).Not a goal
What changed (motivation → approach → change)
Ultra reads shared rules only through skills → so the test keys each shared rule to short anchor phrases in
goal-conductor/SKILL.md, not to full text, and ordinary rewording does not break it.ULTRA_SKILL_ANCHORS: rule key → anchor phrases.ULTRA_GAPS: rule key → (anchor, reason) for rules the skill does not carry today._LEDGER_CONDUCTOR_RULESkey must sit in exactly one of the two maps. A new key (e.g.host_pressure,resource_wave) fails until it is mapped: that is the extension point.team-leadandgoal-conductor, theteam-leadskill says "read goal-conductor first", and the installed spec maps both skills.kirocrew-conductoris the plain and child conductor; the team lead section is described.Two gaps on main today:
dependent_callsandpatrol_requestedhave no counterpart in either skill.Backwards compatibility
Compatible: test-only; no product code changes.
Removes nothing: the diff adds tests and rewords a docstring.
Tests
test_every_shared_rule_has_an_ultra_counterpart_or_a_named_gap: each shared key is mapped or gapped, and no entry names a missing key.test_goal_conductor_skill_carries_each_mapped_rule: every anchor is in the skill.test_every_ultra_gap_is_still_a_gap: a closed gap is reported.test_the_anchor_check_sees_a_lost_rule: positive control, a missing anchor is caught by key.test_ultra_mode_reaches_goal_conductor_through_team_lead: the prompt → skill → skill chain and the spec's skill mapping.Proof: not provable -- test-only change
Determinism: the whole file passed 24/24 three times in a row, and once with all 24 node ids in reversed order (
-n0). The new tests read checked-in text and one spec written undertmp_path; no clock, network or shared state.test/test_flake_pattern_ratchet.py: 68 passed.Manual verification
N/A — unit coverage sufficient; the tests read checked-in prompt and skill text and one installed spec in
tmp_path.Related Issues
Closes #36501
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)